[Qemu-devel] [PULL 0/5] ipv4-only and ipv6-only support

Update version for v2.6.0-rc0 release (2016-03-30 19:25:40 +0100) are available in the git repository at: http://people.debian.org/~sthibault/qemu.git tags/samuel-thibault-2 for you to fetch changes up to c99751f2a711e9eecf60901520c6d4197bdaf9b4: slirp: Add RDNSS advertisement (2016-03

[Qemu-devel] [PULL 1/5] slirp: Allow disabling IPv4 or IPv6

Add ipv4 and ipv6 boolean options, so the user can setup IPv4-only and IPv6-only network environments. Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> Reviewed-by: Thomas Huth <th...@redhat.com> --- net/slirp.c | 36 ++-- qapi-schem

[Qemu-devel] [PULL 4/5] slirp: Support link-local DNS addresses

They look like fe80::%eth0 Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> Reviewed-by: Thomas Huth <th...@redhat.com> --- slirp/libslirp.h | 2 +- slirp/slirp.c| 26 ++ slirp/socket.c | 2 +- 3 files changed, 24 insertions(+), 6 deleti

[Qemu-devel] [PULL 3/5] slirp: Add dns6 resolution

This makes get_dns_addr address family-agnostic, thus allowing to add the IPv6 case. Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> Reviewed-by: Thomas Huth <th...@redhat.com> --- slirp/ip6.h | 9 +++ slirp/libslirp.h | 1 + slirp/sli

Re: [Qemu-devel] [PULL 0/5] ipv4-only and ipv6-only support

Peter Maydell, on Thu 31 Mar 2016 12:30:24 +0100, wrote: > On 31 March 2016 at 10:20, Samuel Thibault <samuel.thiba...@ens-lyon.org> > wrote: > > http://people.debian.org/~sthibault/qemu.git tags/samuel-thibault-2 > > > > for you to fetch changes up to c99751f2a7

Re: [Qemu-devel] [PULL 0/5] ipv4-only and ipv6-only support

Vasiliy Tolstov, on Thu 31 Mar 2016 14:49:35 +0300, wrote: > Yes, i'm using older version of this patch and without working ipv6 on > host my vm tries to access network via ipv6 (prefered) and not able to > connect. I'm surprised that the vm tries to access the network via ipv6 by default. Which

Re: [Qemu-devel] [PULL 0/5] ipv4-only and ipv6-only support

Vasiliy Tolstov, on Thu 31 Mar 2016 15:03:31 +0300, wrote: > 2016-03-31 14:57 GMT+03:00 Samuel Thibault <samuel.thiba...@gnu.org>: > > I'm surprised that the vm tries to access the network via ipv6 by > > default. Which OS is this? With the default fec0:: prefix, ipv4 &g

Re: [Qemu-devel] [PULL 0/5] ipv4-only and ipv6-only support

Vasiliy Tolstov, on Thu 31 Mar 2016 15:04:02 +0300, wrote: > 2016-03-31 15:03 GMT+03:00 Vasiliy Tolstov : > > This is debian. I'm use old patch for qemu-2.1.0. > > > May be my problem that my host system have ipv6 address but i'm not > able to connect to remote servers via

Re: [Qemu-devel] [PATCH 0/3] slirp: deliver received TCP RSTs to the guest

Hello, Steven Luo, on Wed 06 Apr 2016 17:00:50 -0700, wrote: > That said, sorecvoob() also calls soread(), so I'd guess we need to > deal with the possibility that soread() frees the socket in that case > as well? Indeed, then sorecvoob() needs to return that information, so slirp_pollfds_poll

Re: [Qemu-devel] [PATCH 0/3] slirp: deliver received TCP RSTs to the guest

Hello, Thanks for this! ste...@steven676.net, on Tue 05 Apr 2016 17:13:58 -0700, wrote: > The second, > which fixes delivery of an RST interrupting an already-established TCP > connection, was submitted by Edgar Iglesias in 2008 and appears to have > been missed then. The last patch fixes the

[Qemu-devel] [PULL 1/4] slirp: don't crash when tcp_sockclosed() is called with a NULL tp

From: Steven Luo <steven+q...@steven676.net> Signed-off-by: Steven Luo <steven+q...@steven676.net> Reviewed-by: Edgar E. Iglesias <edgar.igles...@xilinx.com> Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> --- slirp/tcp_subr.c | 7 +-- 1 file cha

[Qemu-devel] [PULL 4/4] slirp: handle deferred ECONNREFUSED on non-blocking TCP sockets

hat we deliver the appropriate RST to the guest in this case. Signed-off-by: Steven Luo <steven+q...@steven676.net> Reviewed-by: Edgar E. Iglesias <edgar.igles...@xilinx.com> Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> --- slirp/socket.c| 2 +- slirp/tcp_inp

[Qemu-devel] [PULL 3/4] slirp: Propagate host TCP RST to the guest.

tyle adjustments] Signed-off-by: Steven Luo <steven+q...@steven676.net> Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> --- slirp/socket.c | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/slirp/socket.c b/slirp/socket.c index 7f022a6

[Qemu-devel] [PULL 0/4] slirp: deliver received TCP RSTs to the guest

The following changes since commit 7acbff99c6c285b3070bf0e768d56f511e2bf346: Update version for v2.6.0-rc1 release (2016-04-05 21:53:18 +0100) are available in the git repository at: http://people.debian.org/~sthibault/qemu.git tags/samuel-thibault for you to fetch changes up

[Qemu-devel] [PULL 2/4] slirp: avoid use-after-free in slirp_pollfds_poll() if soread() returns an error

From: Steven Luo <steven+q...@steven676.net> Samuel Thibault pointed out that it's possible that slirp_pollfds_poll() will try to use a socket even after soread() returns an error, resulting in an use-after-free if the socket was removed while handling the error. Avoid this by re

[Qemu-devel] [PULL 2/4] slirp: avoid use-after-free in slirp_pollfds_poll() if soread() returns an error

From: Steven Luo <steven+q...@steven676.net> Samuel Thibault pointed out that it's possible that slirp_pollfds_poll() will try to use a socket even after soread() returns an error, resulting in an use-after-free if the socket was removed while handling the error. Avoid this by re

[Qemu-devel] [PULL 1/4] slirp: don't crash when tcp_sockclosed() is called with a NULL tp

From: Steven Luo <steven+q...@steven676.net> Signed-off-by: Steven Luo <steven+q...@steven676.net> Reviewed-by: Edgar E. Iglesias <edgar.igles...@xilinx.com> Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> --- slirp/tcp_subr.c | 7 +-- 1 file cha

[Qemu-devel] [PULL 3/4] slirp: Propagate host TCP RST to the guest.

ias <edgar.igles...@xilinx.com> [ste...@steven676.net: coding style adjustments] Signed-off-by: Steven Luo <steven+q...@steven676.net> Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> --- slirp/socket.c | 17 - 1 file changed, 16 insertions(+), 1 deletion

[Qemu-devel] [PULL 4/4] slirp: handle deferred ECONNREFUSED on non-blocking TCP sockets

hat we deliver the appropriate RST to the guest in this case. Signed-off-by: Steven Luo <steven+q...@steven676.net> Reviewed-by: Edgar E. Iglesias <edgar.igles...@xilinx.com> Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> --- slirp/socket.c| 2 +- slirp/tcp_inp

Re: [Qemu-devel] [PULL 0/4] slirp: deliver received TCP RSTs to the guest

Peter Maydell, on Thu 07 Apr 2016 11:37:45 +0100, wrote: > Thanks; Samuel, can I ask you to respin with that line added? Done so. Samuel

[Qemu-devel] [PULL 0/4] slirp: deliver received TCP RSTs to the guest

The following changes since commit 7acbff99c6c285b3070bf0e768d56f511e2bf346: Update version for v2.6.0-rc1 release (2016-04-05 21:53:18 +0100) are available in the git repository at: http://people.debian.org/~sthibault/qemu.git tags/samuel-thibault for you to fetch changes up

Re: [Qemu-devel] [PATCH] slirp: Allow to disable IPv4 or IPv6

Markus Armbruster, on Mon 21 Mar 2016 08:33:52 +0100, wrote: > > +either in the form a.b.c.d or as number of valid top-most bits. Set to > > 0.0.0.0 > > +to disable IPv4 completely. Default is 10.0.2.0/24. > > Long line. How long is too long? This is 78 characters, and I see plenty of lines

[Qemu-devel] [PULL] slirp: Fix memory leak on small incoming ipv4 packet

Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> --- slirp/ip_input.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/slirp/ip_input.c b/slirp/ip_input.c index 12f173d..b464f6b 100644 --- a/slirp/ip_input.c +++ b/slirp/ip_input.c @@ -85,7 +85,7 @@ ip_input(

[Qemu-devel] [PATCH] slirp: Allow to disable IPv4 or IPv6

Make net=0.0.0.0 disable IPv4 and ip6-net=:: disable IPv6, so the user can setup IPv4-only and IPv6-only network environments. Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> --- net/slirp.c | 8 +--- qapi-schema.json | 4 ++-- qemu-options.hx | 7 --- sli

Re: [Qemu-devel] [PATCH] slirp: Allow to disable IPv4 or IPv6

Samuel Thibault, on Sun 20 Mar 2016 12:39:14 +0100, wrote: > void icmp6_init(Slirp *slirp) > { > +if (in6_zero(>vprefix_addr6)) { > +/* IPv6 is disabled */ > +return; > +} > + (Note: vprefix_addr6 is not actually initialized yet at that point, w

Re: [Qemu-devel] [PATCH] slirp: Allow to disable IPv4 or IPv6

Markus Armbruster, on Mon 21 Mar 2016 08:33:52 +0100, wrote: > Samuel Thibault <samuel.thiba...@ens-lyon.org> writes: > > Make net=0.0.0.0 disable IPv4 and ip6-net=:: disable IPv6, so the user can > > setup IPv4-only and IPv6-only network environments. > > Do "ne

Re: [Qemu-devel] [PULL] slirp: Fix memory leak on small incoming ipv4 packet

Hello, Peter Maydell, on Mon 21 Mar 2016 09:48:48 +, wrote: > Generally the > process for QEMU is that first patches are sent as normal [PATCH] mails, > for code review. Patches should only be put into pull requests once > they've been through the review process. (And then you can batch them

[Qemu-devel] [PATCH] slirp: Fix memory leak on small incoming ipv4 packet

Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> --- slirp/ip_input.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/slirp/ip_input.c b/slirp/ip_input.c index 12f173d..b464f6b 100644 --- a/slirp/ip_input.c +++ b/slirp/ip_input.c @@ -85,7 +85,7 @@ ip_input(

[Qemu-devel] [PATCH] slirp: send icmp6 errors when UDP send failed

Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> --- slirp/udp6.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/slirp/udp6.c b/slirp/udp6.c index 60a91c9..a23026f 100644 --- a/slirp/udp6.c +++ b/slirp/udp6.c @@ -113,8 +113,7 @@ void udp6_input(struct m

Re: [Qemu-devel] [PATCH] slirp: Allow to disable IPv4 or IPv6

Hello, Markus Armbruster, on Mon 21 Mar 2016 08:33:52 +0100, wrote: > > -# @net: #optional IP address and optional netmask > > +# @net: #optional IP address and optional netmask. Set to 0.0.0.0 to > > disable IPv4 completely > > Long line. > > Syntax? Default value? Something like this? #

Re: [Qemu-devel] [PULL 00/13] vhost, virtio, pci, pxe

Peter Maydell, on Wed 23 Mar 2016 12:43:44 +, wrote: > On 23 March 2016 at 00:05, Samuel Thibault <samuel.thiba...@gnu.org> wrote: > > Peter Maydell, on Fri 19 Feb 2016 12:09:17 +, wrote: > >> diff --git a/slirp/mbuf.h b/slirp/mbuf.h > >> index 38fedf4

[Qemu-devel] [PULL] slirp: Fix memory leak on small incoming ipv4 packet

Samuel Thibault (1): slirp: Fix memory leak on small incoming ipv4 packet slirp/ip_input.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[Qemu-devel] [PULL] slirp: Fix memory leak on small incoming ipv4 packet

Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> --- slirp/ip_input.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/slirp/ip_input.c b/slirp/ip_input.c index 12f173d..b464f6b 100644 --- a/slirp/ip_input.c +++ b/slirp/ip_input.c @@ -85,7 +85,7 @@ ip_input(

Re: [Qemu-devel] [PULL] slirp: Fix memory leak on small incoming ipv4 packet

Ah, sorry, that didn't include the cover letter with the branch to pull from. I have resent the pull request. Samuel

Re: [Qemu-devel] [PATCH 2/3] slirp: Add dns6 resolution

Samuel Thibault, on Sun 20 Mar 2016 15:45:25 +0100, wrote: > -*pdns_addr = dns_addr; > +memcpy(pdns_addr, _addr, addrlen); Oops, sorry, it should have been > +memcpy(pdns_addr, cached_addr, addrlen); In my tests I had forgotten to try resolving more than o

[Qemu-devel] [PATCH 4/4] slirp: Add RDNSS advertisement

This adds the RDNSS option to IPv6 router advertisements, so that the guest can autoconfigure the DNS server address. Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> --- slirp/ip6_icmp.c | 19 --- slirp/ip6_icmp.h | 12 ++-- 2 files changed, 26 inse

[Qemu-devel] [PATCH 3/4] slirp: Support link-local DNS addresses

They look like fe80::%eth0 Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> --- slirp/libslirp.h | 2 +- slirp/slirp.c| 26 ++ slirp/socket.c | 2 +- 3 files changed, 24 insertions(+), 6 deletions(-) diff --git a/slirp/libslirp.h b/slirp/libs

[Qemu-devel] [PATCH 0/4] slirp: Add dns6 support

This adds support for DNS over IPv6 in slirp, which is notably useful when the host has only an IPv6 DNS server. This series depends on "slirp: Allow to disable IPv4 or IPv6" which defines in6_zero. Samuel Thibault (4): slirp: Split get_dns_addr slirp: Add dns6 resolution slir

[Qemu-devel] [PULL] slirp: send icmp6 errors when UDP send failed

Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> --- slirp/udp6.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/slirp/udp6.c b/slirp/udp6.c index 60a91c9..a23026f 100644 --- a/slirp/udp6.c +++ b/slirp/udp6.c @@ -113,8 +113,7 @@ void udp6_input(struct m

[Qemu-devel] [PATCH 1/4] slirp: Split get_dns_addr

Separate get_dns_addr into get_dns_addr_cached and get_dns_addr_resolv_conf to make conversion to IPv6 easier. Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> --- slirp/slirp.c | 53 ++--- 1 file changed, 34 insertions(

[Qemu-devel] [PATCH 2/4] slirp: Add dns6 resolution

This makes get_dns_addr address family-agnostic, thus allowing to add the IPv6 case. Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> --- slirp/libslirp.h | 1 + slirp/slirp.c| 72 slirp/socket.c | 4 ++-- 3

[Qemu-devel] [PULL] slirp: send icmp6 errors when UDP send failed

Samuel Thibault (1): slirp: send icmp6 errors when UDP send failed slirp/udp6.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)

[Qemu-devel] [PATCH 2/3] slirp: Add dns6 resolution

This makes get_dns_addr address family-agnostic, thus allowing to add the IPv6 case. Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> --- slirp/libslirp.h | 1 + slirp/slirp.c| 72 slirp/socket.c | 4 ++-- 3

[Qemu-devel] [PATCH 3/3] slirp: Support link-local DNS addresses

They look like fe80::%eth0 Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> --- slirp/libslirp.h | 2 +- slirp/slirp.c| 26 ++ slirp/socket.c | 2 +- 3 files changed, 24 insertions(+), 6 deletions(-) diff --git a/slirp/libslirp.h b/slirp/libs

[Qemu-devel] [PATCH 1/3] slirp: Split get_dns_addr

Separate get_dns_addr into get_dns_addr_cached and get_dns_addr_resolv_conf to make conversion to IPv6 easier. Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> --- slirp/slirp.c | 53 ++--- 1 file changed, 34 insertions(

[Qemu-devel] [PATCH 0/3] Add dns6 support

This adds support for DNS over IPv6 in slirp, which is notably useful when the host has only an IPv6 DNS server. Samuel Thibault (3): slirp: Split get_dns_addr slirp: Add dns6 resolution slirp: Support link-local DNS addresses slirp/libslirp.h | 1 + slirp/slirp.c| 117

Re: [Qemu-devel] [PULL 00/13] vhost, virtio, pci, pxe

Hello Peter, Peter Maydell, on Fri 19 Feb 2016 12:09:17 +, wrote: > diff --git a/slirp/mbuf.h b/slirp/mbuf.h > index 38fedf4..ef5a4f7 100644 > --- a/slirp/mbuf.h > +++ b/slirp/mbuf.h > @@ -81,11 +81,9 @@ struct mbuf { > Slirp *slirp; > boolresolution_requested; >

[Qemu-devel] [PATCHv2] slirp: Allow disabling IPv4 or IPv6

Add ipv4 and ipv6 boolean options, so the user can setup IPv4-only and IPv6-only network environments. Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> --- Changes since previous versions: - Introduce boolean options ipv4 and ipv6 instead of net=none and ip6-net=none. -

[Qemu-devel] [PATCHv3 0/2] Rework ipv6 options, add ipv4/ipv6 enabling/disabling options

This is a split of the previously-sent "Allow disabling IPv4 or IPv6" patch, to separate reworking the existing newly-added options and the new ipv4/ipv6 options. Samuel Thibault (2): Rework ipv6 options slirp: Allow disabling IPv4 or IPv6 net/slirp.c

[Qemu-devel] [PATCHv3 1/2] Rework ipv6 options

Rename ip6-foo options into ipv6-foo options, to make them coherent with other ipv6 options. Also rework the documentation. --- net/slirp.c | 6 +++--- qapi-schema.json | 25 - qemu-options.hx | 18 ++ 3 files changed, 29 insertions(+), 20

Re: [Qemu-devel] [PATCHv2] slirp: Allow to disable IPv4 or IPv6

Eric Blake, on Thu 24 Mar 2016 15:36:19 -0600, wrote: > > Make net=none disable IPv4 and ip6-net=none disable IPv6, so the user can > > setup IPv4-only and IPv6-only network environments. > > This mentions 'net=none', but I don't see that in the patch below; > instead I see a new boolean.

Re: [Qemu-devel] [PATCHv2] slirp: Allow to disable IPv4 or IPv6

Hello, Eric Blake, on Thu 24 Mar 2016 15:36:19 -0600, wrote: > What happens if 'net' is provided but 'ip4' is false? Is that a user error? We could do that, yes. > The existing 'InetSocketAddress' QAPI type spells these as 'ipv4' and > ipv6'; should we use the same spelling for consistency?

[Qemu-devel] [PATCHv2] slirp: Allow to disable IPv4 or IPv6

Make net=none disable IPv4 and ip6-net=none disable IPv6, so the user can setup IPv4-only and IPv6-only network environments. Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> --- net/slirp.c | 19 +-- qapi-schema.json | 15 +-- qemu-opti

Re: [Qemu-devel] [PATCH 0/4] slirp: Add dns6 support

Hello, Could somebody review this? This will be needed for ipv6-only setups. Samuel Samuel Thibault, on Sun 20 Mar 2016 16:26:24 +0100, wrote: > This adds support for DNS over IPv6 in slirp, which is notably useful when the > host has only an IPv6 DNS server. > > This series depen

Re: [Qemu-devel] [PATCHv3 2/2] slirp: Allow disabling IPv4 or IPv6

Samuel Thibault, on Fri 25 Mar 2016 00:25:55 +0100, wrote: > Also rename recently-added options to make the whole coherent before 2.6 > gets released. GRaaAH I'm so motivated by such bike-shedding changes that I forgot to rework the changelog. Let me do that yet again. Samuel

[Qemu-devel] [PATCHv3 2/2] slirp: Allow disabling IPv4 or IPv6

Add ipv4 and ipv6 boolean options, so the user can setup IPv4-only and IPv6-only network environments. Also rename recently-added options to make the whole coherent before 2.6 gets released. Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> --- Changes since previous ve

[Qemu-devel] [PATCHv4 1/2] Rework ipv6 options

Rename the recently-added ip6-foo options into ipv6-foo options, to make them coherent with other ipv6 options. Also rework the documentation. Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> --- net/slirp.c | 6 +++--- qapi-schema.json | 25 -

[Qemu-devel] [PATCHv4 2/2] slirp: Allow disabling IPv4 or IPv6

Add ipv4 and ipv6 boolean options, so the user can setup IPv4-only and IPv6-only network environments. Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> --- Changes since previous versions: - Introduce boolean options ipv4 and ipv6 instead of net=none and ip6-net=none. -

[Qemu-devel] [PATCHv4 0/2] Rework ipv6 options, add ipv4/ipv6 enabling/disabling options

This is a split of the previously-sent "Allow disabling IPv4 or IPv6" patch, to separate reworking the existing newly-added options and the new ipv4/ipv6 options. Samuel Thibault (2): Rework ipv6 options slirp: Allow disabling IPv4 or IPv6 net/slirp.c

Re: [Qemu-devel] [PATCHv9 0/10] slirp: Adding IPv6 support to Qemu -net user mode

Jason Wang, on Mon 07 Mar 2016 14:48:16 +0800, wrote: > - Lots of checkpatch warnings, let's try to silent it. They are indentation issues, yes. They are already existing in slirp/ . Whenever new code was added we sticked with the qemu style, but for patched code we prefered to stick to the

Re: [Qemu-devel] [PATCHv9 09/10] qapi-schema, qemu-options & slirp: Adding Qemu options for IPv6 addresses

Jason Wang, on Mon 07 Mar 2016 15:05:05 +0800, wrote: > Please do unnecessary changes like this since it will cause extra effort > for git blame and other things. Ok. I just do hope that no other reviewer will come and say that we should fix the alignment of the parameters. Samuel

Re: [Qemu-devel] [PATCHv9 03/10] slirp: Adding IPv6 UDP support

Jason Wang, on Mon 07 Mar 2016 14:57:11 +0800, wrote: > Part of the codes looks duplicated with ipv4 version. Any chances to > merge them like tcp? The duplication is actually quite small: accessing the ip length is different, filling the address is different, etc. So there are differences all

Re: [Qemu-devel] [PATCHv9 0/10] slirp: Adding IPv6 support to Qemu -net user mode

Jason Wang, on Mon 07 Mar 2016 13:03:11 +0800, wrote: > Btw, do you want to be the maintainer of slirp? (Or maybe Tohmas want to > do this?) I already said I was fine with it, yes, and submitted a MAINTAINERS patch towards that, without any response. Samuel

Re: [Qemu-devel] [PATCHv9 01/10] slirp: Adding IPv6, ICMPv6 Echo and NDP autoconfiguration

Jason Wang, on Mon 07 Mar 2016 14:53:54 +0800, wrote: > > +switch (ip6->ip_nh) { > > +#if 0 > > +case IPPROTO_TCP: > > +tcp_input(m, hlen, (struct socket *)NULL); > > +break; > > +case IPPROTO_UDP: > > +udp_input(m, hlen); > > +break; > > +#endif > >

Re: [Qemu-devel] [PATCHv9 06/10] slirp: Reindent after refactoring

Jason Wang, on Mon 07 Mar 2016 15:02:53 +0800, wrote: > On 02/23/2016 03:28 AM, Samuel Thibault wrote: > > From: Guillaume Subiron <maet...@subiron.org> > > > > No code change. > > > > Signed-off-by: Guillaume Subiron <maet...@subiron.org> > >

Re: [Qemu-devel] [PATCHv9 0/10] slirp: Adding IPv6 support to Qemu -net user mode

Jan Kiszka, on Mon 07 Mar 2016 13:06:20 +0100, wrote: > On 2016-03-07 12:09, Samuel Thibault wrote: > > Jason Wang, on Mon 07 Mar 2016 13:03:11 +0800, wrote: > >> Btw, do you want to be the maintainer of slirp? (Or maybe Tohmas want to > >> do this?) > > > >

Re: [Qemu-devel] [PATCHv9 09/10] qapi-schema, qemu-options & slirp: Adding Qemu options for IPv6 addresses

Jason Wang, on Mon 07 Mar 2016 15:05:05 +0800, wrote: > Please do unnecessary changes like this since it will cause extra effort > for git blame and other things. Which is exactly why we avoided to fix all the checkpatch warnings by leaving existing non-qemu-style indentation. Samuel

Re: [Qemu-devel] [PATCHv9 0/10] slirp: Adding IPv6 support to Qemu -net user mode

Jason Wang, on Mon 07 Mar 2016 14:48:16 +0800, wrote: > - the series does not build on w32: > In file included from ./slirp/slirp.h:126:0, > from stubs/slirp.c:3: > ./slirp/ip6.h:9:24: fatal error: netinet/in.h: No such file or directory Is it the only issue? Does it build if

[Qemu-devel] [PATCHv10 03/11] slirp: Adding ICMPv6 error sending

denave <m...@meowstars.org> Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> Reviewed-by: Thomas Huth <th...@redhat.com> --- slirp/ip6_icmp.c | 66 +++ slirp/ip6_icmp.h | 10 + slirp/ip6_input.c | 11 +++

[Qemu-devel] [PATCHv10 01/11] slirp: Adding IPv6, ICMPv6 Echo and NDP autoconfiguration

he RFC, to make the guest refresh its route. This also adds ip6_cksum() to compute ICMPv6 checksums using IPv6 pseudo-header. Some #define ETH_* are moved upper in slirp.h to make them accessible to other slirp/*.h Signed-off-by: Guillaume Subiron <maet...@subiron.org> Signed-off-by: Sam

[Qemu-devel] [PATCHv10 04/11] slirp: Adding IPv6 UDP support

<maet...@subiron.org> Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> Reviewed-by: Thomas Huth <th...@redhat.com> --- slirp/Makefile.objs | 2 +- slirp/ip6_input.c | 2 +- slirp/socket.c | 43 +++--- slirp/socket.h | 6 ++ slirp/udp.h

[Qemu-devel] [PATCHv10 08/11] slirp: Handle IPv6 in TCP functions

; Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> Reviewed-by: Thomas Huth <th...@redhat.com> --- slirp/ip6_input.c | 3 ++- slirp/tcp.h| 2 ++ slirp/tcp_input.c | 72 +- slirp/tcp_output.c | 16

[Qemu-devel] [PATCHv10 10/11] qapi-schema, qemu-options & slirp: Adding Qemu options for IPv6 addresses

ec0::3. Signed-off-by: Yann Bordenave <m...@meowstars.org> Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> --- net/net.c| 31 ++ net/slirp.c | 81 +++- qapi-schema.json | 12 + qem

[Qemu-devel] [PATCHv10 06/11] slirp: Generalizing and neutralizing various TCP functions before adding IPv6 stuff

they are working on. This patch does not include the entailed reindentation, to make proofread easier. Reindentation is adressed in the following no-op patch. Signed-off-by: Guillaume Subiron <maet...@subiron.org> Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> Reviewed-by: T

[Qemu-devel] [PATCHv10 02/11] slirp: Fix ICMP error sending

From: Yann Bordenave <m...@meowstars.org> Disambiguation : icmp_error is renamed into icmp_send_error, since it doesn't manage errors, but only sends ICMP Error messages. Signed-off-by: Yann Bordenave <m...@meowstars.org> Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyo

[Qemu-devel] [PATCHv10 0/11] slirp: Adding IPv6 support to Qemu -net user mode

Hello, This is another respin of IPv6 in Qemu -net user mode. These patches add ICMPv6, NDP, make UDP and TCP compatible with IPv6, and add TFTP over IPv6. Difference with version 9 is: - split icmp error patch in two - fix sending icmp6 errors on unreachable net or host - forbidding prefix

[Qemu-devel] [PATCHv10 11/11] slirp: Add IPv6 support to the TFTP code

th <th...@redhat.com> Reviewed-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> --- slirp/tftp.c | 133 +-- slirp/tftp.h | 7 ++-- slirp/udp.c | 16 --- slirp/udp6.c | 16 +-- 4 files changed, 100 insertions(+), 72 deletions(-)

[Qemu-devel] [PATCHv10 07/11] slirp: Reindent after refactoring

From: Guillaume Subiron <maet...@subiron.org> No code change. Signed-off-by: Guillaume Subiron <maet...@subiron.org> Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> Reviewed-by: Thomas Huth <th...@redhat.com> ---

[Qemu-devel] [PATCHv10 09/11] slirp: Adding IPv6 address for DNS relay

resses. For now this only points to localhost. Further development will be needed to automatically fetch the IPv6 address from resolv.conf, and announce this via RDNSS. Signed-off-by: Guillaume Subiron <maet...@subiron.org> Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> R

[Qemu-devel] [PATCHv10 05/11] slirp: Factorizing tcpiphdr structure with an union

margin computation in various functions, and makes them compatible with the new tcpiphdr structure, whose size will be bigger than sizeof(struct tcphdr) + sizeof(struct ip) Signed-off-by: Guillaume Subiron <maet...@subiron.org> Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> R

[Qemu-devel] [PULL] MAINTAINERS: Add Samuel Thibault as slirp maintainer

From: Samuel Thibault <samuel.thiba...@gnu.org> Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 2f5a338..a316bc3 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1217,6

[Qemu-devel] [PULL] MAINTAINERS: Add Samuel Thibault as slirp maintainer

-thibault for you to fetch changes up to 1aa0033e3b8cce188be885573763552baccb1316: MAINTAINERS: Add Samuel Thibault as slirp maintainer (2016-03-07 14:42:51 +0100) Add Samuel Thibault as slirp maintainer

Re: [Qemu-devel] [PATCHv9 0/10] slirp: Adding IPv6 support to Qemu -net user mode

Jason Wang, on Tue 08 Mar 2016 10:48:27 +0800, wrote: > ./scripts/checkpatch.pl > 0001-slirp-Adding-IPv6-ICMPv6-Echo-and-NDP-autoconfigurat.patch > ERROR: return is not a function, parentheses are not required > #177: FILE: slirp/ip6.h:65: > +return (a->s6_addr[prefix_len / 8] & ((1U << (8 -

Re: [Qemu-devel] [PATCHv9 0/10] slirp: Adding IPv6 support to Qemu -net user mode

Jason Wang, on Tue 08 Mar 2016 10:15:57 +0800, wrote: > Build works but get some warnings: > > > slirp/ip6_icmp.c: In function 'icmp6_send_error': > slirp/ip6_icmp.c:84:5: warning: implicit declaration of function > 'inet_ntop' [-Wimplicit-function-declaration] > inet_ntop(AF_INET6,

Re: [Qemu-devel] [PATCHv9 0/10] slirp: Adding IPv6 support to Qemu -net user mode

Hello, Jan Kiszka, on Fri 04 Mar 2016 16:50:32 +0100, wrote: > On 2016-03-04 09:41, Thomas Huth wrote: > > On 22.02.2016 20:28, Samuel Thibault wrote: > >> Hello, > >> > >> This is another respin of IPv6 in Qemu -net user mode. > >> > >> Thes

Re: [Qemu-devel] [PATCHv9 0/10] slirp: Adding IPv6 support to Qemu -net user mode

Thomas Huth, on Mon 07 Mar 2016 13:00:48 +0100, wrote: > On 07.03.2016 12:19, Samuel Thibault wrote: > > Jason Wang, on Mon 07 Mar 2016 14:48:16 +0800, wrote: > >> - I expects a unit-test for this. You may want to have a look at the > >> pxe-test in tests/, I think i

Re: [Qemu-devel] [PATCHv9 02/10] slirp: Adding ICMPv6 error sending

Jason Wang, on Mon 07 Mar 2016 14:55:52 +0800, wrote: > On 02/23/2016 03:28 AM, Samuel Thibault wrote: > > From: Yann Bordenave <m...@meowstars.org> > > > > Disambiguation : icmp_error is renamed into icmp_send_error, since it > > doesn't manage errors, b

[Qemu-devel] [PULL] MAINTAINERS: Add Samuel Thibault as slirp maintainer

From: Samuel Thibault <samuel.thiba...@gnu.org> Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 2f5a338..a316bc3 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1217,6

[Qemu-devel] [PULL] MAINTAINERS: Add Samuel Thibault as slirp maintainer

to fetch changes up to 1aa0033e3b8cce188be885573763552baccb1316: MAINTAINERS: Add Samuel Thibault as slirp maintainer (2016-03-07 14:42:51 +0100) Samuel Thibault (1): MAINTAINERS: Add Samuel Thibault as slirp maintainer

Re: [Qemu-devel] [PATCHv9 0/10] slirp: Adding IPv6 support to Qemu -net user mode

Hello, Thomas Huth, on Mon 07 Mar 2016 16:37:59 +0100, wrote: > Is that "#include " required in ip6.h at all? It also seems > to compile if I omit that include completely here... Well, it makes sense to put it in ip6.h. That said, since ip6.h is only included through slirp.h which includes

[Qemu-devel] [PULL] slirp updates

The following changes since commit de1d099a448beb2ec39af4bd9ce4dd6452a18cb5: Merge remote-tracking branch 'remotes/thibault/tags/samuel-thibault-2' into staging (2016-04-01 11:15:20 +0100) are available in the git repository at: http://people.debian.org/~sthibault/qemu.git tags/samuel

[Qemu-devel] [PULL] slirp: Allow disabling IPv4 or IPv6

Add ipv4 and ipv6 boolean options, so the user can setup IPv4-only and IPv6-only network environments. Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> Reviewed-by: Thomas Huth <th...@redhat.com> --- net/slirp.c | 36 ++-- qapi-schem

Re: [Qemu-devel] [PATCH 1/5] slirp: Allow disabling IPv4 or IPv6

Thomas Huth, on Wed 30 Mar 2016 17:29:12 +0200, wrote: > On 30.03.2016 17:13, Samuel Thibault wrote: > > Thomas Huth, on Wed 30 Mar 2016 17:06:51 +0200, wrote: > >> The "restrict" option is listed with "=on|off" here, that's why I > >> thought it sh

Re: [Qemu-devel] [PATCH 1/5] slirp: Allow disabling IPv4 or IPv6

Hello, Thomas Huth, on Wed 30 Mar 2016 10:38:46 +0200, wrote: > > -"-netdev > > user,id=str[,net=addr[/mask]][,host=addr][,ipv6-net=addr[/int]]\n" > > -" > > [,ipv6-host=addr][,restrict=on|off][,hostname=host][,dhcpstart=addr]\n" > > +"-netdev

Re: [Qemu-devel] [PATCH 1/5] slirp: Allow disabling IPv4 or IPv6

Thomas Huth, on Wed 30 Mar 2016 17:06:51 +0200, wrote: > The "restrict" option is listed with "=on|off" here, that's why I > thought it should be there for "ipv4" and "ipv6", too. Which boolean > options are missing the "=on|off" ? All the ipv4 and ipv6 options in the same file. Samuel

Re: [Qemu-devel] [PATCH] slirp: Fix migration from older versions of QEMU to the current one

t's fix > this by checking the version ID of the migration stream and by using > the old behavior if we've detected version 3 or less. > > Signed-off-by: Thomas Huth <th...@redhat.com> Reviewed-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> Just realizing... We'd need to add AF

Re: [Qemu-devel] [PULL 0/5] ipv4-only and ipv6-only support

Peter Maydell, on Thu 31 Mar 2016 15:11:27 +0100, wrote: > On 31 March 2016 at 13:51, Samuel Thibault <samuel.thiba...@gnu.org> wrote: > > Peter Maydell, on Thu 31 Mar 2016 13:47:28 +0100, wrote: > >> On 31 March 2016 at 10:20, Samuel Thibault <samuel.thiba..

Re: [Qemu-devel] [PULL 0/5] ipv4-only and ipv6-only support

Peter Maydell, on Thu 31 Mar 2016 15:44:13 +0100, wrote: > if (get_dns6_addr(>sin6_addr, > >sin6_scope_id) < 0) { > ^ > In file included from > /home/petmay01/linaro/qemu-for-merges/slirp/slirp.h:99:0, > from

[Qemu-devel] [PULL] slirp updates

MAINTAINERS: Delete invalid maintainer entries of the Exynos section (2016-03-31 18:21:01 +0100) are available in the git repository at: http://people.debian.org/~sthibault/qemu.git tags/samuel-thibault-2 for you to fetch changes up to eaf136f9a21e02a2f55346e44d2d88df37b2cde3: slirp

[Qemu-devel] [PULL] slirp: Fix migration from older versions of QEMU to the current one

ration stream and by using the old behavior if we've detected version 3 or less. Signed-off-by: Thomas Huth <th...@redhat.com> Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> --- slirp/slirp.c | 44 ++-- 1 file changed, 26 insertions(+

<    1   2   3   4   5   6   7   8   9   10   >