RE: [PATCH v6] Hexagon: add PC alignment check and exception

2024-05-07 Thread Brian Cain
> -Original Message- > From: Matheus Bernardino (QUIC) > Sent: Friday, May 3, 2024 11:53 AM > To: qemu-devel@nongnu.org > Cc: Brian Cain ; Sid Manning ; > a...@rev.ng; a...@rev.ng; ltaylorsimp...@gmail.com; > richard.hender...@linaro.org; Laurent Vivier > Sub

[PULL 10/15] Hexagon (target/hexagon) Mark has_pred_dest in trans functions

2024-05-05 Thread Brian Cain
From: Taylor Simpson Check that the value matches opcode_wregs Signed-off-by: Taylor Simpson Reviewed-by: Brian Cain Message-Id: <20240307032327.4799-5-ltaylorsimp...@gmail.com> Signed-off-by: Brian Cain --- target/hexagon/decode.c | 3 +++ target/hexagon/gen_trans_funcs.

[PULL 14/15] Hexagon (target/hexagon) Remove gen_shortcode.py

2024-05-05 Thread Brian Cain
From: Taylor Simpson This data structure is not used Signed-off-by: Taylor Simpson Reviewed-by: Brian Cain Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20240307032327.4799-9-ltaylorsimp...@gmail.com> Signed-off-by: Brian Cain --- target/hexagon/README | 1 - target/h

[PULL 05/15] Hexagon (target/hexagon) Pass SP explicitly to helpers that need it

2024-05-05 Thread Brian Cain
From: Taylor Simpson Rather than reading SP from the env, pass it explicitly Signed-off-by: Taylor Simpson Reviewed-by: Anton Johansson Tested-by: Anton Johansson Reviewed-by: Brian Cain Message-Id: <20240214042726.19290-3-ltaylorsimp...@gmail.com> Signed-off-by: Brian Cain ---

[PULL 15/15] Hexagon (target/hexagon) Remove hex_common.read_attribs_file

2024-05-05 Thread Brian Cain
From: Taylor Simpson The attribinfo data structure is not used Adjust the command-line arguments to the python scripts Add hex_common.read_common_files for TCG/helper generation scripts Signed-off-by: Taylor Simpson Reviewed-by: Brian Cain Reviewed-by: Philippe Mathieu-Daudé Message-Id

[PULL 06/15] Hexagon (target/hexagon) Only pass env to generated helper when needed

2024-05-05 Thread Brian Cain
def-parser disabled: 1543 total, 550 with env Signed-off-by: Taylor Simpson Reviewed-by: Anton Johansson Tested-by: Anton Johansson Message-Id: <20240214042726.19290-4-ltaylorsimp...@gmail.com> Signed-off-by: Brian Cain --- target/hexagon/gen_helper_protos.py | 12 ++--

[PULL 11/15] Hexagon (tests/tcg/hexagon) Test HVX .new read from high half of pair

2024-05-05 Thread Brian Cain
From: Taylor Simpson Make sure the decoding of HVX .new is correctly handling this case Signed-off-by: Taylor Simpson Reviewed-by: Brian Cain Message-Id: <20240307032327.4799-6-ltaylorsimp...@gmail.com> Signed-off-by: Brian Cain --- tests/tcg/hexagon/hvx_misc.c | 16 +++-

[PULL 07/15] Hexagon (target/hexagon) Add is_old/is_new to Register class

2024-05-05 Thread Brian Cain
From: Taylor Simpson Signed-off-by: Taylor Simpson Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Brian Cain Message-Id: <20240307032327.4799-2-ltaylorsimp...@gmail.com> Signed-off-by: Brian Cain --- target/hexagon/hex_common.py | 12 1 file changed, 12 insertions(+)

[PULL 02/15] Hexagon (target/hexagon) Enable more short-circuit packets (scalar core)

2024-05-05 Thread Brian Cain
set_label $L0 exit_tb $0x7f976443 Signed-off-by: Taylor Simpson Reviewed-by: Brian Cain Message-Id: <20240201103340.119081-3-ltaylorsimp...@gmail.com> Signed-off-by: Brian Cain --- target/hexagon/translate.c | 21 - target/hexagon/translate.h | 13 +++-- 2

[PULL 13/15] Hexagon (target/hexagon) Remove gen_op_regs.py

2024-05-05 Thread Brian Cain
From: Taylor Simpson Signed-off-by: Taylor Simpson Reviewed-by: Brian Cain Message-Id: <20240307032327.4799-8-ltaylorsimp...@gmail.com> Signed-off-by: Brian Cain --- target/hexagon/README | 1 - target/hexagon/gen_op_regs.py | 125 -- target/h

[PULL 04/15] Hexagon (target/hexagon) Pass P0 explicitly to helpers that need it

2024-05-05 Thread Brian Cain
From: Taylor Simpson Rather than reading P0 from the env, pass it explicitly Signed-off-by: Taylor Simpson Reviewed-by: Anton Johansson Tested-by: Anton Johansson Reviewed-by: Brian Cain Message-Id: <20240214042726.19290-2-ltaylorsimp...@gmail.com> Signed-off-by: Brian Cain ---

[PULL 12/15] Hexagon (target/hexagon) Remove uses of op_regs_generated.h.inc

2024-05-05 Thread Brian Cain
From: Taylor Simpson Signed-off-by: Taylor Simpson Reviewed-by: Brian Cain Message-Id: <20240307032327.4799-7-ltaylorsimp...@gmail.com> Signed-off-by: Brian Cain --- target/hexagon/decode.c | 55 +++-- target/hexagon/mmvec/decode_ext_mmvec.

[PULL 08/15] Hexagon (target/hexagon) Mark new_read_idx in trans functions

2024-05-05 Thread Brian Cain
From: Taylor Simpson Check that the value matches opcode_reginfo Signed-off-by: Taylor Simpson Reviewed-by: Brian Cain Message-Id: <20240307032327.4799-3-ltaylorsimp...@gmail.com> Signed-off-by: Brian Cain --- target/hexagon/decode.c | 2 ++ target/h

[PULL 00/15] Hexagon: simplify gen for packets w/o read-after-write

2024-05-05 Thread Brian Cain
The following changes since commit 248f6f62df073a3b4158fd0093863ab885feabb5: Merge tag 'pull-axp-20240504' of https://gitlab.com/rth7680/qemu into staging (2024-05-04 08:39:46 -0700) are available in the Git repository at: https://github.com/quic/qemu tags/pull-hex-20240505 for you to

[PULL 09/15] Hexagon (target/hexagon) Mark dest_idx in trans functions

2024-05-05 Thread Brian Cain
From: Taylor Simpson Check that the value matches opcode_reginfo/opcode_wregs Signed-off-by: Taylor Simpson Reviewed-by: Brian Cain Message-Id: <20240307032327.4799-4-ltaylorsimp...@gmail.com> Signed-off-by: Brian Cain --- target/hexagon/decode.c | 2 ++ target/h

[PULL 03/15] Hexagon (target/hexagon) Enable more short-circuit packets (HVX)

2024-05-05 Thread Brian Cain
From: Taylor Simpson Look for read-after-write instead of overlap of reads and writes HVX instructions with helpers have pass-by-reference semantics, so we check for overlaps of reads and writes within the same instruction. Signed-off-by: Taylor Simpson Reviewed-by: Brian Cain Message-Id

[PULL 01/15] Hexagon (target/hexagon) Analyze reads before writes

2024-05-05 Thread Brian Cain
to improving the analysis for short-circuiting the packet semantics in a subsequent commit Signed-off-by: Taylor Simpson Reviewed-by: Brian Cain Message-Id: <20240201103340.119081-2-ltaylorsimp...@gmail.com> Signed-off-by: Brian Cain --- target/hexagon/README | 9 +++--

RE: [PATCH v3] Hexagon: add PC alignment check and exception

2024-04-30 Thread Brian Cain
> -Original Message- > From: Richard Henderson > Sent: Tuesday, April 30, 2024 10:53 AM > To: Matheus Bernardino (QUIC) ; qemu- > de...@nongnu.org > Cc: Brian Cain ; Sid Manning ; > a...@rev.ng; a...@rev.ng; ltaylorsimp...@gmail.com; Laurent Vivier > > Subj

RE: [PATCH] Hexagon: add PC alignment check and exception

2024-04-26 Thread Brian Cain
> -Original Message- > From: Matheus Bernardino (QUIC) > Sent: Friday, April 26, 2024 1:16 PM > To: qemu-devel@nongnu.org > Cc: Brian Cain ; Sid Manning ; > a...@rev.ng; a...@rev.ng; ltaylorsimp...@gmail.com > Subject: [PATCH] Hexagon: add PC alignmen

RE: [PATCH v2 1/3] Hexagon (target/hexagon) Analyze reads before writes

2024-03-28 Thread Brian Cain
> -Original Message- > From: Taylor Simpson > Sent: Thursday, February 1, 2024 4:34 AM > To: qemu-devel@nongnu.org > Cc: Brian Cain ; Matheus Bernardino (QUIC) > ; Sid Manning ; > Marco Liebel (QUIC) ; > richard.hender...@linaro.org; phi...@linaro.org;

RE: [PATCH v2 2/3] Hexagon (target/hexagon) Enable more short-circuit packets (scalar core)

2024-03-28 Thread Brian Cain
> -Original Message- > From: Taylor Simpson > Sent: Thursday, February 1, 2024 4:34 AM > To: qemu-devel@nongnu.org > Cc: Brian Cain ; Matheus Bernardino (QUIC) > ; Sid Manning ; > Marco Liebel (QUIC) ; > richard.hender...@linaro.org; phi...@linaro.org;

RE: [PATCH v2 3/3] Hexagon (target/hexagon) Enable more short-circuit packets (HVX)

2024-03-28 Thread Brian Cain
> -Original Message- > From: Taylor Simpson > Sent: Thursday, February 1, 2024 4:34 AM > To: qemu-devel@nongnu.org > Cc: Brian Cain ; Matheus Bernardino (QUIC) > ; Sid Manning ; > Marco Liebel (QUIC) ; > richard.hender...@linaro.org; phi...@linaro.org;

RE: [PATCH v2 1/9] Hexagon (target/hexagon) Add is_old/is_new to Register class

2024-03-28 Thread Brian Cain
> -Original Message- > From: Taylor Simpson > Sent: Wednesday, March 6, 2024 9:23 PM > To: qemu-devel@nongnu.org > Cc: Brian Cain ; Matheus Bernardino (QUIC) > ; Sid Manning ; > Marco Liebel (QUIC) ; > richard.hender...@linaro.org; phi...@linaro.org;

RE: [PATCH v2 2/9] Hexagon (target/hexagon) Mark new_read_idx in trans functions

2024-03-28 Thread Brian Cain
> -Original Message- > From: Taylor Simpson > Sent: Wednesday, March 6, 2024 9:23 PM > To: qemu-devel@nongnu.org > Cc: Brian Cain ; Matheus Bernardino (QUIC) > ; Sid Manning ; > Marco Liebel (QUIC) ; > richard.hender...@linaro.org; phi...@linaro.org;

RE: [PATCH v2 3/9] Hexagon (target/hexagon) Mark dest_idx in trans functions

2024-03-28 Thread Brian Cain
> -Original Message- > From: Taylor Simpson > Sent: Wednesday, March 6, 2024 9:23 PM > To: qemu-devel@nongnu.org > Cc: Brian Cain ; Matheus Bernardino (QUIC) > ; Sid Manning ; > Marco Liebel (QUIC) ; > richard.hender...@linaro.org; phi...@linaro.org;

RE: [PATCH v2 5/9] Hexagon (tests/tcg/hexagon) Test HVX .new read from high half of pair

2024-03-28 Thread Brian Cain
> -Original Message- > From: Taylor Simpson > Sent: Wednesday, March 6, 2024 9:23 PM > To: qemu-devel@nongnu.org > Cc: Brian Cain ; Matheus Bernardino (QUIC) > ; Sid Manning ; > Marco Liebel (QUIC) ; > richard.hender...@linaro.org; phi...@linaro.org;

RE: [PATCH v2 4/9] Hexagon (target/hexagon) Mark has_pred_dest in trans functions

2024-03-28 Thread Brian Cain
> -Original Message- > From: Taylor Simpson > Sent: Wednesday, March 6, 2024 9:23 PM > To: qemu-devel@nongnu.org > Cc: Brian Cain ; Matheus Bernardino (QUIC) > ; Sid Manning ; > Marco Liebel (QUIC) ; > richard.hender...@linaro.org; phi...@linaro.org;

RE: [PATCH v2 6/9] Hexagon (target/hexagon) Remove uses of op_regs_generated.h.inc

2024-03-28 Thread Brian Cain
> -Original Message- > From: Taylor Simpson > Sent: Wednesday, March 6, 2024 9:23 PM > To: qemu-devel@nongnu.org > Cc: Brian Cain ; Matheus Bernardino (QUIC) > ; Sid Manning ; > Marco Liebel (QUIC) ; > richard.hender...@linaro.org; phi...@linaro.org;

RE: [PATCH v2 7/9] Hexagon (target/hexagon) Remove gen_op_regs.py

2024-03-28 Thread Brian Cain
> -Original Message- > From: Taylor Simpson > Sent: Wednesday, March 6, 2024 9:23 PM > To: qemu-devel@nongnu.org > Cc: Brian Cain ; Matheus Bernardino (QUIC) > ; Sid Manning ; > Marco Liebel (QUIC) ; > richard.hender...@linaro.org; phi...@linaro.org;

RE: [PATCH v2 9/9] Hexagon (target/hexagon) Remove hex_common.read_attribs_file

2024-03-28 Thread Brian Cain
> -Original Message- > From: Taylor Simpson > Sent: Wednesday, March 6, 2024 9:23 PM > To: qemu-devel@nongnu.org > Cc: Brian Cain ; Matheus Bernardino (QUIC) > ; Sid Manning ; > Marco Liebel (QUIC) ; > richard.hender...@linaro.org; phi...@linaro.org;

RE: [PATCH v2 8/9] Hexagon (target/hexagon) Remove gen_shortcode.py

2024-03-28 Thread Brian Cain
> -Original Message- > From: Taylor Simpson > Sent: Wednesday, March 6, 2024 9:23 PM > To: qemu-devel@nongnu.org > Cc: Brian Cain ; Matheus Bernardino (QUIC) > ; Sid Manning ; > Marco Liebel (QUIC) ; > richard.hender...@linaro.org; phi...@linaro.org;

RE: [PATCH-for-9.1 08/27] target/hexagon: Convert to TCGCPUOps::get_cpu_state()

2024-03-22 Thread Brian Cain
; Philippe Mathieu-Daudé ; Brian Cain > > Subject: [PATCH-for-9.1 08/27] target/hexagon: Convert to > TCGCPUOps::get_cpu_state() > > WARNING: This email originated from outside of Qualcomm. Please be wary > of any links or attachments, and do not enable macros. > > Convert cp

RE: [PATCH v3 1/3] Hexagon (target/hexagon) Pass P0 explicitly to helpers that need it

2024-02-16 Thread Brian Cain
> -Original Message- > From: Taylor Simpson > Sent: Tuesday, February 13, 2024 10:27 PM > To: qemu-devel@nongnu.org > Cc: Brian Cain ; Matheus Bernardino (QUIC) > ; Sid Manning ; Marco > Liebel (QUIC) ; richard.hender...@linaro.org; > phi...@linaro.org;

RE: [PATCH v3 2/3] Hexagon (target/hexagon) Pass SP explicitly to helpers that need it

2024-02-16 Thread Brian Cain
> -Original Message- > From: Taylor Simpson > Sent: Tuesday, February 13, 2024 10:27 PM > To: qemu-devel@nongnu.org > Cc: Brian Cain ; Matheus Bernardino (QUIC) > ; Sid Manning ; Marco > Liebel (QUIC) ; richard.hender...@linaro.org; > phi...@linaro.org;

RE: [PATCH v3 2/3] Hexagon (target/hexagon) Pass SP explicitly to helpers that need it

2024-02-16 Thread Brian Cain
> -Original Message- > From: Taylor Simpson > Sent: Tuesday, February 13, 2024 10:27 PM > To: qemu-devel@nongnu.org > Cc: Brian Cain ; Matheus Bernardino (QUIC) > ; Sid Manning ; Marco > Liebel (QUIC) ; richard.hender...@linaro.org; > phi...@linaro.org;

RE: [PATCH v3 11/29] target/hexagon: Prefer fast cpu_env() over slower CPU QOM cast macro

2024-01-29 Thread Brian Cain
enderson ; > Philippe Mathieu-Daudé ; Brian Cain > > Subject: [PATCH v3 11/29] target/hexagon: Prefer fast cpu_env() over slower > CPU QOM cast macro > > WARNING: This email originated from outside of Qualcomm. Please be wary of > any links or attachments, and do not ena

KVM Forum 2024?

2024-01-26 Thread Brian Cain
All, https://kvm-forum.qemu.org/ shows a plan for "Spring 2024" - so that's as soon as ~mid-March or as late as mid-June? I'd like to understand if we think that it's more likely to be later in that range? Last year was mid June I think? So should we expect something similar this year?

RE: hexagon: modeling a shared lock state

2024-01-25 Thread Brian Cain
> -Original Message- > From: Richard Henderson > Sent: Wednesday, January 24, 2024 6:22 PM > To: Brian Cain ; Philippe Mathieu-Daudé > > Cc: qemu-devel@nongnu.org; Sid Manning ; Marco > Liebel ; Matheus Bernardino > > Subject: Re: hexagon: modeling a sha

hexagon: modeling a shared lock state

2024-01-24 Thread Brian Cain
Philippe, For hexagon sysemu, while internally reviewing patches to be upstreamed we noticed that our design for a lock instruction is not quite suitable. The k0lock instruction will halt if some other hexagon hardware CPU has already claimed the kernel lock, only to continue executing once

[PULL 11/15] Hexagon (target/hexagon) Remove dead functions from hex_common.py

2024-01-21 Thread Brian Cain
From: Taylor Simpson These functions are no longer used after making the generators object oriented. Signed-off-by: Taylor Simpson Reviewed-by: Brian Cain Message-Id: <20231210220712.491494-10-ltaylorsimp...@gmail.com> Signed-off-by: Brian Cain --- target/hexagon/hex_common.p

[PULL 10/15] Hexagon (target/hexagon) Remove unused WRITES_PRED_REG attribute

2024-01-21 Thread Brian Cain
From: Taylor Simpson This is the only remaining use of the is_written function. We will remove it in the subsequent commit. Signed-off-by: Taylor Simpson Reviewed-by: Brian Cain Message-Id: <20231210220712.491494-9-ltaylorsimp...@gmail.com> Signed-off-by: Brian Cain --- target/h

[PULL 07/15] Hexagon (target/hexagon) Make generators object oriented - gen_idef_parser_funcs

2024-01-21 Thread Brian Cain
From: Taylor Simpson Signed-off-by: Taylor Simpson Reviewed-by: Brian Cain Message-Id: <20231210220712.491494-6-ltaylorsimp...@gmail.com> Signed-off-by: Brian Cain --- target/hexagon/gen_idef_parser_funcs.py | 20 1 file changed, 4 insertions(+), 16 deletions(-)

[PULL 04/15] Hexagon (target/hexagon) Make generators object oriented - gen_tcg_funcs

2024-01-21 Thread Brian Cain
that use regtype/regid (e.g., is_read) This patch creates the class hierarchy in hex_common and converts gen_tcg_funcs.py. The other scripts will be converted in subsequent patches in this series. Signed-off-by: Taylor Simpson Reviewed-by: Brian Cain Message-Id: <20231210220712.49149

[PULL 15/15] target/hexagon: reduce scope of def_regnum, remove dead assignment

2024-01-21 Thread Brian Cain
This is intended to address a coverity finding: CID 1527408. Signed-off-by: Brian Cain Reviewed-by: Matheus Tavares Bernardino Message-Id: <20240114234453.4114587-1-bc...@quicinc.com> --- target/hexagon/mmvec/decode_ext_mmvec.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)

[PULL 13/15] Hexagon (target/hexagon) Use QEMU decodetree (16-bit instructions)

2024-01-21 Thread Brian Cain
Cain Message-Id: <20240115221443.365287-3-ltaylorsimp...@gmail.com> Signed-off-by: Brian Cain --- target/hexagon/README | 1 + target/hexagon/decode.c | 85 + target/hexagon/gen_decodetree.py | 12 - target/hexagon/gen_trans_funcs.p

[PULL 01/15] tests/docker: Hexagon toolchain update

2024-01-21 Thread Brian Cain
This update includes support for privileged instructions. Signed-off-by: Brian Cain Reviewed-by: Matheus Tavares Bernardino Tested-by: Matheus Tavares Bernardino Message-Id: <20240114232354.4109231-1-bc...@quicinc.com> --- tests/docker/dockerfiles/debian-hexagon-cross.docker | 4 ++--

[PULL 02/15] Hexagon (target/hexagon) Fix shadow variable when idef-parser is off

2024-01-21 Thread Brian Cain
From: Taylor Simpson Adding -Werror=shadow=compatible-local causes Hexagon not to build when idef-parser is off. The "label" variable in CHECK_NOSHUF_PRED shadows a variable in the surrounding code. Signed-off-by: Taylor Simpson Reviewed-by: Brian Cain Reviewed-by: Philippe Mat

[PULL 12/15] Hexagon (target/hexagon) Use QEMU decodetree (32-bit instructions)

2024-01-21 Thread Brian Cain
instructions Signed-off-by: Taylor Simpson Reviewed-by: Brian Cain Message-Id: <20240115221443.365287-2-ltaylorsimp...@gmail.com> Signed-off-by: Brian Cain --- target/hexagon/README | 13 +- target/hexagon/decode.c | 54 - target/hexagon/decode.h

[PULL 06/15] Hexagon (target/hexagon) Make generators object oriented - gen_helper_funcs

2024-01-21 Thread Brian Cain
From: Taylor Simpson Signed-off-by: Taylor Simpson Reviewed-by: Brian Cain Message-Id: <20231210220712.491494-5-ltaylorsimp...@gmail.com> Signed-off-by: Brian Cain --- target/hexagon/gen_helper_funcs.py | 370 + target/hexagon/hex_common.py | 48 +

[PULL 14/15] Hexagon (target/hexagon) Remove old dectree.py

2024-01-21 Thread Brian Cain
From: Taylor Simpson Now that we are using QEMU decodetree.py, remove the old decoder Signed-off-by: Taylor Simpson Reviewed-by: Brian Cain Message-Id: <20240115221443.365287-4-ltaylorsimp...@gmail.com> Signed-off-by: Brian Cain --- target/hexagon/decode.c

[PULL 03/15] Hexagon (target/hexagon) Clean up handling of modifier registers

2024-01-21 Thread Brian Cain
register corresponding to the modifier register specified in the instruction. We create a TCGv variable "CS" to hold the value to pass to the helper. Reviewed-by: Brian Cain Signed-off-by: Taylor Simpson Message-Id: <20231210220712.491494-2-ltaylorsimp...@gmail.com> Signed-of

[PULL 05/15] Hexagon (target/hexagon) Make generators object oriented - gen_helper_protos

2024-01-21 Thread Brian Cain
From: Taylor Simpson Signed-off-by: Taylor Simpson Reviewed-by: Brian Cain Message-Id: <20231210220712.491494-4-ltaylorsimp...@gmail.com> Signed-off-by: Brian Cain --- target/hexagon/gen_helper_protos.py | 149 ++-- target/hexagon/hex_common.py| 7

[PULL 08/15] Hexagon (target/hexagon) Make generators object oriented - gen_op_regs

2024-01-21 Thread Brian Cain
From: Taylor Simpson Reviewed-by: Brian Cain Signed-off-by: Taylor Simpson Message-Id: <20231210220712.491494-7-ltaylorsimp...@gmail.com> Signed-off-by: Brian Cain --- target/hexagon/gen_op_regs.py | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/target/h

[PULL 09/15] Hexagon (target/hexagon) Make generators object oriented - gen_analyze_funcs

2024-01-21 Thread Brian Cain
From: Taylor Simpson This patch conflicts with https://lists.gnu.org/archive/html/qemu-devel/2023-11/msg00729.html If that series goes in first, we'll rework this patch and vice versa. Signed-off-by: Taylor Simpson Reviewed-by: Brian Cain Message-Id: <20231210220712.491494-8-ltaylors

[PULL 00/15] target-hexagon queue, hexagon docker

2024-01-21 Thread Brian Cain
Brian Cain (2): tests/docker: Hexagon toolchain update target/hexagon: reduce scope of def_regnum, remove dead assignment Taylor Simpson (13): Hexagon (target/hexagon) Fix shadow variable when idef-parser is off Hexagon (target

RE: [PATCH v2 0/9] Hexagon (target/hexagon) Make generators object oriented

2024-01-15 Thread Brian Cain
> -Original Message- > From: Taylor Simpson > Sent: Sunday, December 10, 2023 4:07 PM > To: qemu-devel@nongnu.org > Cc: Brian Cain ; Matheus Bernardino (QUIC) > ; Sid Manning ; Marco > Liebel (QUIC) ; richard.hender...@linaro.org; > phi...@linaro.org;

RE: [PATCH v2 0/3] Hexagon (target/hexagon) Use QEMU decodetree

2024-01-15 Thread Brian Cain
> -Original Message- > From: Taylor Simpson > Sent: Monday, January 15, 2024 4:15 PM > To: qemu-devel@nongnu.org > Cc: Brian Cain ; Matheus Bernardino (QUIC) > ; Sid Manning ; Marco > Liebel (QUIC) ; richard.hender...@linaro.org; > phi...@linaro.org;

RE: [PATCH v2 3/3] Hexagon (target/hexagon) Remove old dectree.py

2024-01-14 Thread Brian Cain
> -Original Message- > From: Taylor Simpson > Sent: Monday, January 8, 2024 4:49 PM > To: qemu-devel@nongnu.org > Cc: Brian Cain ; Matheus Bernardino (QUIC) > ; Sid Manning ; Marco > Liebel (QUIC) ; richard.hender...@linaro.org; > phi...@linaro.org; a...@rev.ng;

RE: [PATCH v2 2/3] Hexagon (target/hexagon) Use QEMU decodetree (16-bit instructions)

2024-01-14 Thread Brian Cain
> -Original Message- > From: Taylor Simpson > Sent: Monday, January 8, 2024 4:49 PM > To: qemu-devel@nongnu.org > Cc: Brian Cain ; Matheus Bernardino (QUIC) > ; Sid Manning ; Marco > Liebel (QUIC) ; richard.hender...@linaro.org; > phi...@linaro.org; a...@rev.ng;

RE: [PATCH v2 1/3] Hexagon (target/hexagon) Use QEMU decodetree (32-bit instructions)

2024-01-14 Thread Brian Cain
> -Original Message- > From: Taylor Simpson > Sent: Monday, January 8, 2024 4:49 PM > To: qemu-devel@nongnu.org > Cc: Brian Cain ; Matheus Bernardino (QUIC) > ; Sid Manning ; Marco > Liebel (QUIC) ; richard.hender...@linaro.org; > phi...@linaro.org; a...@rev.ng;

[PATCH] Reduce scope of def_regnum, remove dead assignment

2024-01-14 Thread Brian Cain
This is intended to address a coverity finding: CID 1527408. Signed-off-by: Brian Cain --- target/hexagon/mmvec/decode_ext_mmvec.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/target/hexagon/mmvec/decode_ext_mmvec.c b/target/hexagon/mmvec/decode_ext_mmvec.c index

[PATCH] tests/docker: Hexagon toolchain update

2024-01-14 Thread Brian Cain
This update includes support for privileged instructions. Signed-off-by: Brian Cain --- tests/docker/dockerfiles/debian-hexagon-cross.docker | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/docker/dockerfiles/debian-hexagon-cross.docker b/tests/docker/dockerfiles

RE: [PATCH v2 8/9] Hexagon (target/hexagon) Remove unused WRITES_PRED_REG attribute

2024-01-11 Thread Brian Cain
> -Original Message- > From: Taylor Simpson > Sent: Sunday, December 10, 2023 4:07 PM > To: qemu-devel@nongnu.org > Cc: Brian Cain ; Matheus Bernardino (QUIC) > ; Sid Manning ; Marco > Liebel (QUIC) ; richard.hender...@linaro.org; > phi...@linaro.org;

RE: [PATCH v2 9/9] Hexagon (target/hexagon) Remove dead functions from hex_common.py

2024-01-11 Thread Brian Cain
> -Original Message- > From: Taylor Simpson > Sent: Sunday, December 10, 2023 4:07 PM > To: qemu-devel@nongnu.org > Cc: Brian Cain ; Matheus Bernardino (QUIC) > ; Sid Manning ; Marco > Liebel (QUIC) ; richard.hender...@linaro.org; > phi...@linaro.org;

RE: [PATCH v2 6/9] Hexagon (target/hexagon) Make generators object oriented - gen_op_regs

2024-01-11 Thread Brian Cain
> -Original Message- > From: Taylor Simpson > Sent: Sunday, December 10, 2023 4:07 PM > To: qemu-devel@nongnu.org > Cc: Brian Cain ; Matheus Bernardino (QUIC) > ; Sid Manning ; Marco > Liebel (QUIC) ; richard.hender...@linaro.org; > phi...@linaro.org;

RE: [PATCH v2 4/9] Hexagon (target/hexagon) Make generators object oriented - gen_helper_funcs

2024-01-11 Thread Brian Cain
> -Original Message- > From: Taylor Simpson > Sent: Sunday, December 10, 2023 4:07 PM > To: qemu-devel@nongnu.org > Cc: Brian Cain ; Matheus Bernardino (QUIC) > ; Sid Manning ; Marco > Liebel (QUIC) ; richard.hender...@linaro.org; > phi...@linaro.org;

RE: [PATCH v2 7/9] Hexagon (target/hexagon) Make generators object oriented - gen_analyze_funcs

2024-01-11 Thread Brian Cain
> -Original Message- > From: Taylor Simpson > Sent: Sunday, December 10, 2023 4:07 PM > To: qemu-devel@nongnu.org > Cc: Brian Cain ; Matheus Bernardino (QUIC) > ; Sid Manning ; Marco > Liebel (QUIC) ; richard.hender...@linaro.org; > phi...@linaro.org;

RE: [PATCH v2 2/9] Hexagon (target/hexagon) Make generators object oriented - gen_tcg_funcs

2024-01-11 Thread Brian Cain
> -Original Message- > From: Taylor Simpson > Sent: Sunday, December 10, 2023 4:07 PM > To: qemu-devel@nongnu.org > Cc: Brian Cain ; Matheus Bernardino (QUIC) > ; Sid Manning ; Marco > Liebel (QUIC) ; richard.hender...@linaro.org; > phi...@linaro.org;

RE: [PATCH v2 3/9] Hexagon (target/hexagon) Make generators object oriented - gen_helper_protos

2024-01-11 Thread Brian Cain
> -Original Message- > From: Taylor Simpson > Sent: Sunday, December 10, 2023 4:07 PM > To: qemu-devel@nongnu.org > Cc: Brian Cain ; Matheus Bernardino (QUIC) > ; Sid Manning ; Marco > Liebel (QUIC) ; richard.hender...@linaro.org; > phi...@linaro.org;

RE: [PATCH v2 5/9] Hexagon (target/hexagon) Make generators object oriented - gen_idef_parser_funcs

2024-01-11 Thread Brian Cain
> -Original Message- > From: Taylor Simpson > Sent: Sunday, December 10, 2023 4:07 PM > To: qemu-devel@nongnu.org > Cc: Brian Cain ; Matheus Bernardino (QUIC) > ; Sid Manning ; Marco > Liebel (QUIC) ; richard.hender...@linaro.org; > phi...@linaro.org;

testing without the translation cache

2024-01-08 Thread Brian Cain
Alex, A very long time ago QEMU supported disabling the translation cache via "-translation no-cache". That option was deliberately removed. We are looking into a hexagon-specific failure when there's a TB lookup miss from a cpu_loop_exit_restore().I'd like to test our fix for this

RE: [PATCH 3/9] Hexagon (target/hexagon) Make generators object oriented - gen_helper_protos

2023-12-04 Thread Brian Cain
> -Original Message- > From: Taylor Simpson > Sent: Monday, December 4, 2023 7:53 PM > To: qemu-devel@nongnu.org > Cc: Brian Cain ; Matheus Bernardino (QUIC) > ; Sid Manning ; Marco > Liebel (QUIC) ; richard.hender...@linaro.org; > phi...@linaro.org;

RE: [PATCH 1/9] Hexagon (target/hexagon) Clean up handling of modifier registers

2023-12-04 Thread Brian Cain
> -Original Message- > From: Taylor Simpson > Sent: Monday, December 4, 2023 7:53 PM > To: qemu-devel@nongnu.org > Cc: Brian Cain ; Matheus Bernardino (QUIC) > ; Sid Manning ; Marco > Liebel (QUIC) ; richard.hender...@linaro.org; > phi...@linaro.org;

RE: [PATCH 6/9] Hexagon (target/hexagon) Make generators object oriented - gen_op_regs

2023-12-04 Thread Brian Cain
> -Original Message- > From: Taylor Simpson > Sent: Monday, December 4, 2023 7:53 PM > To: qemu-devel@nongnu.org > Cc: Brian Cain ; Matheus Bernardino (QUIC) > ; Sid Manning ; Marco > Liebel (QUIC) ; richard.hender...@linaro.org; > phi...@linaro.org;

RE: [PATCH 2/9] Hexagon (target/hexagon) Make generators object oriented - gen_tcg_funcs

2023-12-04 Thread Brian Cain
> -Original Message- > From: Taylor Simpson > Sent: Monday, December 4, 2023 7:53 PM > To: qemu-devel@nongnu.org > Cc: Brian Cain ; Matheus Bernardino (QUIC) > ; Sid Manning ; Marco > Liebel (QUIC) ; richard.hender...@linaro.org; > phi...@linaro.org;

RE: [PATCH] Hexagon (target/hexagon) Fix shadow variable when idef-parser is off

2023-11-30 Thread Brian Cain
> -Original Message- > From: Philippe Mathieu-Daudé > Sent: Thursday, November 30, 2023 2:17 PM > To: Taylor Simpson ; qemu-devel@nongnu.org > Cc: Brian Cain ; Matheus Bernardino (QUIC) > ; Sid Manning ; Marco > Liebel (QUIC) ; richard.hender...@linaro.org; >

RE: [PATCH] Hexagon (target/hexagon) Fix shadow variable when idef-parser is off

2023-11-30 Thread Brian Cain
> -Original Message- > From: Taylor Simpson > Sent: Thursday, November 30, 2023 12:40 PM > To: qemu-devel@nongnu.org > Cc: Brian Cain ; Matheus Bernardino (QUIC) > ; Sid Manning ; Marco > Liebel (QUIC) ; richard.hender...@linaro.org; > phi...@linaro.org;

RE: [PULL v2 25/30] Hexagon HVX (target/hexagon) instruction decoding

2023-11-26 Thread Brian Cain
> -Original Message- > From: Brian Cain > Sent: Tuesday, November 21, 2023 9:52 AM > To: Peter Maydell > Cc: qemu-devel@nongnu.org; richard.hender...@linaro.org; f4...@amsat.org > Subject: RE: [PULL v2 25/30] Hexagon HVX (target/hexagon) instruction > decoding >

RE: [PULL v2 25/30] Hexagon HVX (target/hexagon) instruction decoding

2023-11-21 Thread Brian Cain
> -Original Message- > From: qemu-devel-bounces+bcain=quicinc@nongnu.org bounces+bcain=quicinc@nongnu.org> On Behalf Of Peter Maydell > Sent: Tuesday, November 21, 2023 8:33 AM > To: Taylor Simpson > Cc: qemu-devel@nongnu.org; richard.hender...@linaro.org; f4...@amsat.org >

RE: [RFC PATCH] Hexagon (target/hexagon) Make generators object oriented

2023-11-16 Thread Brian Cain
> -Original Message- > From: ltaylorsimp...@gmail.com > Sent: Thursday, November 16, 2023 1:19 PM > To: Brian Cain ; qemu-devel@nongnu.org > Cc: Matheus Bernardino (QUIC) ; Sid Manning > ; richard.hender...@linaro.org; phi...@linaro.org; > a...@rev.ng; a...@rev.n

RE: [RFC PATCH] Hexagon (target/hexagon) Make generators object oriented

2023-11-16 Thread Brian Cain
> -Original Message- > From: ltaylorsimp...@gmail.com > Sent: Wednesday, November 15, 2023 4:03 PM > To: Brian Cain ; qemu-devel@nongnu.org > Cc: Matheus Bernardino (QUIC) ; Sid Manning > ; richard.hender...@linaro.org; phi...@linaro.org; > a...@rev.ng; a...@rev.n

RE: [RFC PATCH] Hexagon (target/hexagon) Make generators object oriented

2023-11-15 Thread Brian Cain
> -Original Message- > From: qemu-devel-bounces+bcain=quicinc@nongnu.org AFAICT the keys for registers and new_registers can be derived from the values > themselves. Rather than worry about copy/paste errors causing these not to > correspond, you can create a dictionary from an

RE: [RFC PATCH] Hexagon (target/hexagon) Make generators object oriented

2023-11-15 Thread Brian Cain
> -Original Message- > From: Taylor Simpson > Sent: Thursday, November 9, 2023 3:26 PM > To: qemu-devel@nongnu.org > Cc: Brian Cain ; Matheus Bernardino (QUIC) > ; Sid Manning ; > richard.hender...@linaro.org; phi...@linaro.org; a...@rev.ng; a...@rev.ng; >

QEMU snapshotting

2023-11-15 Thread Brian Cain
Alexander, Bandan, Paolo, Stefan, Manuel, Hi, I'm Brian and I maintain the Hexagon arch for QEMU. Elia, a security researcher at Qualcomm is exploring ways to fuzz some hexagon OS kernel with QEMU and in particular leveraging snapshotting, inspired by your research and more. I'm not an

RE: [PATCH 0/1] Enable -Wshadow=local

2023-10-26 Thread Brian Cain
> -Original Message- > From: Stefan Hajnoczi > Sent: Thursday, October 26, 2023 7:52 PM > To: Markus Armbruster > Cc: qemu-devel@nongnu.org; pbonz...@redhat.com; > marcandre.lur...@redhat.com; berra...@redhat.com; th...@redhat.com; > phi...@linaro.org; Brian C

RE: [PATCH v2 07/16] target/hexagon: Declare QOM definitions in 'cpu-qom.h'

2023-10-26 Thread Brian Cain
- > ri...@nongnu.org; Palmer Dabbelt ; Yoshinori Sato > ; Bastian Koppelmann paderborn.de>; Bin Meng ; Daniel Henrique > Barboza ; Mark Cave-Ayland ayl...@ilande.co.uk>; Weiwei Li ; Daniel Henrique > Barboza ; Nicholas Piggin > ; qemu-...@nongnu.org; Liu Zhiwei > ; Marek Vasut

[PULL 1/2] target/hexagon: move GETPC() calls to top level helpers

2023-10-18 Thread Brian Cain
: <2c74c3696946edba7cc5b2942cf296a5af532052.1689070412.git.quic_mathb...@quicinc.com>-ne Reviewed-by: Brian Cain Signed-off-by: Brian Cain Message-Id: <20231008220945.983643-2-bc...@quicinc.com> --- target/hexagon/macros.h| 19 +- target/hexagon/op_h

[PULL 0/2] hex queue - GETPC() fixes, shadowing fixes

2023-10-18 Thread Brian Cain
Brian Cain (1): target/hexagon: fix some occurrences of -Wshadow=local Matheus Tavares Bernardino (1): target/hexagon: move GETPC() calls to top level helpers target/hexagon/imported/alu.idef | 6 +-- target/hexagon/macros.h | 19 + target/hexagon

[PULL 2/2] target/hexagon: fix some occurrences of -Wshadow=local

2023-10-18 Thread Brian Cain
ino Signed-off-by: Brian Cain Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20231008220945.983643-3-bc...@quicinc.com> --- target/hexagon/imported/alu.idef | 6 +++--- target/hexagon/mmvec/macros.h| 2 +- target/hexagon/op_helper.c | 9 +++-- target/hexagon/translate.c

RE: [PATCH v2 3/3] target/hexagon: avoid shadowing globals

2023-10-17 Thread Brian Cain
> -Original Message- > From: Philippe Mathieu-Daudé > Sent: Tuesday, October 10, 2023 12:23 AM > To: Brian Cain ; richard.hender...@linaro.org; > a...@rev.ng > Cc: arm...@redhat.com; peter.mayd...@linaro.org; Matheus Bernardino > (QUIC) ; stefa...@redhat.com; a...@r

RE: [PATCH v2 3/3] target/hexagon: avoid shadowing globals

2023-10-09 Thread Brian Cain
> -Original Message- > From: Philippe Mathieu-Daudé > Sent: Monday, October 9, 2023 1:43 AM > To: Brian Cain ; qemu-devel@nongnu.org > Cc: arm...@redhat.com; richard.hender...@linaro.org; > peter.mayd...@linaro.org; Matheus Bernardino (QUIC) > ; stefa...@re

[PATCH v3 3/3] target/hexagon: avoid shadowing globals

2023-10-08 Thread Brian Cain
The typedef `vaddr` is shadowed by `vaddr` identifiers, so we rename the identifiers to avoid shadowing the type name. The global `tcg_env` is shadowed by local `tcg_env` arguments, so we rename the function arguments to avoid shadowing the global. Signed-off-by: Brian Cain --- target/hexagon

[PATCH v3 2/3] target/hexagon: fix some occurrences of -Wshadow=local

2023-10-08 Thread Brian Cain
ino Signed-off-by: Brian Cain --- target/hexagon/imported/alu.idef | 6 +++--- target/hexagon/mmvec/macros.h| 2 +- target/hexagon/op_helper.c | 9 +++-- target/hexagon/translate.c | 10 +- 4 files changed, 12 insertions(+), 15 deletions(-) diff --git a/target/hexa

[PATCH v3 0/3] hexagon: GETPC() fixes, shadowing fixes

2023-10-08 Thread Brian Cain
Changes since v2: - rebased, suggested by Markus - s/cpu_env/tcg_env/ - For local shadows: s/tcg_env/tcg_env_/ Brian Cain (2): target/hexagon: fix some occurrences of -Wshadow=local target/hexagon: avoid shadowing globals Matheus Tavares Bernardino (1): target/hexagon

[PATCH v3 1/3] target/hexagon: move GETPC() calls to top level helpers

2023-10-08 Thread Brian Cain
: <2c74c3696946edba7cc5b2942cf296a5af532052.1689070412.git.quic_mathb...@quicinc.com>-ne Reviewed-by: Brian Cain Signed-off-by: Brian Cain --- target/hexagon/macros.h| 19 +- target/hexagon/op_helper.c | 75 +++--- target/hexagon/op_helper.h | 9 - 3

RE: [PATCH v2 3/3] target/hexagon: avoid shadowing globals

2023-10-08 Thread Brian Cain
> -Original Message- > From: ltaylorsimp...@gmail.com > Sent: Friday, October 6, 2023 11:01 AM > To: Brian Cain ; qemu-devel@nongnu.org > Cc: arm...@redhat.com; richard.hender...@linaro.org; phi...@linaro.org; > peter.mayd...@linaro.org; Matheus Bernardino (QUIC) >

[PATCH v2 2/3] target/hexagon: fix some occurrences of -Wshadow=local

2023-10-05 Thread Brian Cain
ino Signed-off-by: Brian Cain --- target/hexagon/imported/alu.idef | 6 +++--- target/hexagon/mmvec/macros.h| 6 +++--- target/hexagon/op_helper.c | 9 +++-- target/hexagon/translate.c | 9 - 4 files changed, 13 insertions(+), 17 deletions(-) diff --git a/target/hexa

[PATCH v2 1/3] target/hexagon: move GETPC() calls to top level helpers

2023-10-05 Thread Brian Cain
: <2c74c3696946edba7cc5b2942cf296a5af532052.1689070412.git.quic_mathb...@quicinc.com>-ne Reviewed-by: Brian Cain Signed-off-by: Brian Cain --- target/hexagon/macros.h| 19 +- target/hexagon/op_helper.c | 75 +++--- target/hexagon/op_helper.h | 9 - 3

[PATCH v2 3/3] target/hexagon: avoid shadowing globals

2023-10-05 Thread Brian Cain
The typedef `vaddr` is shadowed by `vaddr` identifiers, so we rename the identifiers to avoid shadowing the type name. The global `cpu_env` is shadowed by local `cpu_env` arguments, so we rename the function arguments to avoid shadowing the global. Signed-off-by: Brian Cain --- target/hexagon

[PATCH v2 0/3] hexagon: GETPC() and shadowing fixes

2023-10-05 Thread Brian Cain
In v2: reworked with suggestions from Philippe and added a new patch to cover -Wshadow=global. Brian Cain (2): target/hexagon: fix some occurrences of -Wshadow=local target/hexagon: avoid shadowing globals Matheus Tavares Bernardino (1): target/hexagon: move GETPC() calls to top level

  1   2   >