On 31/10/23 11:12 pm, Juan Quintela wrote:
Fabiano Rosas wrote:
From: Het Gala
Integrate MigrateChannelList with all transport backends
(socket, exec and rdma) for both src and dest migration
endpoints for hmp migration.
Suggested-by: Aravind Retnakaran
Signed-off-by: Het Gala
Signed
On 01/11/23 12:25 am, Juan Quintela wrote:
I intrehated al parches until this forma next pull.
I should just add the last 2 patches as individual ones, is that what
you mean ?
On Tue, Oct 31, 2023, 19:51 Het Gala wrote:
On 31/10/23 11:12 pm, Juan Quintela wrote:
> Fabiano Ro
On 18/10/23 7:58 pm, Fabiano Rosas wrote:
Het Gala writes:
Fabiano, would your below commits impact this patchset 'make check'
tests ? Because you have added tests for file based migration, which is
still not included in this patchset.
AFAICS, the tests shouldn't break.
I tried two
On 05/09/23 6:52 pm, Fabiano Rosas wrote:
Het Gala writes:
Hi qemu-devel community,
A gentle reminder and request for all migration maintainers - Peter,
Juan, Dr. Gilbert and others too for review of the patchset series.
Received reviewed-by from Daniel on migration implementation patches
This patch parses 'migrate' and 'migrate-incoming' QAPI's 'uri'
string containing migration connection related information
and stores them inside well defined 'MigrateAddress' struct.
Suggested-by: Aravind Retnakaran
Signed-off-by: Het Gala
Reviewed-by: Daniel P. Berrangé
---
migration/exec.c
t type
------
Het Gala (10):
migration: New QAPI type 'MigrateAddress'
migration: convert migration 'uri' into 'MigrateAddress'
migration: convert socket backend to accept MigrateAddress
migration: convert rdma backend to accept MigrateA
Integrate MigrateChannelList with all transport backends
(socket, exec and rdma) for both src and dest migration
endpoints for hmp migration.
Suggested-by: Aravind Retnakaran
Signed-off-by: Het Gala
Reviewed-by: Daniel P. Berrangé
---
migration/migration-hmp-cmds.c | 15
Signed-off-by: Het Gala
Reviewed-by: Daniel P. Berrangé
---
migration/migration.c | 30 ++
migration/socket.c| 39 +--
migration/socket.h| 7 ---
3 files changed, 31 insertions(+), 45 deletions(-)
diff --git a/migration
migration
QAPIs future proof.
Suggested-by: Aravind Retnakaran
Signed-off-by: Het Gala
Acked-by: Markus Armbruster
Reviewed-by: Daniel P. Berrangé
---
migration/migration-hmp-cmds.c | 6 +-
migration/migration.c | 56 +++--
qapi/migration.json| 109
Signed-off-by: Het Gala
Reviewed-by: Daniel P. Berrangé
---
migration/migration.c | 8
migration/rdma.c | 34 --
migration/rdma.h | 6 --
3 files changed, 20 insertions(+), 28 deletions(-)
diff --git a/migration/migration.c b/migration
nel' :
migration_channels_and_uri_compatible() ->
migration_channels_and_transport_compatible() passes object as argument
and check for valid transport mechanism.
Suggested-by: Aravind Retnakaran
Signed-off-by: Het Gala
Reviewed-by: Daniel P. Berrangé
---
migration/migration.c | 25 ++---
1 file chang
Exec transport backend for 'migrate'/'migrate-incoming' QAPIs accept
new wire protocol of MigrateAddress struct.
It is achived by parsing 'uri' string and storing migration parameters
required for exec connection into strList struct.
Suggested-by: Aravind Retnakaran
Signed-off-by: Het Gala
-off-by: Het Gala
Reviewed-by: Daniel P. Berrangé
---
migration/migration.c | 95 +++
1 file changed, 52 insertions(+), 43 deletions(-)
diff --git a/migration/migration.c b/migration/migration.c
index 6f948988ec..3eae32e616 100644
--- a/migration/migration.c
Retnakaran
Signed-off-by: Het Gala
Reviewed-by: Juan Quintela
Reviewed-by: Daniel P. Berrangé
Acked-by: Markus Armbruster
---
qapi/migration.json | 41 +
1 file changed, 41 insertions(+)
diff --git a/qapi/migration.json b/qapi/migration.json
index
modify multifd tcp common test to incorporate the new QAPI
syntax defined.
Suggested-by: Aravind Retnakaran
Signed-off-by: Het Gala
Reviewed-by: Daniel P. Berrangé
---
tests/qtest/migration-test.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/tests/qtest/migration
On 04/10/23 7:03 pm, Fabiano Rosas wrote:
Het Gala writes:
This is v11 patchset of modified 'migrate' and 'migrate-incoming' QAPI design
for upstream review.
Update: Daniel has reviewed all patches and is okay with them. Markus has also
given Acked-by tag for patches related
On 10/4/2023 8:55 PM, Fabiano Rosas wrote:
Het Gala writes:
modify multifd tcp common test to incorporate the new QAPI
syntax defined.
Suggested-by: Aravind Retnakaran
Signed-off-by: Het Gala
Reviewed-by: Daniel P. Berrangé
---
tests/qtest/migration-test.c | 7 ++-
1 file changed, 6
On 10/4/2023 9:02 PM, Fabiano Rosas wrote:
Fabiano Rosas writes:
Het Gala writes:
On 04/10/23 7:03 pm, Fabiano Rosas wrote:
Het Gala writes:
This is v11 patchset of modified 'migrate' and 'migrate-incoming' QAPI design
for upstream review.
Update: Daniel has reviewed all patches
This patch parses 'migrate' and 'migrate-incoming' QAPI's 'uri'
string containing migration connection related information
and stores them inside well defined 'MigrateAddress' struct.
Suggested-by: Aravind Retnakaran
Signed-off-by: Het Gala
---
migration/exec.c | 1 -
migration/exec.h
Exec transport backend for 'migrate'/'migrate-incoming' QAPIs accept
new wire protocol of MigrateAddress struct.
It is achived by parsing 'uri' string and storing migration parameters
required for exec connection into strList struct.
Suggested-by: Aravind Retnakaran
Signed-off-by: Het Gala
migration
QAPIs future proof.
Suggested-by: Aravind Retnakaran
Signed-off-by: Het Gala
Acked-by: Markus Armbruster
Reviewed-by: Daniel P. Berrangé
---
migration/migration-hmp-cmds.c | 6 +-
migration/migration.c | 56 +++--
qapi/migration.json| 109
Integrate MigrateChannelList with all transport backends
(socket, exec and rdma) for both src and dest migration
endpoints for hmp migration.
Suggested-by: Aravind Retnakaran
Signed-off-by: Het Gala
---
migration/migration-hmp-cmds.c | 27 ++-
migration/migration.c
Signed-off-by: Het Gala
Reviewed-by: Daniel P. Berrangé
---
migration/migration.c | 8
migration/rdma.c | 33 +++--
migration/rdma.h | 6 --
3 files changed, 19 insertions(+), 28 deletions(-)
diff --git a/migration/migration.c b/migration
Signed-off-by: Het Gala
Reviewed-by: Daniel P. Berrangé
---
migration/migration.c | 30 ++
migration/socket.c| 39 +--
migration/socket.h| 7 ---
3 files changed, 31 insertions(+), 45 deletions(-)
diff --git a/migration
nel' :
migration_channels_and_uri_compatible() ->
migration_channels_and_transport_compatible() passes object as argument
and check for valid transport mechanism.
Suggested-by: Aravind Retnakaran
Signed-off-by: Het Gala
Reviewed-by: Daniel P. Berrangé
---
migration/migration.c | 25 ++---
1 file chang
-off-by: Het Gala
---
migration/migration.c | 95 +++
1 file changed, 52 insertions(+), 43 deletions(-)
diff --git a/migration/migration.c b/migration/migration.c
index cf5a620c8e..7db1f3196e 100644
--- a/migration/migration.c
+++ b/migration/migration.c
Retnakaran
Signed-off-by: Het Gala
Reviewed-by: Juan Quintela
Reviewed-by: Daniel P. Berrangé
Acked-by: Markus Armbruster
---
qapi/migration.json | 41 +
1 file changed, 41 insertions(+)
diff --git a/qapi/migration.json b/qapi/migration.json
index
t type
------
Het Gala (10):
migration: New QAPI type 'MigrateAddress'
migration: convert migration 'uri' into 'MigrateAddress'
migration: convert socket backend to accept MigrateAddress
migration: convert rdma backend to accept MigrateAddress
mig
modify multifd tcp common test to incorporate the new QAPI
syntax defined.
Suggested-by: Aravind Retnakaran
Signed-off-by: Het Gala
---
tests/qtest/migration-test.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration
On 10/4/2023 7:33 PM, Fabiano Rosas wrote:
Het Gala writes:
On 04/10/23 7:03 pm, Fabiano Rosas wrote:
Het Gala writes:
This is v11 patchset of modified 'migrate' and 'migrate-incoming' QAPI design
for upstream review.
Update: Daniel has reviewed all patches and is okay with them. Markus
On 10/4/2023 8:13 PM, Fabiano Rosas wrote:
Het Gala writes:
This patch parses 'migrate' and 'migrate-incoming' QAPI's 'uri'
string containing migration connection related information
and stores them inside well defined 'MigrateAddress' struct.
Suggested-by: Aravind Retnakaran
Signed-off
On 10/4/2023 11:42 PM, Fabiano Rosas wrote:
Daniel P. Berrangé writes:
On Wed, Oct 04, 2023 at 11:43:12AM -0300, Fabiano Rosas wrote:
Het Gala writes:
This patch parses 'migrate' and 'migrate-incoming' QAPI's 'uri'
string containing migration connection related information
and stores
On 10/4/2023 8:51 PM, Fabiano Rosas wrote:
Het Gala writes:
Integrate MigrateChannelList with all transport backends
(socket, exec and rdma) for both src and dest migration
endpoints for qmp migration.
For current series, limit the size of MigrateChannelList
to single element (single
On 10/4/2023 8:55 PM, Fabiano Rosas wrote:
Het Gala writes:
Integrate MigrateChannelList with all transport backends
(socket, exec and rdma) for both src and dest migration
endpoints for hmp migration.
Suggested-by: Aravind Retnakaran
Signed-off-by: Het Gala
Reviewed-by: Daniel P. Berrangé
On 10/4/2023 8:25 PM, Fabiano Rosas wrote:
Het Gala writes:
Exec transport backend for 'migrate'/'migrate-incoming' QAPIs accept
new wire protocol of MigrateAddress struct.
It is achived by parsing 'uri' string and storing migration parameters
required for exec connection into strList struct
migration in
these patches or as you said eariler, you will introduce those patches
on top of my patches. Please let me know.
On 12/10/23 8:40 pm, Het Gala wrote:
This is v13 patchset of modified 'migrate' and 'migrate-incoming' QAPI design
for upstream review.
Would like to thank all the maintainers
On 10/10/2023 7:56 PM, Fabiano Rosas wrote:
Fabiano Rosas writes:
Het Gala writes:
On 10/10/2023 2:34 AM, Fabiano Rosas wrote:
Het Gala writes:
This is v12 patchset of modified 'migrate' and 'migrate-incoming' QAPI design
for upstream review.
Would like to thank all the maintainers
migration
QAPIs future proof.
Suggested-by: Aravind Retnakaran
Signed-off-by: Het Gala
Acked-by: Markus Armbruster
Reviewed-by: Daniel P. Berrangé
---
migration/migration-hmp-cmds.c | 6 +-
migration/migration.c | 56 +++--
qapi/migration.json| 109
l-type
Transport-type
Migration parameters based on transport type
------
Het Gala (10):
migration: New QAPI type 'MigrateAddress'
migration: convert migration 'uri' into 'MigrateAddress'
mig
Signed-off-by: Het Gala
Reviewed-by: Daniel P. Berrangé
---
migration/migration.c | 8
migration/rdma.c | 34 --
migration/rdma.h | 6 --
3 files changed, 20 insertions(+), 28 deletions(-)
diff --git a/migration/migration.c b/migration
Retnakaran
Signed-off-by: Het Gala
Reviewed-by: Juan Quintela
Reviewed-by: Daniel P. Berrangé
Acked-by: Markus Armbruster
---
qapi/migration.json | 41 +
1 file changed, 41 insertions(+)
diff --git a/qapi/migration.json b/qapi/migration.json
index
Signed-off-by: Het Gala
Reviewed-by: Daniel P. Berrangé
---
migration/migration.c | 30 ++
migration/socket.c| 39 +--
migration/socket.h| 7 ---
3 files changed, 31 insertions(+), 45 deletions(-)
diff --git a/migration
This patch parses 'migrate' and 'migrate-incoming' QAPI's 'uri'
string containing migration connection related information
and stores them inside well defined 'MigrateAddress' struct.
Suggested-by: Aravind Retnakaran
Signed-off-by: Het Gala
---
migration/exec.c | 1 -
migration/exec.h
-off-by: Het Gala
---
migration/migration.c | 95 +++
1 file changed, 52 insertions(+), 43 deletions(-)
diff --git a/migration/migration.c b/migration/migration.c
index 23c3a1079f..ff04728b33 100644
--- a/migration/migration.c
+++ b/migration/migration.c
nel' :
migration_channels_and_uri_compatible() ->
migration_channels_and_transport_compatible() passes object as argument
and check for valid transport mechanism.
Suggested-by: Aravind Retnakaran
Signed-off-by: Het Gala
Reviewed-by: Daniel P. Berrangé
---
migration/migration.c | 25 ++---
1 file chang
Integrate MigrateChannelList with all transport backends
(socket, exec and rdma) for both src and dest migration
endpoints for hmp migration.
Suggested-by: Aravind Retnakaran
Signed-off-by: Het Gala
---
migration/migration-hmp-cmds.c | 15 +--
migration/migration.c | 5
Exec transport backend for 'migrate'/'migrate-incoming' QAPIs accept
new wire protocol of MigrateAddress struct.
It is achived by parsing 'uri' string and storing migration parameters
required for exec connection into strList struct.
Suggested-by: Aravind Retnakaran
Signed-off-by: Het Gala
modify multifd tcp common test to incorporate the new QAPI
syntax defined.
Suggested-by: Aravind Retnakaran
Signed-off-by: Het Gala
---
tests/qtest/migration-test.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration
On 10/9/2023 7:43 PM, Fabiano Rosas wrote:
Het Gala writes:
On 10/4/2023 11:42 PM, Fabiano Rosas wrote:
Daniel P. Berrangé writes:
On Wed, Oct 04, 2023 at 11:43:12AM -0300, Fabiano Rosas wrote:
Het Gala writes:
This patch parses 'migrate' and 'migrate-incoming' QAPI's 'uri'
string
On 10/10/2023 2:38 AM, Fabiano Rosas wrote:
Het Gala writes:
Integrate MigrateChannelList with all transport backends
(socket, exec and rdma) for both src and dest migration
endpoints for hmp migration.
Suggested-by: Aravind Retnakaran
Signed-off-by: Het Gala
---
migration/migration-hmp
On 10/9/2023 7:59 PM, Fabiano Rosas wrote:
Het Gala writes:
On 10/4/2023 8:51 PM, Fabiano Rosas wrote:
Het Gala writes:
Integrate MigrateChannelList with all transport backends
(socket, exec and rdma) for both src and dest migration
endpoints for qmp migration.
For current series
On 10/9/2023 8:05 PM, Fabiano Rosas wrote:
Het Gala writes:
On 10/4/2023 8:55 PM, Fabiano Rosas wrote:
Het Gala writes:
Integrate MigrateChannelList with all transport backends
(socket, exec and rdma) for both src and dest migration
endpoints for hmp migration.
Suggested-by: Aravind
On 10/10/2023 2:34 AM, Fabiano Rosas wrote:
Het Gala writes:
This is v12 patchset of modified 'migrate' and 'migrate-incoming' QAPI design
for upstream review.
Would like to thank all the maintainers that actively participated in the v11
patchset discussion and gave insightful suggestions
on the patches soon.
Thankyou :)
On 03/08/23 11:13 am, Het Gala wrote:
Hi,
A gentle reminder for Juan and other migration maintainers for the
review of this patchset series if any changes are required or give to
queue them. There are more patchset series coming after this. As
discussed earlier
qmp command:
{ "execute": "migrate-incoming",
"arguments": {"uri": "tcp::6789",
"multi-fd-uri-list" : [ {"destination-uri" : "tcp::6900",
"multifd-channels": 4}, {"dest
and
destination pairs.
Suggested-by: Manish Mishra
Signed-off-by: Het Gala
---
chardev/char-socket.c | 4 +-
include/io/channel-socket.h | 26 ++-
include/qemu/sockets.h | 6 ++-
io/channel-socket.c | 50 ++--
migration
’ list, length of the list
and total number of multi-fd channels for all the connections together is
stored in ‘OutgoingArgs’ struct.
Suggested-by: Manish Mishra
Signed-off-by: Het Gala
---
include/qapi/util.h | 9
migration/migration.c | 47
' command to be used.
iii) Format for -multi-fd-incoming flag as a comma separated string has been
added with each substring containing listener socket address and number
of sockets to open.
Suggested-by: Manish Mishra
Signed-off-by: Het Gala
---
include/qapi/util.h | 1 +
migration
or incoming flag itself.
Suggested-by: Manish Mishra
Signed-off-by: Het Gala
---
migration/migration.c | 15 ---
migration/migration.h | 1 -
migration/multifd.c | 42 +-
migration/socket.c| 42
On 16/06/22 10:56 pm, Dr. David Alan Gilbert wrote:
* Het Gala (het.g...@nutanix.com) wrote:
> First of all, I apologise for the late reply. I was on a leave after
internship ended
at Nutanix. Hope to learn a lot from you all in the process of
upstreaming multifd
patches.
i) Modif
On 18/07/22 2:05 pm, Markus Armbruster wrote:
Het Gala writes:
i) Modified the format of the qemu monitor command : 'migrate' by adding a list,
each element in the list consists of multi-FD connection parameters: source
and destination uris and of the number of multi-fd channels
On 18/07/22 8:03 pm, Markus Armbruster wrote:
Het Gala writes:
On 18/07/22 2:05 pm, Markus Armbruster wrote:
Het Gala writes:
i) Modified the format of the qemu monitor command : 'migrate' by adding a list,
each element in the list consists of multi-FD connection parameters: source
On 19/07/22 12:36 pm, Markus Armbruster wrote:
Het Gala writes:
On 18/07/22 8:03 pm, Markus Armbruster wrote:
Het Gala writes:
On 18/07/22 2:05 pm, Markus Armbruster wrote:
Het Gala writes:
i) Modified the format of the qemu monitor command : 'migrate' by adding a list,
each
On 19/07/22 3:18 pm, Markus Armbruster wrote:
Het Gala writes:
On 19/07/22 12:36 pm, Markus Armbruster wrote:
Het Gala writes:
On 18/07/22 8:03 pm, Markus Armbruster wrote:
Het Gala writes:
On 18/07/22 2:05 pm, Markus Armbruster wrote:
Het Gala writes:
i) Modified the format
On 17/06/22 12:10 am, Dr. David Alan Gilbert wrote:
* Het Gala (het.g...@nutanix.com) wrote:
i) Modified the format of qemu monitor command: ‘migrate-incoming’ by adding
a list, each element in the list is to open listeners with a given number
of multiFD channels.
ii) Qemu starts
On 13/07/22 1:38 pm, Het Gala wrote:
On 16/06/22 10:56 pm, Dr. David Alan Gilbert wrote:
* Het Gala (het.g...@nutanix.com) wrote:
> First of all, I apologise for the late reply. I was on a leave after
internship ended
at Nutanix. Hope to learn a lot from you all in the proc
On 26/07/22 4:50 pm, Daniel P. Berrangé wrote:
On Thu, Jul 21, 2022 at 07:56:16PM +, Het Gala wrote:
i) Modified the format of qemu monitor command: 'migrate-incoming' by adding
a list, each element in the list to open socket listeners with a given
number of multifd channels.
ii
On 26/07/22 4:14 pm, Daniel P. Berrangé wrote:
In $SUBJECT s/multifd:/io:/ as this is not migration related.
On Thu, Jul 21, 2022 at 07:56:18PM +, Het Gala wrote:
i) Binding of the socket to source ip address and port on the non-default
interface has been implemented for multi
On 26/07/22 4:43 pm, Daniel P. Berrangé wrote:
On Thu, Jul 21, 2022 at 07:56:15PM +, Het Gala wrote:
i) Modified the format of the qemu monitor command : 'migrate' by adding a list,
each element in the list consisting of multifd connection parameters: source
uri, destination uri
and
destination pairs.
Suggested-by: Manish Mishra
Signed-off-by: Het Gala
---
include/io/channel-socket.h| 44
include/qemu/sockets.h | 6 ++-
io/channel-socket.c| 93 ++
migration/socket.c | 4 +-
tests/unit
i) strList_from_string() shifted from hm-cmds.c -> qapi-util.c
ii) Adding qemu_string_count_delim() helper func. in qapi-util.c and
QAPI_LIST_LENGTH() macro defined func. in util.h
Suggested-by: Manish Mishra
Signed-off-by: Het Gala
---
include/qapi/util.h | 12
monitor/
i) hmp_migrate and hmp_migrate_incoming functions are modified
according to the modified qmp monitor commands.
Suggested-by: Manish Mishra
Signed-off-by: Het Gala
---
monitor/hmp-cmds.c | 34 +++---
1 file changed, 31 insertions(+), 3 deletions(-)
diff --git
ore connection is created.
----
Het Gala (7):
multifd: adding more helper functions in util files for live migration
multifd: modifying 'migrate' qmp command to add multifd socket on
particular src and dest pair
multifd: adding multi-interface support for multifd on destinat
Suggested-by: Manish Mishra
Signed-off-by: Het Gala
---
util/qemu-sockets.c | 24
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/util/qemu-sockets.c b/util/qemu-sockets.c
index 491e2f2bc9..724c081e6c 100644
--- a/util/qemu-sockets.c
+++ b/util/qemu
' list and length of the
list is stored in 'OutgoingMigrateParams' struct.
Suggested-by: Manish Mishra
Signed-off-by: Het Gala
---
migration/migration.c | 52 +
migration/socket.c| 60 ---
migration/socket.h| 19
i) Dynamically decide appropriate source and destination ip pairs for the
corresponding multifd channel to be connected.
Suggested-by: Manish Mishra
Signed-off-by: Het Gala
---
migration/multifd.c | 6 +++---
migration/socket.c | 37 ++---
migration
' command to be used.
iii) Format for -multi-fd-incoming flag as a comma separated string has been
added with each substring containing listener socket address and number
of sockets to open.
Suggested-by: Manish Mishra
Signed-off-by: Het Gala
---
migration/migration.c | 143
On 08/08/22 11:41 am, Het Gala wrote:
On 02/08/22 1:23 pm, Markus Armbruster wrote:
Het Gala writes:
On 26/07/22 4:43 pm, Daniel P. Berrangé wrote:
On Thu, Jul 21, 2022 at 07:56:15PM +, Het Gala wrote:
i) Modified the format of the qemu monitor command : 'migrate' by adding a list
On 29/08/22 10:04 am, Het Gala wrote:
On 08/08/22 11:41 am, Het Gala wrote:
On 02/08/22 1:23 pm, Markus Armbruster wrote:
Het Gala writes:
On 26/07/22 4:43 pm, Daniel P. Berrangé wrote:
On Thu, Jul 21, 2022 at 07:56:15PM +, Het Gala wrote:
i) Modified the format of the qemu
On 02/08/22 1:23 pm, Markus Armbruster wrote:
Het Gala writes:
On 26/07/22 4:43 pm, Daniel P. Berrangé wrote:
On Thu, Jul 21, 2022 at 07:56:15PM +, Het Gala wrote:
i) Modified the format of the qemu monitor command : 'migrate' by adding a list,
each element in the list consisting
From: Author Het Gala
Existing 'migrate' QAPI design enforces transport mechanism, ip address
of destination interface and corresponding port number in the form
of a unified string 'uri' parameter. This scheme does seem to have an issue
in it, i.e. double-level encoding of URIs.
The current
From: Author Het Gala
'migrate-incoming' QAPI design have been modified into a well-defined struct
'MigrateChannel'. Similarly like the source side, modified design was
introduced on destination side mainly to prevent multiple-level encoding of
uri string.
The struct contains various fields
ype
Migration parameters based on transport type
-
Author Het Gala (5):
migration: Updated QAPI format for 'migrate' qemu monitor command
migration: HMP side changes for modified 'migrate' QAPI des
From: Author Het Gala
hmp_migrate() accepts uri (backward compatibility) and a
well-defined struct for migration parameters, and with help of
migrate_channel_from_qdict() maps QDict's 'key':'value' pair
required for migration stream into MigrateChannel struct.
Suggested-by: Daniel P. Berrange
From: Author Het Gala
Existing uri is encoded at multiple levels to extract the relevant
migration information.
The modified QAPI design maps migration parameters into MigrateChannel
struct before, thus avoiding double-level uri encoding.
socket_outgoing_migration() has been depricated as It's
From: Author Het Gala
Modified 'migrate-incoming' QAPI supports MigrateChannel parameters to prevent
multi-level encodings of uri on the destination side.
socket_start_incoming_migration() has been depricated as it's only purpose was
uri parsing.
Renamed socket_outgoing_migration_internal
On 09/01/23 7:44 pm, Daniel P. Berrangé wrote:
On Mon, Dec 26, 2022 at 05:33:27AM +, Het Gala wrote:
From: Author Het Gala
Existing uri is encoded at multiple levels to extract the relevant
migration information.
The modified QAPI design maps migration parameters into MigrateChannel
On 09/01/23 7:37 pm, Daniel P. Berrangé wrote:
On Mon, Dec 26, 2022 at 05:33:25AM +, Het Gala wrote:
From: Author Het Gala
Existing 'migrate' QAPI design enforces transport mechanism, ip address
of destination interface and corresponding port number in the form
of a unified string 'uri
On 10/01/23 3:02 pm, Daniel P. Berrangé wrote:
On Tue, Jan 10, 2023 at 01:09:35PM +0530, Het Gala wrote:
On 09/01/23 7:37 pm, Daniel P. Berrangé wrote:
Loooking at the RDMA code it takes the str, and treats it
as an IPv4 address:
addr = g_new(InetSocketAddress, 1
On 09/01/23 7:37 pm, Daniel P. Berrangé wrote:
On Mon, Dec 26, 2022 at 05:33:25AM +, Het Gala wrote:
From: Author Het Gala
Existing 'migrate' QAPI design enforces transport mechanism, ip address
of destination interface and corresponding port number in the form
of a unified string 'uri
On 26/12/22 11:03 am, Het Gala wrote:
Current QAPI 'migrate' command design (for initiating a migration
stream) contains information regarding different migrate transport mechanism
(tcp / unix / exec), dest-host IP address, and binding port number in form of
a string. Thus the design does seem
Retnakaran
Suggested-by: Manish Mishra
Signed-off-by: Het Gala
---
qapi/migration.json | 127 +++-
1 file changed, 125 insertions(+), 2 deletions(-)
diff --git a/qapi/migration.json b/qapi/migration.json
index 88ecf86ac8..fd9286ea0f 100644
--- a/qapi
On 22/11/22 2:53 pm, Daniel P. Berrangé wrote:
On Mon, Nov 21, 2022 at 01:40:27PM +0100, Juan Quintela wrote:
Het Gala wrote:
To prevent double data encoding of uris, instead of passing transport
mechanisms, host address and port all together in form of a single string
and writing different
On 21/11/22 6:10 pm, Juan Quintela wrote:
Het Gala wrote:
To prevent double data encoding of uris, instead of passing transport
mechanisms, host address and port all together in form of a single string
and writing different parsing functions, we intend the user to explicitly
mention most
On 17/01/23 4:22 pm, Claudio Fontana wrote:
Hi,
On 12/26/22 06:33, Het Gala wrote:
Current QAPI 'migrate' command design (for initiating a migration
stream) contains information regarding different migrate transport mechanism
(tcp / unix / exec), dest-host IP address, and binding port number
On 17/01/23 4:13 pm, Dr. David Alan Gilbert wrote:
* Daniel P. Berrangé (berra...@redhat.com) wrote:
On Mon, Dec 26, 2022 at 05:33:25AM +, Het Gala wrote:
From: Author Het Gala
Existing 'migrate' QAPI design enforces transport mechanism, ip address
of destination interface
On 17/01/23 4:17 pm, Dr. David Alan Gilbert wrote:
* Het Gala (het.g...@nutanix.com) wrote:
From: Author Het Gala
Existing 'migrate' QAPI design enforces transport mechanism, ip address
of destination interface and corresponding port number in the form
of a unified string 'uri' parameter
On 02/01/23 12:48 pm, Het Gala wrote:
On 26/12/22 11:03 am, Het Gala wrote:
Current QAPI 'migrate' command design (for initiating a migration
stream) contains information regarding different migrate transport
mechanism
(tcp / unix / exec), dest-host IP address, and binding port number
ion_in_union);
output_visitor_test_add("/visitor/output/alternate",
_visitor_data, test_visitor_out_alternate);
output_visitor_test_add("/visitor/output/null",
The changes look good to me. I have tried to built migrate QAPI changes
on top of Daniel's v1 changes, and it was successful.
Once Markus and other maintainers approves this patchset, I can post v4
version of 'migrate' qapi changes on top of this change.
Looking forward for replies on this patchset :)
Regards,
Het Gala
On 14/02/23 3:46 pm, Markus Armbruster wrote:
Het Gala writes:
On 10/02/23 12:54 pm, Markus Armbruster wrote:
Daniel P. Berrangé writes:
[...]
+##
+# @MigrateAddress:
+#
+# The options available for communication transport mechanisms for migration
+#
+# Since 8.0
+##
+{ 'union
1 - 100 of 378 matches
Mail list logo
