Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/23136
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/23136#discussion_r237643173
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsAllocator.scala
---
@@ -86,11 +88,14 @@
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/23136#discussion_r237642388
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsLifecycleManager.scala
---
@@ -30,7 +30,7 @@
Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/23136#discussion_r237626777
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsAllocator.scala
---
@@ -86,11 +88,14 @@
Github user onursatici commented on a diff in the pull request:
https://github.com/apache/spark/pull/23136#discussion_r237534100
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsAllocator.scala
---
@@ -86,11 +88,14 @@
Github user onursatici commented on a diff in the pull request:
https://github.com/apache/spark/pull/23136#discussion_r237534125
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsLifecycleManager.scala
---
@@ -30,7 +30,7
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/23136#discussion_r236488306
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsAllocator.scala
---
@@ -86,11 +88,14 @@
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/23136#discussion_r236485835
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsAllocator.scala
---
@@ -86,11 +88,14 @@
Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/23136#discussion_r236463330
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsAllocator.scala
---
@@ -86,11 +88,14 @@
Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/23136#discussion_r236461893
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsAllocator.scala
---
@@ -86,11 +88,14 @@
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/23136#discussion_r236457049
--- Diff: docs/running-on-kubernetes.md ---
@@ -926,6 +926,13 @@ specific to Spark on Kubernetes.
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/23136#discussion_r236456591
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsAllocator.scala
---
@@ -86,11 +88,14 @@
Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/23136#discussion_r236455466
--- Diff: docs/running-on-kubernetes.md ---
@@ -926,6 +926,13 @@ specific to Spark on Kubernetes.
Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/23136#discussion_r236455846
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsAllocator.scala
---
@@ -86,11 +88,14 @@
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/23136#discussion_r236432458
--- Diff:
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsLifecycleManagerSuite.scala
---
@@ -100,6
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/23136#discussion_r236431997
--- Diff:
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsLifecycleManagerSuite.scala
---
@@ -100,6
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/23136#discussion_r236089683
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesClusterSchedulerBackend.scala
---
@@ -82,11
GitHub user skonto opened a pull request:
https://github.com/apache/spark/pull/23136
[SPARK-25515][K8s] Adds a config option to keep executor pods for debuging
## What changes were proposed in this pull request?
Keeps K8s executor resources present if case of failure or normal
18 matches
Mail list logo