[GitHub] spark pull request: [SPARK-15313][SQL] EmbedSerializerInFilter rul...

Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/13096 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-15360][Spark-Submit]Should print spark-...

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13163#issuecomment-220523618 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15313][SQL] EmbedSerializerInFilter rul...

Github user rxin commented on the pull request: https://github.com/apache/spark/pull/13096#issuecomment-220523585 Alright I'm going to merge this in master/2.0. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-15360][Spark-Submit]Should print spark-...

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13163#issuecomment-220523617 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15114][SQL] Column name generated by ty...

Github user dilipbiswal commented on a diff in the pull request: https://github.com/apache/spark/pull/13045#discussion_r63994025 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Column.scala --- @@ -37,6 +38,14 @@ private[sql] object Column { def apply(expr:

[GitHub] spark pull request: [SPARK-15360][Spark-Submit]Should print spark-...

Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13163#issuecomment-220523513 **[Test build #58937 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58937/consoleFull)** for PR 13163 at commit

[GitHub] spark pull request: [SPARK-15431][SQL] Support LIST FILE(s)|JAR(s)...

Github user xwu0226 commented on the pull request: https://github.com/apache/spark/pull/13212#issuecomment-220523283 @rxin Updated the code. Please help double check. Thank you very much! --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [SPARK-15335] [SQL] Implement TRUNCATE TABLE C...

Github user hvanhovell commented on the pull request: https://github.com/apache/spark/pull/13170#issuecomment-220523237 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-15379][SQL] check special invalid date

Github user wangyang1992 commented on the pull request: https://github.com/apache/spark/pull/13169#issuecomment-220523060 Addressed your comments. @cloud-fan --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: Revert "[SPARK-10216][SQL] Avoid creating empt...

Github user HyukjinKwon commented on the pull request: https://github.com/apache/spark/pull/13181#issuecomment-220522607 @marmbrus I tested and could produce the exceptions for reading in https://issues.apache.org/jira/browse/SPARK-15393 but it seems this might not be the reason.

[GitHub] spark pull request: [SPARK-15165][SPARK-15205][SQL] Introduce plac...

Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12979#issuecomment-220522052 **[Test build #58945 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58945/consoleFull)** for PR 12979 at commit

[GitHub] spark pull request: [MINOR] Fix Typos

Github user rxin commented on the pull request: https://github.com/apache/spark/pull/13078#issuecomment-220521732 @srowen we should backport the doc fixes into branch-2.0. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark pull request: [SPARK-15206][SQL] add testcases for distinct ...

Github user xwu0226 commented on the pull request: https://github.com/apache/spark/pull/12984#issuecomment-220521657 @cloud-fan Please see if we should add these test cases to 2.0 branch. It is related to the distinct aggregate in having clause. Thanks! --- If your project is set up

[GitHub] spark pull request: [SPARK-15075][SPARK-15345][SQL] Clean up Spark...

Github user dilipbiswal commented on a diff in the pull request: https://github.com/apache/spark/pull/13200#discussion_r63993278 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala --- @@ -735,29 +731,130 @@ object SparkSession { } /**

[GitHub] spark pull request: [SPARK-8603][SPARKR] Incorrect file separator ...

Github user sun-rui commented on the pull request: https://github.com/apache/spark/pull/13165#issuecomment-220521666 1. A rough scan of the test failures shows most of them are probably related to path handling. You can replay the failed test case in R on Windows. For debug

[GitHub] spark pull request: [DOC][MINOR] ml.feature Scala and Python API s...

Github user rxin commented on the pull request: https://github.com/apache/spark/pull/13159#issuecomment-220521612 @MLnick did you actually merge this in 2.0? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15165][SPARK-15205][SQL] Introduce plac...

Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12979#issuecomment-220521459 **[Test build #58944 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58944/consoleFull)** for PR 12979 at commit

[GitHub] spark pull request: [SPARK-15075][SPARK-15345][SQL] Clean up Spark...

Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/13200#discussion_r63993145 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala --- @@ -735,29 +731,130 @@ object SparkSession { } /** -

[GitHub] spark pull request: [SPARK-15078][SQL] Add all TPCDS 1.4 benchmark...

Github user sameeragarwal commented on a diff in the pull request: https://github.com/apache/spark/pull/13188#discussion_r63993020 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/tpcds/TPCDSQueryBenchmark.scala --- @@ -0,0 +1,132 @@ +/* + *

[GitHub] spark pull request: [SPARK-15313][SQL] EmbedSerializerInFilter rul...

Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/13096#issuecomment-220521107 LGTM, thanks for finding this bug! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-15057][GRAPHX] Remove stale TODO commen...

Github user rxin commented on the pull request: https://github.com/apache/spark/pull/12839#issuecomment-220521039 Since this is very low risk, I'm going to cherry-pick this in branch-2.0 too to minimize the diff. --- If your project is set up for it, you can reply to this email and

[GitHub] spark pull request: [SPARK-15313][SQL] EmbedSerializerInFilter rul...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13096#discussion_r63992991 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -1560,7 +1561,14 @@ object EmbedSerializerInFilter

[GitHub] spark pull request: [SPARK-15308][SQL] RowEncoder should preserve ...

Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/13090#issuecomment-220520673 LGTM except one style comment, thanks for working on it! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-15308][SQL] RowEncoder should preserve ...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13090#discussion_r63992806 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/RowEncoder.scala --- @@ -149,12 +149,12 @@ object RowEncoder {

[GitHub] spark pull request: [SPARK-15075][SPARK-15345][SQL] Clean up Spark...

Github user dilipbiswal commented on a diff in the pull request: https://github.com/apache/spark/pull/13200#discussion_r63992730 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala --- @@ -735,29 +731,130 @@ object SparkSession { } /**

[GitHub] spark pull request: [SPARK-14261][SQL] Memory leak in Spark Thrift...

Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/12932 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-14261][SQL] Memory leak in Spark Thrift...

Github user rxin commented on the pull request: https://github.com/apache/spark/pull/12932#issuecomment-220519882 I'm going to merge this in master/2.0/1.6. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-15433][PySpark] PySpark core test shoul...

Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13214#issuecomment-220519810 **[Test build #58943 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58943/consoleFull)** for PR 13214 at commit

[GitHub] spark pull request: [SPARK-15282][SQL] PushDownPredicate should no...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13087#discussion_r63992511 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -1025,7 +1025,8 @@ object PushDownPredicate extends

[GitHub] spark pull request: [SPARK-15313][SQL] EmbedSerializerInFilter rul...

Github user rxin commented on the pull request: https://github.com/apache/spark/pull/13096#issuecomment-220519361 cc @cloud-fan --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-15424][SQL] Revert SPARK-14807 Create a...

Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13207#issuecomment-220519275 **[Test build #58942 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58942/consoleFull)** for PR 13207 at commit

[GitHub] spark pull request: [SPARK-15078][SQL] Add all TPCDS 1.4 benchmark...

Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/13188#discussion_r63992275 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/tpcds/TPCDSQueryBenchmark.scala --- @@ -0,0 +1,132 @@ +/* + * Licensed to

[GitHub] spark pull request: [SPARK-15433][PySpark] PySpark core test shoul...

GitHub user viirya opened a pull request: https://github.com/apache/spark/pull/13214 [SPARK-15433][PySpark] PySpark core test should not use SerDe from PythonMLLibAPI ## What changes were proposed in this pull request? Currently PySpark core test uses the `SerDe` from

[GitHub] spark pull request: [SPARK-15431][SQL] Support LIST FILE(s)|JAR(s)...

Github user xwu0226 commented on a diff in the pull request: https://github.com/apache/spark/pull/13212#discussion_r63992232 --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala --- @@ -1387,6 +1387,27 @@ class SparkContext(config: SparkConf) extends Logging with

[GitHub] spark pull request: [SPARK-15078][SQL] Add all TPCDS 1.4 benchmark...

Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/13188#discussion_r63992224 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/tpcds/TPCDSQueryBenchmark.scala --- @@ -0,0 +1,132 @@ +/* + * Licensed to

[GitHub] spark pull request: [SPARK-15363][ML][Example]:Example code should...

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13213#issuecomment-220519177 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14990][SQL] nvl, coalesce, array with p...

Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/12768 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-15363][ML][Example]:Example code should...

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13213#issuecomment-220519176 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15363][ML][Example]:Example code should...

Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13213#issuecomment-220519138 **[Test build #58941 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58941/consoleFull)** for PR 13213 at commit

[GitHub] spark pull request: [SPARK-14990][SQL] Fix checkForSameTypeInputEx...

Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/13208 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-15431][SQL] Support LIST FILE(s)|JAR(s)...

Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/13212#discussion_r63992144 --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala --- @@ -1387,6 +1387,27 @@ class SparkContext(config: SparkConf) extends Logging with

[GitHub] spark pull request: [SPARK-15078][SQL] Add all TPCDS 1.4 benchmark...

Github user sameeragarwal commented on a diff in the pull request: https://github.com/apache/spark/pull/13188#discussion_r63992090 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/tpcds/TPCDSQueryBenchmark.scala --- @@ -0,0 +1,132 @@ +/* + *

[GitHub] spark pull request: [SPARK-15431][SQL] Support LIST FILE(s)|JAR(s)...

Github user xwu0226 commented on a diff in the pull request: https://github.com/apache/spark/pull/13212#discussion_r63992055 --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala --- @@ -1387,6 +1387,27 @@ class SparkContext(config: SparkConf) extends Logging with

[GitHub] spark pull request: [SPARK-14990][SQL] Fix checkForSameTypeInputEx...

Github user rxin commented on the pull request: https://github.com/apache/spark/pull/13208#issuecomment-220518940 Merging in master/2.0. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-15114][SQL] Column name generated by ty...

Github user dilipbiswal commented on a diff in the pull request: https://github.com/apache/spark/pull/13045#discussion_r63992015 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Column.scala --- @@ -37,6 +38,14 @@ private[sql] object Column { def apply(expr:

[GitHub] spark pull request: [SPARK-14990][SQL] Fix checkForSameTypeInputEx...

Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/13208#issuecomment-220518610 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-15363][ML][Example]:Example code should...

Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13213#issuecomment-220518293 **[Test build #58941 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58941/consoleFull)** for PR 13213 at commit

[GitHub] spark pull request: [SPARK-15363][ML][Example]:Example code should...

GitHub user wangmiao1981 opened a pull request: https://github.com/apache/spark/pull/13213 [SPARK-15363][ML][Example]:Example code shouldn't use VectorImplicits._, asML/fromML ## What changes were proposed in this pull request? (Please fill in changes proposed in this fix)

[GitHub] spark pull request: [SPARK-15379][SQL] check special invalid date

Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/13169#issuecomment-220518098 LGTM, except some minor comment, thanks for working on it! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-15379][SQL] check special invalid date

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13169#discussion_r63991642 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/DateTimeUtilsSuite.scala --- @@ -353,6 +353,20 @@ class DateTimeUtilsSuite

[GitHub] spark pull request: [SPARK-15114][SQL] Column name generated by ty...

Github user dilipbiswal commented on a diff in the pull request: https://github.com/apache/spark/pull/13045#discussion_r63991554 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetAggregatorSuite.scala --- @@ -240,4 +240,15 @@ class DatasetAggregatorSuite extends

[GitHub] spark pull request: [SPARK-15428][SQL] Disable multiple streaming ...

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13210#issuecomment-220517869 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15428][SQL] Disable multiple streaming ...

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13210#issuecomment-220517868 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15428][SQL] Disable multiple streaming ...

Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13210#issuecomment-220517778 **[Test build #58936 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58936/consoleFull)** for PR 13210 at commit

[GitHub] spark pull request: [SPARK-15379][SQL] check special invalid date

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13169#discussion_r63991470 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala --- @@ -426,6 +426,26 @@ object DateTimeUtils { }

[GitHub] spark pull request: [SPARK-15431][SQL] Support LIST FILE(s)|JAR(s)...

Github user xwu0226 commented on a diff in the pull request: https://github.com/apache/spark/pull/13212#discussion_r63991418 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/resources.scala --- @@ -46,3 +46,33 @@ case class AddFile(path: String) extends

[GitHub] spark pull request: [SPARK-15431][SQL] Support LIST FILE(s)|JAR(s)...

Github user xwu0226 commented on a diff in the pull request: https://github.com/apache/spark/pull/13212#discussion_r63991451 --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala --- @@ -1387,6 +1387,27 @@ class SparkContext(config: SparkConf) extends Logging with

[GitHub] spark pull request: [SPARK-15431][SQL] Support LIST FILE(s)|JAR(s)...

Github user xwu0226 commented on a diff in the pull request: https://github.com/apache/spark/pull/13212#discussion_r63991431 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/resources.scala --- @@ -46,3 +46,33 @@ case class AddFile(path: String) extends

[GitHub] spark pull request: [SPARK-15367] [SQL] Add refreshTable back

Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13156#issuecomment-220517365 **[Test build #58940 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58940/consoleFull)** for PR 13156 at commit

[GitHub] spark pull request: [SPARK-15431][SQL] Support LIST FILE(s)|JAR(s)...

Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/13212#discussion_r63991280 --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala --- @@ -1387,6 +1387,27 @@ class SparkContext(config: SparkConf) extends Logging with

[GitHub] spark pull request: [SPARK-15431][SQL] Support LIST FILE(s)|JAR(s)...

Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/13212#discussion_r63991284 --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala --- @@ -1724,6 +1745,22 @@ class SparkContext(config: SparkConf) extends Logging with

[GitHub] spark pull request: [SPARK-15114][SQL] Column name generated by ty...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13045#discussion_r63991309 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Column.scala --- @@ -37,6 +38,14 @@ private[sql] object Column { def apply(expr: Expression):

[GitHub] spark pull request: [SPARK-15114][SQL] Column name generated by ty...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13045#discussion_r63991215 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetAggregatorSuite.scala --- @@ -240,4 +240,15 @@ class DatasetAggregatorSuite extends

[GitHub] spark pull request: [SPARK-15431][SQL] Support LIST FILE(s)|JAR(s)...

Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/13212#discussion_r63991184 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/resources.scala --- @@ -46,3 +46,33 @@ case class AddFile(path: String) extends

[GitHub] spark pull request: [SPARK-15431][SQL] Support LIST FILE(s)|JAR(s)...

Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/13212#discussion_r63991179 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/resources.scala --- @@ -46,3 +46,33 @@ case class AddFile(path: String) extends

[GitHub] spark pull request: [SPARK-15075][SPARK-15345][SQL] Clean up Spark...

Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/13200 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-15114][SQL] Column name generated by ty...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13045#discussion_r63991134 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala --- @@ -325,10 +325,13 @@ case class

[GitHub] spark pull request: [SPARK-15236][SQL][SPARK SHELL] Add spark-defa...

Github user xwu0226 commented on the pull request: https://github.com/apache/spark/pull/13088#issuecomment-220516958 @rxin @yhuai @andrewor14 Please help check if the updated change is in the right direction, Thank you very much! --- If your project is set up for it, you can reply

[GitHub] spark pull request: [SPARK-15075][SPARK-15345][SQL] Clean up Spark...

Github user rxin commented on the pull request: https://github.com/apache/spark/pull/13200#issuecomment-220516955 Thanks - merging in master/2.0. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-15367] [SQL] Add refreshTable back

Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/13156#issuecomment-220516949 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-15114][SQL] Column name generated by ty...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13045#discussion_r63991063 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -174,14 +174,16 @@ class Analyzer( private

[GitHub] spark pull request: [SPARK-15313][SQL] EmbedSerializerInFilter rul...

Github user rxin commented on the pull request: https://github.com/apache/spark/pull/13096#issuecomment-220516852 Can you add the jira ticket somewhere as inline comment in the test case and in the analyzer code? --- If your project is set up for it, you can reply to this email and

[GitHub] spark pull request: [SPARK-15075][SPARK-15345][SQL] Clean up Spark...

Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/13200#issuecomment-220516804 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-15075][SPARK-15345][SQL] Clean up Spark...

Github user rxin commented on the pull request: https://github.com/apache/spark/pull/13200#issuecomment-220516531 @marmbrus i know you were looking at this. Did you end up going through it? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-15431][SQL] Support LIST FILE(s)|JAR(s)...

Github user xwu0226 commented on the pull request: https://github.com/apache/spark/pull/13212#issuecomment-220516455 cc @yhuai @hvanhovell @gatorsmile Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15431][SQL] Support LIST FILE(s)|JAR(s)...

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13212#issuecomment-220516397 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11827] [SQL] Adding java.math.BigIntege...

Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/10125#issuecomment-220516202 thanks, merging to master and 2.0! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-11827] [SQL] Adding java.math.BigIntege...

Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/10125 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-15075][SPARK-15345][SQL] Clean up Spark...

Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13200#issuecomment-220515969 **[Test build #58939 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58939/consoleFull)** for PR 13200 at commit

[GitHub] spark pull request: [SPARK-15431][SQL] Support LIST FILE(s)|JAR(s)...

GitHub user xwu0226 opened a pull request: https://github.com/apache/spark/pull/13212 [SPARK-15431][SQL] Support LIST FILE(s)|JAR(s) command natively ## What changes were proposed in this pull request? Currently command "ADD FILE|JAR " is supported natively in

[GitHub] spark pull request: [SPARK-15114][SQL] Column name generated by ty...

Github user dilipbiswal commented on the pull request: https://github.com/apache/spark/pull/13045#issuecomment-220515698 cc @cloud-fan Hi Wenchen, I have made the changes per your comments. Could you please look through it when you get a chance ? Thanks.. --- If your project is set

[GitHub] spark pull request: [SPARK-15367] [SQL] Add refreshTable back

Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/13156#issuecomment-220515502 LGTM, pending jenkins --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-15425][SQL] Disallow cartesian joins by...

Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/13209#discussion_r63990349 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -348,6 +348,11 @@ object SQLConf { .booleanConf

[GitHub] spark pull request: [SPARK-8603][SPARKR] Incorrect file separator ...

Github user HyukjinKwon commented on the pull request: https://github.com/apache/spark/pull/13165#issuecomment-220515342 This raises some questions to me. 1. It seems several tests were failed. Could you please inform me your thoughts? 2. Now, I think I can add some

[GitHub] spark pull request: [SPARK-8603][SPARKR] Incorrect file separator ...

Github user HyukjinKwon commented on the pull request: https://github.com/apache/spark/pull/13165#issuecomment-220515182 @sun-rui @felixcheung Right. It seems finally I made it. I made gists and upload a PDF file for Spark UI. Let me tell you the test results first.

[GitHub] spark pull request: [SPARK-15321] Fix bug where Array[Timestamp] c...

Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/13108 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-15321] Fix bug where Array[Timestamp] c...

Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/13108#issuecomment-220514860 LGTM, merging to master and 2.0, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15430][SQL] Fix potential ConcurrentMod...

Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13211#issuecomment-220514553 **[Test build #58938 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58938/consoleFull)** for PR 13211 at commit

[GitHub] spark pull request: [SPARK-15430][SQL] Fix potential ConcurrentMod...

GitHub user viirya opened a pull request: https://github.com/apache/spark/pull/13211 [SPARK-15430][SQL] Fix potential ConcurrentModificationException for ListAccumulator ## What changes were proposed in this pull request? In `ListAccumulator` we create an unmodifiable view

[GitHub] spark pull request: [SPARK-15367] [SQL] Add refreshTable back

Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/13156#issuecomment-220513843 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-15100][DOC] Modified user guide and exa...

Github user GayathriMurali commented on the pull request: https://github.com/apache/spark/pull/13176#issuecomment-220513197 @hhbyyh Can you please help review this? I will resolve the branch conflict along with review comments --- If your project is set up for it, you can reply to

[GitHub] spark pull request: [SPARK-15379][SQL] check special invalid date

Github user wangyang1992 commented on the pull request: https://github.com/apache/spark/pull/13169#issuecomment-220512727 @cloud-fan Could you please help me look at this some time? A simple fix. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SPARK-15360][Spark-Submit]Should print spark-...

Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13163#issuecomment-220512285 **[Test build #58937 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58937/consoleFull)** for PR 13163 at commit

[GitHub] spark pull request: [SPARK-15360][Spark-Submit]Should print spark-...

Github user wangmiao1981 commented on a diff in the pull request: https://github.com/apache/spark/pull/13163#discussion_r63988573 --- Diff: launcher/src/test/java/org/apache/spark/launcher/SparkSubmitCommandBuilderSuite.java --- @@ -59,6 +59,18 @@ public void

[GitHub] spark pull request: [SPARK-15321] Fix bug where Array[Timestamp] c...

Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13108#issuecomment-220511906 **[Test build #2999 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2999/consoleFull)** for PR 13108 at commit

[GitHub] spark pull request: [SPARK-15428][SQL] Disable multiple streaming ...

Github user tdas commented on the pull request: https://github.com/apache/spark/pull/13210#issuecomment-220511611 cc @marmbrus --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-15335] [SQL] Implement TRUNCATE TABLE C...

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13170#issuecomment-220511333 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15335] [SQL] Implement TRUNCATE TABLE C...

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13170#issuecomment-220511331 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15428][SQL] Disable multiple streaming ...

Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/13210#discussion_r63988111 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/UnsupportedOperationChecker.scala --- @@ -55,10 +55,19 @@ object

[GitHub] spark pull request: [SPARK-15335] [SQL] Implement TRUNCATE TABLE C...

Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13170#issuecomment-220511206 **[Test build #58935 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58935/consoleFull)** for PR 13170 at commit

  1   2   3   4   5   6   7   8   9   >