Re: Simplified and uniform volume handling - asking for opinions

2005-12-09 Thread Simon M.
Hi, I think the new volume setting is fine and the -db setting is very intuitive when you get used to it. But I think it wasn't a good idea to remove clipping prevention completely. The argument was: almost no hifi-equipment uses clipping prevention, so why should we use it? Rockbox is better

Re: Simplified and uniform volume handling - asking for opinions

2005-12-08 Thread Jens Arnold
On 08.12.2005, Magnus Holmgren wrote: My patch removes clipping prevention altogether (like we had it on Archos Recorders Ondios for years, btw). And makes fade on stop pretty ugly (sounds get chopped rather than change smoothly), it seems... :) Oooops, that's a bug. I forgot to adjust the

Re: Simplified and uniform volume handling - asking for opinions

2005-12-08 Thread Manuel Dejonghe
On 12/8/05, [IDC]Dragon [EMAIL PROTECTED] wrote: I don't think I've ever seen any audio playback equipment of any kind offer clipping prevention. Haha, I just envision how odd it would be if my amp would start turning other knobs as I crank up the volume... lol. That's a good one. lImbus

Re: Simplified and uniform volume handling - asking for opinions

2005-12-07 Thread Björn Stenberg
Christi Alice Scarborough wrote: I do believe that there is value in an option that prevents clipping, particularly if it can be implemented in a platform independent way. Personally I find the whole idea of clipping prevention somewhat odd, very much protecting the user from himself which

Re: Simplified and uniform volume handling - asking for opinions

2005-12-06 Thread Linus Nielsen Feltzing
Jens Arnold wrote: Now I am asking for opinions/ suggestions on this. I would really like to commit this... Gets my vote. Linus

Re: Simplified and uniform volume handling - asking for opinions

2005-12-06 Thread Thom Johansen
Jens Arnold wrote: Now I am asking for opinions/ suggestions on this. I would really like to commit this... This is more or less exactly what I've wanted all along, so thumbs up from me. Thom

RE: Simplified and uniform volume handling - asking for opinions

2005-12-06 Thread Daniel Stenberg
On Tue, 6 Dec 2005, Anton Oleynikov wrote: The whole point of me doing first patch was that second option. It was extensively discussed in the forum and now that seem to be eliminated, right? In the forum perhaps, but not a lot here. How come? Jens explained it pretty well in his mail,

RE: Simplified and uniform volume handling - asking for opinions

2005-12-06 Thread Daniel Stenberg
On Tue, 6 Dec 2005, Anton Oleynikov wrote: And no matter what, it is always considered fine to improve whatever we did before. Improve - yes, but completely remove what I've just done after not even speak up when asked - its another thing :) But he mailed here now and we're debating it

Re: Simplified and uniform volume handling - asking for opinions

2005-12-06 Thread Linus Nielsen Feltzing
Anton Oleynikov wrote: The whole point of my patch was that user finally have intelligent bass/volume control that allow him to compare sound directly to original iRiver's firmware This is absolutely irrelevant IMHO. We couldn't care less about the original firmware. Linus

Re: Simplified and uniform volume handling - asking for opinions

2005-12-06 Thread Daniel Stenberg
On Tue, 6 Dec 2005, Michael E. DiFebbo wrote: I also believe that having a prevent clipping function similar to what Anton developed is beneficial to Rockbox, particularly with respect to making it more accessible to less sophisticated users. All the discussions that have been held on this