Re: [CVS] RPM: rpm/lib/ rpmds.c

2011-04-10 Thread Jeff Johnson
There's a segfault here when rindex returns NULL. And POSIX strchr/strrchr, not *BSD index/rindex please. 73 de Jeff On Apr 10, 2011, at 2:05 AM, Per Øyvind Karlsen wrote: RPM Package Manager, CVS Repository http://rpm5.org/cvs/

Re: [CVS] RPM: rpm/lib/ rpmds.c

2011-04-10 Thread Jeff Johnson
And try to avoid strstr please. The behavior implemented in strstr(3) is sloppy and inevitably (in my experience) leads to some bizarre corner case breakage. 73 de Jeff en On Apr 10, 2011, at 2:57 AM, Per Øyvind Karlsen wrote: RPM Package Manager, CVS Repository http://rpm5.org/cvs/

Re: [CVS] RPM: rpm/lib/ rpmds.c

2011-01-25 Thread Jeff Johnson
This change MUST be tested and integrated somehow. As long as there are no test cases and explicit test harnesses across more than de facto Mandriva Cooker, well, the change cannot be Just Turned On. There's all sorts of creeping crud that crawls out when RPM version comparison changes, and

Re: [CVS] RPM: rpm/lib/ rpmds.c

2011-01-25 Thread Per Øyvind Karlsen
2011/1/25 Jeff Johnson n3...@mac.com: This change MUST be tested and integrated somehow. I'm working on it, this is why my later commits are touching /tests. :) I'm about to push a new cvs snapshot to cooker with 'make check' (finally) enabled now, you should see some new regression tests

Re: [CVS] RPM: rpm/lib/ rpmds.c

2009-03-20 Thread Per Øyvind Karlsen
2009/3/19 Jeff Johnson n3...@mac.com That's better, but there's still a fundamental flaw in what you are attempting. Data has endiannness, not CPU's. Yes, but the order of the data read depends on the cpu..? I'm not sure what you mean.. So a library for cpuinfo only provides (at

Re: [CVS] RPM: rpm/lib/ rpmds.c rpmrc.c

2009-03-19 Thread Jeff Johnson
This is pointless crapola. Endianness can be figured at run-time without all the baggage: union _dbswap { rpmuint32_t ui; unsigned char uc[4]; }; static union _dbswap bigorlittle = { .ui = 0x00112233 }; bool littleendian = (bigorlittle.uc[0] != 0x00); One does not need a library API

Re: [CVS] RPM: rpm/lib/ rpmds.c

2009-03-19 Thread Jeff Johnson
That's better, but there's still a fundamental flaw in what you are attempting. Data has endiannness, not CPU's. So a library for cpuinfo only provides (at best) half of what is needed, and the run-time detection of cpu endianness is trivially done whenever/wherever needed. Tagging

Re: [CVS] RPM: rpm/lib/ rpmds.c

2008-03-14 Thread Jeff Johnson
On Mar 14, 2008, at 10:02 PM, Olivier Thauvin wrote: Le samedi 15 mars 2008, Jeff Johnson a écrit : Um, please start some discussion before just adding two new dependency types to rpmds. I'm strongly opposed to adding 2 new dependency types within package content. RPMSENSE_MISSINGOK to

Re: [CVS] RPM: rpm/lib/ rpmds.c rpmrc.c

2007-07-03 Thread Jeff Johnson
On Jul 3, 2007, at 11:53 AM, Ralf S. Engelschall wrote: On Tue, Jul 03, 2007, Mark Hatle wrote: Jeff Johnson wrote: IMHO, this is the wrong fix. per-system configuration belongs in the per-system configuration directory, which is /etc everywhere. scarcasm Or perhaps I missed some n00bie