You can view, comment on, or merge this pull request online at:
https://github.com/rpm-software-management/rpm/pull/2713
-- Commit Summary --
* Move $PWD bind mount out of snapshot shell
* Bind mount $PWD at $PWD, not /srv
* Dont stack overlays in test-suite
* Move make_install to
@pmatilai commented on this pull request.
> +rpmRC rc = RPMRC_FAIL;
+
+/* XXX Skip valid arch check if not building binary package */
+if (!(spec->flags & RPMSPEC_ANYARCH) && checkForValidArchitectures(spec)) {
+ goto exit;
+}
+
+
@pmatilai converted this issue into discussion #2711.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2697#event-10602607945
You are receiving this because you are subscribed to this thread.
Message ID:
@pmatilai commented on this pull request.
> @@ -37,6 +37,7 @@ enum rpmSpecFlags_e {
RPMSPEC_FORCE = (1 << 1),
RPMSPEC_NOLANG = (1 << 2),
RPMSPEC_NOUTF8 = (1 << 3),
+RPMSPEC_NOFINALIZATION = (1 << 4),
I actually meant just "NOFINALIZE" which isn't quite as
@pmatilai commented on this pull request.
> +rpmRC rc = RPMRC_FAIL;
+
+/* XXX Skip valid arch check if not building binary package */
+if (!(spec->flags & RPMSPEC_ANYARCH) && checkForValidArchitectures(spec)) {
+ goto exit;
+}
+
+
The main reason is to get real-world relevant warnings from the CI build, gcc
with no optimizations seems to miss all sorts of things. Debug info is just
handy to have around when developing.
You can view, comment on, or merge this pull request online at:
@pmatilai pushed 1 commit.
a2bbe74fb4c1190b2c4d250a9306330e866fe346 Test fubar
--
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2712/files/1e6eb4dad3511b881c185a50e225c7ced97d247a..a2bbe74fb4c1190b2c4d250a9306330e866fe346
You are receiving this because you are
Merged #2712 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2712#event-10603865070
You are receiving this because you are subscribed to this thread.
Message ID:
___
Rpm-maint
BTW one cosmetic issue here in all but the first commits: the commit summary
line and actual message should be independent of each other. Continuing the
description where the summary line left off seems to be a bit of a habbit of
yours (ie not just in this PR), please don't do that.
--
Reply
Have you tested this with some of the more complicated specs in Fedora, eg
kernel / texlive / the Lua-generated stuff and so on? Our test-suite doesn't
really exercise the spec parsing voodoo that deeply, and a change this big in
that department makes this sheep rather nervous.
--
Reply to
@pmatilai commented on this pull request.
> +rpmRC rc = RPMRC_FAIL;
+
+/* XXX Skip valid arch check if not building binary package */
+if (!(spec->flags & RPMSPEC_ANYARCH) && checkForValidArchitectures(spec)) {
+ goto exit;
+}
+
+
@pmatilai pushed 1 commit.
80c0866ef079484f30315559959643917c8e3506 Run the CI build in parallel
--
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2712/files/5f27567799b6e7bac4da7a20702109afc4fa29f8..80c0866ef079484f30315559959643917c8e3506
You are receiving this
@pmatilai pushed 1 commit.
5f27567799b6e7bac4da7a20702109afc4fa29f8 Run the CI build in parallel
--
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2712/files/a2bbe74fb4c1190b2c4d250a9306330e866fe346..5f27567799b6e7bac4da7a20702109afc4fa29f8
You are receiving this
@dmnks pushed 1 commit.
84ffcefee3d9189ad07f3fea3dcb98a7702156e6 Add rpmtests wrapper for container use
--
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2713/files/2bc57d15f4c76a907484d8713503e480ccf8e973..84ffcefee3d9189ad07f3fea3dcb98a7702156e6
You are receiving this
@dmnks pushed 5 commits.
2337e3b83249bc693df23dbbd5d853bc97677ee1 Don't stack overlays in test-suite
ad91f9959513ce96a1b246d7a2801c114dfdbcfa Move make_install to after package
installation
51bf6f91e3aaa7ca9f1cfff38084b27a7cc27a45 Depend on mktree script when building
the tree
Here goes one more commit on top :smile:
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2713#issuecomment-1755795740
You are receiving this because you are subscribed to this thread.
Message ID:
We have some accumulated fixes from the last ~6 months, time to put out a
bugfix release. There should be several others but in particular 4.18.x not
having ea3187cfcf9cac87e5bc5e7db79b0338da9e355e is causing dnf segfaults so
it's a bit critical. If it turns out that we only have five patches
17 matches
Mail list logo
