Colon is a perfectly natural tuple separator widely used: see $PATH for an
obvious example.
This is a parsing, not an aesthetic, issue whatever your opinion might be.
Dependency tuples need to be easily parsed into a {E,V,R,D,...} tuple as simply
and speedily as possible.
--
You are
Conan-Kudo commented on this pull request.
> @@ -731,13 +731,14 @@ int rpmdbCountPackages(rpmdb db, const char * name)
}
/**
- * Attempt partial matches on name[-version[-release]][.arch] strings.
+ * Attempt partial matches on name[-version[-release]][/disttag][.arch]
strings.
No one
There are 2 parsing problems triggered by adding disttag:
1) how to represent distag in dependencies (omv used a ':' separator)
2) how to represent distag in package file names (omv used a '-' separator)
There is also the question of precedence in version comparison, whether disttag
should be
ignatenkobrain: I don't think it makes sense to allow the disttag in
dependencies, aka EVR. It's for the "canonical" package name, i.e. NEVRA.
In other words, 'rpm -qa' should print it and thus 'rpm -q' should understand
it. It should also be a part of the filename, so '/' should not be used
wladmis commented on this pull request.
> @@ -731,13 +731,14 @@ int rpmdbCountPackages(rpmdb db, const char * name)
}
/**
- * Attempt partial matches on name[-version[-release]][.arch] strings.
+ * Attempt partial matches on name[-version[-release]][/disttag][.arch]
strings.
@Conan-Kudo
I'm fine with MIT as well.
Jindrich
On 11/9/18 4:35 PM, Tom Callaway wrote:
>
> Because I enjoy resolving 20 year old licensing issues... :)
>
> The existing license on find-lang.sh reads:
>
> |#findlang is copyright (c) 1998 by W. L. Estes
> #Redistribution and use of this software are hereby
Conan-Kudo commented on this pull request.
> @@ -731,13 +731,14 @@ int rpmdbCountPackages(rpmdb db, const char * name)
}
/**
- * Attempt partial matches on name[-version[-release]][.arch] strings.
+ * Attempt partial matches on name[-version[-release]][/disttag][.arch]
strings.
@wladmis
Conan-Kudo commented on this pull request.
> @@ -731,13 +731,14 @@ int rpmdbCountPackages(rpmdb db, const char * name)
}
/**
- * Attempt partial matches on name[-version[-release]][.arch] strings.
+ * Attempt partial matches on name[-version[-release]][/disttag][.arch]
strings.
The
Conan-Kudo commented on this pull request.
> @@ -731,13 +731,14 @@ int rpmdbCountPackages(rpmdb db, const char * name)
}
/**
- * Attempt partial matches on name[-version[-release]][.arch] strings.
+ * Attempt partial matches on name[-version[-release]][/disttag][.arch]
strings.
@wladmis
wladmis commented on this pull request.
> @@ -731,13 +731,14 @@ int rpmdbCountPackages(rpmdb db, const char * name)
}
/**
- * Attempt partial matches on name[-version[-release]][.arch] strings.
+ * Attempt partial matches on name[-version[-release]][/disttag][.arch]
strings.
I don't know
wladmis commented on this pull request.
> @@ -731,13 +731,14 @@ int rpmdbCountPackages(rpmdb db, const char * name)
}
/**
- * Attempt partial matches on name[-version[-release]][.arch] strings.
+ * Attempt partial matches on name[-version[-release]][/disttag][.arch]
strings.
I decided to
I'm ok with relicensing to MIT.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/595#issuecomment-437435051___
Rpm-maint
- [x] @scop ok with relicensing under MIT
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/595#issuecomment-437430364___
Conan-Kudo commented on this pull request.
> @@ -731,13 +731,14 @@ int rpmdbCountPackages(rpmdb db, const char * name)
}
/**
- * Attempt partial matches on name[-version[-release]][.arch] strings.
+ * Attempt partial matches on name[-version[-release]][/disttag][.arch]
strings.
Do you
Because I enjoy resolving 20 year old licensing issues... :)
The existing license on find-lang.sh reads:
```
#findlang is copyright (c) 1998 by W. L. Estes
#Redistribution and use of this software are hereby permitted for any
#purpose as long as this notice and the above copyright notice
ignatenkobrain commented on this pull request.
> @@ -731,13 +731,14 @@ int rpmdbCountPackages(rpmdb db, const char * name)
}
/**
- * Attempt partial matches on name[-version[-release]][.arch] strings.
+ * Attempt partial matches on name[-version[-release]][/disttag][.arch]
strings.
I
I am not at all against having scripts for normal dependency generation. But
their are a few important differences to the BuildRequires:
- They have to be attached to a sub package and cannot be global
- We may want to (be able to) associate the script to files - so we need a way
of passing the
Conan-Kudo requested changes on this pull request.
> @@ -731,13 +731,14 @@ int rpmdbCountPackages(rpmdb db, const char * name)
}
/**
- * Attempt partial matches on name[-version[-release]][.arch] strings.
+ * Attempt partial matches on name[-version[-release]][/disttag][.arch]
strings.
> Still haven't gotten around to look this in any real detail, but here's
> another thought: why limit this to only buildrequires? One of the major
> shortcomings of the "new" dependency generator is the inability to generate
> package specific dependencies easily, and this looks like a nice
Still haven't gotten around to look this in any real detail, but here's another
thought: why limit this to only buildrequires? One of the major shortcomings of
the "new" dependency generator is the inability to generate package specific
dependencies easily, and this looks like a nice general
Hmm, explicit attr used to be required for ghosts that don't exist in the
buildroot, but seems that went out with
d6775a746bbaf8ddc8a91c9fae68ae91af1cc570. In retrospective, "If %defattr()
doesn't specify a mode the file will be seen without any permissions at all,
but that's not strictly an
21 matches
Mail list logo
