Re: [Rpm-maint] [PATCH 3/5] Drop local implementation of xsetprogname/xgetprogname

2017-03-24 Thread Panu Matilainen
On 03/23/2017 09:08 PM, Neal Gompa wrote: On Thu, Mar 23, 2017 at 2:22 PM, Gleb Fotengauer-Malinovskiy wrote: It can be dropped because this code was never actually enabled. Actually, this implementation *surely* never ever compiled. Are you sure of this? Because this

Re: [Rpm-maint] [PATCH 2/5] Only build bundled fts if system has a bad version that doesn't handle LFS

2017-03-24 Thread Panu Matilainen
On 03/23/2017 08:21 PM, Gleb Fotengauer-Malinovskiy wrote: Older versions of glibc included an fts implementation that didn't have Large File Support on 32-bit systems. We worked that around by bundling fts into rpm codebase. Thanks to Mark Wielaard, glibc >= 2.23 has LFS support in fts.

Re: [Rpm-maint] [PATCH 3/5] Drop local implementation of xsetprogname/xgetprogname

2017-03-24 Thread Panu Matilainen
On 03/24/2017 11:02 AM, Panu Matilainen wrote: On 03/23/2017 10:48 PM, Dmitry V. Levin wrote: On Thu, Mar 23, 2017 at 03:08:57PM -0400, Neal Gompa wrote: On Thu, Mar 23, 2017 at 2:22 PM, Gleb Fotengauer-Malinovskiy wrote: It can be dropped because this code was never actually enabled.

Re: [Rpm-maint] [PATCH v2] Unbreak short-circuited binary builds (RhBug:1434235)

2017-03-24 Thread Panu Matilainen
On 03/23/2017 04:37 PM, Mark Wielaard wrote: On Wed, 2017-03-22 at 14:37 +0200, Panu Matilainen wrote: Guess there's some unhandled corner left still :) Yeah, that was because my fix was bogus :{ It didn't construct the linkpath correctly (because it was relative). It checked with readlink

Re: [Rpm-maint] [PATCH 3/5] Drop local implementation of xsetprogname/xgetprogname

2017-03-24 Thread Panu Matilainen
On 03/23/2017 10:48 PM, Dmitry V. Levin wrote: On Thu, Mar 23, 2017 at 03:08:57PM -0400, Neal Gompa wrote: On Thu, Mar 23, 2017 at 2:22 PM, Gleb Fotengauer-Malinovskiy wrote: It can be dropped because this code was never actually enabled. Actually, this implementation *surely* never ever

Re: [Rpm-maint] [PATCH 2/5] Only build bundled fts if system has a bad version that doesn't handle LFS

2017-03-24 Thread Mark Wielaard
On Fri, 2017-03-24 at 11:15 +0200, Panu Matilainen wrote: > On 03/23/2017 08:21 PM, Gleb Fotengauer-Malinovskiy wrote: > > diff --git a/configure.ac b/configure.ac > > index bdcb741..687d58c 100644 > > --- a/configure.ac > > +++ b/configure.ac > > @@ -717,6 +717,9 @@ AC_CHECK_FUNCS( > >

Re: [Rpm-maint] [PATCH] build/files.c (generateBuildIDs): Fix small memory leak.

2017-03-24 Thread Panu Matilainen
On 03/23/2017 04:46 PM, Mark Wielaard wrote: From: Mark Wielaard mainiddir and debugiddir are allocated through rpmGetPath () and should be released when done. Signed-off-by: Mark Wielaard --- build/files.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [Rpm-maint] [PATCH 5/5] Include system.h in ima and syslog plugins

2017-03-24 Thread Panu Matilainen
On 03/23/2017 08:23 PM, Gleb Fotengauer-Malinovskiy wrote: Currently, there is no harm if config.h is not included in these files because they are not sensitive to macros defined in config.h, but any code added later or any plugin created using these plugins as examples might be affected by

Re: [Rpm-maint] [PATCH 3/5] Drop local implementation of xsetprogname/xgetprogname

2017-03-24 Thread Panu Matilainen
On 03/23/2017 08:22 PM, Gleb Fotengauer-Malinovskiy wrote: It can be dropped because this code was never actually enabled. Actually, this implementation *surely* never ever compiled. Signed-off-by: Gleb Fotengauer-Malinovskiy After spending a few minutes looking at what

[Rpm-maint] [PATCH] Support debuginfo subpackages

2017-03-24 Thread Michael Schroeder
The attached patch makes rpm create debuginfo subpackage for each subpackage that contains files with debug data. This is pretty much a complete rewrite of the old SUSE patch, so this needs a review. As this is off by default it can't break anything. Cheers, Michael. -- Michael Schroeder

Re: [Rpm-maint] [PATCH] Support debugsource subpackages

2017-03-24 Thread Dmitry V. Levin
On Fri, Mar 24, 2017 at 04:15:36PM +0100, Michael Schroeder wrote: > > The attached patch makes rpm create -debugsource subpackages containing > the debug sources. [...] > +if [ -n "$srcout" ]; then > + > "$srcout" > + if [ -d "${RPM_BUILD_ROOT}/usr/src" ]; then > +(cd

[Rpm-maint] [rpm-software-management/rpm] Add support for debugsource subpackages and split debuginfo subpackages (#180)

2017-03-24 Thread Michael Schroeder
This adds support for SUSE style debuginfo packages. Due to the changes in rpm upstream the patch had to be pretty much rewritten from scratch. As the new functionality is off per default the patch cannot break anything. You can view, comment on, or merge this pull request online at:

[Rpm-maint] [PATCH] Support debugsource subpackages

2017-03-24 Thread Michael Schroeder
The attached patch makes rpm create -debugsource subpackages containing the debug sources. Cheers, Michael. -- Michael Schroeder m...@suse.de SUSE LINUX GmbH, GF Jeff Hawn, HRB 16746 AG Nuernberg