Thank *you!*
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/154#issuecomment-280033726___
Rpm-maint mailing list
Merged #154.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/154#event-963210836___
Rpm-maint mailing list
torsava commented on this pull request.
> if not dist.py_version:
-warn("Version for {!r} has not been found".format(dist),
RuntimeWarning)
-continue
+# Try to parse the Python version from the path the metadata
+# resides at (e.g.
ffesti commented on this pull request.
> if not dist.py_version:
-warn("Version for {!r} has not been found".format(dist),
RuntimeWarning)
-continue
+# Try to parse the Python version from the path the metadata
+# resides at (e.g.
I've changed it to `\d+\.\d` so we don't get a Python Y2K equivalent. :)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
torsava commented on this pull request.
> if not dist.py_version:
-warn("Version for {!r} has not been found".format(dist),
RuntimeWarning)
-continue
+# Try to parse the Python version from the path the metadata
+# resides at (e.g.
ffesti requested changes on this pull request.
Other than the bit sloppy RE this looks good.
> if not dist.py_version:
-warn("Version for {!r} has not been found".format(dist),
RuntimeWarning)
-continue
+# Try to parse the Python version from the
@ffesti Could you please merge this?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/154#issuecomment-279715293___
Rpm-maint
ignatenkobrain approved this pull request.
LGTM, @Conan-Kudo thoughts?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
