On Tue, 19 Mar 2024 17:46:31 GMT, Tobias Holenstein
wrote:
>> I've asked this myself (after making the change).
>> Being in `WXWrite` mode would be wrong if the thread would execute
>> dynamically generated code. There's not too much happening outside the scope
>> of the
On Mon, 18 Mar 2024 13:14:41 GMT, Richard Reingruber wrote:
>> This pr changes `JfrJvmtiAgent::retransform_classes()` and
>> `jfr_set_enabled` to switch to `WXWrite` before transitioning to the vm.
>>
>> Testing:
>> make test TEST=jdk/jfr/event/runtime/TestClassLoadEvent.java
>>
On Mon, 18 Mar 2024 13:14:41 GMT, Richard Reingruber wrote:
>> This pr changes `JfrJvmtiAgent::retransform_classes()` and
>> `jfr_set_enabled` to switch to `WXWrite` before transitioning to the vm.
>>
>> Testing:
>> make test TEST=jdk/jfr/event/runtime/TestClassLoadEvent.java
>>
On Tue, 19 Mar 2024 15:17:50 GMT, Thomas Stuefe wrote:
> > Not necessarily. It may well remove some transitions from paths that don't
> > need it, but if you move the state change too low down the call chain you
> > could end up transitioning much more often in code that does need it e.g.
> >
On Mon, 18 Mar 2024 13:14:41 GMT, Richard Reingruber wrote:
>> This pr changes `JfrJvmtiAgent::retransform_classes()` and
>> `jfr_set_enabled` to switch to `WXWrite` before transitioning to the vm.
>>
>> Testing:
>> make test TEST=jdk/jfr/event/runtime/TestClassLoadEvent.java
>>
On Mon, 18 Mar 2024 13:14:41 GMT, Richard Reingruber wrote:
>> This pr changes `JfrJvmtiAgent::retransform_classes()` and
>> `jfr_set_enabled` to switch to `WXWrite` before transitioning to the vm.
>>
>> Testing:
>> make test TEST=jdk/jfr/event/runtime/TestClassLoadEvent.java
>>
On Mon, 18 Mar 2024 13:14:41 GMT, Richard Reingruber wrote:
>> This pr changes `JfrJvmtiAgent::retransform_classes()` and
>> `jfr_set_enabled` to switch to `WXWrite` before transitioning to the vm.
>>
>> Testing:
>> make test TEST=jdk/jfr/event/runtime/TestClassLoadEvent.java
>>
On Wed, 13 Mar 2024 13:53:46 GMT, Richard Reingruber wrote:
>> src/hotspot/share/jfr/instrumentation/jfrJvmtiAgent.cpp line 160:
>>
>>> 158: ResourceMark rm(THREAD);
>>> 159: // WXWrite is needed before entering the vm below and in callee
>>> methods.
>>> 160:
On Tue, 19 Mar 2024 17:08:52 GMT, Richard Reingruber wrote:
> I see it differently. This PR is just a simple attempt to get clean test runs
> with AssertWXAtThreadSync (after fixing an actual crash
> https://bugs.openjdk.org/browse/JDK-8327036). While the violating locations
> in this PR
On Tue, 19 Mar 2024 12:17:22 GMT, David Holmes wrote:
> But all this discussion suggests to me that this PR is not really worth
> pursuing at this time - IIUC no actual failures are observed other than those
> pertaining to AssertWXAtThreadSync and that flag will be gone if we do decide
> to
On Tue, 19 Mar 2024 12:17:22 GMT, David Holmes wrote:
>> Instead, could we tag code that needs one or the other, keep track of the
>> current WX state in thread-local memory, and flip WX only when we know we
>> need to?
The first part we already do.
I wonder wheter we could - at least as
On Tue, 19 Mar 2024 12:17:22 GMT, David Holmes wrote:
> IIUC no actual failures are observed other than those pertaining to
> AssertWXAtThreadSync
We saw sporadic crashes in our jtreg (maybe also jck?) runs; only **_later_**
we enabled AssertWXAtThreadSync for more checking.
-
On Tue, 19 Mar 2024 09:30:52 GMT, Andrew Haley wrote:
> That's very odd. The example there doesn't even involve MAP_JIT memory, so
> what does it have to do with WX?
@theRealAph that is the mystery we hope will be resolved once we know the
nature of the underlying OS bug. Somehow switching to
On Tue, 19 Mar 2024 04:37:41 GMT, David Holmes wrote:
> That said we have had a lot of people looking at the overall WX state
> management logic in the past week or so due to
> https://bugs.openjdk.org/browse/JDK-8327860. The workaround there requires us
> to be in EXEC mode
That's very odd.
On Mon, 18 Mar 2024 13:14:41 GMT, Richard Reingruber wrote:
>> This pr changes `JfrJvmtiAgent::retransform_classes()` and
>> `jfr_set_enabled` to switch to `WXWrite` before transitioning to the vm.
>>
>> Testing:
>> make test TEST=jdk/jfr/event/runtime/TestClassLoadEvent.java
>>
> This pr changes `JfrJvmtiAgent::retransform_classes()` and `jfr_set_enabled`
> to switch to `WXWrite` before transitioning to the vm.
>
> Testing:
> make test TEST=jdk/jfr/event/runtime/TestClassLoadEvent.java
> TEST_VM_OPTS=-XX:+AssertWXAtThreadSync
> make test
16 matches
Mail list logo
