Re: [Spacewalk-devel] Reason why we should use dist-5E-sw-0.4

2008-11-26 Thread Jan Pazdziora
On Tue, Nov 25, 2008 at 09:02:54PM -0600, Dennis Gilmore wrote: I do not thing we are that far away from teh same goals. I just think that doing builds needs to be the deliberate action of an engineer. We can and should make make tag do the build also. The trouble is -- after you make

Re: [Spacewalk-devel] Reason why we should use dist-5E-sw-0.4

2008-11-26 Thread Miroslav Suchý
Jan Pazdziora wrote: I'd consider it a feature. The developer should tag the package when he/she feels it is reasonably stable to be built into -candidate. There is however nothing wrong with the developer pushing their work to the public repo (for others to see and work on), even if the thing

Re: [Spacewalk-devel] Reason why we should use dist-5E-sw-0.4

2008-11-26 Thread Jan Pazdziora
On Tue, Nov 25, 2008 at 11:56:36AM +0100, Miroslav Suchý wrote: Right now we build into tag dist-5E-sw-0.4-candidate. When I have been working on that nightly repo I find one good reason why we should use tag dist-5E-sw-0.4 and only successful builds tagged there from

Re: [Spacewalk-devel] Reason why we should use dist-5E-sw-0.4

2008-11-26 Thread Jan Pazdziora
On Wed, Nov 26, 2008 at 11:29:25AM +0100, Miroslav Suchý wrote: Are we still speaking about nightly builds? Now I only care about final release that way that I do not want to break process of final release. Ok. So make the question straight: Will I break something in your rel-eng realm, if

Re: [Spacewalk-devel] Reason why we should use dist-5E-sw-0.4

2008-11-26 Thread Miroslav Suchý
Dennis Gilmore wrote: I think we can assume if its not tagged that means that the work is not complete and not ready to be built or tested. I spoke about make tag-release, which make git tag. Do not mistake it for koji tag. 2) Create tag dist-5E-sw-0.4. Normally build into

Re: [Spacewalk-devel] Reason why we should use dist-5E-sw-0.4

2008-11-26 Thread Jan Pazdziora
On Tue, Nov 25, 2008 at 09:02:54PM -0600, Dennis Gilmore wrote: I honestly do not like how when you tag something it bumps the release. Well, the primary reason why we have the tag-release and tag-minor-release Makefile targets is to bump the version or release, and then tag that. Could you

Re: [Spacewalk-devel] Reason why we should use dist-5E-sw-0.4

2008-11-26 Thread Dennis Gilmore
On Wednesday 26 November 2008 04:29:25 am Miroslav Suchý wrote: Dennis Gilmore wrote: I think we can assume if its not tagged that means that the work is not complete and not ready to be built or tested. I spoke about make tag-release, which make git tag. Do not mistake it for koji tag.

Re: [Spacewalk-devel] Reason why we should use dist-5E-sw-0.4

2008-11-26 Thread Devan Goodwin
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Wed, 26 Nov 2008 14:23:15 +0100 Jan Pazdziora [EMAIL PROTECTED] wrote: To summarize: from my point of view building test-srpm (the .git.longsha1) packages to dist-5E-sw-0.4-candidate is counterinuitive. It has that longsha1 in its name for a

Re: [Spacewalk-devel] Reason why we should use dist-5E-sw-0.4

2008-11-26 Thread Jesus M. Rodriguez
On Wed, Nov 26, 2008 at 8:23 AM, Jan Pazdziora [EMAIL PROTECTED] wrote: On Wed, Nov 26, 2008 at 01:50:45PM +0100, Miroslav Suchý wrote: That is probably OK with small packages (like nocpulse-common), but it do not work with main packages (like java), which are usually rebuild only once just

Re: [Spacewalk-devel] Reason why we should use dist-5E-sw-0.4

2008-11-26 Thread Jesus M. Rodriguez
Just to chime in with my preference, I think I'd prefer to have it remain largely as we do today. - - Require manual package rebuilds. (assign people to keep a loose eye on certain packages if there's a genuine problem with no re-builds taking place) - - Keep the version going up for each

Re: [Spacewalk-devel] Reason why we should use dist-5E-sw-0.4

2008-11-26 Thread Miroslav Suchý
Jesus M. Rodriguez wrote: As far as auto building the rpm, I don't like that idea. I prefer that a developer build it manually. OK. I'm outvoted :) So we keep the nightly repos in current state, where it builds only package, which are git-tagged. Can I politely ask all you folks to do add

Re: [Spacewalk-devel] Reason why we should use dist-5E-sw-0.4

2008-11-26 Thread Dennis Gilmore
On Wednesday 26 November 2008 06:24:48 am Jan Pazdziora wrote: On Wed, Nov 26, 2008 at 11:29:25AM +0100, Miroslav Suchý wrote: Are we still speaking about nightly builds? Now I only care about final release that way that I do not want to break process of final release. Ok. So make the

[Spacewalk-devel] Reason why we should use dist-5E-sw-0.4

2008-11-25 Thread Miroslav Suchý
Right now we build into tag dist-5E-sw-0.4-candidate. When I have been working on that nightly repo I find one good reason why we should use tag dist-5E-sw-0.4 and only successful builds tagged there from dist-5E-sw-0.4-candidate. The reason are nightly builds. Now the package get into

Re: [Spacewalk-devel] Reason why we should use dist-5E-sw-0.4

2008-11-25 Thread Dennis Gilmore
On Tuesday 25 November 2008 04:56:36 am Miroslav Suchý wrote: Right now we build into tag dist-5E-sw-0.4-candidate. When I have been working on that nightly repo I find one good reason why we should use tag dist-5E-sw-0.4 and only successful builds tagged there from dist-5E-sw-0.4-candidate.