Re: [Spacewalk-devel] commit messages proposal

2009-04-01 Thread Cliff
Jesus Rodriguez wrote: Today we have two commit formats. If you are fixing a bug the format is: bznumber - msg If it is not a bug fix, it is just: msg This has been working out ok so far. But we're getting more descriptive in our commits which is good for looking back at history but

Re: [Spacewalk-devel] commit messages proposal

2009-03-31 Thread Devan Goodwin
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Mon, 30 Mar 2009 22:37:12 -0400 Jesus Rodriguez jes...@redhat.com wrote: Today we have two commit formats. If you are fixing a bug the format is: bznumber - msg If it is not a bug fix, it is just: msg This has been working out ok

Re: [Spacewalk-devel] commit messages proposal

2009-03-31 Thread James Bowes
On Tue, Mar 31, 2009 at 09:50:26AM +0200, Jan Pazdziora wrote: On Mon, Mar 30, 2009 at 10:37:12PM -0400, Jesus Rodriguez wrote: Thoughts? I suspect the lengths will cause folks to balk at this suggestion :) -1. I do not like restricting length of the first line of the commit message

Re: [Spacewalk-devel] commit messages proposal

2009-03-31 Thread Jason Dobies
[snip] The 50 characters was a suggestion :) I could live with a oneline summary then longer messages separated by a blank line. My biggest fear with the 50 character limit was 'fixed bug' type of commit messages. I like the summary and then extended detail separation... add in IDEs in

Re: [Spacewalk-devel] commit messages proposal

2009-03-31 Thread Justin Sherrill
Partha Aji wrote: Just an observation here.. I generally prefer using git ci-m message vs using an editor.. But if we have git commit format regulations I guess I'll have to use vi.. Would be nice though if I could stick to -m... I really like using '-m' as well, but you can do multi-line

[Spacewalk-devel] commit messages proposal

2009-03-30 Thread Jesus Rodriguez
Today we have two commit formats. If you are fixing a bug the format is: bznumber - msg If it is not a bug fix, it is just: msg This has been working out ok so far. But we're getting more descriptive in our commits which is good for looking back at history but sucks for changelogs and 'git

Re: [Spacewalk-devel] commit messages

2009-02-06 Thread Rob James
Looking at the commit logs recently a lot of the linked Bugzilla reports seem to have restricted access - is this just that they are coming from the Satellite QA or is it that they have customer info in? Where possible it would be nice for the community for bug reports to be open access. -R On

Re: [Spacewalk-devel] commit messages

2009-02-06 Thread Rob James
In the last 24 hours of commits at least these seem to be restricted: Justin Sherrill [Fri, 6 Feb 2009 16:31:49 +] 458943 - fixed issue where having 500 items on a page and clicking confirm would result in page not found Brad Buckingham [Fri, 6 Feb 2009 16:16:42 +] 483824 - fix apidoc

Re: [Spacewalk-devel] commit messages

2009-02-06 Thread Devan Goodwin
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Fri, 6 Feb 2009 16:53:29 + Rob James rssja...@googlemail.com wrote: In the last 24 hours of commits at least these seem to be restricted: Justin Sherrill [Fri, 6 Feb 2009 16:31:49 +] 458943 - fixed issue where having 500 items on a

[Spacewalk-devel] commit messages

2009-02-05 Thread Jesus Rodriguez
Folks have been doing pretty good with using the proper commit message format. I applaud you for that. But, yes there is a bug, can we try and use more descriptive commit messages? They don't have to be epic poems, but something other than: - a few more schema fixes - fixed bug etc. I