Re: [Spacewalk-devel] pgsql review

2009-05-22 Thread Devan Goodwin
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Thu, 21 May 2009 16:23:17 -0400 Jeff Ortel jor...@redhat.com wrote: All, The outcome of the meeting yesterday regarding the pgsql branch review is as follows: After lengthy discussion it was decided (almost unanimously by attendance) that

Re: [Spacewalk-devel] pgsql review

2009-05-22 Thread Jeff Ortel
Milan Zazrivec wrote: On Thursday 21 May 2009 22:23:17 Jeff Ortel wrote: All, The outcome of the meeting yesterday regarding the pgsql branch review is as follows: After lengthy discussion it was decided (almost unanimously by attendance) that the work on the pgsql branch would be merged to

Re: [Spacewalk-devel] pgsql review

2009-05-22 Thread Jeff Ortel
Devan Goodwin wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Thu, 21 May 2009 16:23:17 -0400 Jeff Ortel jor...@redhat.com wrote: All, The outcome of the meeting yesterday regarding the pgsql branch review is as follows: After lengthy discussion it was decided (almost unanimously

Re: [Spacewalk-devel] pgsql review

2009-05-22 Thread Jeff Ortel
Jan Pazdziora wrote: On Thu, May 21, 2009 at 04:23:17PM -0400, Jeff Ortel wrote: After lengthy discussion it was decided (almost unanimously by attendance) that the work on the pgsql branch would be merged to master without refactoring the commits. There I would appreciate anything you

Re: [Spacewalk-devel] pgsql review

2009-05-22 Thread Devan Goodwin
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Fri, 22 May 2009 13:09:44 -0400 Jeff Ortel jor...@redhat.com wrote: I fear our other test suites will require us to merge back so we can actually tag packages and have a sane way to deploy the postgresql modified code. (right now we just

Re: [Spacewalk-devel] pgsql review

2009-05-22 Thread Brad Buckingham
Devan Goodwin wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Fri, 22 May 2009 13:09:44 -0400 Jeff Ortel jor...@redhat.com wrote: I fear our other test suites will require us to merge back so we can actually tag packages and have a sane way to deploy the postgresql modified code.

Re: [Spacewalk-devel] pgsql review

2009-05-20 Thread Devan Goodwin
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Thu, 14 May 2009 13:11:19 +0200 Jan Pazdziora jpazdzi...@redhat.com wrote: On Tue, May 12, 2009 at 12:42:32PM -0400, Jeff Ortel wrote: All, I'd like to start getting some eyes on the pgsql branch in preparation of a merge to master. So

Re: [Spacewalk-devel] pgsql review

2009-05-15 Thread Jan Pazdziora
On Thu, May 14, 2009 at 11:24:33AM -0400, Jeff Ortel wrote: The views/rhnHistoryView.sql file seems to still contain definition of rhnHistoryView_pkglist function. Is that correct? Hmm... didn't expect to find function definitions in a view file so I didn't look. I agree this function

Re: [Spacewalk-devel] pgsql review

2009-05-15 Thread Michael Mraka
Jeff Ortel wrote: % Jan, I appreciate you comments :) % % Jan Pazdziora wrote: % On Thu, May 14, 2009 at 11:24:33AM -0400, Jeff Ortel wrote: % The views/rhnHistoryView.sql file seems to still contain definition of % rhnHistoryView_pkglist function. Is that correct? % Hmm... didn't expect to find

Re: [Spacewalk-devel] pgsql review

2009-05-15 Thread Jeff Ortel
Michael Mraka wrote: Jeff Ortel wrote: % Jan, I appreciate you comments :) % % Jan Pazdziora wrote: % On Thu, May 14, 2009 at 11:24:33AM -0400, Jeff Ortel wrote: % The views/rhnHistoryView.sql file seems to still contain definition of % rhnHistoryView_pkglist function. Is that correct? %

Re: [Spacewalk-devel] pgsql review

2009-05-14 Thread Jan Pazdziora
On Tue, May 12, 2009 at 12:42:32PM -0400, Jeff Ortel wrote: All, I'd like to start getting some eyes on the pgsql branch in preparation of a merge to master. So far, the changes on this branch have been focused on porting the schema and updating the application infrastructure to work

Re: [Spacewalk-devel] pgsql review

2009-05-14 Thread Jan Pazdziora
On Tue, May 12, 2009 at 12:42:32PM -0400, Jeff Ortel wrote: The goal here was to push as much of the schema into common as practical and make the schema code tree as developer friendly as possible. - The schema directory has been refactored replacing rhnsat/ with: oracle/

Re: [Spacewalk-devel] pgsql review

2009-05-14 Thread Jan Pazdziora
Another email, focusing on the tables/ directory. On Tue, May 12, 2009 at 12:42:32PM -0400, Jeff Ortel wrote: - Table files (rhnsat/tables/*) - table.sql files: - Most moved to common/tables/ - Trigger DDL split out and moved into existing or new oracle/triggers/table.sql -

Re: [Spacewalk-devel] pgsql review

2009-05-14 Thread Jan Pazdziora
On Tue, May 12, 2009 at 12:42:32PM -0400, Jeff Ortel wrote: - Upgrades (upgrade/* directories files): - Most files (git) moved to common/upgrade/upgrade - Few files forked: (git) moved to oracle/upgrade/upgrade. - Few files forked: copied to postgres/upgrade/upgrade and ported to PG.

Re: [Spacewalk-devel] pgsql review

2009-05-14 Thread Jan Pazdziora
On Tue, May 12, 2009 at 12:42:32PM -0400, Jeff Ortel wrote: MAKEFILES The Makefile.schema refactored into a /regular/ makefile. Dependency sorting and .sql file aggregation split out into a build tool named blend. Although, make does do dependency sorting with the .deps files, the

Re: [Spacewalk-devel] pgsql review

2009-05-14 Thread Jan Pazdziora
On Tue, May 12, 2009 at 12:42:32PM -0400, Jeff Ortel wrote: PACKAGING The spacewalk-schema.spec was updated to package and install install / upgrade scripts for both oracle and postgres. The files are installed in: /etc/sysconif/rhn/oracle/ main.sql spacewalk_0.4-spacewalk_0.5.sql

Re: [Spacewalk-devel] pgsql review

2009-05-14 Thread Jeff Ortel
Thanks for you comments! Jan Pazdziora wrote: On Tue, May 12, 2009 at 12:42:32PM -0400, Jeff Ortel wrote: All, I'd like to start getting some eyes on the pgsql branch in preparation of a merge to master. So far, the changes on this branch have been focused on porting the schema and

Re: [Spacewalk-devel] pgsql review

2009-05-14 Thread Jeff Ortel
Jan Pazdziora wrote: On Tue, May 12, 2009 at 12:42:32PM -0400, Jeff Ortel wrote: The goal here was to push as much of the schema into common as practical and make the schema code tree as developer friendly as possible. - The schema directory has been refactored replacing rhnsat/

Re: [Spacewalk-devel] pgsql review

2009-05-14 Thread Jeff Ortel
Jan Pazdziora wrote: Another email, focusing on the tables/ directory. On Tue, May 12, 2009 at 12:42:32PM -0400, Jeff Ortel wrote: - Table files (rhnsat/tables/*) - table.sql files: - Most moved to common/tables/ - Trigger DDL split out and moved into existing or new

Re: [Spacewalk-devel] pgsql review

2009-05-14 Thread Jeff Ortel
Jan Pazdziora wrote: On Tue, May 12, 2009 at 12:42:32PM -0400, Jeff Ortel wrote: - Upgrades (upgrade/* directories files): - Most files (git) moved to common/upgrade/upgrade - Few files forked: (git) moved to oracle/upgrade/upgrade. - Few files forked: copied to

Re: [Spacewalk-devel] pgsql review

2009-05-14 Thread Jason Dobies
Jan Pazdziora wrote: On Tue, May 12, 2009 at 12:42:32PM -0400, Jeff Ortel wrote: STYLE You may notice that the common/tables/*.sql were formatted using chameleon. Consistent with most DDL/SQL style guides, chameleon renders keywords in caps and uses spaces instead of tabs. If you don't like

Re: [Spacewalk-devel] pgsql review

2009-05-14 Thread Jeff Ortel
Jan Pazdziora wrote: On Tue, May 12, 2009 at 12:42:32PM -0400, Jeff Ortel wrote: At build, common (common/) files are transformed by a build tool named chameleon into DB specific files. For example: # # cd oracle # chameleon -s oracle -o tables/common/x.sql ../common/tables/x.sql # Long

Re: [Spacewalk-devel] pgsql review

2009-05-14 Thread Jeff Ortel
Jan Pazdziora wrote: On Tue, May 12, 2009 at 12:42:32PM -0400, Jeff Ortel wrote: MAKEFILES The Makefile.schema refactored into a /regular/ makefile. Dependency sorting and .sql file aggregation split out into a build tool named blend. Although, make does do dependency sorting with the

Re: [Spacewalk-devel] pgsql review

2009-05-14 Thread Jeff Ortel
Jan Pazdziora wrote: On Tue, May 12, 2009 at 12:42:32PM -0400, Jeff Ortel wrote: PACKAGING The spacewalk-schema.spec was updated to package and install install / upgrade scripts for both oracle and postgres. The files are installed in: /etc/sysconif/rhn/oracle/ main.sql

Re: [Spacewalk-devel] pgsql review

2009-05-14 Thread Jan Pazdziora
On Thu, May 14, 2009 at 03:18:25PM -0400, Jeff Ortel wrote: You cannot aggregate upgrade scripts because other products (like Satellite) might want to address individual upgrade scripts (via symlinks, or, work-in-progress, via references). There is a reason we kept the upgrade scripts

Re: [Spacewalk-devel] pgsql review

2009-05-14 Thread Jeff Ortel
Jan Pazdziora wrote: On Thu, May 14, 2009 at 03:18:25PM -0400, Jeff Ortel wrote: You cannot aggregate upgrade scripts because other products (like Satellite) might want to address individual upgrade scripts (via symlinks, or, work-in-progress, via references). There is a reason we kept the

Re: [Spacewalk-devel] pgsql review

2009-05-14 Thread Jeff Ortel
Jan Pazdziora wrote: On Thu, May 14, 2009 at 02:33:47PM -0400, Jeff Ortel wrote: Note: I don't really care about the actual format, so I'm not voting against the format per se (apart from the trailing spaces it seems to introduce). We can put together some coding guidelines and use them for

Re: [Spacewalk-devel] pgsql review

2009-05-13 Thread Devan Goodwin
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Tue, 12 May 2009 12:42:32 -0400 Jeff Ortel jor...@redhat.com wrote: All, I'd like to start getting some eyes on the pgsql branch in preparation of a merge to master. So far, the changes on this branch have been focused on porting the schema