Re: [Spacewalk-devel] [PATCH] Adding a password strength meter to spacewalk

2014-01-28 Thread Maximilian Meister
On 01/24/2014 12:29 PM, Matej Kollar wrote: Hi everybody, here you can find the new patch with the following changes: Hi Maximilian. I see you have made some nice work there but there are still few things that need to be fixed. * Warning pop-up. * Could it be moved to the right or

Re: [Spacewalk-devel] [PATCH] Adding a password strength meter to spacewalk

2014-01-28 Thread Matej Kollar
-- Matej Kollar Satellite Engineering, Red Hat - Original Message - From: Maximilian Meister mmeis...@suse.de To: spacewalk-devel@redhat.com Sent: Friday, January 24, 2014 2:33:46 PM Subject: Re: [Spacewalk-devel] [PATCH] Adding a password strength meter to spacewalk On 01/24

Re: [Spacewalk-devel] [PATCH] Adding a password strength meter to spacewalk

2014-01-28 Thread Matej Kollar
Subject: Re: [Spacewalk-devel] [PATCH] Adding a password strength meter to spacewalk On 01/24/2014 12:29 PM, Matej Kollar wrote: Hi everybody, here you can find the new patch with the following changes: Hi Maximilian. I see you have made some nice work there but there are still few

Re: [Spacewalk-devel] [PATCH] Adding a password strength meter to spacewalk

2014-01-24 Thread Matej Kollar
Meister mmeis...@suse.de To: spacewalk-devel@redhat.com Sent: Thursday, January 23, 2014 2:08:56 PM Subject: Re: [Spacewalk-devel] [PATCH] Adding a password strength meter to spacewalk On 01/23/2014 11:04 AM, Michael Mraka wrote: Hi Maximilian, that sounds great. % Question is now do

Re: [Spacewalk-devel] [PATCH] Adding a password strength meter to spacewalk

2014-01-24 Thread Maximilian Meister
On 01/24/2014 12:29 PM, Matej Kollar wrote: * Warning pop-up. * Could it be moved to the right or bottom of the filed? Yes. Though on the bottom it overlaps with the bar, and on the right it could end up being compressed, depending on the window size of your browser. I guess I could

Re: [Spacewalk-devel] [PATCH] Adding a password strength meter to spacewalk

2014-01-23 Thread Michael Mraka
Maximilian Meister wrote: % Is it possible to keep original pwstrength-bootstrap*.js unmodified and % put modification to the separate .js (call modified functions from the % page and call original functions from them)? % % Hi Michael, % % I end up with 2 separate .js files now. % First one is

Re: [Spacewalk-devel] [PATCH] Adding a password strength meter to spacewalk

2014-01-23 Thread Maximilian Meister
On 01/23/2014 11:04 AM, Michael Mraka wrote: Hi Maximilian, that sounds great. % Question is now do I need to package the second .js as well? Or can % i simply add it to the git tree % in web/html/javascript? If it's spacewalk specific (I think so) then just put it to web/html/javascript

Re: [Spacewalk-devel] [PATCH] Adding a password strength meter to spacewalk

2014-01-21 Thread Maximilian Meister
On 01/07/2014 12:04 PM, Michael Mraka wrote: Is it possible to keep original pwstrength-bootstrap*.js unmodified and put modification to the separate .js (call modified functions from the page and call original functions from them)? Hi Michael, I end up with 2 separate .js files now. First

Re: [Spacewalk-devel] [PATCH] Adding a password strength meter to spacewalk

2014-01-08 Thread Michael Mraka
Maximilian Meister wrote: % I see. Then it should keep the original name so we can easily figure out % where it came from and replace it with newer version in the future. % % Hi Michael, % % the original name would be pwstrength.js (in 0.5.0). We decided to % use the spacewalk- prefix to

Re: [Spacewalk-devel] [PATCH] Adding a password strength meter to spacewalk

2014-01-08 Thread Johannes Renner
On 01/08/2014 02:34 PM, Michael Mraka wrote: Maximilian Meister wrote: % I see. Then it should keep the original name so we can easily figure out % where it came from and replace it with newer version in the future. % % Hi Michael, % % the original name would be pwstrength.js (in 0.5.0).

Re: [Spacewalk-devel] [PATCH] Adding a password strength meter to spacewalk

2014-01-08 Thread Maximilian Meister
On 01/08/2014 02:34 PM, Michael Mraka wrote: As it's new feature in spacewalk I'd vote for using current latest version of pwstrength-bootstrap. Okay, I'll work out a new patch with the latest version in the following days. I understand it. In such cases where we need to modify upstream

Re: [Spacewalk-devel] [PATCH] Adding a password strength meter to spacewalk

2014-01-07 Thread Johannes Renner
On 12/20/2013 05:15 PM, R P Herrold wrote: On Fri, 20 Dec 2013, Maximilian Meister wrote: this patch would add a bootstrapified password strength meter to all pages where user details are being created or edited (create the initial admin user, create/edit normal users and create

Re: [Spacewalk-devel] [PATCH] Adding a password strength meter to spacewalk

2014-01-07 Thread Michael Mraka
Maximilian Meister wrote: % Hi everybody, % % this patch would add a bootstrapified password strength meter to all % pages where % user details are being created or edited (create the initial admin user, % create/edit normal users and create organization). % There is also a tick icon on the side

Re: [Spacewalk-devel] [PATCH] Adding a password strength meter to spacewalk

2014-01-07 Thread Michael Mraka
Johannes Renner wrote: % On 01/07/2014 10:54 AM, Michael Mraka wrote: % Maximilian Meister wrote: % % Hi everybody, % % ... % % Hello Maximilian, % % Is the spacewalk-pwstrength.js a copy of jquery.pwstrength.bootstrap % (i.e. third party stuff) or your own implementation of it? % %

Re: [Spacewalk-devel] [PATCH] Adding a password strength meter to spacewalk

2014-01-07 Thread Maximilian Meister
On 01/07/2014 12:04 PM, Michael Mraka wrote: I see. Then it should keep the original name so we can easily figure out where it came from and replace it with newer version in the future. Hi Michael, the original name would be pwstrength.js (in 0.5.0). We decided to use the spacewalk- prefix

Re: [Spacewalk-devel] [PATCH] Adding a password strength meter to spacewalk

2014-01-06 Thread Silvio Moioli
On 12/20/2013 05:15 PM, R P Herrold wrote: This seems to pull in new dependencies, doesn't it? This merely adds some new Javascript files - that is standard practice in Spacewalk AFAIU, since packaging rules for Web resources in Fedora are still in draft and the Spacewalk community has not