Re: [Spacewalk-devel] [PATCH] Kickstartable channels should contain the anaconda package

2013-04-05 Thread Jan Pazdziora
On Thu, Apr 04, 2013 at 05:44:09PM +0200, Johannes Renner wrote: Can you elaborate on the purpose of this change in general? The current code uses the Channel.kickstartableChannels query everywhere (via getKickstartableChannels). The patch seems to change the semantics for

Re: [Spacewalk-devel] [PATCH] Kickstartable channels should contain the anaconda package

2013-04-05 Thread Johannes Renner
On 04/05/2013 08:52 AM, Jan Pazdziora wrote: Hmm, I wonder if the current logic is actually correct. It feel that a kickstartable channel (for the purpose of creating kickstart profile, for example) would be channel that has at least one kickstartable tree, or channel cloned from one that has

Re: [Spacewalk-devel] [PATCH] Kickstartable channels should contain the anaconda package

2013-04-04 Thread Jan Pazdziora
On Thu, Apr 04, 2013 at 03:37:07PM +0200, Johannes Renner wrote: On 03/22/2013 02:55 PM, Michael Calmer wrote: Hi, please do not apply these patches. I found out, that it is not correct. It removes the channels at more places than needed. I guess the initial patch would be fine, as

Re: [Spacewalk-devel] [PATCH] Kickstartable channels should contain the anaconda package

2013-04-04 Thread Johannes Renner
On 04/04/2013 04:31 PM, Jan Pazdziora wrote: On Thu, Apr 04, 2013 at 03:37:07PM +0200, Johannes Renner wrote: On 03/22/2013 02:55 PM, Michael Calmer wrote: Hi, please do not apply these patches. I found out, that it is not correct. It removes the channels at more places than needed. I

Re: [Spacewalk-devel] [PATCH] Kickstartable channels should contain the anaconda package

2013-03-22 Thread Michael Calmer
Hi, please do not apply these patches. I found out, that it is not correct. It removes the channels at more places than needed. Am Mittwoch, 13. März 2013, 17:33:50 schrieb Johannes Renner: Hey, attached is a patch that should take care that only kickstartable channels are actually returned

Re: [Spacewalk-devel] [PATCH] Kickstartable channels should contain the anaconda package

2013-03-14 Thread Johannes Renner
On 03/13/2013 05:33 PM, Johannes Renner wrote: attached is a patch that should take care that only kickstartable channels are actually returned by the getKickstartableChannels() method in the ChannelFactory class. Argh, this fixes ConcurrentModificationException, sorry! -- SUSE LINUX