[Spacewalk-devel] Eclipse with Spacewalk Java code
Hi all. In case you tried to use Eclipse to edit Spacewalk Java stuff and followed these instructions [1], you might have failed. If so, you might want to give it another try, as Stephen took a look and fixed the problem (well, at least it works for me now ;-). Thanks Stephen! Matej [1] https://fedorahosted.org/spacewalk/wiki/EclipseSetup -- Matej Kollar Satellite Engineering, Red Hat ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
[Spacewalk-devel] [PATCH] SUSE Studio API will stop working via unencrypted HTTP
Hello, The SUSE Studio API will no longer process requests via unencrypted HTTP after Jan 2014, see here: http://blog.susestudio.com/2013/12/coming-soon-https-only-on-suse-studio.html Therefore attached is a patch to change the default endpoint to use SSL. Thank you, Johannes -- SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer From f523f1d0188c4094888513026478435db169ce3c Mon Sep 17 00:00:00 2001 From: Johannes Renner jren...@suse.de Date: Wed, 22 Jan 2014 10:41:08 +0100 Subject: [PATCH] SUSE Studio API will stop working via unencrypted HTTP --- .../com/redhat/rhn/frontend/action/user/UserCredentialsEditAction.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/java/code/src/com/redhat/rhn/frontend/action/user/UserCredentialsEditAction.java b/java/code/src/com/redhat/rhn/frontend/action/user/UserCredentialsEditAction.java index 66efc89..72395f3 100644 --- a/java/code/src/com/redhat/rhn/frontend/action/user/UserCredentialsEditAction.java +++ b/java/code/src/com/redhat/rhn/frontend/action/user/UserCredentialsEditAction.java @@ -40,7 +40,7 @@ public class UserCredentialsEditAction extends RhnAction { private static final String PARAM_USER = studio_user; private static final String PARAM_KEY = studio_key; private static final String PARAM_URL = studio_url; -private static final String DEFAULT_URL = http://susestudio.com;; +private static final String DEFAULT_URL = https://susestudio.com;; /** {@inheritDoc} */ @Override -- 1.8.4 ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] [PATCH] SUSE Studio API will stop working via unencrypted HTTP
On Wednesday 22 January 2014 12:18:02 Johannes Renner wrote: Hello, The SUSE Studio API will no longer process requests via unencrypted HTTP after Jan 2014, see here: http://blog.susestudio.com/2013/12/coming-soon-https-only-on-suse-studio.htm l Therefore attached is a patch to change the default endpoint to use SSL. Applied in 8373210db3c22057ac8d5f42eff886996734e122 Thank you -Milan Zázrivec ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] [PATCH] Single-system reboot page ported to Java
Thanks for your patchs, I have applied/pushed them to the master. -- Matej Kollar Satellite Engineering, Red Hat - Original Message - From: Silvio Moioli smoi...@suse.de To: spacewalk-devel@redhat.com Sent: Tuesday, January 21, 2014 6:19:49 PM Subject: Re: [Spacewalk-devel] [PATCH] Single-system reboot page ported to Java On 01/21/2014 01:26 PM, Matej Kollar wrote: * $Rev$ is legacy of our old versioning system (cvs) and has no use now that we use git (and we would not like to see it in new code). Just to have everyone informed: I used those tags because they were required by checkstyle_eclipse.xml. Matej will fix that configuration file, meanwhile I fixed the patch. By the way I also fixed my review-pending branches with these commits: e9ac621 - master-pxe-default-image-no-powermanagement 9e04ed5 - master-power-management-ssm * Preferred space indentation for `.jsp` files is 2 spaces. As discussed, since there is no current standard in Spacewalk and the Oracle code conventions for JSP is four spaces[1], we will stick with four. Of course we can revert the decision later if a decision is taken. * Use of `property=dispatch` for submit button isn't needed when the only thing you actually check is `isSubmitted(form)`. [...] Agreed, fixed. * Confirm button -- I would prefer Reboot system that was used on `.pxt` page.. Fixed. * Using sid: [...] one sid is enough. Okay! :-) Thanks for your review and thorough explanations. Regards [1] http://www.oracle.com/technetwork/articles/javase/code-convention-138726.html -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] [PATCH] Added extra log folder to spacewalk-debug
Flavio Castelli wrote: % Add extra log folder /var/log/rhn/tasko/sat/ in spacewalk-debug. Hi Flavio, patch commited into master as 8793925a10d2e482669c0e6104197737fad0cad8. Thanks. -- Michael Mráka Satellite Engineering, Red Hat ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] Action scheduling on ported pages
Bo Maryniuk wrote: % On Wed, Jan 08, 2014 at 01:12:06PM +0100, Michael Mraka wrote: % % Could be. But it doesn't answer my questions. I'm asking for timeframe % % because this is one of the blockers for Spacewalk 2.1 release and we % % have to decide whether wait for it or not. % % % % OK, that sounds reasonable. Then I will make some more patches that will % % synchronize the rest of the pages with the current Date picker. Then we will % % introduce the new Date picker (as a tag, so it will instantly replace % % everything). Fair enough? % % Yes, that will solve it. % % Michael, % what is the status here reviewing it, please? Hello Bo, I'm sorry it took me very long to review it. It looks good, just two notes: - SSM/Configuration/Enable: The message 'You may schedule rhncfg* package...' should stay above the date picker as it was originally. - The original text before the date picker ('You may schedule the package installations to take place as soon as possible, or no sooner than a specified time') suggests that the action might not take place immediately while with new wording 'Schedule at' users would expect the action is going to happen right after confirmation. I'd prefer something with similar meaning to the original. Regards, -- Michael Mráka Satellite Engineering, Red Hat ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] [PATCH]es ISE fix and UI unification, phase 1
Bo Maryniuk wrote: % Hi! % % While doing UI unification (attached here one more time again, since I didn't % see it went to the mailing list archives for some odd reasons), I also % accidentally step on the ISE, which happens if Cobbler is not installed (at % least properly). % % Here are those two patches, please review. :) Hello Bo, I've commited cobbler issue fix. As for UI unification I've already reviewed it and answered in the previous email. Thanks. Regards, -- Michael Mráka Satellite Engineering, Red Hat ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel