[Spacewalk-devel] [PATCH] UserManagerTest: don't rely on hardcoded default time zone

2013-09-09 Thread Silvio Moioli
UserManagerTest relied on a default America/New_York time zone, I removed the hardcoded string replacing it with UserFactory.getDefaultTimeZone(). See attached patch. Regards, -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany From

[Spacewalk-devel] [PATCH] ConfigureSatelliteCommandTest: do not rely on HashMap key ordering

2013-09-09 Thread Silvio Moioli
I noticed that ConfigureSatelliteCommandTest makes an assertion that depends on a HashMap key ordering, it was changed it to a SortedMap to guarantee repeatability. See attached patch. Regards, -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany From

[Spacewalk-devel] [PATCH] SystemManagerTest: missing super.setUp() call added

2013-09-09 Thread Silvio Moioli
See attached patch. Regards, -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany From 8377a9ba5f349a661f49a7f0ad9c393f7745f0fc Mon Sep 17 00:00:00 2001 From: Silvio Moioli smoi...@suse.de Date: Thu, 5 Sep 2013 09:11:37 +0200 Subject: [PATCH] SystemManagerTest:

[Spacewalk-devel] [PATCH] MonitoringManagerTest: missing super.setUp() call added

2013-09-09 Thread Silvio Moioli
See attached patch. Regards, -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany From 5865f906d561acb613addd31fa7e6b9e4e05e8af Mon Sep 17 00:00:00 2001 From: Silvio Moioli smoi...@suse.de Date: Wed, 4 Sep 2013 11:58:10 +0200 Subject: [PATCH] MonitoringManagerTest:

[Spacewalk-devel] [PATCH] UpdateErrataCacheCommand: log an error when orgId is incorrect

2013-09-09 Thread Silvio Moioli
See attached patch. Previously a NPE would be generated, but since the stack trace is not very useful as it can only go back until run(), it only polluted test outputs. I think that logging the error makes more sense in this case. Regards, -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße

[Spacewalk-devel] [PATCH] VirtualizationEntitlementsManagerTest fixes

2013-09-09 Thread Silvio Moioli
I attached two patches: 0001 - avoid failure if virtualization channels/packages are not present; 0002 - use Session.disconnect() instead of session.clear() after an expected ROLLBACK to properly resume Hibernate work in the test method, as clear() was not enough, at least in our environment,

Re: [Spacewalk-devel] [PATCH] VirtualizationEntitlementsManagerTest fixes

2013-09-09 Thread Silvio Moioli
On 09/09/2013 08:29 AM, Silvio Moioli wrote: I attached two patches: Patches updated to apply cleanly after Grant's commits. I apologize for the double post. Regards, -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany From

[Spacewalk-devel] Some Spacewalk packages orphaned

2013-09-09 Thread Miroslav Suchý
Hi, I orphaned following packages in Fedora (and EPEL): nocpulse-common perl-NOCpulse-CLAC perl-NOCpulse-Debug perl-NOCpulse-Gritch perl-NOCpulse-Object perl-NOCpulse-SetID perl-NOCpulse-Utils spacewalk-admin They transitively need new package, which is not yet in Fedora. And since I do not use

Re: [Spacewalk-devel] [PATCH] UpdateErrataCacheCommand: log an error when orgId is incorrect

2013-09-09 Thread Tomas Lestach
Hey Silvio, are you sure this change is necessary? The proposed change is in the UpdateErrataCacheCommand's updateErrataCache method. This method is called only from the UpdateErrataCacheAction's doExecute method. Couple of line above the updateErrataCache call we check whether orgId is null

Re: [Spacewalk-devel] [PATCH] UpdateErrataCacheCommand: log an error when orgId is incorrect

2013-09-09 Thread Silvio Moioli
On 09/09/2013 10:03 AM, Tomas Lestach wrote: So, what is the motivation of this change? (The only scenario I can imagine is, that the errata cache event will be queued and its organization gets deleted before the background errata cache action gets executed.) I think that is exactly the

Re: [Spacewalk-devel] [PATCH] UpdateErrataCacheCommand: log an error when orgId is incorrect

2013-09-09 Thread Grant Gainey
- Original Message - So, what is the motivation of this change? (The only scenario I can imagine is, that the errata cache event will be queued and its organization gets deleted before the background errata cache action gets executed.) Exactly so. Because of the way the tests run,

Re: [Spacewalk-devel] [PATCH] UpdateErrataCacheCommand: log an error when orgId is incorrect

2013-09-09 Thread Tomas Lestach
- Original Message - So, what is the motivation of this change? (The only scenario I can imagine is, that the errata cache event will be queued and its organization gets deleted before the background errata cache action gets executed.) Exactly so. Because of the way the

[Spacewalk-devel] Spacewalk/Satellite patching report

2013-09-09 Thread Innes, Duncan
Folks, I currently have a Satellite patching report that I cobbled together in Python. It gives me a breakdown of the outstanding Security Errata for each client. Downside to this is that it only tells me how many errata are *currently* outstanding. We clone the official RHEL channels into:

Re: [Spacewalk-devel] [PATCH] UserManagerTest: don't rely on hardcoded default time zone

2013-09-09 Thread Grant Gainey
- Original Message - UserManagerTest relied on a default America/New_York time zone, I removed the hardcoded string replacing it with UserFactory.getDefaultTimeZone(). See attached patch. commit 4cba00f46447a5808e20ddc299c88a4335c08d6d Thanks for contributing! Grant Regards,

Re: [Spacewalk-devel] [PATCH] ConfigureSatelliteCommandTest: do not rely on HashMap key ordering

2013-09-09 Thread Grant Gainey
- Original Message - I noticed that ConfigureSatelliteCommandTest makes an assertion that depends on a HashMap key ordering, it was changed it to a SortedMap to guarantee repeatability. See attached patch. commit 59aafcf1a04208e67ea6a664052087fe266de32b Thanks for contributing!

Re: [Spacewalk-devel] [PATCH] MonitoringManagerTest: missing super.setUp() call added

2013-09-09 Thread Grant Gainey
- Original Message - See attached patch. commit a549568dd1a0d12aad605c5610e8cb8a5015c886 Thanks for contributing! Grant Regards, -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany ___

Re: [Spacewalk-devel] [PATCH] VirtualizationEntitlementsManagerTest fixes

2013-09-09 Thread Grant Gainey
- Original Message - On 09/09/2013 08:29 AM, Silvio Moioli wrote: I attached two patches: Patches updated to apply cleanly after Grant's commits. I apologize for the double post. No problem - added as commit - 21199a55fda8ecd893947dbad90b5cbff6328585 Thanks for your