On Tue, May 3, 2011 at 2:34 AM, Naga Mohan Pothula
nagamohan.poth...@yahoo.com wrote:
Hi,
Audio is not working in 64-bit Windows7 Guest connected from any
Linux/Windows Client.
I noticed this problem with Spice v0.63/0.8 versions. I haven't tried on
other Spice versions.
When starting
On Tue, May 03, 2011 at 01:51:46AM +0200, Marc-André Lureau wrote:
Hi Alon,
After a couple of days getting a bit more familiar with the server
code, and reading each patches individually, I have made several
observations and commented some of the patches (see patch reply). I
still don't
On Tue, May 03, 2011 at 01:54:05AM +0200, Marc-André Lureau wrote:
On Tue, Apr 26, 2011 at 12:55 PM, Alon Levy al...@redhat.com wrote:
Required to support multiple clients.
Also changes somewhat the way we produce PIPE_ITEM_TYPE_LOCAL_CURSOR. Btw,
I haven't managed to see when we actually
On Tue, May 03, 2011 at 01:53:01AM +0200, Marc-André Lureau wrote:
- as a reminder, there is too many MainChannelClient typedef, and
build fails (you fixed it in your latest branch, thx).
- there is a few trailing lines added to b/server/red_channel.c
On Tue, Apr 26, 2011 at 12:54 PM, Alon
On Tue, May 03, 2011 at 01:52:52AM +0200, Marc-André Lureau wrote:
On Tue, Apr 26, 2011 at 12:54 PM, Alon Levy al...@redhat.com wrote:
TODO:
multiple todo's added for multiclient handling. I don't remember why
I wrote them exactly, and besides if I did any migration tests. So: TODO.
I
On Tue, May 03, 2011 at 01:52:38AM +0200, Marc-André Lureau wrote:
On Tue, Apr 26, 2011 at 12:54 PM, Alon Levy al...@redhat.com wrote:
Introduce functions to add (via producer method) the same item to multiple
pipes, all for the same channel.
Note: Right now there is only a single
Hey,
On Fri, Apr 29, 2011 at 10:46:43AM +0200, Kai Mosebach wrote:
I am running spicy under OSX. If I press the 'a' key, nothing happens
(within the guest). Can you please try if this is the same for you?
Marc-André spotted a commit fixing this very bug in gtk-vnc which I applied
to my local
On Tue, May 03, 2011 at 01:52:38AM +0200, Marc-André Lureau wrote:
The __ prefix is not necessary imho, however a static modifier would be
nice.
For what it's worth, names starting with __ are reserved for internal gcc
use:
http://www.gnu.org/s/hello/manual/libc/Reserved-Names.html
all
On Tue, May 03, 2011 at 01:53:40AM +0200, Marc-André Lureau wrote:
It looks like it is later reverted in the patch:
server/red_worker: split display and cursor channels
The current code style tends to reserve _proc for function type name
only. Should we try to keep it that way?
I don't
- Original Message -
From: Naga Mohan Pothula nagamohan.poth...@yahoo.com
To: spice-devel@lists.freedesktop.org
Sent: Monday, May 2, 2011 6:34:30 PM
Subject: [Spice-devel] Audio Fails in 64-bit Windows7 Guest
Hi,
Audio is not working in 64-bit Windows7 Guest connected from
On Mon, May 02, 2011 at 11:18:50AM +0200, Christophe Fergeau wrote:
On Wed, Apr 27, 2011 at 05:43:10PM +0200, Marc-André Lureau wrote:
It would be great to get an ACK first from someone building with
Windows before merging.
Ping? Anyone on the list who could test a build with these patches
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
---
modulesets/spice.xml |9 +
1 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/modulesets/spice.xml b/modulesets/spice.xml
index 9603438..a640afd 100644
--- a/modulesets/spice.xml
+++ b/modulesets/spice.xml
@@ -23,6 +23,8
On Wed, Apr 27, 2011 at 06:01:58PM +0200, Marc-André Lureau wrote:
Ack (with the corrections you mentioned)
And pushed.
Christophe
pgpObI4XYjjE0.pgp
Description: PGP signature
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
On Tue, May 03, 2011 at 03:48:25PM +0300, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
---
modulesets/spice.xml |9 +
1 files changed, 9 insertions(+), 0 deletions(-)
Pushed with the addition of autogenargs=--enable-spice
Christophe
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
---
configure.ac |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/configure.ac b/configure.ac
index 8144ef6..17ba8c5 100644
--- a/configure.ac
+++ b/configure.ac
@@ -135,12 +135,12 @@ AC_SUBST([SASL_LIBS])
Because we use c99: stdbool.h, inttypes.h, bool, variadic macros, // comments,
...
---
configure.ac |5 +
server/Makefile.am |1 -
2 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/configure.ac b/configure.ac
index 430bf83..9a303c9 100644
--- a/configure.ac
+++
This patch has not been verified with VS/brew. It should be safe
hopefully. Compilation is fine with mingw32/spice-gtk.
---
client/windows/platform.cpp |1 -
common/canvas_base.h|3 +++
common/canvas_utils.c |2 +-
common/canvas_utils.h |4
4 files
(this patch is not to solve a crash fix, but to align with glib API)
---
common/mem.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/common/mem.c b/common/mem.c
index 96be351..7236cf0 100644
--- a/common/mem.c
+++ b/common/mem.c
@@ -74,6 +74,10 @@ void
We don't support the autoconf ALLOCA/C_ALLOC fallback. If one day,
someone cares for a weird platform, he can fix it.
---
common/mem.h | 30 ++
configure.ac |1 +
2 files changed, 31 insertions(+), 0 deletions(-)
diff --git a/common/mem.h b/common/mem.h
index
Please notice it has a static modifier, like the rest of the inlined
functions in ring.h, so it won't warn if it isn't used.
---
common/ring.h | 13 +
1 files changed, 13 insertions(+), 0 deletions(-)
diff --git a/common/ring.h b/common/ring.h
index ff4ef6d..bd030d2 100644
---
Code adapter from RedPeer::ssl_verify_callback() and used by
spice-gtk.
Since v1:
- fixed Makefile.am
- added config.h include
- autoconf alloca added in patch series
- moved int escape inside for loop
- added a failed case when missing assignment
- replaced strlen () by -1
- skip spaces
---
client/application.cpp | 19 ++-
client/red_client.cpp |2 +-
client/red_peer.cpp| 375 +++-
client/red_peer.h | 23 +---
4 files changed, 35 insertions(+), 384 deletions(-)
diff --git a/client/application.cpp
CC test_playback.o
test_playback.c: In function ‘playback_timer_cb’:
test_playback.c:56:5: warning: implicit declaration of function ‘gettimeofday’
---
server/tests/test_playback.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/server/tests/test_playback.c
On Tue, May 03, 2011 at 04:37:38PM +0200, Marc-André Lureau wrote:
AC_PROG_CC
+AC_PROG_CC_C99
+if test x$ac_cv_prog_cc_c99 = xno; then
+AC_MSG_ERROR([C99 compiler is required.])
+fi
+AS_IF([test $CXXFLAGS = ], [], [_cxxflags_is_set=yes])
ACK with this line removed (it probably
On Tue, May 03, 2011 at 04:37:39PM +0200, Marc-André Lureau wrote:
This patch has not been verified with VS/brew. It should be safe
hopefully. Compilation is fine with mingw32/spice-gtk.
ACK from me, with the same reservation as before, I know nothing about
windows :)
Christophe
On Tue, May 03, 2011 at 04:37:40PM +0200, Marc-André Lureau wrote:
(this patch is not to solve a crash fix, but to align with glib API)
ACK
Christophe
pgpMdGzvzSw7k.pgp
Description: PGP signature
___
Spice-devel mailing list
On Tue, May 03, 2011 at 04:37:42PM +0200, Marc-André Lureau wrote:
Please notice it has a static modifier, like the rest of the inlined
functions in ring.h, so it won't warn if it isn't used.
ACK
pgp98GRTnfnj0.pgp
Description: PGP signature
___
On Tue, May 03, 2011 at 04:37:44PM +0200, Marc-André Lureau wrote:
CC test_playback.o
test_playback.c: In function ‘playback_timer_cb’:
test_playback.c:56:5: warning: implicit declaration of function ‘gettimeofday’
It's weird to have this patch sit between 6/8 and 8/8, could you move it
Fixed since v1:
- don't include C code, rather use the common lib
- add missing spice_openssl_verify_free() call
- keep the extra-parsing of subject for error reporting
---
client/application.cpp | 19 ++-
client/red_client.cpp |2 +-
client/red_peer.cpp| 377
applied (since f15/gtk3 is the new world order)
Ideally, we would have a default on auto (note: I am still running f14)
On Tue, May 3, 2011 at 3:21 PM, zee...@gmail.com wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
---
configure.ac | 4 ++--
1 files changed, 2 insertions(+),
On Thu, Apr 28, 2011 at 3:39 PM, Gerd Hoffmann kra...@redhat.com wrote:
This fails will fail to build with older spice-server versions. It should
be ifdef'ed using SPICE_SERVER_VERSION for the release which introduces
those functions.
We still don't have a release with SASL, so I don't know
On Tue, May 03, 2011 at 04:52:37PM +0200, Marc-André Lureau wrote:
@@ -2516,7 +2519,7 @@ void spice_log(unsigned int type, const char *function,
const char *format, ...)
Platform::get_thread_id(),
function_to_func_name(function).c_str(),
On Tue, May 3, 2011 at 5:12 PM, Christophe Fergeau cferg...@redhat.com wrote:
On Tue, May 03, 2011 at 04:52:37PM +0200, Marc-André Lureau wrote:
@@ -2516,7 +2519,7 @@ void spice_log(unsigned int type, const char
*function, const char *format, ...)
Platform::get_thread_id(),
On 05/03/11 17:12, Marc-André Lureau wrote:
On Thu, Apr 28, 2011 at 3:39 PM, Gerd Hoffmannkra...@redhat.com wrote:
This fails will fail to build with older spice-server versions. It should
be ifdef'ed using SPICE_SERVER_VERSION for the release which introduces
those functions.
We still
On Tue, May 03, 2011 at 11:48:59AM +0800, Shuxiang Lim wrote:
Hi,All!
Hi Shuxiang,
AFAIK you can't avoid non jpeg images because most (all?) rendering operations
still happen
on the client, so it can't or/xor/move with mask an 'almost' bitmap.
But the person who wrote this code should be
SASL functions will be released with 0.9.0
---
server/spice.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/server/spice.h b/server/spice.h
index d22425b..425d586 100644
--- a/server/spice.h
+++ b/server/spice.h
@@ -21,7 +21,7 @@
#include stdint.h
#include
wrong patch, just forget this mail.
On Tue, May 3, 2011 at 8:41 PM, Marc-André Lureau
marcandre.lur...@gmail.com wrote:
Turn on SASL support by appending sasl to the spice arguments, which
requires that the client use SASL to authenticate with the spice. The
exact choice of authentication
The current code doesn't reply correctly SPICE_LINK_ERR_ in case of failure.
It also doesn't respect the protocol properly (the error string is not defined)
This patch fixes that case, and has been tested with spice-gtk master.
---
server/reds.c | 24 ++--
1 files changed,
Turn on SASL support by appending sasl to the spice arguments, which
requires that the client use SASL to authenticate with the spice. The
exact choice of authentication method used is controlled from the
system / user's SASL configuration file for the 'qemu' service. This
is typically found in
I have not resolved these issues from below with MacPorts x11 or Xquartz. I am
still getting these errors in the /var/log/system.log file when trying to run
any x application.
But, I was able to work around these problems.
I used launchctl -w to disable macports x11 and xquartz entries. This
On Tue, May 03, 2011 at 03:34:07PM -0500, Cliff Sharp wrote:
I have not resolved these issues from below with MacPorts x11 or Xquartz.
I am still getting these errors in the /var/log/system.log file when
trying to run any x application.
But, I was able to work around these problems. I used
I agree totally.
What I am doing is using MacPorts to download all the software ports, that are
available for osx, to use to build spicec and spice-gtk successfully -
including xorg. BTW - there is only one package that is not in MacPorts in
order to build spice-gtk and that is celt051.
I
Ok,
I've found a simple way in gcc manual, just disable all optimization option
in gcc by -O0 will help this,but I'm not sure whether it's the final
solution.
Rgrds.
On Wed, May 4, 2011 at 10:33 AM, Shuxiang Lim shohyang...@gmail.com wrote:
Hi,Alon!
Thanks,but now I decide to abandon such
43 matches
Mail list logo
