[Spice-devel] [PATCH 21/30] Remove unused cairo helper functions

2010-02-18 Thread Alexander Larsson
--- common/cairo_canvas.c | 455 - common/canvas_base.c | 39 - 2 files changed, 0 insertions(+), 494 deletions(-) diff --git a/common/cairo_canvas.c b/common/cairo_canvas.c index 0335aeb..0b6f9ff 100644 --- a/common/cairo_canvas.c +++

Re: [Spice-devel] [PATCH 00/30] Convert cairo canvas to use pixman

2010-02-19 Thread Alexander Larsson
On Fri, 2010-02-19 at 10:25 +0200, Izik Eidus wrote: So I will take this weekened to agreesivly test it and compare it to the old code and read the code more carefuly again in the problomatic areas, and we can commit it after the weekend, how is this sound? Sounds great. Today I want to

Re: [Spice-devel] [PATCH 03/30] Add line rasterizer

2010-02-19 Thread Alexander Larsson
On Fri, 2010-02-19 at 10:43 +0200, Izik Eidus wrote: On Thu, 18 Feb 2010 21:58:29 +0100 Alexander Larsson al...@redhat.com wrote: This is based on the X11 line drawers in mi/mizerline.c etc --- client/Makefile.am |1 + client/lines.cpp | 24 + client/x11/Makefile.am

Re: [Spice-devel] [PATCH 16/30] Convert cairo canvas alpha_blend to using pixman

2010-02-19 Thread Alexander Larsson
On Fri, 2010-02-19 at 10:47 +0200, Izik Eidus wrote: On Thu, 18 Feb 2010 21:58:42 +0100 Alexander Larsson al...@redhat.com wrote: + +if (mask) +pixman_image_unref (mask); Any strong feelings against changing it to if (mask) { pixman_image_unref (mask); } Nah,

[Spice-devel] [PATCH 1/2] spice client: fix dns lookup

2010-02-19 Thread Gerd Hoffmann
ignore lookup results which are not ipv4 Signed-off-by: Gerd Hoffmann kra...@redhat.com --- client/red_peer.cpp |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/client/red_peer.cpp b/client/red_peer.cpp index bdbf1ff..f252ef2 100644 --- a/client/red_peer.cpp +++

[Spice-devel] [PATCH 2/2] spice client: add ipv6 support.

2010-02-19 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- client/red_peer.cpp | 89 +++--- 1 files changed, 41 insertions(+), 48 deletions(-) diff --git a/client/red_peer.cpp b/client/red_peer.cpp index f252ef2..a6afcc2 100644 --- a/client/red_peer.cpp +++

Re: [Spice-devel] [PATCH 16/30] Convert cairo canvas alpha_blend to using pixman

2010-02-19 Thread Izik Eidus
On Fri, 19 Feb 2010 10:15:14 +0100 Alexander Larsson al...@redhat.com wrote: On Fri, 2010-02-19 at 10:47 +0200, Izik Eidus wrote: On Thu, 18 Feb 2010 21:58:42 +0100 Alexander Larsson al...@redhat.com wrote: + +if (mask) +pixman_image_unref (mask); Any

Re: [Spice-devel] [PATCH 16/30] Convert cairo canvas alpha_blend to using pixman

2010-02-19 Thread Alexander Larsson
On Fri, 2010-02-19 at 17:04 +0200, Izik Eidus wrote: On Fri, 19 Feb 2010 10:15:14 +0100 Alexander Larsson al...@redhat.com wrote: On Fri, 2010-02-19 at 10:47 +0200, Izik Eidus wrote: On Thu, 18 Feb 2010 21:58:42 +0100 Alexander Larsson al...@redhat.com wrote: + +if

Re: [Spice-devel] [PATCH] spice-protocl: add SPICE_MSG_DISPLAY_SURFACE_CREATE/DESTROY

2010-02-19 Thread Izik Eidus
On Fri, 19 Feb 2010 16:35:46 +0100 Alexander Larsson al...@redhat.com wrote: \ is it really that bad to give stride as well? (I really have no strong feeling to drop it, so if you still want, i will drop it) Well, forcing the client to pick a particular stride might cause it to run

Re: [Spice-devel] [PATCH 00/30] Convert cairo canvas to use pixman

2010-02-19 Thread Alexander Larsson
On Thu, 2010-02-18 at 21:58 +0100, Alexander Larsson wrote: This series converts the software based canvas cairo_canvas to use pixman for rendering instead of cairo. It uses the upstream pixman (the latest version, 0.7.16 is needed) thus dropping the dependencies on qcairo and qpixman (and

[Spice-devel] [PATCH] spice server: surface create/destroy protocol support

2010-02-20 Thread Izik Eidus
From 3d5ce2e630a02f5edd8b22fe353433bb9a8321d8 Mon Sep 17 00:00:00 2001 From: Izik Eidus iei...@redhat.com Date: Thu, 18 Feb 2010 01:11:33 +0200 Subject: [PATCH] spice server: surface create/destroy protocol support Now we can send commands from the server to the client to destroy surfaces (right

Re: [Spice-devel] [PATCH 03/30] Add line rasterizer

2010-02-21 Thread Soeren Sandmann
Alexander Larsson al...@redhat.com writes: On Fri, 2010-02-19 at 10:43 +0200, Izik Eidus wrote: On Thu, 18 Feb 2010 21:58:29 +0100 Alexander Larsson al...@redhat.com wrote: This is based on the X11 line drawers in mi/mizerline.c etc --- client/Makefile.am |1 +

Re: [Spice-devel] [PATCH 11/30] Convert cairo canvas draw_opaque() to using pixman

2010-02-21 Thread Soeren Sandmann
Alexander Larsson al...@redhat.com writes: +static void scale_image (CairoCanvas *canvas, + pixman_region32_t *region, + SPICE_ADDRESS src_bitmap, + int src_x, int src_y, + int src_width, int

Re: [Spice-devel] [PATCH 14/30] Convert cairo canvas copy bits to pixman

2010-02-21 Thread Soeren Sandmann
Alexander Larsson al...@redhat.com writes: --- common/cairo_canvas.c | 254 - 1 files changed, 41 insertions(+), 213 deletions(-) diff --git a/common/cairo_canvas.c b/common/cairo_canvas.c index d0307d8..109a07c 100644 ---

Re: [Spice-devel] [PATCH 2/2] spice client: add ipv6 support.

2010-02-21 Thread Uri Lublin
On 02/19/2010 01:21 PM, Gerd Hoffmann wrote: Signed-off-by: Gerd Hoffmannkra...@redhat.com --- client/red_peer.cpp | 89 +++--- 1 files changed, 41 insertions(+), 48 deletions(-) diff --git a/client/red_peer.cpp b/client/red_peer.cpp index

Re: [Spice-devel] [PATCH 14/30] Convert cairo canvas copy bits to pixman

2010-02-22 Thread Alexander Larsson
On Sun, 2010-02-21 at 10:46 +0100, Soeren Sandmann wrote: Alexander Larsson al...@redhat.com writes: --- common/cairo_canvas.c | 254 - 1 files changed, 41 insertions(+), 213 deletions(-) diff --git a/common/cairo_canvas.c

Re: [Spice-devel] Project Information

2010-02-25 Thread Uri Lublin
On 02/24/2010 03:32 AM, Kris Lyttle wrote: Hello, I came across your website while researching systems that will remotely control a virtualized computer environment or virtual machine (VM) via the internet, i.e., controlling a VM as if it were a physical machine using VNC, VPN, etc., and it

[Spice-devel] Information on VT-D support for qemu-spice

2010-03-01 Thread Damien Bruley
Hi, I'm new to this mailing list, i've tested qemu-spice and i'm amaized of the overall performance. In fact, I would like to use that solution as Client Hypervisor and develop an administration console to easily deploy VM to end user devices. As Spice is based on KVM and QEMU I would like

Re: [Spice-devel] Information on VT-D support for qemu-spice

2010-03-01 Thread Izik Eidus
On 03/01/2010 06:35 PM, Damien Bruley wrote: Hi, I'm new to this mailing list, i've tested qemu-spice and i'm amaized of the overall performance. In fact, I would like to use that solution as Client Hypervisor and develop an administration console to easily deploy VM to end user devices.

Re: [Spice-devel] Compile error on vdesktop

2010-03-02 Thread Alexander Larsson
On Tue, 2010-03-02 at 03:44 +0200, Izik Eidus wrote: On 03/01/2010 07:11 PM, Cam Macdonell wrote: On Mon, Mar 1, 2010 at 9:29 AM, Izik Eidusiei...@redhat.com wrote: On 02/25/2010 08:53 PM, Cam Macdonell wrote: Hi, I'm trying to build vdesktop's git repo and I get the

[Spice-devel] An overview of Network redirection in Spice

2010-03-02 Thread Yonit Halperin
Hi, I’ve previously worked on the network redirection feature, which part of it is already in the upstream. Here, I present an overview of this feature and its status. Motivation -- In many scenarios, the network that the Spice client resides in is not accessible from the virtual machine.

Re: [Spice-devel] An overview of Network redirection in Spice

2010-03-02 Thread Yaniv Kaul
On 2010-03-02 16:29, Yonit Halperin wrote: Hi, I’ve previously worked on the network redirection feature, which part of it is already in the upstream. Here, I present an overview of this feature and its status. Motivation -- In many scenarios, the network that the Spice client resides

Re: [Spice-devel] An overview of Network redirection in Spice

2010-03-02 Thread Arnon Gilboa
Great overview! I finally understood what my neighbor was working on... Please wikify it add link@ http://cleo/qumrawiki/Spice Arnon Yonit Halperin wrote: Hi, I’ve previously worked on the network redirection feature, which part of it is already in the upstream. Here, I present an overview of

Re: [Spice-devel] [PATCH 2/2] spice client: add ipv6 support.

2010-03-03 Thread Alexander Larsson
On Thu, 2010-02-25 at 14:52 +0100, Gerd Hoffmann wrote: +ai.ai_flags = AI_CANONNAME | AI_ADDRCONFIG; This broke the windows xp build, because AI_ADDRCONFIG is only vista or newer. I pushed a fix:

[Spice-devel] QXL and /GB switch

2010-03-04 Thread David Martin
Any reason why booting XP with the /3GB switch would break the QXL driver with the following status This device cannot start. (Code 10)? David Martin ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org

[Spice-devel] [PATCH 2/8] Make glz_decoder non-optional canvas_base in canvas constructors

2010-03-08 Thread alexl
From: Alexander Larsson al...@redhat.com It can still be NULL, but we simplify the headers by always including it. There is no practical performance difference here. --- common/cairo_canvas.c |7 +-- common/cairo_canvas.h |2 -- common/canvas_base.c | 13 -

Re: [Spice-devel] SPICE questions

2010-03-11 Thread Stefan Zintgraf
Hi Izik, Find below all messages that are logged, the message qxl_exit_vga_mode is one of the last messages. Thanks Stefan ++ /home/rte/Proj/spice/vdesktop/qemu/qemu: /usr/lib/i686/cmov/libavutil.so.49: no version

[Spice-devel] bilinear fast path

2010-03-15 Thread Alexander Larsson
On Fri, 2010-03-12 at 16:18 +0100, Alexander Larsson wrote: I took this as a base and created a new branch that does fast scaling, achieving similar performance, and passing scaling-test. http://cgit.freedesktop.org/~alexl/pixman/log/?h=alex-scaler Based on this i also made a

[Spice-devel] Windows 7 64 bit support

2010-03-15 Thread Michal Purzynski
hey, i'm trying to install the latest drivers binary release (windows_binaries 0.4 downloaded from spice-space.org) in windows 7, 64 bit. it refuses to install them, since they aren't 64 bit. what can i do about that? compille the never ones from repo? i'd like to know if anyone got it working,

Re: [Spice-devel] QXL and /GB switch

2010-03-16 Thread David Martin
- Izik Eidus iei...@redhat.com wrote: On Tue, 16 Mar 2010 11:48:37 -0500 (CDT) David Martin da...@lsbase.com wrote: - Izik Eidus iei...@redhat.com wrote: On Thu, 4 Mar 2010 17:43:40 -0600 (CST) David Martin da...@lsbase.com wrote: Any reason why booting XP with the

[Spice-devel] Is SPICE working only with KVM /QEMU?

2010-03-23 Thread Irbis Irbis
I want to user SPICE with OpenVZ virtualization solution for setting up terminal server. Is SPICE working only with KVM/QEMU or I can install it on my host system or in my OpenVZ container? Thank you. ___ Spice-devel mailing list

Re: [Spice-devel] Adding a proper marshaller/demarshaller to spice

2010-03-23 Thread Yaniv Kaul
On 2010-03-23 17:58, Alexander Larsson wrote: I've been doing some research on adding a proper validating demarshaller to spice. What i mean by this is a piece of code that parses the bytes recieved from the network, validates that it is a proper spice message and then generates an internal

Re: [Spice-devel] spice client displays wrong in fullscreen on ubuntu 9.10(it has window title bar)

2010-03-25 Thread Coolper Chen
Thank you for replying, I'm sorry for describing my problem not clear. Here's my details about the problem: 1.I built spice client(from git) in ubuntu 9.10 64bit; 2.I ran ./spicec -h localhost -p 1 -f to connect a running spice server(the guest os is windows xp); 3.Spice displayed a window

Re: [Spice-devel] autoconf for slirp

2010-03-26 Thread Alexander Larsson
On Fri, 2010-03-26 at 10:25 +1000, Dave Airlie wrote: this is quick and dirty, and not completely tested yet, but it makes my life a little bit easier, since I don't install stuff in /usr ever. I took this, cleaned it up and made it pass distcheck and commited. However, whats the general deal

[Spice-devel] [PATCH] client: x11: fix a crash caused by a call to a destroyed window.

2010-04-01 Thread Yonit Halperin
Happens when a focused window is destroyed without a focus out event, and a focus-in event occurs on another window. --- client/x11/red_window.cpp | 12 +--- client/x11/red_window_p.h |2 +- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/client/x11/red_window.cpp

Re: [Spice-devel] spice client displays wrong in fullscreen on ubuntu 9.10(it has window title bar)

2010-04-01 Thread Coolper Chen
oh, yes, I am using compiz window manager. thanks a lot for your resolution. -Original Message- From: Liang Guo bluestonech...@gmail.com To: Coolper Chen lxc...@tnsoft.com.cn Cc: spice-devel@lists.freedesktop.org spice-devel@lists.freedesktop.org Subject: Re: [Spice-devel] spice client

Re: [Spice-devel] [PATCH] client: x11: fix a crash caused by a call to a destroyed window.

2010-04-02 Thread Izik Eidus
On Thu, 1 Apr 2010 12:11:44 +0300 Yonit Halperin yhalp...@redhat.com wrote: Happens when a focused window is destroyed without a focus out event, and a focus-in event occurs on another window. Hi Yonit, it look good... applied it... ___ Spice-devel

Re: [Spice-devel] [Spice-commits] 2 commits - server/reds.c server/red_worker.c

2010-04-07 Thread Izik Eidus
On Wed, 07 Apr 2010 16:52:38 +0300 Yonit Halperin yhalp...@redhat.com wrote: +static void red_clear_surface_glz_drawables(RedWorker *worker, int surface_id) +{ +RingItem *ring_item; + +if (!worker-display_channel) { +return; +} + +

[Spice-devel] spice for upstream qemu

2010-04-07 Thread Gerd Hoffmann
Hi, I'm busy fixing up the libspice-server API and preparing patches for upstream qemu. The bits start to become usable now, so I've prepared git trees for you to checkout. spice bits: http://cgit.freedesktop.org/~kraxel/spice/log/?h=api.v2 qemu bits:

Re: [Spice-devel] spice for upstream qemu

2010-04-09 Thread Alexander Larsson
On Wed, 2010-04-07 at 17:50 +0200, Gerd Hoffmann wrote: Hi, I'm busy fixing up the libspice-server API and preparing patches for upstream qemu. The bits start to become usable now, so I've prepared git trees for you to checkout. spice bits:

[Spice-devel] New win32 binary set

2010-04-12 Thread Alexander Larsson
We just added a new set of win32 dependency libraries for unstable spice at: http://spice-space.org/download.html This contains both the new dependencies (libjpeg and pixman 0.18.0), and removes the ones not needed anymore (ffmpeg) and some version updates (freetype). Furthermore all the

Re: [Spice-devel] libjpeg performance

2010-04-12 Thread Izik Eidus
On Mon, 12 Apr 2010 22:36:03 +0200 Alexander Larsson al...@redhat.com wrote: On Mon, 2010-04-12 at 20:57 +0200, Alexander Larsson wrote: I did some simple testing of the new mjpeg encoder. Showing the youtube will it blend - ipad video i got quite better compression (24k per frame average

[Spice-devel] [PATCH] DrvSetPointerShape: handle surface which is not bitmap

2010-04-13 Thread Yonit Halperin
--- display/res.c | 99 +++- display/rop.c |2 +- display/rop.h |3 ++ 3 files changed, 87 insertions(+), 17 deletions(-) diff --git a/display/res.c b/display/res.c index 318ea9c..2ea9565 100644 --- a/display/res.c +++ b/display/res.c

[Spice-devel] Spice relicensed to LGPL 2.1 or later

2010-04-13 Thread Alexander Larsson
I just commited a change of all header and copyright notices changing the license of spice to LGPL 2.1 or later. This includes the client program, because we want to convert much of that code into a library. We hope this will help make spice interesting to more people. --

Re: [Spice-devel] libjpeg performance

2010-04-14 Thread Alexander Larsson
On Wed, 2010-04-14 at 09:33 +0300, Uri Lublin wrote: On 04/12/2010 09:57 PM, Alexander Larsson wrote: I did some simple testing of the new mjpeg encoder. Showing the youtube will it blend - ipad video i got quite better compression (24k per frame average as opposed to 35k before), but the

[Spice-devel] [PATCH] make unstable qxl compatible with 0.4 qxl

2010-04-14 Thread Gerd Hoffmann
Add SET_MODE IO port back in. Add QXLRom offset fields back in. I/O ports, RAM and ROM layout are binary compatible now. With these changes merged it should be possible to create *one* qxl device which supports *both* 0.4 and unstable spice commands. Everything the guest touches before entering

[Spice-devel] Pixel format handling with offscreen surfaces

2010-04-14 Thread Alexander Larsson
With the new support for offscreen surfaces has an issue that we did not have before has come up. It shows up particularly when using 32bit depth surfaces as sources to the alpha_blend operation. The problem is whether to treat the source bitmap as if it has an alpha channel or not. Both formats

[Spice-devel] Multi-monitor / multi-session

2010-04-14 Thread Jaryd Malbin
Hey All, Is there any one out there that has attempted to get multiple SPICE sessions working in a multi-monitor setup? We have users that work in different platforms, and typically have up to four monitors with different sessions in each. I have only begun to play around with SPICE, and

Re: [Spice-devel] Multi-monitor / multi-session

2010-04-14 Thread Izik Eidus
On Wed, 14 Apr 2010 10:43:18 -0400 Jaryd Malbin jmal...@itpros.com wrote: Hey All, Is there any one out there that has attempted to get multiple SPICE sessions working in a multi-monitor setup? We have users that work in different platforms, and typically have up to four monitors with

Re: [Spice-devel] Pixel format handling with offscreen surfaces

2010-04-15 Thread Alexander Larsson
On Thu, 2010-04-15 at 02:12 +0300, Izik Eidus wrote: On Wed, 14 Apr 2010 16:12:21 +0200 Alexander Larsson al...@redhat.com wrote: enum { SPICE_SURFACE_FMT_INVALID, SPICE_SURFACE_FMT_1A, SPICE_SURFACE_FMT_8A, SPICE_SURFACE_FMT_16_555, SPICE_SURFACE_FMT_16_565,

[Spice-devel] [PATCH] spice server: fix typo in private key error message

2010-04-15 Thread Uri Lublin
From: Dan Kenigsberg dan...@redhat.com --- server/reds.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/server/reds.c b/server/reds.c index 7d7fd44..e6fc9c4 100644 --- a/server/reds.c +++ b/server/reds.c @@ -3230,7 +3230,7 @@ static void reds_init_ssl()

[Spice-devel] [PATCH v2] make unstable qxl compatible with 0.4 qxl

2010-04-16 Thread Gerd Hoffmann
Add SET_MODE IO port back in. Add QXLRom offset fields back in. I/O ports, RAM and ROM layout are binary compatible now. With these changes merged it should be possible to create *one* qxl device which supports *both* 0.4 and unstable spice commands. Everything the guest touches before entering

Re: [Spice-devel] SPICE

2010-04-21 Thread Arnon Gilboa
Hello Vijender, As you have already noticed, Spice is a really cool, high-performance intensively developing open project. We will be more than happy if you guys will join us in making Spice even better. I forward your message to our devel list, so you can discuss your participation with the

[Spice-devel] Spice in Fedora Rawhide?

2010-04-21 Thread Matthew Miller
Hi everyone. I've been following spice development casually, hopefully as a technology we can use for a big virtualization project in the next year or so. I notice that Spice is included in the RHEL 6 beta, which is very cool -- congratulations to everyone who worked on that. However, the state

Re: [Spice-devel] Spice in Fedora Rawhide?

2010-04-22 Thread Alexander Larsson
On Wed, 2010-04-21 at 12:00 -0400, Matthew Miller wrote: Hi everyone. I've been following spice development casually, hopefully as a technology we can use for a big virtualization project in the next year or so. I notice that Spice is included in the RHEL 6 beta, which is very cool --

Re: [Spice-devel] Spice in Fedora Rawhide?

2010-04-22 Thread Matthew Miller
On Thu, Apr 22, 2010 at 10:28:14AM +0200, Alexander Larsson wrote: We're currently working heavily on getting spice into fedora. We've now dropped all the problematic dependencies (ffmpeg, forked cairo, etc) so we're in a much better state for his. Good to hear -- thanks.

Re: [Spice-devel] Spice in Fedora Rawhide?

2010-04-22 Thread Gerd Hoffmann
Hi, Getting upstream qemu to have the patches sounds important regardless, but I'm unclear on the first part of what you say here. Wouldn't any libraries needed for spice by definition be used by an application? That application would be qemu ... This work is led by Gerd Hoffmann and can

Re: [Spice-devel] Spice in Fedora Rawhide?

2010-04-22 Thread Matthew Miller
On Thu, Apr 22, 2010 at 04:27:08PM +0200, Gerd Hoffmann wrote: I think it'd probably be productive to have the existing (or a new) yum repository for fedora ready to go. It could hold the patched qemu, plus RPMs of nightly snapshots of the source. Does that make sense? It's something I could

Re: [Spice-devel] kerberos for clients?

2010-04-22 Thread Yaniv Kaul
On 4/22/2010 4:07 PM, Matthew Miller wrote: Has anyone looked at making the spice clients use Kerberos/GSSAPI for authentication? Since F11, Fedora has had this for VNC: http://fedoraproject.org/wiki/Features/VirtVNCAuth and it'd be a shame to not have the equivalent in Spice. This seems very

Re: [Spice-devel] Ubuntu Spice Howto

2010-04-25 Thread Bryan Stillwell
On Fri, Apr 23, 2010 at 11:34:26PM -0400, Todd Deshane wrote: We've been testing out the initial release of Spice in our lab [1] and have found it to be quite impressive. We made a little howto [2] for Ubuntu, since much of the documentation and packages are Fedora-based. We just wanted to share

Re: [Spice-devel] Ubuntu Spice Howto

2010-04-25 Thread Todd Deshane
Hi Bryan, Thanks for testing! It's finals week here, so we'll test more here as we have time and get back to you with updates. I had forgotten about the Spice Wiki...It would make sense for us to move content there. We haven't started testing the Qemu upstream stuff yet. Last I knew, it was

[Spice-devel] [PATCH] fix two warnings

2010-04-26 Thread Gerd Hoffmann
--- client/x11/platform.cpp |2 +- common/canvas_base.c|2 ++ 2 files changed, 3 insertions(+), 1 deletions(-) diff --git a/client/x11/platform.cpp b/client/x11/platform.cpp index 498e6e5..550de19 100644 --- a/client/x11/platform.cpp +++ b/client/x11/platform.cpp @@ -260,7 +260,7 @@

Re: [Spice-devel] New win32 driver for master

2010-04-27 Thread Gerd Hoffmann
On 04/26/10 16:38, Alexander Larsson wrote: I just commited the patches from gerd for backwards compatibility with 0.4, and this in addition to the recent format changes break compatibility with the win32 driver, so i built a new driver, availible at:

[Spice-devel] [PATCH] server: fix invalid self loop in surfaces dependencies.

2010-04-28 Thread Yonit Halperin
Cyclic dependencies between surfaces mustn't occur. They can cause invalid rendering - recent drawables might be rendered before older ones. --- server/red_worker.c | 27 ++- 1 files changed, 22 insertions(+), 5 deletions(-) diff --git a/server/red_worker.c

[Spice-devel] C version of find_msb()

2010-05-01 Thread Bryan Stillwell
Recently I tried building the Ubuntu SPICE packages on powerpc and found that the spicec package fails on some x86 assembly code in common/gl_utils.h. This motivated me to create an optimized C version of the find_msb() function, which I've attached. This patch allows people to build the

[Spice-devel] libspice and save/restore/migration

2010-05-03 Thread Gerd Hoffmann
Hi, I want change the way save/restore works for the qxl device. 0.4 works this way: savevm qxl: call worker-save() worker: call interface-set_save_data(data, size) qxl: save data block. loadvm qxl: load data block. qxl: call worker-load() worker: call

Re: [Spice-devel] C version of find_msb()

2010-05-03 Thread Gerd Hoffmann
Hi, This patch allows people to build the spice-client on any 32bit/64bit architecture, but it doesn't solve the endianess problems in the SPICE protocol itself. Has anyone looked into the network byte-ordering issues? spice protocol (on the wire) is defined to be little endian. Alexander

[Spice-devel] CEGUI xml error

2010-05-03 Thread Attila Sukosd
Hi all, I have compiled the spice client from the git repo on Ubuntu 9.04, but when I try to launch it, nothing happens. It does create a CEGUI.log and it seems like it has a problem parsing the TaharezLook.scheme file which is I guess define in the taharez_look.scheme.c. I have even tried

Re: [Spice-devel] C version of find_msb()

2010-05-03 Thread Alexander Larsson
On Mon, 2010-05-03 at 11:30 +0200, Gerd Hoffmann wrote: Hi, This patch allows people to build the spice-client on any 32bit/64bit architecture, but it doesn't solve the endianess problems in the SPICE protocol itself. Has anyone looked into the network byte-ordering issues? spice

Re: [Spice-devel] C version of find_msb()

2010-05-03 Thread Alexander Larsson
On Sat, 2010-05-01 at 22:25 -0600, Bryan Stillwell wrote: Recently I tried building the Ubuntu SPICE packages on powerpc and found that the spicec package fails on some x86 assembly code in common/gl_utils.h. This motivated me to create an optimized C version of the find_msb() function, which

[Spice-devel] Banner

2010-05-03 Thread Robert Rebstock
Hello all, can someone please tell me how to disable the Red Hat Enterprise Virtualization | SPICE banner. Many thanks in advance, RR PS. Please mail me directly, as I am not subscribed to this list. ___ Spice-devel mailing list

Re: [Spice-devel] libspice and save/restore/migration

2010-05-03 Thread Alexander Larsson
Plan for unstable: (1) Keep surface metadata in device memory, i.e. delay the release of QXL_SURFACE_CMD_CREATE command until the surface is destroyed. (2) Keep the most recent QXL_CURSOR_SET command in device memory, i.e. delay the release until the next one comes in. (3)

Re: [Spice-devel] Banner

2010-05-03 Thread Izik Eidus
On Sun, 2 May 2010 13:35:22 + (UTC) Robert Rebstock rebst...@scienceworks.com wrote: Hello all, can someone please tell me how to disable the Red Hat Enterprise Virtualization | SPICE banner. Currently no way to do so. But support for such thing can be easily added, I will look on

Re: [Spice-devel] CEGUI xml error

2010-05-04 Thread Attila Sukosd
Hi again, On Mon, May 3, 2010 at 1:24 PM, Attila Sukosd attila.suk...@gmail.com wrote: Hi all, I have compiled the spice client from the git repo on Ubuntu 9.04, but when I try to launch it, nothing happens. It does create a CEGUI.log and it seems  like it has a problem parsing the

[Spice-devel] Build Windows Client from git Repo

2010-05-10 Thread bwellsnc
Hi, I have installed the experimental spice repo from http://kraxel.fedorapeople.org/spice/. I was wondering if there is a howto to build the windows client or is there a windows client for this version. I am getting version mismatch when I try to connect to my spice instance using the 0.4.0

[Spice-devel] [PATCH 03/35] zap CoreInterface-next()

2010-05-12 Thread Gerd Hoffmann
Interfaces must be registered after spice_server_init(). The next callback is used to discover interfaces registered before spice_server_init(). Which is a empty list and thus pretty pointless. Remove it. --- server/reds.c |7 --- server/vd_interface.h |2 -- 2 files

[Spice-devel] [PATCH 02/35] channel security cleanup

2010-05-12 Thread Gerd Hoffmann
- drop spice_channel_name_t enum, use spice-protocol defines instead. - switch spice_server_set_channel_security() channel parameter from enum to string. - drop spice_server_set_default_channel_security(), use spice_server_set_channel_security with channel == NULL instead. --- server/reds.c

[Spice-devel] [PATCH 09/35] new watch api: switch listening sockets

2010-05-12 Thread Gerd Hoffmann
--- server/reds.c | 34 -- 1 files changed, 20 insertions(+), 14 deletions(-) diff --git a/server/reds.c b/server/reds.c index d7a8132..89f828d 100644 --- a/server/reds.c +++ b/server/reds.c @@ -245,6 +245,8 @@ typedef struct RedsStatValue { typedef struct

[Spice-devel] [PATCH 06/35] zap CoreInterface-{term_printf,log}

2010-05-12 Thread Gerd Hoffmann
Was used to print stuff to the qemu monitor. Fundamentally incompatible with QMP. Remove. --- server/reds.c | 48 +--- server/vd_interface.h |4 2 files changed, 5 insertions(+), 47 deletions(-) diff --git a/server/reds.c

[Spice-devel] [PATCH 07/35] fix visibility

2010-05-12 Thread Gerd Hoffmann
--- server/reds.c | 50 ++ server/reds.h |2 ++ 2 files changed, 28 insertions(+), 24 deletions(-) diff --git a/server/reds.c b/server/reds.c index 74da545..d7a8132 100644 --- a/server/reds.c +++ b/server/reds.c @@ -4305,14 +4305,14 @@ static

[Spice-devel] [PATCH 14/35] new watch api: switch migration

2010-05-12 Thread Gerd Hoffmann
--- server/reds.c | 59 + 1 files changed, 30 insertions(+), 29 deletions(-) diff --git a/server/reds.c b/server/reds.c index d995f78..095e644 100644 --- a/server/reds.c +++ b/server/reds.c @@ -3246,6 +3246,7 @@ typedef struct

[Spice-devel] [PATCH 13/35] new watch api: switch inputs

2010-05-12 Thread Gerd Hoffmann
--- server/reds.c | 50 +- 1 files changed, 25 insertions(+), 25 deletions(-) diff --git a/server/reds.c b/server/reds.c index 138d0f4..d995f78 100644 --- a/server/reds.c +++ b/server/reds.c @@ -2277,31 +2277,31 @@ static void

[Spice-devel] [PATCH 19/35] shlib major

2010-05-12 Thread Gerd Hoffmann
--- configure.ac |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/configure.ac b/configure.ac index 94cd65f..0958b6d 100644 --- a/configure.ac +++ b/configure.ac @@ -26,7 +26,7 @@ AC_PROG_LIBTOOL AM_PROG_CC_C_O AC_C_BIGENDIAN -SPICE_LT_VERSION=m4_format(%d:%d:%d,

[Spice-devel] [PATCH 21/35] s/CoreInterface/SpiceCoreInterface/

2010-05-12 Thread Gerd Hoffmann
--- server/red_channel.c |3 ++- server/red_channel.h |5 +++-- server/red_tunnel_worker.c |5 +++-- server/red_tunnel_worker.h |2 +- server/reds.c | 14 -- server/reds.h |2 +- server/spice.h |5 +

[Spice-devel] [PATCH 22/35] KeyboardInterface: redesign.

2010-05-12 Thread Gerd Hoffmann
This is the direction I wanna take with all interfaces: Clearly separate interface (aka version information and function pointers) and state information. SpiceKbdInterface defines the interface, SpiceKbdInstance maintains per-instance state information. Keyboard hasn't much beside a pointer to

[Spice-devel] [PATCH 18/35] minor timer interface cleanups.

2010-05-12 Thread Gerd Hoffmann
Make the timer interface largely look like the watch interface. Simliar naming convention for the functions (timer_*) and a opaque SpiceTimer type. --- server/red_tunnel_worker.c |5 ++--- server/reds.c | 40 server/vd_interface.h |

[Spice-devel] [PATCH 33/35] [debug] migration troubleshooting

2010-05-12 Thread Gerd Hoffmann
--- client/application.cpp |2 +- server/reds.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/client/application.cpp b/client/application.cpp index 4eb8ac8..74f5543 100644 --- a/client/application.cpp +++ b/client/application.cpp @@ -2110,7 +2110,7 @@ void

[Spice-devel] [PATCH 25/35] TabletInterface: redesign

2010-05-12 Thread Gerd Hoffmann
--- server/reds.c | 41 ++--- server/reds.h |4 server/vd_interface.h | 27 +-- 3 files changed, 47 insertions(+), 25 deletions(-) diff --git a/server/reds.c b/server/reds.c index 62a2cab..24b1507 100644 ---

[Spice-devel] [PATCH 20/35] VDInterface: redesign.

2010-05-12 Thread Gerd Hoffmann
VDInterface has been renamed to SpiceBaseInterface. Dropped base_version element, shlib versioning should be used instead. Dropped id element, it is passed to spice_server_add_interface() instead. Now SpiceBaseInterface has static information only, multiple interface instances can share it.

[Spice-devel] [PATCH 24/35] QXL: redesign.

2010-05-12 Thread Gerd Hoffmann
--- server/red_dispatcher.c | 36 ++-- server/red_dispatcher.h |2 +- server/red_worker.c | 38 +++--- server/red_worker.h |2 +- server/reds.c | 20 +++- server/reds.h |5

[Spice-devel] [PATCH 26/35] SoundInterfaces: redesign

2010-05-12 Thread Gerd Hoffmann
--- server/reds.c | 30 +- server/snd_worker.c | 160 server/snd_worker.h |8 +- server/vd_interface.h | 84 +- 4 files changed, 141 insertions(+), 141 deletions(-) diff --git a/server/reds.c

[Spice-devel] [PATCH 31/35] replace worker load/save with loadvm_commands, allow keeping surface content

2010-05-12 Thread Gerd Hoffmann
Add worker-loadvm_commands. qemu will uses this to send a series of commands needed to restore state after savevm/loadvm and migration. That will be one create-surface command per surface and one cursor-set command for the local pointer. The worker-save/load functions are not needed any more.

[Spice-devel] [PATCH 11/35] new watch api: switch main channel

2010-05-12 Thread Gerd Hoffmann
--- server/reds.c | 40 +--- 1 files changed, 21 insertions(+), 19 deletions(-) diff --git a/server/reds.c b/server/reds.c index 959e4dd..73d53f3 100644 --- a/server/reds.c +++ b/server/reds.c @@ -364,7 +364,6 @@ typedef struct PingItem { static uint8_t

[Spice-devel] [PATCH 35/35] zap MigrationInterface

2010-05-12 Thread Gerd Hoffmann
Remove remaining MigrationInterface bits. --- server/reds.c | 16 server/vd_interface.h | 11 --- 2 files changed, 0 insertions(+), 27 deletions(-) diff --git a/server/reds.c b/server/reds.c index 6275cf0..a09cb0d 100644 --- a/server/reds.c +++

[Spice-devel] [PATCH 05/35] zap qterm interfaces

2010-05-12 Thread Gerd Hoffmann
old way to handle monitor, obsolete. --- server/reds.c | 688 - server/vd_interface.h | 50 2 files changed, 0 insertions(+), 738 deletions(-) diff --git a/server/reds.c b/server/reds.c index dd8034c..a9767ad 100644 ---

[Spice-devel] [PATCH 32/35] zap migration code

2010-05-12 Thread Gerd Hoffmann
Drop all code which depends on accessing the migration file handle. --- server/reds.c | 642 + server/vd_interface.h |7 +- 2 files changed, 11 insertions(+), 638 deletions(-) diff --git a/server/reds.c b/server/reds.c index

Re: [Spice-devel] [PATCH 20/35] VDInterface: redesign.

2010-05-17 Thread Alexander Larsson
On Wed, 2010-05-12 at 13:32 +0200, Gerd Hoffmann wrote: +} else if (strcmp(interface-type, VD_INTERFACE_NET_WIRE) == 0) { #ifdef HAVE_SLIRP -NetWireInterface * net_wire = (NetWireInterface *)interface; -red_printf(VD_INTERFACE_NET_WIRE); -if

Re: [Spice-devel] [PATCH 28/35] vdi port: redesign.

2010-05-17 Thread Alexander Larsson
On Wed, 2010-05-12 at 13:32 +0200, Gerd Hoffmann wrote: -while (reds-agent_state.plug_ref != INVALID_VD_OBJECT_REF) { +sif = SPICE_CONTAINEROF(vdagent-base.sif, SpiceVDIPortInterface, base); +for (;;) { Changing a while to for(;;;) doesn't seem right. We can still hit:

Re: [Spice-devel] [PATCH 28/35] vdi port: redesign.

2010-05-17 Thread Alon Levy
Hi, As long as we are changing the way SpiceVDIPortPlug (plug) works, we should have the read callback direction reversed: struct SpiceVDIPortInterface { +int (*have_data)(SpiceVDIPortInstance *sin, uint8_t *buf, int len); -int (*read)(SpiceVDIPortInstance *sin, uint8_t *buf, int len);

Re: [Spice-devel] [PATCH 31/35] replace worker load/save with loadvm_commands, allow keeping surface content

2010-05-17 Thread Alexander Larsson
On Wed, 2010-05-12 at 13:32 +0200, Gerd Hoffmann wrote: -static void qxl_worker_stop(QXLWorker *qxl_worker) -{ -RedDispatcher *dispatcher = (RedDispatcher *)qxl_worker; -RedWorkeMessage message = RED_WORKER_MESSAGE_STOP; +RedWorkeMessage message =

  1   2   3   4   5   6   7   8   9   10   >