---
vdagent/vdagent.cpp | 23 +++
1 files changed, 11 insertions(+), 12 deletions(-)
diff --git a/vdagent/vdagent.cpp b/vdagent/vdagent.cpp
index 307b7da..af99961 100644
--- a/vdagent/vdagent.cpp
+++ b/vdagent/vdagent.cpp
@@ -1206,48 +1206,47 @@ bool
rhbz#872252
---
vdagent/vdagent.cpp |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/vdagent/vdagent.cpp b/vdagent/vdagent.cpp
index a061973..307b7da 100644
--- a/vdagent/vdagent.cpp
+++ b/vdagent/vdagent.cpp
@@ -796,6 +796,7 @@ bool
rhbz #951618
---
vdagent/vdagent.cpp | 13 ++---
1 files changed, 10 insertions(+), 3 deletions(-)
diff --git a/vdagent/vdagent.cpp b/vdagent/vdagent.cpp
index 1fad0e6..3c0f829 100644
--- a/vdagent/vdagent.cpp
+++ b/vdagent/vdagent.cpp
@@ -979,9 +979,12 @@ void
vdagent is stopped, so a new instance is to be launched by vdservice.
imho, this seems simpler than cleaning agent in/out msg state and
reseting the vio-serial device to cleanup pending msgs.
rhbz #956133
---
vdagent/vdagent.cpp |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff
rhbz #953973
---
vdagent/vdagent.cpp |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/vdagent/vdagent.cpp b/vdagent/vdagent.cpp
index dde967c..118cafd 100644
--- a/vdagent/vdagent.cpp
+++ b/vdagent/vdagent.cpp
@@ -622,6 +622,11 @@ bool
When enabling a disabled monitor, init_dev_mod() failed to create DC,
and therefore due to the custom resolution received, in set_displays()
No suitable mode found for display.
Enabling with standard resoultion (800*600) solves the issue.
rhbz #910634
---
vdagent/vdagent.cpp |5 +
1
for the case path contains a space, see CreateService() doc:
http://msdn.microsoft.com/en-us/library/windows/desktop/ms682450.aspx
rhbz #918635
---
vdservice/vdservice.cpp |8 ++--
1 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/vdservice/vdservice.cpp
for decoding, keep using CF_DIB and CxImage.CopyToHandle() as before.
Regression was due to commit da07ce (rhbz #919150)
rhbz #921980
---
vdagent/vdagent.cpp |6 +-
1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/vdagent/vdagent.cpp b/vdagent/vdagent.cpp
index
rhbz #919451 preparation
---
common/vdcommon.cpp| 36
common/vdcommon.h |8
vdservice/vdservice.cpp| 24
vdservice/vdservice.vcproj |4
4 files changed, 48 insertions(+), 24 deletions(-)
rhbz #919451 debugging, useful anyway
---
vdagent/vdagent.cpp | 11 ---
1 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/vdagent/vdagent.cpp b/vdagent/vdagent.cpp
index b5d65cd..e20c830 100644
--- a/vdagent/vdagent.cpp
+++ b/vdagent/vdagent.cpp
@@ -914,13 +914,16 @@ bool
so vdagent can keep running as standalone without dependency on vdservice.
Regression was due to commit c1807e.
rhbz #903379
---
vdagent/vdagent.cpp | 22 +-
1 files changed, 9 insertions(+), 13 deletions(-)
diff --git a/vdagent/vdagent.cpp b/vdagent/vdagent.cpp
index
Running the helper with ShellExecute(...runas...) is the way to SendInput()
to the UAC dialog in Windows Vista and above.
http://stackoverflow.com/questions/2426594/starting-a-uac-elevated-process-
from-a-non-interactive-service-win32-net-power
(Win7 class includes Win8/Vista/Server2012/Server2008/R2)
This new api was introduced in Vista/2K8 to keep track of clipboard changes,
without the need to trust the (mis)behavior of other applications registered
to the clipboard.
If the issue is reproduced on XP as well, it can be hacked by a
CxImage DIB to PNG encoding seems to ignore pallete in some scenarios.
This issue happens when copying a png from FireFox, but with IE it's ok.
rhbz #919150
---
vdagent/vdagent.cpp | 11 ---
1 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/vdagent/vdagent.cpp
vdagent terminates when the global event is set by vdservice. vdservice is also
responsible to reset the event in any case, without trusting vdagent to do so.
Otherwise, it may terminate the following vdagent instance immediately as well.
Regression was due to commit 2d03cc.
rhbz #868254
---
Terminate agent politely instead of ugly TerminateProcess(), so now
VD_AGENT_CLIPBOARD_RELEASE is sent (if guest owned the clipboard),
followed by cleanup.
rhbz #903379
---
common/vdcommon.h |1 +
vdagent/vdagent.cpp | 16 +++-
vdservice/vdservice.cpp |5 -
3
which vdagent version are you using? which windows version?
please send %windir%\temp\vdagemt.log vdservice.log.
I guess it's something to do with the different sessions used by spice
rdp.
flooding Controlled wrote:
I do not know how you can use spice and RDP together, can you explain your
---
Makefile.am |6 --
1 files changed, 0 insertions(+), 6 deletions(-)
diff --git a/Makefile.am b/Makefile.am
index 9b73def..3bd66aa 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -31,13 +31,7 @@ vdagent_SOURCES =\
vdagent/desktop_layout.h\
Han Pilmeyer wrote:
Thanks for your efforts Arnon,
On 02/12/2012 08:23, Arnon Gilboa wrote:
Lots of virtio-serial driver bugs, which are very relevant to
cut/paste, were recently fixed.
The driver on the above link seem to be outdated. I'll try to find a
link for an updated upstream version
::Failed
opening \\.\Global\com.redhat.spice.0, error 2
2332::INFO::2012-11-29 17:35:51,830::VDAgent::run::***Agent started in
session 1***
On 29/11/2012 17:27, Arnon Gilboa wrote:
Han Pilmeyer wrote:
Arnon,
Just a quick question before I do something stupid. I just tried
placing the exe's
Han Pilmeyer wrote:
On 29/11/2012 13:58, Christophe Fergeau wrote:
On Thu, Nov 29, 2012 at 12:56:49PM +0200, Arnon Gilboa wrote:
Han Pilmeyer wrote:
However both yesterday and today, the guest refuses to do
cut/paste between the guest and host. Below I have the relevant
portion
Han Pilmeyer wrote:
Hi,
This last Tuesday I had a full day when cut/paste between my Windows 7
guest and Fedora 17 KVM host worked flawlessly. So I had high hopes
that the spice-guest-0.2.exe drivers had indeed fixed my issues.
However both yesterday and today, the guest refuses to do
seems ok, feel free to review ;)
Arnon Gilboa wrote:
NACK, seems it needs some more testing
Arnon Gilboa wrote:
---
vdagent/vdagent.cpp | 239
+++
1 files changed, 109 insertions(+), 130 deletions(-)
diff --git a/vdagent/vdagent.cpp b/vdagent
Currently, a SetClipboardData failure is followed by useless wait for timeout
(VD_CLIPBOARD_TIMEOUT_MS)
---
vdagent/vdagent.cpp | 30 --
1 files changed, 16 insertions(+), 14 deletions(-)
diff --git a/vdagent/vdagent.cpp b/vdagent/vdagent.cpp
index 3f1053d..2bb466d
---
vdagent/vdagent.cpp | 239 +++
1 files changed, 109 insertions(+), 130 deletions(-)
diff --git a/vdagent/vdagent.cpp b/vdagent/vdagent.cpp
index 2bb466d..85244c0 100644
--- a/vdagent/vdagent.cpp
+++ b/vdagent/vdagent.cpp
@@ -16,8 +16,6 @@
*/
---
vdagent/vdagent.vcproj | 24
1 files changed, 0 insertions(+), 24 deletions(-)
diff --git a/vdagent/vdagent.vcproj b/vdagent/vdagent.vcproj
index b99297e..5e7bb43 100644
--- a/vdagent/vdagent.vcproj
+++ b/vdagent/vdagent.vcproj
@@ -350,25 +350,13 @@
---
vdagent/pci_vdi_port.cpp| 132 --
vdagent/pci_vdi_port.h | 59 --
vdagent/vdi_port.cpp| 90 -
vdagent/vdi_port.h | 75 -
vdagent/virtio_vdi_port.cpp | 187
NACK, seems it needs some more testing
Arnon Gilboa wrote:
---
vdagent/vdagent.cpp | 239 +++
1 files changed, 109 insertions(+), 130 deletions(-)
diff --git a/vdagent/vdagent.cpp b/vdagent/vdagent.cpp
index 2bb466d..85244c0 100644
vdagent was ok, but vdservice required adding these to the version check.
Both are handled as the rest of the Win7 class.
Tested on Win8x64.
---
vdservice/vdservice.cpp |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/vdservice/vdservice.cpp b/vdservice/vdservice.cpp
Erik Lotspeich wrote:
On 11/21/2012 07:13 AM, Christophe Fergeau wrote:
On Wed, Nov 21, 2012 at 02:59:44PM +0200, Arnon Gilboa wrote:
Christophe Fergeau wrote:
On Tue, Nov 20, 2012 at 11:34:56AM -0600, Erik Lotspeich wrote:
I was wondering if there will be a Windows 8
Arnon Gilboa wrote:
Erik Lotspeich wrote:
On 11/21/2012 07:13 AM, Christophe Fergeau wrote:
On Wed, Nov 21, 2012 at 02:59:44PM +0200, Arnon Gilboa wrote:
Christophe Fergeau wrote:
On Tue, Nov 20, 2012 at 11:34:56AM -0600, Erik Lotspeich wrote:
I was wondering
Christophe Fergeau wrote:
Hey,
On Tue, Nov 20, 2012 at 11:34:56AM -0600, Erik Lotspeich wrote:
I was wondering if there will be a Windows 8 build for the Windows guest
tools soon. I don't have much experience with Windows development or how
to compile the source. Is this something that is
Christophe Fergeau wrote:
On Mon, Nov 19, 2012 at 08:33:36AM -0500, Marc-André Lureau wrote:
- Mensaje original -
When it's defined, this causes some fallback code to be used. In
particular, this causes log messages to not get timestamps.
Issue reported by Han Pilmeyer.
ack
Christophe Fergeau wrote:
This got broken with the recent code moves from vdservice to vdagent.
---
Makefile.am | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/Makefile.am b/Makefile.am
index b050aff..9b73def 100644
--- a/Makefile.am
+++ b/Makefile.am
@@
Christophe Fergeau wrote:
On Wed, Nov 07, 2012 at 03:19:51PM +0200, Arnon Gilboa wrote:
---
vdagent/vdagent.cpp | 105 +++
1 files changed, 56 insertions(+), 49 deletions(-)
diff --git a/vdagent/vdagent.cpp b/vdagent/vdagent.cpp
index
Christophe Fergeau wrote:
This one is quite complicated to review, I didn't look at it very
carefully...
will be nice if you give it another 5 mins...
On Wed, Nov 07, 2012 at 03:19:49PM +0200, Arnon Gilboa wrote:
---
vdagent/vdagent.cpp| 467
Christophe Fergeau wrote:
On Wed, Nov 07, 2012 at 03:19:46PM +0200, Arnon Gilboa wrote:
-move virtio-serial use from vdservice to vdagent
-remove named pipe between vdservice vdagent
pros:
-make agent independent so it can run seperately without service
(e.g. single user, testing
Itamar Heim wrote:
On 10/18/2012 12:26 PM, Arnon Gilboa wrote:
Hi,
I'd like to make a small change in vdagent-win:
-move virtio-serial use from vdservice to vdagent
-remove named pipe between vdservice vdagent
pros:
-make agent independent so it can run separately without service (e.g.
single
Alon Levy wrote:
-move virtio-serial use from vdservice to vdagent
-remove named pipe between vdservice vdagent
pros:
-make agent independent so it can run seperately without service
(e.g. single user, testing)
-simplify service to just a launcher of agents
-performance - data is currently
/write
-separation between user sessions, no communication with service
-easier to debug
cons:
-when switching between users client will switch to server mode for a few ms
Arnon Gilboa (5):
vdservice: remove virtio-serial pipe usage
vdagent: mv vdi_port files from vdservice
vdagent: use
---
vdservice/vdservice.cpp| 471
vdservice/vdservice.vcproj | 24 ---
2 files changed, 36 insertions(+), 459 deletions(-)
diff --git a/vdservice/vdservice.cpp b/vdservice/vdservice.cpp
index 2b925fd..8f12317 100644
---
---
vdagent/pci_vdi_port.cpp | 132 +
vdagent/pci_vdi_port.h| 59 +
vdagent/vdi_port.cpp | 90
vdagent/vdi_port.h| 75
vdagent/virtio_vdi_port.cpp | 187
---
vdagent/vdagent.cpp| 467 +++-
vdagent/vdagent.vcproj | 32 +++-
2 files changed, 256 insertions(+), 243 deletions(-)
diff --git a/vdagent/vdagent.cpp b/vdagent/vdagent.cpp
index 078e50f..9bb0898 100644
--- a/vdagent/vdagent.cpp
+++
---
common/vdcommon.h | 31 ---
1 files changed, 0 insertions(+), 31 deletions(-)
diff --git a/common/vdcommon.h b/common/vdcommon.h
index 394333b..e50f2b0 100644
--- a/common/vdcommon.h
+++ b/common/vdcommon.h
@@ -32,19 +32,8 @@ typedef CRITICAL_SECTION mutex_t;
---
vdagent/vdagent.cpp | 105 +++
1 files changed, 56 insertions(+), 49 deletions(-)
diff --git a/vdagent/vdagent.cpp b/vdagent/vdagent.cpp
index 9bb0898..7495826 100644
--- a/vdagent/vdagent.cpp
+++ b/vdagent/vdagent.cpp
@@ -80,6 +80,7 @@
currently:
-handling client disconnect during clipboard data trasfer is buggy
-agent also timeouts on large paste from client (10sec)
therfore:
-reduce VD_CLIPBOARD_TIMEOUT_MS to 3sec from previous clipboard chunk
-remove _clipboard_event and use _control_event(CONTROL_CLIPBOARD) instead
-use
-add Advapi32.lib ole32.lib, set RTL to MT instead of MD
-otherwise it requires to install MS VC++ 2008 SP1 redist
-solves libwdi error WDI_ERROR_NEEDS_ADMIN (-15)
Unable to run process with required administrative privileges
rhbz#857119
---
libwdi/.msvc/installer_x64_2008.vcproj | 10
ack
Marc-André Lureau wrote:
Set low integrity on named-pipes.
This bug was originally resolved as:
https://bugzilla.redhat.com/show_bug.cgi?id=668980
Fixes regression:
https://bugzilla.redhat.com/show_bug.cgi?id=844461
---
gtk/controller/Makefile.am | 2 +
ack
Marc-André Lureau wrote:
Based on RHEV spicec-win only code.
---
gtk/controller/win32-util.c | 50 -
1 file changed, 49 insertions(+), 1 deletion(-)
diff --git a/gtk/controller/win32-util.c b/gtk/controller/win32-util.c
index 4e3ec4c..1268b2a
ack. seems ok, although CreateFile can move to init.
Uri Lublin wrote:
With this message usbclerk keeps a list of devices for which
a libusb driver was installed (per connection).
When a spice-gtk client exits, the connection is closed, and
usbclerk uninstalls the driver for all devices in the
Alon Levy wrote:
We could also use the existing SPICE_CLIENT_AGENT_DATA message, extending the
ports to include an additional client port, keeping it compatible with multiple
clients in the future. But otoh I like that your suggestion is simpler, I don't
like that multiplexing that much.
Hi,
I'd like to make a small change in vdagent-win:
-move virtio-serial use from vdservice to vdagent
-remove named pipe between vdservice vdagent
pros:
-make agent independent so it can run separately without service (e.g.
single user, testing)
-simplify service to just a launcher of
Marc-André Lureau wrote:
Hi
- Mensaje original -
I'd like to make a small change in vdagent-win:
-move virtio-serial use from vdservice to vdagent
-remove named pipe between vdservice vdagent
pros:
-make agent independent so it can run separately without service
(e.g.
single
communication to
per-user agent make such scenario unfixable?
David
same as before, at each moment only a single agent will run - on the
active session.
what you have mentioned seems like a bug, and it will be even easier to
fix it that way.
Arnon Gilboa píše v Čt 18. 10. 2012 v 12:26 +0200:
Hi
ack
Yonit Halperin wrote:
snd_channel_put freed channel, and then channel-worker was accessed.
It caused segmentation faults during connections and disconnections of the
client.
---
server/snd_worker.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git
Christophe Fergeau wrote:
On Wed, Oct 10, 2012 at 10:02:48AM +0800, me,apporc wrote:
I feel it 's wired, there must be something wrong with this source code.
Because i need some features from new version spice client, usb redir eg. I
have to compile it from source. Could any one give me some
ACK series
Acked-by: Arnon Gilboa agil...@redhat.com
Christophe Fergeau wrote:
It needs to be executable to be useful
---
0 files changed
mode change 100644 = 100755 autogen.sh
diff --git a/autogen.sh b/autogen.sh
old mode 100644
new mode 100755
win7-only issue
rhbz#845222
---
vdservice/vdservice.cpp | 10 ++
1 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/vdservice/vdservice.cpp b/vdservice/vdservice.cpp
index 696f3da..b48cbeb 100644
--- a/vdservice/vdservice.cpp
+++ b/vdservice/vdservice.cpp
@@ -590,6 +590,16
as recommended by MS. seems like defined behavior of the driver.
rhbz#839564
---
vdservice/virtio_vdi_port.cpp |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/vdservice/virtio_vdi_port.cpp b/vdservice/virtio_vdi_port.cpp
index 31a3862..92eb129 100644
---
read write are async, and their completion is handled by handle_event(),
which returns status used by service execute loop.
previously an error in GetOverlappedResult caused vdservice hang.
rhbz#839564
---
vdservice/pci_vdi_port.cpp|3 ++-
vdservice/pci_vdi_port.h |2 +-
-add message type USB_CLERK_DRIVER_SESSION_INSTALL, bump version to 3
-handle multiple pipe connections concurrently with thread for each one
-keep pipe open, and on pipe close - cleanup the session-specific devices
-add test for temporary driver install and multiple devices
rhbz#845216
---
Alon Levy wrote:
ACK with one question.
User Interface Privilege Isolation is usually used only for specific
windows of
system security applications (anti-viruses etc.), so with this patch
mouse will
be irresponsive for these windows but keep working for the rest. A
complete
solution might
This is only part of the message corruption solution.
The other part is fixing virtio-serial / spice-qemu-char throttling code.
-replace write_[lock/unlock/completion] calls with [new/enqueue]_message
-remove clipboard specific _out_msg_* class members
-remove ugly loop - while (a-_out_msg
User Interface Privilege Isolation is usually used only for specific windows of
system security applications (anti-viruses etc.), so with this patch mouse will
be irresponsive for these windows but keep working for the rest. A complete
solution might be switching to server mouse mode while the
win7-only issue
rhbz#845222
---
vdservice/vdservice.cpp | 10 ++
1 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/vdservice/vdservice.cpp b/vdservice/vdservice.cpp
index 696f3da..b48cbeb 100644
--- a/vdservice/vdservice.cpp
+++ b/vdservice/vdservice.cpp
@@ -590,6 +590,16
ack w minor notes
Alon Levy wrote:
Presence of the key disables off screen surfaces creation; The callback
is still registered, but it always fails.
Registry key is checked on device initialization only, not during
runtime, so you must reset the vm to see any affects.
---
display/driver.c
\Naga.
From: Yaniv Kaul yk...@redhat.com
To: Arnon Gilboa agil...@redhat.com
Cc: spice-devel@lists.freedesktop.org; Naga Mohan Pothula nagamohan.poth...@yahoo.com
Sent: Wednesday, August 15, 2012 5:19 AM
Subject: Re: [Spice-devel] Mouse failure happens when
is the eror that causes vdagent.exe to be terminated abruptly.
VDAgent::send_input::SendInput failed: 0
VDAgent::run::Agent stopped
I've checked integrity level of Kaspersky UI process and it is lesser than VDAgent.exe
Thanks/Naga.
From: Arnon Gilboa agil
VDAgent::run::Agent stopped
I've checked integrity level of Kaspersky UI process and it is
lesser than VDAgent.exe
Thanks/Naga.
From: Arnon Gilboa agil...@redhat.comfail due to UIPI blocking
To: Naga Mohan Pothula nagamohan.poth...@yahoo.com
Cc: spice-devel
Naga Mohan Pothula wrote:
Hi,
VDAgent in Windows 7 guest gets terminated when mouse hovers on some applications like Kaspersky Anti-virus tool.
Noticed SendInput Windows API fails whenever any mouse operation performs on this tool. handle_mouse_event method returns with failure due to this and
info for the currently
active config. Note that what happens on the host side is that the filter
gets run for the current config, and if the config changes it gets re-run
with the new interface info.
Regards,
Hans
On 07/23/2012 11:23 AM, Arnon Gilboa wrote:
---
usbclerk.cpp | 72
Uri Lublin wrote:
filter_rules should be initialized to NULL and filter_count to 0.
In case they are not initialized by usbredirfilter_string_to_rules
(e.g. if
that registry entry does not exist).
sure, already fixed, name was also with no _prefix...
diff --git a/usbclerk.vcproj
prevents user from replacing the drivers
---
usbclerk.cpp | 12 +++-
1 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/usbclerk.cpp b/usbclerk.cpp
index 441f4a1..9100811 100644
--- a/usbclerk.cpp
+++ b/usbclerk.cpp
@@ -17,7 +17,7 @@
#define USB_CLERK_LOG_PATH
---
usbclerk.cpp | 33 -
1 files changed, 20 insertions(+), 13 deletions(-)
diff --git a/usbclerk.cpp b/usbclerk.cpp
index e01489b..09f1e66 100644
--- a/usbclerk.cpp
+++ b/usbclerk.cpp
@@ -39,6 +39,7 @@ private:
bool remove_winusb_driver(int vid, int pid);
until switching to mingw build
---
stdint.h | 256 +
usbredirfilter.c | 260 ++
usbredirfilter.h | 127 ++
3 files changed, 643 insertions(+), 0 deletions(-)
read from HKLM\Software\USBClerk\filter_rules
same format as in client
---
usbclerk.cpp| 69 +++
usbclerk.vcproj | 40 +++
2 files changed, 109 insertions(+), 0 deletions(-)
diff --git a/usbclerk.cpp
ack
Uri Lublin wrote:
Currently only NamePipe server is available.
We want to support also NamedPipe Client.
This property is to be used in a following patch.
---
gtk/controller/namedpipe.c | 17 +
1 files changed, 17 insertions(+), 0 deletions(-)
diff --git
ack
Uri Lublin wrote:
Currently both users are servers.
---
gtk/controller/namedpipe.c | 24 +---
gtk/controller/namedpipe.h |4 +++-
gtk/controller/spice-controller-listener.c |2 +-
ack, but a short comment on the detailed default format of
spice_usb_device_get_description() will be nice.
Uri Lublin wrote:
---
gtk/spicy.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/gtk/spicy.c b/gtk/spicy.c
index 98a44d5..ba0aa4b 100644
--- a/gtk/spicy.c
+++
See notes below.
I guess you defined it only for ref counting, otherwise you would have
used simply a struct (similar to _SpiceUsbDevicePrivate) ?
btw, why define Private and getters and not putting it all public?
Is it the the right gobject-way? no shorter way to do it? (see
ack, seems ok to me but can u pls remind me why needed to add
$(GUDEV_CFLAGS/LIBS) ?
Uri Lublin wrote:
For windows GUDEV is not required
For Linux GUDEV is checked as a part of USBREDIR block, but
as a separate check.
---
configure.ac| 15 ++-
gtk/Makefile.am |2 ++
2
ack
Uri Lublin wrote:
Also changed a bit the warning text on device-add to differentiate the two.
---
gtk/usb-device-manager.c |8 ++--
1 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/gtk/usb-device-manager.c b/gtk/usb-device-manager.c
index 8340335..d4740cf 100644
---
Seems great to me, but few comments below.
Uri Lublin wrote:
Note that this change may affect performance a bit, as we now need to look
for the libusb_device if we need it. Likely it's negligible.
---
gtk/Makefile.am |4 +
gtk/channel-usbredir-priv.h |4 +-
reviewed most of it before;) but added some comments for your changes below.
Uri Lublin wrote:
From: Arnon Gilboa agil...@redhat.com
- Added win-usb-dev.[ch]
- Added GUdevDevice and GUdevClient like classes
- Added uevent signal based on WM_DEVICECHANGE
With this patch usb-device-manager can
ack. I know this one;)
Uri Lublin wrote:
---
gtk/win-usb-driver-install.c | 69 +-
gtk/win-usb-driver-install.h |6
2 files changed, 54 insertions(+), 21 deletions(-)
diff --git a/gtk/win-usb-driver-install.c b/gtk/win-usb-driver-install.c
on a brief review, it seems ok, but won't a worker thread simplify the
code and cut it by half?
few minor comments below.
Uri Lublin wrote:
- Added win-usb-driver-install.[ch]
- Added win-usb-clerk.h
Operation (on Windows, spice-gtk point of view):
- After some sanity checks, just before
Nice catch. ACK.
Marc-André Lureau wrote:
When resizing desktop to best match, the agent fails to update
it's current mode width/height and then incorrectly report
different total_width/total_height than real screen dimensions,
then scaling input incorrectly results in mouse cursor offset.
Seems like the right hack. ACK.
Marc-André Lureau wrote:
Waiting for a Windows event will not last if it is already set.
For example, the client may send clipboard_release() messages
while we are not waiting in on_clipboard_request(), and this will
SetEvent(clipboard_event)
The following
Hi Joris, see below.
Enjoy,
Arnon
joris wrote:
Dear list
most likely I'm doing something stupid, but i searched all over google
and cannot find the answer. I also looked through the docs on the
spice website and still nothing. The problem however is quite simple.
I downloaded the spice
Alon Levy wrote:
On Fri, May 11, 2012 at 06:39:18PM +0200, Marc-André Lureau wrote:
Use QXL_ESCAPE_SET_CUSTOM_DISPLAY to update custom mode,
and switch to it.
---
vdagent/desktop_layout.cpp | 26 ++
1 file changed, 26 insertions(+)
diff --git
breaks vs build
1LIBCMT.lib(wincrt0.obj) : error LNK2001: unresolved external symbol
_WinMain@16
1Release\vdagent.exe : fatal error LNK1120: 1 unresolved externals
we may patch vsproj || ifdef || add this line to vdagent.cpp:
#pragma comment (linker, /ENTRY:mainCRTStartup)
Marc-André Lureau
(except #2)
ACK series
Acked-by: Arnon Gilboa agil...@redhat.com
Marc-André Lureau wrote:
---
configure.ac |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index 77d5c25..28c9d23 100644
--- a/configure.ac
+++ b/configure.ac
@@ -14,7 +14,7
Thanks for the review.
Great comments which surely help a GObject/Gtk-dummy like myself ;)
See below.
Marc-André Lureau wrote:
Hi
On Mon, May 7, 2012 at 3:15 PM, Uri Lublin u...@redhat.com wrote:
From: Arnon Gilboa agil...@redhat.com
With this patch usb-device-manager can work with little
Hi,
Seems like we are having again some issues with virtio-serial.
Can you please send vdservice.log as well?
10x,
Arnon
wangfeng wangfeng wrote:
Hi,
I have installed vdservice successfully. But after I restart the
windows7 guest, vdagent can not run ,and vdservice stoped.
When I start
::CreateFile() failed:
2
4048::INFO::2012-04-25 17:16:15,963::VDService::execute::Failed to create
VDIPort instance
2012/4/25 Arnon Gilboa agil...@redhat.com
Hi,
Seems like we are having again some issues with virtio-serial.
Can you please send vdservice.log as well?
10x,
Arnon
wangfeng wangfeng
Christophe Fergeau wrote:
Hi,
On Sun, Apr 15, 2012 at 12:24:38PM +0300, Arnon Gilboa wrote:
will be nice to keep latest x86 x64 wspice zips on the new dl page.
otherwise, no way to run the legacy spicec on windows.
These would be
http://spice-space.org/download/stable/wspice
Christophe Fergeau wrote:
Hey,
On Thu, Apr 05, 2012 at 02:40:53PM +, Dylan Denney wrote:
What happened to the windows spice library download? without it the spice
client will not run.
Ah, I recently reorganized the download page and thought they were not
needed. The old page is
AFAIK, Spice server works only on x86_64, because it is dependent on
64-bit atomic operations. There is no known plan to port it to other
architecture. See http://www.spice-space.org/page/FAQ.
Fabiano Fidêncio wrote:
Guys, I've been trouble using spice-protocol/spice/qemu from git, in a
32
spice-gtk windows client support for USB redir is still under
development. Patches will be posted very soon.
The old spicec client for windows supports USB redir using Incentives
Pro's product.
Arnon
Andrew Osborne wrote:
Works with Fedora 16 and WinXp as client
Andrew
On 17 Mar 2012, at
wangfeng wangfeng wrote:
Hi,
I have created a Win7 VM by libvirt. Then I installed only qxl driver
but no virtio-serial driver, and vdservice is also not running. But the
mouse can move smoothly without SHIFT+F12. Isn't this vdagent's function?
After that I installed virtio-serial
1 - 100 of 281 matches
Mail list logo
