[sqlite] A small patch for the SQLite shell in windows.

2015-12-30 Thread Quan Yong Zhai
Thank you Richard. The patch work very well Here is a simple test: E:\sqlite-src-3090200>chcp ?: 936 ---active code page: 936 E:\sqlite-src-3090200>shell SQLite version 3.9.2 2015-11-02 18:31:45 Enter ".help" for usage hints. Connected to a transient in-memory database. Use

[sqlite] Magic number in sqlite source code

2015-12-30 Thread Domingo Alvarez Duarte
Hello Richard ! It's hard to come up with names but as it is on https://www.sqlite.org/src/info/1541607d458069f5 I think that's a good improvement to make the code easier to follow and DRY. This approach has at least 2 benefits: 1- Is easy to see what parts of the code depend on

[sqlite] Documentation Typo in FTS Example

2015-12-30 Thread Dan Kennedy
On 12/30/2015 03:57 PM, Casey Rodarmor wrote: > From https://sqlite.org/fts3.html: > > CREATE TABLE t2(id INTEGER PRIMARY KEY, a, b, c, d); > CREATE VIRTUAL TABLE t3 USING fts4(content="t2", b, c); > > INSERT INTO t2 VALUES(2, 'a b', 'c d', 'e f'); > INSERT INTO t2 VALUES(3, 'g h', 'i j', 'k l');

[sqlite] A small patch for the SQLite shell in windows.

2015-12-30 Thread Quan Yong Zhai
>From: Richard Hipp >Sent: 2015?12?30? 20:21 >To: SQLite mailing list >Subject: Re: [sqlite] A small patch for the SQLite shell in windows. >Please send a unified diff, generated using the -u option to the >"diff" command.? Even better would be the "-U 8" option, to include >more context. diff

[sqlite] Magic number in sqlite source code

2015-12-30 Thread Domingo Alvarez Duarte
Hello Richard ! I just saw this commit https://www.sqlite.org/src/info/6a4cfc7ab62046eb and noticed you've been using magic numbers would it be better to use a macro instead ? I think for other people (and maybe yourself) would be easier to see something like "INFO_SIZE_ADJUST" (or any

[sqlite] Database locked error with only one process?

2015-12-30 Thread Jason H
I read around, and it seems that the consensus is it should only be locked during a multi-thread/multi-process update. However I encountered the error in a python script (single proc/single thread) that was the only reader/writer to the database. It seems that I forgot to con.commit() in a loop

[sqlite] Database locked error with only one process?

2015-12-30 Thread Simon Slavin
On 30 Dec 2015, at 5:12pm, Jason H wrote: > I read around, and it seems that the consensus is it should only be locked > during a multi-thread/multi-process update. Nope. The database is locked any time a transaction is under way [1]. Your program cannot know if another process is going to

[sqlite] Function patternCompare() not EBCDIC friendly

2015-12-30 Thread mbezzi
Roland, I am pleased to see that you are successfully using SQLite on z/OS. Are you using the standard amalgamation? Did you need to apply special mods to SQLite to work on z/OS? Would you mind sharing your build procedure? Few months ago I tried compiling SQLite on z/OS: It worked but the

[sqlite] Function patternCompare() not EBCDIC friendly

2015-12-30 Thread Roland Martin
Hi Mario, I was using SQLite 3.8.6 up to this point on z/OS with a couple of minor code changes which are now included in version 3.9.2. With the fix Richard provided this morning all functionality I have tested so far is working out of the box with no code changes on z/OS. The databases I use

[sqlite] A small patch for the SQLite shell in windows.

2015-12-30 Thread Quan Yong Zhai
Hi, I have a small patch for the SQLite Shell 3.9.2, it convert sql command text to utf-8 before sending to SQLite engine, And convert the result text back to default code page after sqlite3_exec. Before patch( SQLite shell in windows 10 Chinese version): SQLite version 3.9.2 2015-11-02

[sqlite] FTS3 - Unexpected SELECT Results

2015-12-30 Thread Gaius Laubli
I created a table?with the Porter tokenizer: "CREATE VIRTUAL TABLE fts_translations USING fts3(name, tokenize=porter)" Then I execute a select statement, which before?text substitution looks like this: SELECT [symbols].`id`, [symbols].`rid` FROM [symbols] ?INNER JOIN [symbol_translations] ON

[sqlite] Magic number in sqlite source code

2015-12-30 Thread Richard Hipp
On 12/30/15, Richard Hipp wrote: > > I'll continue look for an alternative way to make the intent of the > code clearer. > See https://www.sqlite.org/src/info/1541607d458069f5 for another attempt at removing magic numbers. But I don't like it. It seems to complicate more than it clarifies. My

[sqlite] Magic number in sqlite source code

2015-12-30 Thread Richard Hipp
On 12/30/15, Domingo Alvarez Duarte wrote: > Hello Richard ! > > I just saw this commit https://www.sqlite.org/src/info/6a4cfc7ab62046eb and > noticed you've been using magic numbers would it be better to use a macro > instead ? > > I think for other people (and maybe yourself) would be easier to

[sqlite] Magic number in sqlite source code

2015-12-30 Thread Darren Duncan
On 2015-12-30 12:51 PM, Richard Hipp wrote: > On 12/30/15, Richard Hipp wrote: >> I'll continue look for an alternative way to make the intent of the >> code clearer. > > See https://www.sqlite.org/src/info/1541607d458069f5 for another > attempt at removing magic numbers. But I don't like it.

[sqlite] Function patternCompare() not EBCDIC friendly

2015-12-30 Thread John McKown
On Wed, Dec 30, 2015 at 9:55 AM, Roland Martin wrote: > I have tested the code change on z/OS and it works. > ?Any chance that I could beg the source and executable code from you? > > Thanks for the quick turnaround! > > Roland Martin > > -- Computer Science is the only discipline in which

[sqlite] Function patternCompare() not EBCDIC friendly

2015-12-30 Thread Roland Martin
I have tested the code change on z/OS and it works. Thanks for the quick turnaround! Roland Martin -Original Message- From: drhsqlite at gmail.com [mailto:drhsql...@gmail.com] On Behalf Of Richard Hipp Sent: Wednesday, December 30, 2015 9:08 AM To: SQLite mailing list Cc: rolandsmartin

[sqlite] Date as integer

2015-12-30 Thread Cecil Westerhof
?? 2015-12-30 2:56 GMT+01:00 Richard Hipp : > On 12/29/15, Cecil Westerhof wrote: > > I first had the following table: > > CREATE TABLE simpleLog ( > >datetimeTEXT NOT NULL PRIMARY KEY DEFAULT CURRENT_TIMESTAMP, > >description TEXT NOT NULL > > ) > > > > ?But datetime then takes 19

[sqlite] Function patternCompare() not EBCDIC friendly

2015-12-30 Thread Richard Hipp
On 12/30/15, Roland Martin wrote: > Working with version 3.9.2 on IBM z/OS case insensitive LIKE queries do not > work if case does not match. Please test and let us know if the https://www.sqlite.org/src/info/0a99a8c4facf65ec check-in fixes your problem. -- D. Richard Hipp drh at sqlite.org

[sqlite] A small patch for the SQLite shell in windows.

2015-12-30 Thread Richard Hipp
Please test the alternative patch found at https://www.sqlite.org/src/info/a0a08b8c0bbd4d71 and let me know whether or not the alternative patch fixes your problem. On 12/30/15, Quan Yong Zhai wrote: >>From: Richard Hipp >>Sent: 2015?12?30? 20:21 >>To: SQLite mailing list >>Subject: Re: [sqlite]

[sqlite] Function patternCompare() not EBCDIC friendly

2015-12-30 Thread Roland Martin
Working with version 3.9.2 on IBM z/OS case insensitive LIKE queries do not work if case does not match. The following #if defined(SQLITE_EBCDIC) is important: /* ** For LIKE and GLOB matching on EBCDIC machines, assume that every ** character is exactly one byte in size. Also, provde the

[sqlite] A small patch for the SQLite shell in windows.

2015-12-30 Thread Richard Hipp
On 12/30/15, Quan Yong Zhai wrote: > Hi, > I have a small patch for the SQLite Shell 3.9.2, it convert sql command text > to utf-8 before sending to SQLite engine, Please send a unified diff, generated using the -u option to the "diff" command. Even better would be the "-U 8" option, to include

[sqlite] Date as integer

2015-12-30 Thread Cecil Westerhof
I first had the following table: CREATE TABLE simpleLog ( datetimeTEXT NOT NULL PRIMARY KEY DEFAULT CURRENT_TIMESTAMP, description TEXT NOT NULL ) ?But datetime then takes 19 bytes. I understood you can also use an Integer or Real and that this should be more efficient. At the moment I

[sqlite] Documentation Typo in FTS Example

2015-12-30 Thread Casey Rodarmor
>From https://sqlite.org/fts3.html: CREATE TABLE t2(id INTEGER PRIMARY KEY, a, b, c, d); CREATE VIRTUAL TABLE t3 USING fts4(content="t2", b, c); INSERT INTO t2 VALUES(2, 'a b', 'c d', 'e f'); INSERT INTO t2 VALUES(3, 'g h', 'i j', 'k l'); The two inserts will fail, since t2 has 5 columns but 4