[sqlite] Magic number in sqlite source code

c 30 2015 11:51:54 pm CET CET from "Darren Duncan" > > Subject: Re: [sqlite] Magic number in sqlite > >source code > > > > On 2015-12-30 12:51 PM, Richard Hipp wrote: > > > >>On 12/30/15, Richard Hipp wrote: > >> > >>>

[sqlite] Magic number in sqlite source code

Hello Duncan ! I saw a very good point on your suggestion ! I'll use it when writing/refactoring code. Thanks a lot ! ? > Wed Dec 30 2015 11:51:54 pm CET CET from "Darren Duncan" > Subject: Re: [sqlite] Magic number in sqlite >source code > > On 2015-12-

[sqlite] Magic number in sqlite source code

Hello Richard ! Sorry again for the mess with format and missing parameter on the maybe more friendly function "ptrmapPutOvflPtr" ! I decided to really look at the code now (before I looked at the diffs and saw so many magic numbers "4"). I know that what I'm saying here not always

[sqlite] Magic number in sqlite source code

Hello Richard ! !!! Last message got messed format, sorry !!! I decided to really look at the code now (before I looked at the diffs and saw so many magic numbers "4"). I know that what I'm saying here not always I follow for n reasons but thanks for giving me a chance to take a moment and

[sqlite] Magic number in sqlite source code

Hello Richard ! I decided to really look at the code now (before I looked at the diffs and saw so many magic numbers "4"). I know that what I'm saying here not always I follow for n reasons but thanks for giving me a chance to take a moment and reflect on this that do not seem a problem when

[sqlite] Magic number in sqlite source code

_OVERFLOW1. #define PTRMAP_OVERFLOW1 4 #define OvflOffset(X) ((X)->nSize-PTRMAP_OVERFLOW1) Cheers ! > Wed Dec 30 2015 9:51:52 pm CET CET from "Richard Hipp" >Subject: Re: [sqlite] Magic number in sqlite source code > > On 12/30/15, Richard Hipp wrote: > > &g

[sqlite] Magic number in sqlite source code

Hello Richard ! I just saw this commit https://www.sqlite.org/src/info/6a4cfc7ab62046eb and noticed you've been using magic numbers would it be better to use a macro instead ? I think for other people (and maybe yourself) would be easier to see something like "INFO_SIZE_ADJUST" (or any

[sqlite] Magic number in sqlite source code

On 12/30/15, Richard Hipp wrote: > > I'll continue look for an alternative way to make the intent of the > code clearer. > See https://www.sqlite.org/src/info/1541607d458069f5 for another attempt at removing magic numbers. But I don't like it. It seems to complicate more than it clarifies. My

[sqlite] Magic number in sqlite source code

On 12/30/15, Domingo Alvarez Duarte wrote: > Hello Richard ! > > I just saw this commit https://www.sqlite.org/src/info/6a4cfc7ab62046eb and > noticed you've been using magic numbers would it be better to use a macro > instead ? > > I think for other people (and maybe yourself) would be easier to

[sqlite] Magic number in sqlite source code

On 2015-12-30 12:51 PM, Richard Hipp wrote: > On 12/30/15, Richard Hipp wrote: >> I'll continue look for an alternative way to make the intent of the >> code clearer. > > See https://www.sqlite.org/src/info/1541607d458069f5 for another > attempt at removing magic numbers. But I don't like it.

[sqlite] Magic number in sqlite source code

Hello ! I was looking at this particular commit https://www.sqlite.org/src/info/0ea6e5c9fc6b1dd1 then I realize the usage of magic number through sqlite3 source code like the one bellow, it's not good practice to avoid then ? Cheers ! = case PragTyp_STATS: { static const char

[sqlite] Magic number in sqlite source code

On Sep 3, 2015 4:17 AM, "Domingo Alvarez Duarte" wrote: > > Hello ! > > I was looking at this particular commit > https://www.sqlite.org/src/info/0ea6e5c9fc6b1dd1 then I realize the usage of > magic number through sqlite3 source code like the one bellow, it's not good > practice to avoid then ?