Re: [SSSD] [PATCH] correctly escape RDNs

2009-11-20 Thread Sumit Bose
On Thu, Nov 19, 2009 at 07:30:32PM -0500, Simo Sorce wrote: See commit comment. -- Simo Sorce * Red Hat, Inc * New York From 49862816e3b7077bc7a002c980901d31aff06269 Mon Sep 17 00:00:00 2001 From: Simo Sorce sso...@redhat.com Date: Thu, 19 Nov 2009 19:28:36 -0500 Subject: [PATCH]

Re: [SSSD] [PATCH] Optimize gorup enumerations

2009-11-20 Thread Sumit Bose
On Tue, Nov 17, 2009 at 08:38:00PM -0500, Simo Sorce wrote: I've been thinking about optimizing group enumerations for a while as they were way too slow for my taste. I did that by relying on the way we store users in the database and by parsing the member attribute of the groups counting on

Re: [SSSD] [PATCH] move id range checks into providers

2009-11-20 Thread Sumit Bose
On Fri, Nov 20, 2009 at 10:40:29AM +0100, Sumit Bose wrote: On Wed, Nov 18, 2009 at 12:09:58PM -0500, Simo Sorce wrote: This way we check them once at storage time instead of checking again and again at search time. Applies only on top of the sysdb_enumgrent optimization patch.

Re: [SSSD] [PATCH] Make use of failover code in backends.

2009-11-20 Thread Sumit Bose
On Mon, Nov 16, 2009 at 05:55:51PM -0500, Simo Sorce wrote: This patch implements the use of the fail_over code under the control of the data provider backend code. All providers share the same failover structure and if they use the same service name, they also share the same servers lists.

Re: [SSSD] [PATCH] Improve handling of ccache files

2009-11-20 Thread Sumit Bose
On Thu, Nov 19, 2009 at 02:31:36PM +0100, Sumit Bose wrote: Hi, this patch improves the handling of ccache files. It addresses two issues already discussed on the list. When randomized ccache file are used (or the client process id is used in the name of the ccache file) each

Re: [SSSD] [PATCH] Make use of failover code in backends.

2009-11-20 Thread Simo Sorce
On Fri, 2009-11-20 at 12:23 +0100, Sumit Bose wrote: On Mon, Nov 16, 2009 at 05:55:51PM -0500, Simo Sorce wrote: This patch implements the use of the fail_over code under the control of the data provider backend code. All providers share the same failover structure and if they use the same

Re: [SSSD] [PATCH] move id range checks into providers

2009-11-20 Thread Simo Sorce
On Fri, 2009-11-20 at 11:19 +0100, Sumit Bose wrote: On Fri, Nov 20, 2009 at 10:40:29AM +0100, Sumit Bose wrote: On Wed, Nov 18, 2009 at 12:09:58PM -0500, Simo Sorce wrote: This way we check them once at storage time instead of checking again and again at search time. Applies only

Re: [SSSD] [PATCH] correctly escape RDNs

2009-11-20 Thread Simo Sorce
On Fri, 2009-11-20 at 09:50 +0100, Sumit Bose wrote: On Thu, Nov 19, 2009 at 07:30:32PM -0500, Simo Sorce wrote: See commit comment. -- Simo Sorce * Red Hat, Inc * New York From 49862816e3b7077bc7a002c980901d31aff06269 Mon Sep 17 00:00:00 2001 From: Simo Sorce sso...@redhat.com

Re: [SSSD] [PATCH] Make use of failover code in backends.

2009-11-20 Thread Sumit Bose
On Fri, Nov 20, 2009 at 08:59:49AM -0500, Simo Sorce wrote: On Fri, 2009-11-20 at 12:23 +0100, Sumit Bose wrote: On Mon, Nov 16, 2009 at 05:55:51PM -0500, Simo Sorce wrote: This patch implements the use of the fail_over code under the control of the data provider backend code. All

Re: [SSSD] [PATCH] correctly escape RDNs

2009-11-20 Thread Sumit Bose
On Fri, Nov 20, 2009 at 09:07:31AM -0500, Simo Sorce wrote: On Fri, 2009-11-20 at 09:50 +0100, Sumit Bose wrote: On Thu, Nov 19, 2009 at 07:30:32PM -0500, Simo Sorce wrote: See commit comment. -- Simo Sorce * Red Hat, Inc * New York From

Re: [SSSD] [PATCH] Improve handling of ccache files

2009-11-20 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/20/2009 08:41 AM, Sumit Bose wrote: On Thu, Nov 19, 2009 at 02:31:36PM +0100, Sumit Bose wrote: Hi, this patch improves the handling of ccache files. It addresses two issues already discussed on the list. When randomized ccache file are

Re: [SSSD] [PATCH] Make use of failover code in backends.

2009-11-20 Thread Simo Sorce
On Fri, 2009-11-20 at 15:16 +0100, Sumit Bose wrote: On Fri, Nov 20, 2009 at 08:59:49AM -0500, Simo Sorce wrote: On Fri, 2009-11-20 at 12:23 +0100, Sumit Bose wrote: On Mon, Nov 16, 2009 at 05:55:51PM -0500, Simo Sorce wrote: This patch implements the use of the fail_over code under the

Re: [SSSD] [PATCH] Add empty NL translation

2009-11-20 Thread Simo Sorce
On Thu, 2009-11-19 at 09:20 -0500, Stephen Gallagher wrote: $SUBJECT ACK -- Simo Sorce * Red Hat, Inc * New York ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel

Re: [SSSD] [PATCH] man page fix

2009-11-20 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/20/2009 10:16 AM, Simo Sorce wrote: Trivial man page fix. Simo. ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel Ack.

Re: [SSSD] [PATCH] Validate Kerberos cerdentials with local keytab

2009-11-20 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/19/2009 09:22 AM, Stephen Gallagher wrote: On 11/19/2009 07:58 AM, Sumit Bose wrote: On Wed, Nov 18, 2009 at 05:13:30PM -0500, Stephen Gallagher wrote: On 11/13/2009 09:29 AM, Sumit Bose wrote: On Thu, Nov 12, 2009 at 01:46:39PM -0500,

Re: [SSSD] [PATCH] better cleanup task for ldap driver

2009-11-20 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/20/2009 08:11 AM, Stephen Gallagher wrote: On 11/19/2009 05:36 PM, Simo Sorce wrote: On Thu, 2009-11-19 at 08:55 -0500, Simo Sorce wrote: On Thu, 2009-11-19 at 09:18 +0100, Sumit Bose wrote: On Wed, Nov 18, 2009 at 07:23:09PM -0500, Simo

Re: [SSSD] [PATCHES] Use ipachangeconf in the upgrade script

2009-11-20 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/20/2009 08:42 AM, Stephen Gallagher wrote: On 11/20/2009 08:32 AM, Jakub Hrozek wrote: On 11/20/2009 01:54 PM, Stephen Gallagher wrote: [PATCH 6/6] upgrade_config fixes for SSSD 0.6 and later Incorporates changes we made to v2 after 0.6, or

Re: [SSSD] [PATCH] Improve handling of ccache files

2009-11-20 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/20/2009 09:55 AM, Stephen Gallagher wrote: On 11/20/2009 08:41 AM, Sumit Bose wrote: On Thu, Nov 19, 2009 at 02:31:36PM +0100, Sumit Bose wrote: Hi, this patch improves the handling of ccache files. It addresses two issues already

Re: [SSSD] [PATCH] Add empty NL translation

2009-11-20 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/20/2009 10:11 AM, Simo Sorce wrote: On Thu, 2009-11-19 at 09:20 -0500, Stephen Gallagher wrote: $SUBJECT ACK Pushed to master. - -- Stephen Gallagher RHCE 804006346421761 Delivering value year after year. Red Hat ranks #1 in value

Re: [SSSD] [PATCH] Only display errors in unit tests

2009-11-20 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/20/2009 12:03 PM, Stephen Gallagher wrote: This patch cuts down the output for the unit tests, so they only display errors instead of both error and success statements. This will make it easier to discover what went wrong. Self-nack. The

Re: [SSSD] [PATCH] Make use of failover code in backends.

2009-11-20 Thread Simo Sorce
On Fri, 2009-11-20 at 10:03 -0500, Simo Sorce wrote: ok, modified patch attached. Rebased on top of current master. Simo. -- Simo Sorce * Red Hat, Inc * New York From 623b66a6817c4b87eefddb2d0f2591d18b16ba76 Mon Sep 17 00:00:00 2001 From: Simo Sorce sso...@redhat.com Date: Fri, 20 Nov 2009

Re: [SSSD] [PATCH] Only display errors in unit tests

2009-11-20 Thread Stephen Gallagher
On 11/20/2009 12:13 PM, Stephen Gallagher wrote: Self-nack. The better way to do this is with CK_ENV which will take the value of the environment variable CK_VERBOSITY or default to CK_NORMAL (which only prints the summary and errors) To view output the old (verbose) way, just set

Re: [SSSD] [PATCH] Only display errors in unit tests

2009-11-20 Thread Stephen Gallagher
On 11/20/2009 12:14 PM, Stephen Gallagher wrote: On 11/20/2009 12:13 PM, Stephen Gallagher wrote: Self-nack. The better way to do this is with CK_ENV which will take the value of the environment variable CK_VERBOSITY or default to CK_NORMAL (which only prints the summary and errors) To

Re: [SSSD] [PATCH] Optimize gorup enumerations

2009-11-20 Thread Simo Sorce
On Fri, 2009-11-20 at 11:16 -0500, Stephen Gallagher wrote: Nack You broke the sysdb tests ../../server/tests/sysdb-tests.c:1758:F:SYSDB Tests:test_sysdb_get_user_attr:27010: [5]: Could not get attributes for user testuser27010 [..] Thanks for catching this, it unveiled a serious error.

[SSSD] ELAPI fundamental architectural issue

2009-11-20 Thread Dmitri Pal
Hi, I am pretty close to having ELAPI based on the async processing to at least building. This means that I finally embraced the logic or async programming and managed to understand what should be done where and how. Big progress I should say. So... The events now can be created and logged

Re: [SSSD] ELAPI fundamental architectural issue

2009-11-20 Thread Simo Sorce
On Fri, 2009-11-20 at 12:50 -0500, Dmitri Pal wrote: b) Hold the events in queue inside ELAPI dispatcher and let them go through the whole sink chain only one at a time. In this case there will be only one event traveling the callbacks at a time. This approach though avoids the blocking of

Re: [SSSD] [PATCH] Optimize gorup enumerations

2009-11-20 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/20/2009 12:49 PM, Simo Sorce wrote: Thanks for catching this, it unveiled a serious error. Attached patch that correctly passes all tests. Simo. You're welcome. That's why the tests are there. Ack. - -- Stephen Gallagher RHCE

Re: [SSSD] [PATCH] move id range checks into providers

2009-11-20 Thread Simo Sorce
On Fri, 2009-11-20 at 10:40 +0100, Sumit Bose wrote: Works well, especially with Optimize-sysdb_enumgrent.patch, but please create a utility function or a macro for the range check and fix Revised patch to use a macro. -- Simo Sorce * Red Hat, Inc * New York From

[SSSD] [PATCH] raise a couple of timeouts

2009-11-20 Thread Simo Sorce
They were a bit too strict with high debug levels. Simo. -- Simo Sorce * Red Hat, Inc * New York From bcd36543f40ac48f944970735eddfd37f9cf9ab6 Mon Sep 17 00:00:00 2001 From: Simo Sorce sso...@redhat.com Date: Fri, 20 Nov 2009 14:19:35 -0500 Subject: [PATCH] Raise some timeouts When using high

Re: [SSSD] [PATCH] Add ipa_auth

2009-11-20 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/09/2009 05:35 PM, Sumit Bose wrote: Hi, this patch adds a separate IPA authentication target which glues together Kerberos and LDAP authentication to support IPA password migration. Ack - -- Stephen Gallagher RHCE 804006346421761

Re: [SSSD] ELAPI fundamental architectural issue

2009-11-20 Thread Simo Sorce
On Fri, 2009-11-20 at 14:27 -0500, Dmitri Pal wrote: If I understand you correctly you agree that having an internal queue is the right approach. Do you agree with the recommendation to use different dispatchers if application wants to log sync and async events at the same time? No. It

Re: [SSSD] [PATCH] raise a couple of timeouts

2009-11-20 Thread Jenny Galipeau
Stephen Gallagher wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/20/2009 02:22 PM, Simo Sorce wrote: They were a bit too strict with high debug levels. Simo. Ack. A note to QA: when this patch is pushed it will probably cause a lot of trouble with the tests. It

Re: [SSSD] [PATCH] Ignore shadow attributes

2009-11-20 Thread Sumit Bose
On Mon, Nov 16, 2009 at 09:23:17AM -0500, Simo Sorce wrote: On Mon, 2009-11-16 at 14:06 +0100, Sumit Bose wrote: Hi, this patch should fix #279 by ignoring the shadow attributes by default. I was thinking about this and I think I don't want to go down this way. While automatic

Re: [SSSD] ELAPI fundamental architectural issue

2009-11-20 Thread Dmitri Pal
No I think that apps that use mixed async and sycn logging do so only when sending a sync log requires it to know the operation went through. Ok so I will add a queue at the beginning... Ohh. More complexity and more work... In that case the application is prepared to wait the time it

Re: [SSSD] [PATCH] Enhance check for remote hosts

2009-11-20 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/16/2009 05:52 AM, Sumit Bose wrote: Hi, with this patch the ipa_access target should be functional complete (if I haven't forgotten something). It tries to resolve to group memberships of the remote host and checks the hbac rule against

Re: [SSSD] [PATCH] Make use of failover code in backends.

2009-11-20 Thread Sumit Bose
On Fri, Nov 20, 2009 at 12:14:22PM -0500, Simo Sorce wrote: On Fri, 2009-11-20 at 10:03 -0500, Simo Sorce wrote: ok, modified patch attached. Rebased on top of current master. Simo. I still find it hard to test, but I think the general logic is right. ACK bye, Sumit

Re: [SSSD] [PATCH] Make use of failover code in backends.

2009-11-20 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/20/2009 12:14 PM, Simo Sorce wrote: On Fri, 2009-11-20 at 10:03 -0500, Simo Sorce wrote: ok, modified patch attached. Rebased on top of current master. Simo. Ack - -- Stephen Gallagher RHCE 804006346421761 Delivering value year

Re: [SSSD] [PATCH] Read KDC info from file instead from environment

2009-11-20 Thread Simo Sorce
On Thu, 2009-11-19 at 18:32 +0100, Sumit Bose wrote: Hi, this patch changes the way the locator plugin finds out about the KDC. Now the information is written to a file which is read by the plugin. Two thing will be address in different patches. - the enviroment variables are still sent

Re: [SSSD] [PATCH] Add ipa_auth

2009-11-20 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/20/2009 02:49 PM, Stephen Gallagher wrote: On 11/09/2009 05:35 PM, Sumit Bose wrote: Hi, this patch adds a separate IPA authentication target which glues together Kerberos and LDAP authentication to support IPA password migration. Ack

Re: [SSSD] [PATCH] raise a couple of timeouts

2009-11-20 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/20/2009 02:48 PM, Stephen Gallagher wrote: On 11/20/2009 02:22 PM, Simo Sorce wrote: They were a bit too strict with high debug levels. Simo. Ack. A note to QA: when this patch is pushed it will probably cause a lot of trouble with

Re: [SSSD] [PATCH] move id range checks into providers

2009-11-20 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/20/2009 03:54 PM, Stephen Gallagher wrote: I just tested building this. I see no warnings in this code. Ack. Pushed to master. - -- Stephen Gallagher RHCE 804006346421761 Delivering value year after year. Red Hat ranks #1 in value

Re: [SSSD] [PATCH] Only display errors in unit tests

2009-11-20 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/20/2009 12:48 PM, Simo Sorce wrote: On Fri, 2009-11-20 at 12:18 -0500, Stephen Gallagher wrote: To view output the old (verbose) way, just set CK_VERBOSITY=verbose. This time with the patch attached... This time with the RIGHT patch

Re: [SSSD] [PATCH] Optimize gorup enumerations

2009-11-20 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/20/2009 01:30 PM, Stephen Gallagher wrote: You're welcome. That's why the tests are there. Ack. Pushed to master. - -- Stephen Gallagher RHCE 804006346421761 Delivering value year after year. Red Hat ranks #1 in value among software

Re: [SSSD] [PATCH] raise a couple of timeouts

2009-11-20 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/20/2009 02:48 PM, Stephen Gallagher wrote: On 11/20/2009 02:22 PM, Simo Sorce wrote: They were a bit too strict with high debug levels. Simo. Ack. A note to QA: when this patch is pushed it will probably cause a lot of trouble with