Re: [systemd-devel] systemd doesn't see ttyPS0 devices from udev

Hi, On Wed, Sep 23, 2020 at 04:58:57PM +0800, ZhouPeng wrote: > I find that boot with the 'rescue' option, then exit 'rescue' mode, then > I can login to the ttyPS0, as below You're using a custom kernel, right? Please check the README in the systemd source tree. Specifically the kernel config

Re: [systemd-devel] Bugfix release(s)

On Tue, Jan 15, 2019 at 01:12:13PM +0100, Lennart Poettering wrote: > On Di, 15.01.19 09:51, Michael Olbrich (m.olbr...@pengutronix.de) wrote: > > On Mon, Jan 14, 2019 at 04:36:49PM +0100, Lennart Poettering wrote: > > > I'd love to see some more CI hookup with Arch and

Re: [systemd-devel] Bugfix release(s)

On Mon, Jan 14, 2019 at 04:36:49PM +0100, Lennart Poettering wrote: > I'd love to see some more CI hookup with Arch and Debian for example > (right now there is zero) or even just a git preview package set or so > that interested people can test. Without either it's very likely that > things break

Re: [systemd-devel] ShutdownWatchdogSec does not work as described

On Mon, Mar 19, 2018 at 11:41:33AM +0530, prashantkumar dhotre wrote: > I am observing that ShutdownWatchdogSec setting in system.conf > > In man page, for ShutdownWatchdogSec, I see : > " It works as a safety net to ensure that the reboot takes place even if a > clean reboot attempt

Re: [systemd-devel] stacked automounts

On Fri, Nov 24, 2017 at 09:03:23PM +0100, Olaf Hering wrote: > Is there a way to have stacked automounts? Not really. > In this example only /d is mounted when /d/l/1/ is accessed: > > LABEL=d/d xfs > noatime,x-systemd.automount,x-systemd.idle-timeout=22 1 2 > /d/i/1.iso /d/l/1

Re: [systemd-devel] automount expiry breaks further automounts (was Re: why does bootctl default to /boot and not to /boot/efi?)

On Thu, Jun 02, 2016 at 08:03:31AM +0300, Mantas Mikulėnas wrote: > On Wed, Jun 1, 2016 at 4:51 PM, Lennart Poettering > wrote: > > > On Wed, 01.06.16 09:15, Mantas Mikulėnas (graw...@gmail.com) wrote: > > > > > I'd buy into it if vfat weren't so brittle – several times I

Re: [systemd-devel] [HEADSUP] systemd-222 around the corner

Hi, On Mon, Jul 06, 2015 at 07:54:41PM +0200, David Herrmann wrote: We intend to release v222 tomorrow. If anyone has open issues that need to be in that release, please speak up. Right now, the release consists almost exclusively of bug-fixes, and we want to get those into distributions.

Re: [systemd-devel] [HEADSUP] systemd-222 around the corner

On Tue, Jul 07, 2015 at 10:57:32AM +0200, Kay Sievers wrote: On Tue, Jul 7, 2015 at 10:10 AM, Michael Olbrich m.olbr...@pengutronix.de wrote: On Mon, Jul 06, 2015 at 07:54:41PM +0200, David Herrmann wrote: We intend to release v222 tomorrow. If anyone has open issues that need

Re: [systemd-devel] no tar balls at release time

On Mon, Jun 22, 2015 at 10:21:18PM -0400, Mike Gilbert wrote: On Mon, Jun 22, 2015 at 7:30 PM, Lennart Poettering lenn...@poettering.net wrote: On Tue, 23.06.15 01:21, Kay Sievers (k...@vrfy.org) wrote: We currently considering to stop creating release tar balls. For build systems

Re: [systemd-devel] Minimum required gcc version?

Hi, On Thu, Jun 18, 2015 at 03:20:04PM +0200, Lennart Poettering wrote: On Thu, 18.06.15 14:29, Michael Olbrich (m.olbr...@pengutronix.de) wrote: Do we have a minimum required gcc version? The README just lists gcc without any version. However the current git fails to build with gcc-4.7

Re: [systemd-devel] [HEADSUP] Intend to release 221 by the end of the week

On Mon, Jun 15, 2015 at 05:07:05PM +0200, Lennart Poettering wrote: People asked for a heads-up on this: I intend to prepare v221 by the end of this week. Thanks! It's a good time to start testing what's currently in git! If you take this as hint to start your auto-builder however, then

[systemd-devel] [PATCH] missing: add more btrfs defines

--- src/shared/missing.h | 28 1 file changed, 28 insertions(+) diff --git a/src/shared/missing.h b/src/shared/missing.h index 919400949138..be7f6186fcfb 100644 --- a/src/shared/missing.h +++ b/src/shared/missing.h @@ -269,6 +269,11 @@ struct btrfs_qgroup_inherit {

[systemd-devel] [PATCH] random-util: guard including sys/auxv.h with the corresponding ifdef check

--- src/shared/random-util.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/shared/random-util.c b/src/shared/random-util.c index 88f5182508e7..b230044f5099 100644 --- a/src/shared/random-util.c +++ b/src/shared/random-util.c @@ -23,7 +23,9 @@ #include sys/stat.h #include fcntl.h

[systemd-devel] [PATCH] missing: add more IFLA_VXLAN_* defines

Otherwise building faild with kernel headers v3.16 --- configure.ac | 2 +- src/shared/missing.h | 11 +-- 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/configure.ac b/configure.ac index 48cedb5ab61a..0818dd80cf0c 100644 --- a/configure.ac +++ b/configure.ac @@

Re: [systemd-devel] [PATCH] tmpfiles: try to handle read-only file systems gracefully

On Wed, May 06, 2015 at 04:11:57AM +, Zbigniew Jędrzejewski-Szmek wrote: On Thu, Apr 30, 2015 at 08:50:38PM +0200, Michael Olbrich wrote: On read-only filesystems trying to create the target will not fail with EEXIST but with EROFS. Handle EROFS by checking if the target already exists

[systemd-devel] [PATCH] shared/utmp-wtmp: fix copy/paste error

--- src/shared/utmp-wtmp.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/shared/utmp-wtmp.h b/src/shared/utmp-wtmp.h index 6ac2c7b1c768..5d26ba6fb1d0 100644 --- a/src/shared/utmp-wtmp.h +++ b/src/shared/utmp-wtmp.h @@ -65,7 +65,7 @@ static inline int utmp_wall(

[systemd-devel] [PATCH] tmpfiles: remember errno before it might be overwritten

--- I'm not sure if this is really necessary right now, but that might change in the future. Saving errno before calling another function is always a good idea. Michael src/tmpfiles/tmpfiles.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/tmpfiles/tmpfiles.c

[systemd-devel] [PATCH] tmpfiles: try to handle read-only file systems gracefully

On read-only filesystems trying to create the target will not fail with EEXIST but with EROFS. Handle EROFS by checking if the target already exists, and if empty when truncating. This avoids reporting errors if tmpfiles doesn't actually needs to do anything. --- This is a rework of a patch I

Re: [systemd-devel] [PATCH v2] automount: add expire support

On Tue, Apr 21, 2015 at 08:45:30PM +0200, Lennart Poettering wrote: On Tue, 14.04.15 22:01, Michael Olbrich (m.olbr...@pengutronix.de) wrote: I added some more logging (so that automount_dispatch_expire() can never fail without this being logged) and applied it! I only gave

Re: [systemd-devel] [PATCH] automount: add expire support

On Thu, Apr 02, 2015 at 12:54:00PM +0200, Lennart Poettering wrote: On Sun, 22.03.15 13:36, Michael Olbrich (m.olbr...@pengutronix.de) wrote: Love this work! Thanks. [...] + +if (a-expire_event_source) { +r = sd_event_source_set_time(a-expire_event_source

[systemd-devel] [PATCH v2] automount: add expire support

--- Changes in v2: - addressed comments - check every MAX(a-timeout_idle_usec/10, USEC_PER_SEC) instead of every 5 seconds man/systemd.automount.xml | 8 ++ man/systemd.mount.xml | 9 ++ src/core/automount.c | 221

[systemd-devel] [PATCH] automount: add expire support

--- man/systemd.automount.xml | 8 ++ man/systemd.mount.xml | 9 ++ src/core/automount.c | 209 -- src/core/automount.h | 6 +- src/core/dbus-automount.c | 1 +

Re: [systemd-devel] experiments with 'minimal build'

On Thu, Mar 19, 2015 at 11:37:41PM -0700, Alison Chaiken wrote: Jeff Waugh: The last + is +SYSVINIT, but there doesn't appear to be a configure option to disable sysvinit compatibility anymore. I was wondering about that myself. Try --with-sysvinit-path= --with-sysvrcnd-path=. That should

Re: [systemd-devel] [PATCH] missing.h: add more btrfs types and defines

On Thu, Mar 19, 2015 at 02:05:00PM +0100, David Herrmann wrote: On Wed, Mar 18, 2015 at 2:04 PM, Michael Olbrich m.olbr...@pengutronix.de wrote: it seems we're getting a lot of btrfs stuff here. Maybe we should ship a copy of btrfs.h instead? All these definitions where introduced

[systemd-devel] [PATCH] missing.h: add more btrfs types and defines

--- Hi, it seems we're getting a lot of btrfs stuff here. Maybe we should ship a copy of btrfs.h instead? Michael src/shared/missing.h | 151 +++ 1 file changed, 151 insertions(+) diff --git a/src/shared/missing.h b/src/shared/missing.h index

[systemd-devel] [PATCH] missing.h: add NDA_*

This is necessary to build with older kernel headers. NDA_VLAN was introduced in v3.9 and NDA_PORT, NDA_VNI and NDA_IFINDEX in v3.10 --- configure.ac | 4 +++- src/shared/missing.h | 16 2 files changed, 19 insertions(+), 1 deletion(-) diff --git a/configure.ac

[systemd-devel] unaligned write in dhcp_identifier_set_iaid

Hi, there is an unaligned write in dhcp_identifier_set_iaid() and I'm not quite sure what the correct fix is: int dhcp_identifier_set_iaid(int ifindex, uint8_t *mac, size_t mac_len, uint32_t *_id) { [...] *_id = (id 0x) ^ (id 32); [...] } And this is called with: r =

[systemd-devel] [PATCH] systemctl: don't update the reboot parameter if none is given

Otherwise systemd-reboot.service will remove the parameter that was set before. This was broken in commit b986229efe2cc96157aa14c37bab7843311bbef1 systemctl: bugfix for systemctl reboot command with argument --- This is more a hack than anything else, but I'm not sure who to fix this otherwise.

[systemd-devel] [PATCH] config_parse_set_status: put signals in the correct set

This was broken when the code was rearranged in 1e2fd62d70ff core/load-fragment.c: correct argument sign and split up long lines --- src/core/load-fragment.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/core/load-fragment.c b/src/core/load-fragment.c index

[systemd-devel] [PATCH] missing: define correct syscall numbers for memfd_create() and getrandom() on aarch64

--- Hi, I've tested getrandom(): With 384 the kernel dumps a warning, because the syscall does not exist. With 278 the syscall tracer tells me that it's called when I run e.g. journalctl, so that looks good. I've not tested memfd_create() but it's defined right below getrandom() in

Re: [systemd-devel] Build errors with lto and compat-libs

On Tue, Aug 26, 2014 at 09:42:38PM +0200, Lennart Poettering wrote: On Tue, 26.08.14 15:15, Michael Olbrich (m.olbr...@pengutronix.de) wrote: On Mon, Aug 18, 2014 at 03:48:09PM +0200, Lennart Poettering wrote: On Sun, 17.08.14 09:54, Michael Olbrich (m.olbr...@pengutronix.de) wrote

Re: [systemd-devel] [PATCH] missing: add BPF_XOR

On Thu, Aug 21, 2014 at 01:51:50PM +0200, Michal Sekletar wrote: On Thu, Aug 21, 2014 at 12:38:08PM +0200, Michael Olbrich wrote: BPF_XOR was introduced in kernel 3.7 --- This fixes compiling systemd for me. I'm not sure about the implications of this. I'm not sure what happens

[systemd-devel] [PATCH] missing: add BPF_XOR

BPF_XOR was introduced in kernel 3.7 --- This fixes compiling systemd for me. I'm not sure about the implications of this. I'm not sure what happens if the code using it is executed on a linux kernel 3.7 Michael src/shared/missing.h | 4 1 file changed, 4 insertions(+) diff --git

[systemd-devel] [PATCH 2/2] tmpfiles: explicitly check for existing files

On read-only filesystems trying to create the target will not fail with EEXIST but with EROFS. --- Some more cases that fail on read-only filesystems. src/tmpfiles/tmpfiles.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/src/tmpfiles/tmpfiles.c

[systemd-devel] [PATCHv2 1/2] tmpfiles: only execute chmod()/chown() when needed

This avoids errors like this, when the paths are already there with the correct permissions and owner: chmod(/var/spool) failed: Read-only file system --- Changes since v1: - remember if stat() was successful and use it everywhere. The original code checked for 'stat() = 0'. Any reason for

[systemd-devel] Build errors with lto and compat-libs

Hi, With --enable-compat-libs building fails like this: CCLD libsystemd-journal.la [...] /tmp/ccISOiYU.ltrans1.ltrans.o: In function `sd_journal_process': ccISOiYU.ltrans1.o:(.text+0x0): multiple definition of `sd_journal_process' libsystemd_journal_internal_la-sd-journal.o (symbol from

Re: [systemd-devel] [PATCH] resolved: don't fail if IPv6 is not available

On Wed, Aug 13, 2014 at 03:04:20PM +0200, Lennart Poettering wrote: I applied a different patch now that makes sure we either get the full IPv6 support or none at all, and doesn't generate a warning. Please have a look, if this fixes things for you. This work now. However I had to revert

Re: [systemd-devel] Changing configurations with networkd

On Thu, Aug 14, 2014 at 05:38:05PM +0200, Lennart Poettering wrote: On Fri, 25.07.14 09:48, Michael Olbrich (m.olbr...@pengutronix.de) wrote: What I'm _not_ seeing, and what usually comes when anything else changes in the network configuration is: systemd-timesyncd[348]: Network

[systemd-devel] [PATCH] resolved: don't fail if IPv6 is not available

--- src/resolve/resolved-manager.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/resolve/resolved-manager.c b/src/resolve/resolved-manager.c index a2de2ed..7063af5 100644 --- a/src/resolve/resolved-manager.c +++ b/src/resolve/resolved-manager.c @@ -429,7 +429,9

Re: [systemd-devel] assert() when restarting systemd-networkd

On Wed, Jul 30, 2014 at 06:09:44PM +0200, Tom Gundersen wrote: On Sun, Jul 20, 2014 at 3:12 PM, Michael Olbrich m.olbr...@pengutronix.de wrote: with the current git master (v215-293-g4e6029435111) restarting systemd-networkd triggers an assert() here: In netdev_join_handler

[systemd-devel] systemd-resolved fails without IPv6

Hi, Without IPv6 systemd-resolved fails to start with: Failed to start manager: Address family not supported by protocol strace tells me this is the errno from socket(): [...] socket(PF_INET6, SOCK_DGRAM|SOCK_CLOEXEC|SOCK_NONBLOCK, IPPROTO_IP) = -1 EAFNOSUPPORT (Address family not supported by

Re: [systemd-devel] [patch] #include src/shared/missing.h in src/shared/util.h for missing struct file_handle definition

On Fri, Aug 01, 2014 at 06:37:51PM +0300, Samuli Suominen wrote: On 01/08/14 18:31, Simon McVittie wrote: On 01/08/14 15:53, Simon McVittie wrote: Best-practice in Autotools projects seems to be to include config.h at the very top of every .c file, whether it is currently needed or not.

Re: [systemd-devel] Changing configurations with networkd

Hi, On Thu, Jul 24, 2014 at 11:58:15PM +0200, Tom Gundersen wrote: On Thu, Jul 24, 2014 at 10:54 PM, Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl wrote: On Thu, Jul 24, 2014 at 09:18:14PM +0200, Tom Gundersen wrote: A quick fix would be to set

Re: [systemd-devel] Changing configurations with networkd

On Thu, Jul 24, 2014 at 02:05:24PM +0200, Marcel Holtmann wrote: Right, I spoke too quickly. What I don't want is to preserve state between reboots, preserving it between restarts of networkd would indeed be fine. We already serialize the dhcp leases to /run, so I'd be happy to take a

[systemd-devel] Changing configurations with networkd

Hi, I've been experimenting with systemd-networkd to see where it fits my use-cases. I'm looking for some insight if the issues I'm seeing are bugs, features just not implemented yet or if my use-case is out of scope for networkd. The most common use-case I have is rather simple: One ethernet

Re: [systemd-devel] Changing configurations with networkd

On Wed, Jul 23, 2014 at 12:47:37PM +0200, Tom Gundersen wrote: On Wed, Jul 23, 2014 at 9:50 AM, Michael Olbrich m.olbr...@pengutronix.de wrote: I've been experimenting with systemd-networkd to see where it fits my use-cases. I'm looking for some insight if the issues I'm seeing are bugs

[systemd-devel] assert() when restarting systemd-networkd

Hi, with the current git master (v215-293-g4e6029435111) restarting systemd-networkd triggers an assert() here: In netdev_join_handler(): assert(IN_SET(link-state, LINK_STATE_ENSLAVING, LINK_STATE_FAILED, LINK_STATE_LINGER)); gdb tells me that link-state is

[systemd-devel] [PATCH] units/serial-getty@.service: use the default RestartSec

For pluggable ttys such as USB serial devices, the getty is restarted and exits in a loop until the remove event reaches systemd. Under certain circumstances the restart loop can overload the system in a way that prevents the remove event from reaching systemd for a long time (e.g. at least

[systemd-devel] [PATCH] architecture: fix building for big-endian PowerPC with gcc

gcc does not define WORDS_BIGENDIAN for big-endian PowerPC. It defines __BIG_ENDIAN__ instead. So also check for __BIG_ENDIAN__ to determine if the system is big-endian. --- src/shared/architecture.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/shared/architecture.h

[systemd-devel] [PATCH] tmpfiles: only execute chmod()/chown() when needed

This avoids errors like this, when the paths are already there with the correct permissions and owner: chmod(/var/spool) failed: Read-only file system --- src/tmpfiles/tmpfiles.c | 36 +--- 1 file changed, 21 insertions(+), 15 deletions(-) diff --git

Re: [systemd-devel] [PATCH] architecture: fix building for big-endian PowerPC with gcc

On Fri, Jul 11, 2014 at 03:27:56PM +0200, Lennart Poettering wrote: On Fri, 11.07.14 15:04, Michael Olbrich (m.olbr...@pengutronix.de) wrote: gcc does not define WORDS_BIGENDIAN for big-endian PowerPC. It defines __BIG_ENDIAN__ instead. So also check for __BIG_ENDIAN__ to determine

Re: [systemd-devel] [PATCH] architecture: fix building for big-endian PowerPC with gcc

On Fri, Jul 11, 2014 at 04:01:32PM +0200, Lennart Poettering wrote: On Fri, 11.07.14 15:43, Dan Horák (d...@danny.cz) wrote: Hmm, the sources currently use three different ways to detect endianess: 1) WORDS_BIGENDIAN (which appears to be an autoconf thing actually, enabled via

[systemd-devel] systemd-networkd-wait-online and network.target

Hi, Commit 58e027023b47b32e42cf93dd4a629b869ee1ef25 'units: order network-online.target after network.target' added Before=network.target dependency to systemd-networkd-wait-online.service. Is that correct? If I understand the documentation correctly, then network.target should not be delayed.

[systemd-devel] [PATCH] install: enable timesyncd by default

This treats it similarly to networkd, resolved and others and it matches what 90-systemd.preset does. --- Makefile.am | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Makefile.am b/Makefile.am index 4b292b2..bfef1c3 100644 --- a/Makefile.am +++ b/Makefile.am @@ -4301,6 +4301,9 @@

[systemd-devel] [PATCH v2 2/2] service: rename StartLimitAction enum to FailureAction

It's used for the FailureAction property as well. --- Changes since v1: - rebased on latest master - also rename things in src/test/test-tables.c src/core/dbus-service.c | 6 +++--- src/core/load-fragment-gperf.gperf.m4 | 4 ++-- src/core/load-fragment.c | 4 ++--

[systemd-devel] [PATCH v2 1/2] service: add FailureAction= option

It has the same possible values as StartLimitAction= and is executed immediately if a service fails. --- Changes since v1: - rebased on latest master man/systemd.service.xml | 11 ++ src/core/dbus-service.c | 1 + src/core/load-fragment-gperf.gperf.m4 | 1 +

[systemd-devel] [PATCH 1/2] service: add FailureAction= option

It has the same possible values as StartLimitAction= and is executed immediately if a service fails. --- man/systemd.service.xml | 11 +++ src/core/dbus-service.c | 1 + src/core/load-fragment-gperf.gperf.m4 | 1 + src/core/service.c| 35

[systemd-devel] [PATCH 2/2] service: rename StartLimitAction enum to FailureAction

It's used for the FailureAction property as well. --- src/core/dbus-service.c | 6 +++--- src/core/load-fragment-gperf.gperf.m4 | 4 ++-- src/core/load-fragment.c | 4 ++-- src/core/load-fragment.h | 2 +- src/core/service.c| 28

Re: [systemd-devel] [RFC PATCH] service: add FailureAction= option

On Fri, Apr 11, 2014 at 04:07:46PM +0200, Lennart Poettering wrote: On Fri, 11.04.14 09:48, Michael Olbrich (m.olbr...@pengutronix.de) wrote: +else if (allow_restart I would drop the else here, I think. Is there a reason not to do the restart thing anyway

Re: [systemd-devel] [RFC PATCH] service: add FailureAction= option

On Fri, Apr 11, 2014 at 03:34:42AM +0200, Lennart Poettering wrote: On Wed, 26.03.14 10:02, Michael Olbrich (m.olbr...@pengutronix.de) wrote: It has the same possible values as StartLimitAction= and is executed immediately if a service fails. I think the enum type should probably

Re: [systemd-devel] [PATCH 1/2] systemctl: delete REBOOT_PARAM_FILE if no parameter is specified

On Tue, Mar 25, 2014 at 02:15:44PM +0100, Michael Olbrich wrote: And move it to sperate function. Ping! No comments at all? Michael --- src/shared/util.c | 16 src/shared/util.h | 2 ++ src/systemctl/systemctl.c | 9 +++-- 3 files changed, 21

[systemd-devel] systemd v212 build error

Hi, compiling systemd v212 fails here with: [...] src/libsystemd/sd-rtnl/rtnl-message.c: In function 'sd_rtnl_message_append_u8': src/libsystemd/sd-rtnl/rtnl-message.c:462:38: error: 'IFLA_IPTUN_TTL' undeclared (first use in this function) src/libsystemd/sd-rtnl/rtnl-message.c:462:38: note: each

[systemd-devel] [RFC PATCH] service: add FailureAction= option

It has the same possible values as StartLimitAction= and is executed immediately if a service fails. --- Hi Lennart, Something like this maybe? I'm not quite sure about the condition in service_enter_dead(). I don't think the action should be executed when the service is explicitly stopped.

Re: [systemd-devel] [RFC PATCH] service: add FailureAction= option

On Wed, Mar 26, 2014 at 10:19:53AM +, Jóhann B. Guðmundsson wrote: On 03/26/2014 09:02 AM, Michael Olbrich wrote: It has the same possible values as StartLimitAction= and is executed immediately if a service fails. --- Hi Lennart, Something like this maybe? I'm not quite sure about

[systemd-devel] [PATCH 2/2] service: add support for reboot argument when triggered by StartLimitAction=

When rebooting with systemctl, an optional argument can be passed to the reboot system call. This makes it possible the specify the argument in a service file and use it when the service triggers a restart. This is useful to distinguish between manual reboots and reboots caused by failing

Re: [systemd-devel] [RFC PATCH] service: add Restart option to execute StartLimitAction immediately

Hi, On Mon, Mar 24, 2014 at 08:30:09PM +0100, Lennart Poettering wrote: On Thu, 20.03.14 12:52, Michael Olbrich (m.olbr...@pengutronix.de) wrote: The idea is to reboot immediately when a service crashes or the watchdog triggers. This is useful in embedded scenarios when there is only one

[systemd-devel] [PATCH] service: add support for reboot argument when triggered by StartLimitAction=

When rebooting with systemctl, an optional argument can be passed to the reboot system call. This makes it possible the specify the argument in a service file and use it when the service triggers a restart. This is useful to distinguish between manual reboots and reboots caused by failing

[systemd-devel] [RFC PATCH] service: add Restart option to execute StartLimitAction immediately

--- Hi, The idea is to reboot immediately when a service crashes or the watchdog triggers. This is useful in embedded scenarios when there is only one important service. There are use-cases where rebooting immediately instead of trying to restart the application first makes sense. The

[systemd-devel] [PATCH] networkd: fix typo

It's HAVE_SPLIT_USR not HAVE_SPLIT_USER --- src/network/networkd-manager.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/network/networkd-manager.c b/src/network/networkd-manager.c index c730e71..ea414b1 100644 --- a/src/network/networkd-manager.c +++

Re: [systemd-devel] [patch] Fix AC_PATH_PROG usage in configure.ac for systems with (still) bin vs. sbin distiction

On Sun, Mar 09, 2014 at 08:49:58PM +0100, Michael Biebl wrote: 2014-03-08 8:52 GMT+01:00 Samuli Suominen ssuomi...@gentoo.org: If eg. setcap is in /sbin and user is building as a normal user without $PATH having /sbin, the build system will default to /usr/sbin/setcap as it's defined in

Re: [systemd-devel] [patch] Fix AC_PATH_PROG usage in configure.ac for systems with (still) bin vs. sbin distiction

On Mon, Mar 10, 2014 at 02:13:38PM +0200, Samuli Suominen wrote: On 10/03/14 13:23, Michael Olbrich wrote: On Sun, Mar 09, 2014 at 08:49:58PM +0100, Michael Biebl wrote: 2014-03-08 8:52 GMT+01:00 Samuli Suominen ssuomi...@gentoo.org: If eg. setcap is in /sbin and user is building

[systemd-devel] [PATCH RFC] namespace: make sure ReadWriteDirectories are actually writable

Currently adding directories to ReadWriteDirectories= only restores the original mount flags. So e.g. setting ReadOnlyDirectories=/usr and ReadWriteDirectories=/usr/local works as expected if the underlying file system was writable. However, setting ReadWriteDirectories= has no effect if the

Re: [systemd-devel] [PATCH RFC] namespace: make sure ReadWriteDirectories are actually writable

On Fri, Dec 27, 2013 at 05:52:16PM +0100, Zbigniew Jędrzejewski-Szmek wrote: On Fri, Dec 27, 2013 at 10:18:30AM +0100, Michael Olbrich wrote: Currently adding directories to ReadWriteDirectories= only restores the original mount flags. So e.g. setting ReadOnlyDirectories=/usr

Re: [systemd-devel] [PATCH] service: don't try to kill the service more than once when the watchdog timeout hits

Hi, On Wed, Jul 17, 2013 at 03:53:09AM +0200, Lennart Poettering wrote: On Wed, 12.06.13 01:22, Michael Olbrich (m.olbr...@pengutronix.de) wrote: If ExecStopPost= is defined then it is executed after SIGKILL. Otherwise another round of SIGTERM/SIGSTOP is started which is rather useless

Re: [systemd-devel] [PATCH] service: don't enter a second SIGTERM/SIGKILL cycle if no ExecStopPost= process is defined

On Wed, Jun 12, 2013 at 08:45:35AM +0200, Michael Olbrich wrote: It won't help if the main process is still there and there is no new process to kill. --- Hi, The second SIGTERM/SIGKILL is to kill ExecStopPost= if necessary, right? In that case, this is a better solution. Can anyone

Re: [systemd-devel] start/stop messages when activating a target?

Hi, On Wed, Jun 12, 2013 at 07:02:34AM +0400, Andrey Borzenkov wrote: В Wed, 12 Jun 2013 01:32:37 +0200 Michael Olbrich m.olbr...@pengutronix.de пишет: Hi, When booting or during shutdown systemd prints the start stop messages for the services. Is it possible to get those messages

[systemd-devel] [PATCH] service: don't enter a second SIGTERM/SIGKILL cycle if no ExecStopPost= process is defined

It won't help if the main process is still there and there is no new process to kill. --- Hi, The second SIGTERM/SIGKILL is to kill ExecStopPost= if necessary, right? In that case, this is a better solution. Michael src/core/service.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[systemd-devel] [PATCH] service: don't try to kill the service more than once when the watchdog timeout hits

If ExecStopPost= is defined then it is executed after SIGKILL. Otherwise another round of SIGTERM/SIGSTOP is started which is rather useless when the watchdog timeout hits. So go directly to the final SIGKILL if ExecStopPost= is not defined. --- Hi, I did some more testing with this. I think

[systemd-devel] start/stop messages when activating a target?

Hi, When booting or during shutdown systemd prints the start stop messages for the services. Is it possible to get those messages when activating a target with systemctl? Regards, Michael -- Pengutronix e.K. | | Industrial Linux Solutions

[systemd-devel] build problems without largefile support

Hi, I tried to compile systemd with --disable-largefile and I got this: [...] src/shared/util.c: In function 'parse_bytes': src/shared/util.c:2270:17: error: overflow in implicit constant conversion [-Werror=overflow] src/shared/util.c:2271:17: error: overflow in implicit constant conversion

[systemd-devel] [PATCH] ratelimit: fix off-by-one

The current code might make sense during startup for service restart limiting: With burst=1 after starting num is 1, so the next ('first') restart is still accepted ( 1 = 1). However, once interval has expired, num is 1 after the first restart, so the second restart is also accepted. This change

Re: [systemd-devel] [HEADS-UP] systemd down/upstream meeting at FOSDEM?

Hi, On Tue, Jan 22, 2013 at 11:11:22PM +0100, Lennart Poettering wrote: I just learned that a number of systemd downstream and upstream folks are attending FOSDEM. We'll at least have Michael Biebl, Tollef Fog Heen, Colin Guthrie, Kay Sievers, Harald Hoyer and myself around. We were

[systemd-devel] [PATCH 1/2] service: really stop watchdog timer when stopping

For services without ExecStop= the state SERVICE_STOP is never entered. as a result the watchdog timer is not stopped and the service is restarted (if it is configuered to restart). Stopping the watchdog timer for SERVICE_STOP_SIGTERM as well fixes this. --- src/core/service.c |2 +- 1 file

[systemd-devel] [PATCH 2/2] service: make sure the watchdog timer is not restarted while stopping

A watchdog notification may be handled after the watchdog timer was stopped while stopping the service. As a result the timer is restarted and the service may be restarted as well. The watchdog timestamp is initially set during startup in service_enter_start_post() and cleared when the timer is

[systemd-devel] [PATCH] make sure __NR_name_to_handle_at is correctly defined

341 is only valid for x86, so don't use it for other architectures. Add the correct numbers for ARM and PowerPC while at it. --- src/shared/missing.h | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/src/shared/missing.h b/src/shared/missing.h index

Re: [systemd-devel] journald leaking maps?

On Fri, Oct 12, 2012 at 04:31:46AM -0400, Dave Reisner wrote: On Fri, Oct 12, 2012 at 09:19:08AM +0100, Colin Guthrie wrote: 'Twas brillig, and David Strauss at 12/10/12 05:39 did gyre and gimble: On Thu, Oct 11, 2012 at 3:31 PM, Colin Guthrie gm...@colin.guthr.ie wrote: Something is

Re: [systemd-devel] journald leaking maps?

On Fri, Oct 12, 2012 at 03:58:06PM +0100, Colin Guthrie wrote: 'Twas brillig, and Michael Olbrich at 12/10/12 09:52 did gyre and gimble: On Fri, Oct 12, 2012 at 04:31:46AM -0400, Dave Reisner wrote: On Fri, Oct 12, 2012 at 09:19:08AM +0100, Colin Guthrie wrote: 'Twas brillig, and David

[systemd-devel] [PATCH] check for name_to_handle_at declaration instead of its definition

AC_CHECK_FUNCS may be successful, even though name_to_handle_at and 'struct file_handle' are not available. --- This really looks like something to fix in libc. I mean, supporting libcs with and without this function makes sense, but supporting an (obviously broken/contradicting) glibc that

[systemd-devel] [PATCH v2] check for name_to_handle_at declaration instead of its definition

AC_CHECK_FUNCS may be successful, even though name_to_handle_at and 'struct file_handle' are not available. --- #if !HAVE_DECL_NAME_TO_HANDLE_AT is the correct test... configure.ac |7 --- src/shared/missing.h |2 +- 2 files changed, 5 insertions(+), 4 deletions(-) diff

[systemd-devel] Problems with name_to_handle_at

Hi, compiling the latest systemd fails with: [...] src/shared/path-util.c: In function 'path_is_mount_point': src/shared/path-util.c:348:10: error: dereferencing pointer to incomplete type src/shared/path-util.c:350:9: warning: implicit declaration of function 'name_to_handle_at'

[systemd-devel] [PATCH] libsystemd-core needs libsystemd-id128-internal

Otherwise compiling may fail with e.g.: ./.libs/libsystemd-core.a(libsystemd_core_la-condition.o): In function `test_host': [...]/systemd-189/src/core/condition.c:205: undefined reference to `sd_id128_from_string' [...]/systemd-189/src/core/condition.c:207: undefined reference to

[systemd-devel] [PATCH] journal: don't try to compress without XZ

otherwise the header contains the HEADER_INCOMPATIBLE_COMPRESSED flag even though the data is not compressed and reading the journal fails. --- Hi, I'm not sure if this is the correct place to do this, but the default 'compress = yes' must be ignored somewhere otherwise journalctl will not work

Re: [systemd-devel] setting up to allow separate udev and systemd builds

On Wed, Jun 20, 2012 at 09:38:22AM +0200, Olav Vitters wrote: On Tue, Jun 19, 2012 at 06:44:25PM +0200, Michael Olbrich wrote: This is not about the files from systemd. It's about the dependencies. Every user of a source based distro, that only wants systemd now has to first install dbus

Re: [systemd-devel] ssh socket activation (Was: systemd unit files for Debian based systems)

On Tue, Jun 19, 2012 at 07:45:47PM +0200, Lennart Poettering wrote: On Tue, 19.06.12 23:40, Alexander E. Patrakov (patra...@gmail.com) wrote: IMHO there is one issue with the inetd-style approach: it is explicitly discouraged in man sshd. It may well be the case of outdated documentation,

Re: [systemd-devel] setting up to allow separate udev and systemd builds

On Wed, Jun 20, 2012 at 01:46:40PM +0200, Olav Vitters wrote: On Wed, Jun 20, 2012 at 01:32:52PM +0200, Michael Olbrich wrote: On Wed, Jun 20, 2012 at 09:38:22AM +0200, Olav Vitters wrote: On Tue, Jun 19, 2012 at 06:44:25PM +0200, Michael Olbrich wrote: This is not about the files from

Re: [systemd-devel] setting up to allow separate udev and systemd builds

On Tue, Jun 19, 2012 at 11:21:58AM +0200, Lennart Poettering wrote: On Fri, 15.06.12 20:06, Bryan Kadzban (br...@kadzban.is-a-geek.net) wrote: dbus libcap I am quite happy with depending on these two as it makes little sense to build an OS without it, unless you go super minimal in which

Re: [systemd-devel] setting up to allow separate udev and systemd builds

On Tue, Jun 19, 2012 at 01:59:14PM +0200, Kay Sievers wrote: On Tue, Jun 19, 2012 at 1:10 PM, Michael Olbrich m.olbr...@pengutronix.de wrote: On Tue, Jun 19, 2012 at 11:21:58AM +0200, Lennart Poettering wrote: On Fri, 15.06.12 20:06, Bryan Kadzban (br...@kadzban.is-a-geek.net) wrote: dbus

Re: [systemd-devel] setting up to allow separate udev and systemd builds

On Tue, Jun 19, 2012 at 11:13:50AM +0200, Lennart Poettering wrote: On Thu, 14.06.12 21:32, William Hubbs (w.d.hu...@gmail.com) wrote: Yes, we could, but what about exherbo, funtoo, linux from scratch and the other source based distros that may be out there? I fail to see what this has

[systemd-devel] ssh socket activation (Was: systemd unit files for Debian based systems)

Hi, On Tue, Jun 19, 2012 at 10:03:23AM +0200, Lennart Poettering wrote: On Mon, 18.06.12 21:56, Paul Menzel (paulepan...@users.sourceforge.net) wrote: Do you know of a service file for openssh-server? The Fedora packages have some, but I don't like them too much since they don't use

[systemd-devel] [PATCH 1/3] dbus: add data argument to BusPropertySetCallback

BusPropertyCallback already has the argument. It is necesary for the callback to know what data to access. --- src/dbus-common.c |6 +- src/dbus-common.h |2 +- src/dbus-manager.c |4 ++-- 3 files changed, 8 insertions(+), 4 deletions(-) diff --git a/src/dbus-common.c

  1   2   >