[systemd-devel] Significant performance loss caused by commit a65f06b: journal: return -ECHILD after a fork

2017-07-07 Thread vcaputo
In doing some casual journalctl profiling and stracing, it became apparent that `journalctl -b --no-pager` runs across a significant quantity of logs, ~10% of the time was thrown away on getpid() calls due to commmit a65f06b. As-is: # time ./journalctl -b --no-pager > /dev/null real

Re: [systemd-devel] Significant performance loss caused by commit a65f06b: journal: return -ECHILD after a fork

2017-07-07 Thread vcaputo
On Fri, Jul 07, 2017 at 01:49:54PM -0700, vcap...@pengaru.com wrote: > On Fri, Jul 07, 2017 at 08:37:08PM +, Mantas Mikulėnas wrote: > > Back when that commit was made, didn't glibc cache the getpid() result in > > userspace? That would explain why it was not noticed. > > Hmm, this crossed my

Re: [systemd-devel] Significant performance loss caused by commit a65f06b: journal: return -ECHILD after a fork

2017-07-07 Thread vcaputo
On Fri, Jul 07, 2017 at 10:34:22PM +, Zbigniew Jędrzejewski-Szmek wrote: > On Fri, Jul 07, 2017 at 02:35:16PM -0700, vcap...@pengaru.com wrote: > > On Fri, Jul 07, 2017 at 01:49:54PM -0700, vcap...@pengaru.com wrote: > > > On Fri, Jul 07, 2017 at 08:37:08PM +, Mantas Mikulėnas wrote: > > >

Re: [systemd-devel] Github systemd issue 6237

2017-07-07 Thread Kai Krakow
Am Tue, 4 Jul 2017 21:23:01 + (UTC) schrieb Alexander Bisogiannis : > On Tue, 04 Jul 2017 17:21:01 +, Zbigniew Jędrzejewski-Szmek wrote: > > > If you need root permissions to create a unit, then it's not a > > security issue. An annoyance at most. > > The fact that

Re: [systemd-devel] Significant performance loss caused by commit a65f06b: journal: return -ECHILD after a fork

2017-07-07 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Jul 07, 2017 at 02:35:16PM -0700, vcap...@pengaru.com wrote: > On Fri, Jul 07, 2017 at 01:49:54PM -0700, vcap...@pengaru.com wrote: > > On Fri, Jul 07, 2017 at 08:37:08PM +, Mantas Mikulėnas wrote: > > > Back when that commit was made, didn't glibc cache the getpid() result in > > >

Re: [systemd-devel] Github systemd issue 6237

2017-07-07 Thread Michael Chapman
On Sat, 8 Jul 2017, Kai Krakow wrote: [...] The bug here is that a leading number will "convert" to the number and it actually runs with the UID specified that way: 0day = 0, 7days = 7. No, this is not the case. Only all-digit User= values are treated as UIDs.

Re: [systemd-devel] Significant performance loss caused by commit a65f06b: journal: return -ECHILD after a fork

2017-07-07 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Jul 07, 2017 at 03:54:09PM -0700, vcap...@pengaru.com wrote: > On Fri, Jul 07, 2017 at 10:34:22PM +, Zbigniew Jędrzejewski-Szmek wrote: > > On Fri, Jul 07, 2017 at 02:35:16PM -0700, vcap...@pengaru.com wrote: > > > On Fri, Jul 07, 2017 at 01:49:54PM -0700, vcap...@pengaru.com wrote: >

Re: [systemd-devel] Github systemd issue 6237

2017-07-07 Thread Reindl Harald
Am 07.07.2017 um 21:55 schrieb Kai Krakow: Am Tue, 4 Jul 2017 21:23:01 + (UTC) schrieb Alexander Bisogiannis : On Tue, 04 Jul 2017 17:21:01 +, Zbigniew Jędrzejewski-Szmek wrote: If you need root permissions to create a unit, then it's not a security issue. An

Re: [systemd-devel] Significant performance loss caused by commit a65f06b: journal: return -ECHILD after a fork

2017-07-07 Thread vcaputo
Hmm, this crossed my mind, and come to think of it I did a dist-upgrade from Debian jessie to stretch overnight machine and haven't rebooted. Perhaps the vdso isn't working and the costly getpid() is a red herring, will reboot and retest to confirm. On Fri, Jul 07, 2017 at 08:37:08PM +,

Re: [systemd-devel] Significant performance loss caused by commit a65f06b: journal: return -ECHILD after a fork

2017-07-07 Thread Mantas Mikulėnas
Back when that commit was made, didn't glibc cache the getpid() result in userspace? That would explain why it was not noticed. On Fri, Jul 7, 2017, 23:18 wrote: > In doing some casual journalctl profiling and stracing, it became apparent > that `journalctl -b --no-pager`

Re: [systemd-devel] Significant performance loss caused by commit a65f06b: journal: return -ECHILD after a fork

2017-07-07 Thread vcaputo
On Fri, Jul 07, 2017 at 01:49:54PM -0700, vcap...@pengaru.com wrote: > On Fri, Jul 07, 2017 at 08:37:08PM +, Mantas Mikulėnas wrote: > > Back when that commit was made, didn't glibc cache the getpid() result in > > userspace? That would explain why it was not noticed. > > Hmm, this crossed my

Re: [systemd-devel] Timeout for 'Activating (start)' status

2017-07-07 Thread Mikhail Kasimov
Hello, everyone! 06.07.2017 19:17, Mikhail Kasimov пишет: > > 06.07.2017 19:12, Mikhail Kasimov пишет: >> 06.07.2017 18:27, Michael Chapman пишет: >>> On Fri, 7 Jul 2017, Mikhail Kasimov wrote: 06.07.2017 17:18, Michael Chapman пишет: > On Thu, 6 Jul 2017, Mikhail Kasimov wrote: >>