ifconfig magic number

2017-03-20 Thread Stefan Sperling
Replace a magic number with the corresponding macro. Index: ifconfig.c === RCS file: /cvs/src/sbin/ifconfig/ifconfig.c,v retrieving revision 1.339 diff -u -p -r1.339 ifconfig.c --- ifconfig.c 12 Mar 2017 03:18:57 - 1.339

Re: skeylogin.c: use arc4random_buf instead of /var/db/host.random

2017-03-20 Thread Ted Unangst
Theo Buehler wrote: > libskey reads directly from /var/db/host.random and falls back to the > ctime of /dev/mem or / for generating the fake prompt for the user. > This could be simplified a bit: yeesh, that's very silly. ok

wpa key vs wep key

2017-03-20 Thread Stefan Sperling
I see no reason to leave WEP enabled if a WPA key is set, and leaving WPA enabled when a WEP key is set. Several cases of "my wifi suddenly stopped working" turned out to be due to stale WEP keys interfering with WPA. I think it is better to let the kernel handle this transition instead of

Re: Add a "random" target to bsd.regress.mk

2017-03-20 Thread Scott Cheloha
> On Mar 18, 2017, at 8:48 PM, trondd wrote: > > [...] > > Actually, rereading what I quoted, I see you're concerned with unmasking > false positives, which can be manually rerun in isolation to reproduce. > My thought still stands for the flip-side where a test fails

log.c warn severity

2017-03-20 Thread Alexander Bluhm
Hi, >From a syslog perspective it does not make sense to log fatal and warn with the same severity. I would like to switch log_warn() to LOG_ERR and keep fatal() at LOG_CRIT. ok? bluhm Index: /usr/src/sbin/dhclient/log.c === RCS

Re: skeylogin.c: use arc4random_buf instead of /var/db/host.random

2017-03-20 Thread Todd C. Miller
On Mon, 20 Mar 2017 21:06:23 +0100, Theo Buehler wrote: > libskey reads directly from /var/db/host.random and falls back to the > ctime of /dev/mem or / for generating the fake prompt for the user. You should also remove SKEY_RAND_FILE_PATH from skey.h. OK millert@ with that removed. - todd

skeylogin.c: use arc4random_buf instead of /var/db/host.random

2017-03-20 Thread Theo Buehler
libskey reads directly from /var/db/host.random and falls back to the ctime of /dev/mem or / for generating the fake prompt for the user. This could be simplified a bit: Index: skeylogin.c === RCS file:

Re: amd64 struct reg

2017-03-20 Thread Dale Rahn
On Mon, Mar 20, 2017 at 09:15:09AM -0700, Philip Guenther wrote: > On Mon, 20 Mar 2017, Dale Rahn wrote: > ... > > Including the thread pointer would seem to make sense, but there is there > > a proc vs process issue there (thread vs p > > Uh, the registers are _all_ per-thread! > > > Philip >

Re: amd64 struct reg

2017-03-20 Thread Philip Guenther
On Mon, 20 Mar 2017, Dale Rahn wrote: ... > Including the thread pointer would seem to make sense, but there is there > a proc vs process issue there (thread vs p Uh, the registers are _all_ per-thread! Philip

Re: amd64 struct reg

2017-03-20 Thread Dale Rahn
On Mon, Mar 20, 2017 at 11:54:03AM +0100, Mark Kettenis wrote: > > Date: Mon, 20 Mar 2017 13:31:32 +1100 > > From: Jonathan Gray > > Cc: tech@openbsd.org > > Mail-Followup-To: Mark Kettenis , tech@openbsd.org > > Content-Disposition: inline > >

Re: [PATCH] sensorsd - Command line switch for alternative configuration file

2017-03-20 Thread Alexander Bluhm
On Wed, Mar 15, 2017 at 08:49:17AM +0100, Silamael wrote: > On 14.03.2017 12:55, Alexander Bluhm wrote: > > All other error messages are lower case. I would write "err(1, > > "access configuration file %s", configfile)" as err(3) privides a > > reason anyway. > > > > apart from that OK bluhm@ >

Re: Add a "random" target to bsd.regress.mk

2017-03-20 Thread Alexander Bluhm
On Sat, Mar 18, 2017 at 05:42:20PM -0500, Scott Cheloha wrote: > My thinking is that statically ordered regression runs can mask > bugs in the software under test and the tests themselves. I would expect to find more issues in the tests than in the software. > In general, a test can put your

Re: amd64 struct reg

2017-03-20 Thread Mark Kettenis
> Date: Mon, 20 Mar 2017 13:31:32 +1100 > From: Jonathan Gray > Cc: tech@openbsd.org > Mail-Followup-To: Mark Kettenis , tech@openbsd.org > Content-Disposition: inline > X-XS4ALL-DNSBL-Checked: mxdrop306.xs4all.net checked 210.15.216.215 against > DNS

efi: device i/o protocol has been replaced

2017-03-20 Thread Patrick Wildt
Hi, the Device I/O Protocol has been replaced by the PCI Root Bridge I/O protocol. Since we don't make use of it I think it makes sense to remove the protocol from our headers to actively discourage the use of that protocol. Instead it would make sense to add the PCI Root Bridge I/O protocol

Re: acme-client doc diff

2017-03-20 Thread Stuart Henderson
On 2017/03/18 15:07, Nick Holland wrote: > .It Fl A > -Create a new RSA account key if one does not already exist. > +Create a new RSA account (host) key if one does not already exist. The -A key is for the letsencrypt account, "host key" implies to me that it's the key for the cert you're