Re: openssl(1) remove redundant defines

2015-09-10 Thread Brent Cook
On Wed, Sep 9, 2015 at 9:43 PM, Lawrence Teo wrote: > On Wed, Sep 09, 2015 at 11:17:55AM -0500, Brent Cook wrote: >> On Wed, Sep 9, 2015 at 10:15 AM, Todd C. Miller >> wrote: >> > On Wed, 09 Sep 2015 10:02:17 -0400, Lawrence Teo wrote: >> >> In

Re: openssl(1) remove redundant defines

2015-09-10 Thread Bob Beck
make it so.. ok beck@ On Thu, Sep 10, 2015 at 1:06 AM, Brent Cook wrote: > On Wed, Sep 9, 2015 at 9:43 PM, Lawrence Teo wrote: >> On Wed, Sep 09, 2015 at 11:17:55AM -0500, Brent Cook wrote: >>> On Wed, Sep 9, 2015 at 10:15 AM, Todd C. Miller >>>

openssl(1) remove redundant defines

2015-09-09 Thread Lawrence Teo
This diff removes redundant defines in two files. In s_socket.c, SOCKET_PROTOCOL is defined as IPPROTO_TCP, but it's only used once. In s_time.c, NO_SHUTDOWN is always defined, so there is no need for a bunch of NO_SHUTDOWN #ifdef blocks. No binary change. ok? Index: s_socket.c

Re: openssl(1) remove redundant defines

2015-09-09 Thread Todd C. Miller
On Wed, 09 Sep 2015 10:02:17 -0400, Lawrence Teo wrote: > This diff removes redundant defines in two files. > > In s_socket.c, SOCKET_PROTOCOL is defined as IPPROTO_TCP, but it's only > used once. OK. > In s_time.c, NO_SHUTDOWN is always defined, so there is no need for a > bunch of

Re: openssl(1) remove redundant defines

2015-09-09 Thread Brent Cook
On Wed, Sep 9, 2015 at 10:15 AM, Todd C. Miller wrote: > On Wed, 09 Sep 2015 10:02:17 -0400, Lawrence Teo wrote: > >> This diff removes redundant defines in two files. >> >> In s_socket.c, SOCKET_PROTOCOL is defined as IPPROTO_TCP, but it's only >> used once. > > OK. >

Re: openssl(1) remove redundant defines

2015-09-09 Thread Lawrence Teo
On Wed, Sep 09, 2015 at 11:17:55AM -0500, Brent Cook wrote: > On Wed, Sep 9, 2015 at 10:15 AM, Todd C. Miller > wrote: > > On Wed, 09 Sep 2015 10:02:17 -0400, Lawrence Teo wrote: > >> In s_time.c, NO_SHUTDOWN is always defined, so there is no need for a > >> bunch of