Re: [PATCH] fixes relayd Websocket "Connection: close" header when Upgrade is requested

2021-02-16 Thread Stuart Henderson
On 2021/02/16 20:12, Franz Bettag wrote: > My point, the protocol after HTTP 1.0 encourages keep-alives anyway. > Close is only default in 1.0 so basically you wouldn’t have lingering > dead sockets on your server. If you want a full featured HTTP implementation then perhaps relayd is not for

Re: [PATCH] fixes relayd Websocket "Connection: close" header when Upgrade is requested

2021-02-16 Thread Stuart Henderson
Clearly the current behaviour with two Connection headers is wrong and this may be a correct diff, but the description accompanying it only considers "how does this fix the problem seen" rather than "what are the implications of this, does it do anything bad?". I'm only making very minimal use of

Re: [PATCH] fixes relayd Websocket "Connection: close" header when Upgrade is requested

2021-02-16 Thread Franz Bettag
At least someone besides me cares about correct protocols in base daemons :] Sent from my iPhone > On 14 Feb 2021, at 12:06, Marcus MERIGHI wrote: > > Another month has passed, another friendly bump... > > patch against -current attached, for convenience... > > Marcus > > Index:

Re: [PATCH] fixes relayd Websocket "Connection: close" header when Upgrade is requested

2021-02-14 Thread Marcus MERIGHI
Another month has passed, another friendly bump... patch against -current attached, for convenience... Marcus Index: relay_http.c === RCS file: /cvs/src/usr.sbin/relayd/relay_http.c,v retrieving revision 1.80 diff -u -p -u -r1.80

Re: [PATCH] fixes relayd Websocket "Connection: close" header when Upgrade is requested

2021-01-04 Thread Marcus MERIGHI
One month has passed, this is just a friendly ping... Marcus mcmer-open...@tor.at (Marcus MERIGHI), 2020.12.04 (Fri) 14:18 (CET): > This patch wasn't commited and not discussed (publicly). > > It lets me use relayd as a front-end to the mattermost-server. > > @franz: Thank you! > >

Re: [PATCH] fixes relayd Websocket "Connection: close" header when Upgrade is requested

2020-12-04 Thread Franz Bettag
thanks for bringing it up again, i always have to patch multiple relayds after upgrades. -.- Sent from my iPad > On 4. Dec 2020, at 14:18, Marcus MERIGHI wrote: > > Hello! > > This patch wasn't commited and not discussed (publicly). > > It lets me use relayd as a front-end to the

Re: [PATCH] fixes relayd Websocket "Connection: close" header when Upgrade is requested

2020-12-04 Thread Marcus MERIGHI
Hello! This patch wasn't commited and not discussed (publicly). It lets me use relayd as a front-end to the mattermost-server. Just a friendly reminder... @franz: Thank you! Marcus fr...@bett.ag (Franz Bettag), 2020.03.04 (Wed) 17:52 (CET): > After migrating my home setup from nginx reverse

[PATCH] fixes relayd Websocket "Connection: close" header when Upgrade is requested

2020-03-04 Thread Franz Bettag
After migrating my home setup from nginx reverse proxying to relayd, i noticed my iOS devices having issues connecting through Websockets. After debugging, i noticed that relayd adds the "Connection: close" regardless of upgrade being requested. This issue is also reported on a blog-post using