Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/loader WebappClassLoader.java

2005-09-28 Thread Jan Luehe
Remy, Remy Maucherat wrote On 09/28/05 03:12,: [EMAIL PROTECTED] wrote: +/* + * Clear the IntrospectionUtils cache. + * + * Implementation note: + * Any reference to IntrospectionUtils which may cause the static + * initalizer of that

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/loader WebappClassLoader.java

2005-09-28 Thread Jan Luehe
Remy, Remy Maucherat wrote On 09/28/05 10:18,: Jan Luehe wrote: We have seen the ThreadDeath in our callstacks, hence this fix. Nobody is reading what I am writing anymore ... No, I did. I wrote: The static initializer is called when loading the class, and obviously the webapp CL

Re: DO NOT REPLY [Bug 36534] - Context relative URLs returned by ServletContext.getResource() for the same path are not equal

2005-09-07 Thread Jan Luehe
Remy Maucherat wrote: [EMAIL PROTECTED] wrote: DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUGĀ· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36534. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED ANDĀ· INSERTED IN THE BUG

Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java

2005-07-21 Thread Jan Luehe
Bill, [EMAIL PROTECTED] wrote: billbarker2005/07/20 20:59:10 Modified:jasper2/src/share/org/apache/jasper/compiler Generator.java Log: Make certain that release is called for custom tags when tag-pooling is disabled. Fix for Bug #35696 Revision ChangesPath

StandardContext and serialization

2005-06-18 Thread Jan Luehe
Has anybody ever tried serializing a StandardContext? StandardContext implements java.io.Serializable, but many of its fields are not. I assume StandardContext has to be serializable so it can be transmitted (e.g., via RMI) to any remote javax.management.NotificationListener (e.g.,

StandardContext and serialization

2005-06-18 Thread Jan Luehe
[Resending as first attempt seemed to have failed] Has anybody ever tried serializing a StandardContext? StandardContext implements java.io.Serializable, but many of its fields are not. I assume StandardContext has to be serializable so it can be transmitted (e.g., via RMI) to any remote

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2005-06-15 Thread luehe
luehe 2005/06/15 16:41:25 Modified:catalina/src/share/org/apache/catalina/session StandardSession.java Log: After deserializing a StandardSession, reinit its transient listeners and notes fields, to prevent NPEs when they are accessed. Revision

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2005-06-15 Thread luehe
luehe 2005/06/15 16:50:12 Modified:catalina/src/share/org/apache/catalina/session StandardSession.java Log: Reverted the scope of readObject() and writeObject() from protected to private, in order to give subclasses an opportunity to implement their own

Re: cvs commit: jakarta-tomcat-catalina/webapps/docs changelog.xml

2005-05-12 Thread Jan Luehe
[EMAIL PROTECTED] wrote: remm2005/05/12 06:01:05 Modified:jasper2/src/share/org/apache/jasper/servlet JspCServletContext.java webapps/docs changelog.xml Log: - 34465: jspc without web.xml. - Submitted by Yoichi Hirose.

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core ApplicationContext.java LocalStrings.properties

2005-05-03 Thread luehe
luehe 2005/05/03 10:24:10 Modified:catalina/src/share/org/apache/catalina/core ApplicationContext.java LocalStrings.properties Log: Prevent NPE when passing null path argument in several places Revision ChangesPath 1.28 +18 -1 jakarta

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/servlets DefaultServlet.java

2005-05-02 Thread luehe
luehe 2005/05/02 09:52:10 Modified:catalina/src/share/org/apache/catalina/servlets DefaultServlet.java Log: - Avoid cache lookup if trimmed.equalsIgnoreCase(WEB-INF) || trimmed.equalsIgnoreCase(META-INF) || trimmed.equalsIgnoreCase

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/connector Response.java

2005-04-25 Thread luehe
luehe 2005/04/25 15:06:30 Modified:catalina/src/share/org/apache/catalina/connector Response.java Log: Fix for Bugzilla 32604 (Some httpHeaders can be lost in response). Fix assumes that SRV.5.5, 2nd bullet, will be amended in the upcoming Servlet

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core StandardContext.java

2005-04-19 Thread luehe
luehe 2005/04/19 11:30:21 Modified:catalina/src/share/org/apache/catalina/core StandardContext.java Log: No longer ignore the wrapper class passed to Context.setWrapperClass(). I think the original intent of this method was to pass a class

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core ContainerBase.java

2005-04-19 Thread luehe
luehe 2005/04/19 11:37:26 Modified:catalina/src/share/org/apache/catalina/core ContainerBase.java Log: Allow Container instances to add pipeline pre-invocation and post-invocation logic Revision ChangesPath 1.42 +1 -1 jakarta-tomcat

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core LocalStrings.properties

2005-04-19 Thread luehe
luehe 2005/04/19 11:42:29 Modified:catalina/src/share/org/apache/catalina/core LocalStrings.properties Log: No longer ignore the wrapper class passed to Context.setWrapperClass(). I think the original intent of this method was to pass a class

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/realm RealmBase.java

2005-04-01 Thread luehe
luehe 2005/04/01 13:18:28 Modified:catalina/src/share/org/apache/catalina/realm RealmBase.java Log: Do not add context path to login and error pages, since we are comparing them against request.getRequestPathMB().toString(), which does not include context path

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler JspDocumentParser.java

2005-03-30 Thread luehe
luehe 2005/03/30 12:27:22 Modified:jasper2/src/share/org/apache/jasper/compiler JspDocumentParser.java Log: Do not add taglib to cache if it's already there, i.e., if the cache already contains a taglib with the given uri. This is consistent with how

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/servlet JasperLoader.java

2005-03-29 Thread luehe
luehe 2005/03/29 10:33:21 Modified:jasper2/src/share/org/apache/jasper/servlet JasperLoader.java Log: Simplified the loading of class resources in JasperLoader. There is no reason for it to use different classloaders depending on whether security

Re: Reminder: 5.5.9 tomorrow

2005-03-25 Thread Jan Luehe
Yoav Shapira wrote: Hi, This is just a reminder that I plan to cut and tag Tomcat version 5.5.9 tomorrow, Saturday March 26th, at 1400h my time, which is 1900h UTC/GMT. Jan, as Remy and you discussed yesterday on the mailing list, please revert your commit that throws the

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core StandardContext.java

2005-03-25 Thread luehe
luehe 2005/03/25 10:12:48 Modified:catalina/src/share/org/apache/catalina/core StandardContext.java Log: Minor adjustment to fix for 32866: Issue log message about propagating value of distributable to manager only if there is a manager in place

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper JspC.java

2005-03-24 Thread luehe
luehe 2005/03/24 10:30:40 Modified:jasper2/src/share/org/apache/jasper JspC.java Log: Release URLClassLoader from LogFactory, in order to release any locks on /WEB-INF/... resources of the 1st webapp that is deployed and precompiled and whose URLClassLoader was added

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper JspC.java

2005-03-24 Thread luehe
luehe 2005/03/24 16:55:33 Modified:jasper2/src/share/org/apache/jasper JspC.java Log: Moved the release (from LogFactory) of loader from the finally clause of processFile() to the finally clause of execute(), because the precompilation of different JSPs may trigger different

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/xmlparser ParserUtils.java

2005-03-24 Thread luehe
luehe 2005/03/24 18:42:23 Modified:jasper2/src/share/org/apache/jasper/compiler Tag: TOMCAT_5_0 JspConfig.java jasper2/src/share/org/apache/jasper/xmlparser Tag: TOMCAT_5_0 ParserUtils.java Log: Fix for Bugzilla 34034

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session LocalStrings.properties LocalStrings_es.properties LocalStrings_fr.properties LocalStrings_ja.properties StandardSession.java

2005-03-23 Thread luehe
luehe 2005/03/23 14:44:14 Modified:catalina/src/share/org/apache/catalina/session LocalStrings.properties LocalStrings_es.properties LocalStrings_fr.properties LocalStrings_ja.properties StandardSession.java Log

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2005-03-23 Thread Jan Luehe
Yoav, Yoav Shapira wrote: Hola, My believe is that the above errata will be reflected in the next (maintenance) release of the servlet spec. I will remind the servlet spec lead that this needs to happen. Jan What's the ETA on this maintenance spec release? work is supposed to start

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler JspConfig.java

2005-03-23 Thread luehe
luehe 2005/03/23 20:08:01 Modified:webapps/docs changelog.xml jasper2/src/share/org/apache/jasper/xmlparser ParserUtils.java jasper2/src/share/org/apache/jasper/compiler JspConfig.java Log: Fix for Bugzilla 34034 (Jasper didn't

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2005-03-22 Thread Jan Luehe
Remy Maucherat wrote: Bill Barker wrote: - Original Message - From: Remy Maucherat [EMAIL PROTECTED] To: Tomcat Developers List tomcat-dev@jakarta.apache.org Sent: Tuesday, March 22, 2005 1:57 AM Subject: Re: cvs commit:

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/realm RealmBase.java

2005-03-02 Thread luehe
luehe 2005/03/02 11:27:11 Modified:catalina/src/share/org/apache/catalina/realm RealmBase.java Log: Consider the case where original request was mapped to welcome page. In this case, the mapped welcome page (and not the original request URI!) needs to be the target

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/realm RealmBase.java

2005-03-02 Thread Jan Luehe
RealmBase.java [EMAIL PROTECTED] wrote: luehe 2005/03/02 11:27:11 Modified:catalina/src/share/org/apache/catalina/realm RealmBase.java Log: Consider the case where original request was mapped to welcome page. In this case, the mapped welcome page (and not the original

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/realm RealmBase.java

2005-03-02 Thread Jan Luehe
Remy, Remy Maucherat wrote: Jan Luehe wrote: Bill/Remy, But SRV.9.10 (Welcome Files) already has this: The container may send the request to the welcome resource with a forward, a redirect, or a container specific mechanism **that is indistinguishable from a direct request

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/realm RealmBase.java

2005-03-02 Thread Jan Luehe
Bill, Bill Barker wrote: - Original Message - From: Jan Luehe [EMAIL PROTECTED] To: Tomcat Developers List tomcat-dev@jakarta.apache.org Sent: Wednesday, March 02, 2005 12:51 PM Subject: Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/realm

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/valves ValveBase.java

2005-03-02 Thread Jan Luehe
Remy Maucherat wrote: [EMAIL PROTECTED] wrote: luehe 2005/02/23 11:27:56 Modified:catalina/src/share/org/apache/catalina/authenticator FormAuthenticator.java NonLoginAuthenticator.java SSLAuthenticator.java SingleSignOn.java

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/valves ValveBase.java

2005-03-02 Thread Jan Luehe
Remy Maucherat wrote: Jan Luehe wrote: Remy Maucherat wrote: Actually, this is probably a bad idea (or at least the implementation is bad): the logger must be retrieved only when the context class loader of the application is set. This is where I'm not following: ;-) I don't see any

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/runtime PageContextImpl.java

2005-02-25 Thread luehe
luehe 2005/02/25 09:32:31 Modified:jasper2/src/share/org/apache/jasper/runtime PageContextImpl.java Log: Fixed indentation prior to making changes Revision ChangesPath 1.63 +20 -20 jakarta-tomcat-jasper/jasper2/src/share/org/apache

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/runtime PageContextImpl.java

2005-02-25 Thread luehe
luehe 2005/02/25 09:45:59 Modified:jasper2/src/share/org/apache/jasper/runtime PageContextImpl.java Log: Fixed 31659 (Page context not fully populated for Exception if using app-wide error page) Revision ChangesPath 1.64 +7 -5

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/valves ValveBase.java

2005-02-23 Thread luehe
luehe 2005/02/23 11:27:56 Modified:catalina/src/share/org/apache/catalina/authenticator FormAuthenticator.java NonLoginAuthenticator.java SSLAuthenticator.java SingleSignOn.java catalina/src/share/org/apache/catalina/realm

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/authenticator FormAuthenticator.java NonLoginAuthenticator.java SSLAuthenticator.java SingleSignOn.java mbeans-descriptors.xml

2005-02-18 Thread luehe
luehe 2005/02/18 10:00:22 Modified:catalina/src/share/org/apache/catalina/authenticator FormAuthenticator.java NonLoginAuthenticator.java SSLAuthenticator.java SingleSignOn.java mbeans-descriptors.xml Log

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/realm DataSourceRealm.java JAASCallbackHandler.java JAASMemoryLoginModule.java JDBCRealm.java JNDIRealm.java RealmBase.java UserDatabaseRealm.java

2005-02-18 Thread luehe
luehe 2005/02/18 11:17:57 Modified:catalina/src/share/org/apache/catalina/realm DataSourceRealm.java JAASCallbackHandler.java JAASMemoryLoginModule.java JDBCRealm.java JNDIRealm.java RealmBase.java

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/realm DataSourceRealm.java JAASCallbackHandler.java JAASMemoryLoginModule.java JDBCRealm.java JNDIRealm.java RealmBase.java UserDatabaseRealm.java

2005-02-18 Thread Jan Luehe
Remy Maucherat wrote: [EMAIL PROTECTED] wrote: luehe 2005/02/18 11:17:57 Modified:catalina/src/share/org/apache/catalina/realm DataSourceRealm.java JAASCallbackHandler.java JAASMemoryLoginModule.java JDBCRealm.java

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/realm DataSourceRealm.java JAASCallbackHandler.java JAASMemoryLoginModule.java JDBCRealm.java JNDIRealm.java RealmBase.java UserDatabaseRealm.java

2005-02-18 Thread Jan Luehe
Remy Maucherat wrote: Jan Luehe wrote: Remy Maucherat wrote: [EMAIL PROTECTED] wrote: luehe 2005/02/18 11:17:57 Modified:catalina/src/share/org/apache/catalina/realm DataSourceRealm.java JAASCallbackHandler.java

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/authenticator FormAuthenticator.java NonLoginAuthenticator.java SSLAuthenticator.java SingleSignOn.java

2005-02-18 Thread luehe
luehe 2005/02/18 15:35:18 Modified:catalina/src/share/org/apache/catalina/authenticator FormAuthenticator.java NonLoginAuthenticator.java SSLAuthenticator.java SingleSignOn.java Log: Undid previous commit Revision Changes

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/realm DataSourceRealm.java JAASCallbackHandler.java JAASMemoryLoginModule.java JDBCRealm.java JNDIRealm.java RealmBase.java UserDatabaseRealm.java

2005-02-18 Thread luehe
luehe 2005/02/18 15:43:20 Modified:catalina/src/share/org/apache/catalina/realm DataSourceRealm.java JAASCallbackHandler.java JAASMemoryLoginModule.java JDBCRealm.java JNDIRealm.java RealmBase.java

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/realm DataSourceRealm.java JAASCallbackHandler.java JAASMemoryLoginModule.java JDBCRealm.java JNDIRealm.java RealmBase.java UserDatabaseRealm.java

2005-02-18 Thread Jan Luehe
Remy, Remy Maucherat wrote: Jan Luehe wrote: Remy Maucherat wrote: I'm still confused. ;-) Which log messages are supposed to go to LogFactory.getLog(), and which ones to Container.getLogger()? For example, in StandardContext.java, we're using LogFactory.getLog() exclusively. Shouldn't most

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core StandardContext.java

2005-02-17 Thread luehe
luehe 2005/02/17 09:55:24 Modified:catalina/src/share/org/apache/catalina/core StandardContext.java Log: Removed potential WebappClassLoader leak. Consider the following example scenario: - Servlet class references RequestDispatcher

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core StandardContext.java

2005-02-17 Thread luehe
luehe 2005/02/17 10:25:51 Modified:catalina/src/share/org/apache/catalina/core StandardContext.java Log: Removed previous patch, since it is already being addressed in WebappClassLoader.stop(). Thanks Remy! Revision ChangesPath 1.164 +1 -4

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core StandardContext.java

2005-02-17 Thread Jan Luehe
Remy Maucherat wrote: [EMAIL PROTECTED] wrote: This patch should fix the issue. Let me know if you see any problems. There's the same code (and more) in WebappClassLoader.stop(): // Clear the classloader reference in common-logging

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session ManagerBase.java mbeans-descriptors.xml

2005-02-15 Thread luehe
luehe 2005/02/15 13:10:35 Modified:catalina/src/share/org/apache/catalina/session ManagerBase.java mbeans-descriptors.xml Log: Added getSession() action on session manager mbean Revision ChangesPath 1.40 +38 -1 jakarta-tomcat-catalina

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup ContextConfig.java LocalStrings.properties

2005-02-14 Thread luehe
luehe 2005/02/14 11:27:41 Modified:catalina/src/share/org/apache/catalina/startup ContextConfig.java LocalStrings.properties Log: Use configuration from alt-dd if specified. (Setter for alt-dd had been added to StandardContext, but this info was never

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler TldLocationsCache.java

2005-02-14 Thread luehe
luehe 2005/02/14 11:54:53 Modified:jasper2/src/share/org/apache/jasper Constants.java jasper2/src/share/org/apache/jasper/compiler TldLocationsCache.java Log: Use configuration from alt-dd if specified. (Setter for alt-dd had been added

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup ContextConfig.java LocalStrings.properties

2005-02-14 Thread Jan Luehe
Remy, Remy Maucherat wrote: [EMAIL PROTECTED] wrote: luehe 2005/02/14 11:27:41 Modified:catalina/src/share/org/apache/catalina/startup ContextConfig.java LocalStrings.properties Log: Use configuration from alt-dd if specified. (Setter for alt-dd had

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session ManagerBase.java

2005-02-10 Thread luehe
luehe 2005/02/10 16:05:54 Modified:catalina/src/share/org/apache/catalina/session ManagerBase.java Log: Propagate value of context's distributable property to its session manager. This is to address SRV.7.7.2: Within an application marked

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper JspC.java

2005-02-08 Thread luehe
luehe 2005/02/08 13:08:39 Modified:jasper2/src/share/org/apache/jasper JspC.java Log: Removed return tag from initClassLoader() javadocs, because this method was changed back to 'void' Revision ChangesPath 1.92 +0 -1 jakarta-tomcat-jasper/jasper2/src/share

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core StandardContext.java mbeans-descriptors.xml

2005-02-04 Thread luehe
luehe 2005/02/04 15:39:59 Modified:catalina/src/share/org/apache/catalina/core StandardContext.java mbeans-descriptors.xml Log: Added StandardContext processingTime attribute, which provides the cumulative processing times of all of the context's servlets

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/servlet JspServlet.java

2005-01-25 Thread luehe
luehe 2005/01/25 10:53:17 Modified:jasper2/src/share/org/apache/jasper/servlet JspServlet.java Log: Fix for Bugzilla 33223 (pageContext.forward and jsp:include result in StringIndexOutOfBoundsException) All JSP TCKs still pass, and the test case in the bug report now also

cvs commit: jakarta-tomcat-catalina/webapps/docs changelog.xml

2005-01-25 Thread luehe
luehe 2005/01/25 11:17:52 Modified:webapps/docs changelog.xml Log: Added fix for 33223 Revision ChangesPath 1.226 +11 -0 jakarta-tomcat-catalina/webapps/docs/changelog.xml Index: changelog.xml

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core ApplicationHttpRequest.java

2005-01-11 Thread luehe
luehe 2005/01/11 12:39:52 Modified:catalina/src/share/org/apache/catalina/core ApplicationHttpRequest.java Log: Fix for 32832 (request.getSession(false) fails to return null). I believe this bug has been valid: If the session in the foreign context

cvs commit: jakarta-tomcat-catalina/webapps/docs changelog.xml

2005-01-11 Thread luehe
luehe 2005/01/11 15:27:36 Modified:webapps/docs changelog.xml Log: Added fix for 32832 Revision ChangesPath 1.218 +3 -0 jakarta-tomcat-catalina/webapps/docs/changelog.xml Index: changelog.xml

cvs commit: jakarta-tomcat-catalina/webapps/docs changelog.xml

2004-12-08 Thread luehe
luehe 2004/12/08 11:15:30 Modified:webapps/docs changelog.xml Log: Updated with fix for 28709 Revision ChangesPath 1.200 +3 -0 jakarta-tomcat-catalina/webapps/docs/changelog.xml Index: changelog.xml

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core ApplicationHttpRequest.java

2004-12-07 Thread luehe
luehe 2004/12/07 17:25:52 Modified:catalina/src/share/org/apache/catalina/core ApplicationHttpRequest.java Log: Fix for 28709 (javax.servlet.http.HttpServletRequest.isRequestedSessionIdValid() returns true for an invalidated session!) Please let me

cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/http ServerCookie.java

2004-12-03 Thread luehe
luehe 2004/12/03 10:12:07 Modified:util/java/org/apache/tomcat/util/http ServerCookie.java Log: Escape any double quotes in Version 1 cookies Revision ChangesPath 1.8 +27 -1 jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/http/ServerCookie.java

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/connector Request.java

2004-11-20 Thread luehe
luehe 2004/11/20 13:10:47 Modified:catalina/src/share/org/apache/catalina/connector Request.java Log: Allow parseParameters() to use possibly overridden impl of getCharacterEncoding() Revision ChangesPath 1.18 +5 -2 jakarta-tomcat

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/connector RequestFacade.java

2004-11-01 Thread luehe
luehe 2004/11/01 14:22:37 Modified:catalina/src/share/org/apache/catalina/connector RequestFacade.java Log: Fixed formatting prior to making changes Revision ChangesPath 1.6 +53 -28 jakarta-tomcat-catalina/catalina/src/share/org/apache

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/connector RequestFacade.java LocalStrings.properties

2004-11-01 Thread luehe
luehe 2004/11/01 14:38:44 Modified:catalina/src/share/org/apache/catalina/connector RequestFacade.java LocalStrings.properties Log: Throw more meaningful exception (instead of NPE) if underlying request has been recycled and attempt is made to access

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/connector ResponseFacade.java

2004-11-01 Thread luehe
luehe 2004/11/01 15:21:58 Modified:catalina/src/share/org/apache/catalina/connector ResponseFacade.java Log: Fixed formatting prior to making changes Revision ChangesPath 1.7 +13 -11 jakarta-tomcat-catalina/catalina/src/share/org

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/connector ResponseFacade.java

2004-11-01 Thread luehe
luehe 2004/11/01 15:34:04 Modified:catalina/src/share/org/apache/catalina/connector ResponseFacade.java Log: Throw more meaningful exception (instead of NPE) if underlying response has been recycled and attempt is made to access it via its facade

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/connector LocalStrings.properties

2004-11-01 Thread luehe
luehe 2004/11/01 15:35:39 Modified:catalina/src/share/org/apache/catalina/connector LocalStrings.properties Log: Throw more meaningful exception (instead of NPE) if underlying response has been recycled and attempt is made to access it via its facade

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/connector RequestFacade.java LocalStrings.properties

2004-11-01 Thread Jan Luehe
Remy Maucherat wrote: [EMAIL PROTECTED] wrote: luehe 2004/11/01 14:38:44 Modified:catalina/src/share/org/apache/catalina/connector RequestFacade.java LocalStrings.properties Log: Throw more meaningful exception (instead of NPE) if underlying request has

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/connector RequestFacade.java LocalStrings.properties

2004-11-01 Thread Jan Luehe
Bill Barker wrote: - Original Message - From: Jan Luehe [EMAIL PROTECTED] To: Tomcat Developers List [EMAIL PROTECTED] Sent: Monday, November 01, 2004 3:41 PM Subject: Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/connector RequestFacade.java

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/servlets DefaultServlet.java LocalStrings.properties

2004-10-29 Thread luehe
luehe 2004/10/29 15:29:30 Modified:catalina/src/share/org/apache/catalina/servlets DefaultServlet.java LocalStrings.properties Log: Include warning message when an included resource is not available, instead of ignoring silently Revision Changes

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core StandardWrapper.java

2004-10-28 Thread luehe
luehe 2004/10/28 09:42:37 Modified:catalina/src/share/org/apache/catalina/core StandardWrapper.java Log: Prevent NPE when servlet class is not an instance of HttpServlet. Return hardcoded set of methods in this case. Revision ChangesPath 1.55

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/connector CoyoteAdapter.java

2004-10-28 Thread Jan Luehe
Bill, Bill Barker wrote: [EMAIL PROTECTED] wrote in message news:[EMAIL PROTECTED] luehe 2004/10/27 15:58:17 + +private Method[] getAllDeclaredMethods(Class c) { + +if (c.equals(javax.servlet.http.HttpServlet.class)) { +return null

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/connector CoyoteAdapter.java

2004-10-28 Thread Jan Luehe
Actually, in the case of a JSP, we're dealing w/ JspServlet, which is an instance of HttpServlet. I've changed the code to return a constant set of methods if the servlet is not an instance of HttpServlet, avoiding the NPE. :) My bad. I should pay more attention to Jasper :). However,

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/connector CoyoteAdapter.java

2004-10-27 Thread luehe
luehe 2004/10/27 15:58:17 Modified:catalina/src/share/org/apache/catalina/core StandardWrapper.java catalina/src/share/org/apache/catalina Wrapper.java catalina/src/share/org/apache/catalina/connector

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core StandardWrapper.java mbeans-descriptors.xml

2004-10-26 Thread luehe
luehe 2004/10/26 14:55:43 Modified:catalina/src/share/org/apache/catalina/core StandardWrapper.java mbeans-descriptors.xml Log: Removed ServiceTime property that I had added previously. JSR 77 defines ServiceTime to be of type TimeStatistic, which

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/security SecurityUtil.java

2004-10-25 Thread luehe
luehe 2004/10/25 14:18:49 Modified:catalina/src/share/org/apache/catalina/security SecurityUtil.java Log: Call session.setAttribute(Globals.SUBJECT_ATTR, subject) only if necessary, i.e, only if the session does not already contain such an attribute

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/security SecurityUtil.java

2004-10-25 Thread luehe
luehe 2004/10/25 19:02:37 Modified:catalina/src/share/org/apache/catalina/security SecurityUtil.java Log: Create Subject if one was not already associated with the session, and add it to the session *only* in that case Revision ChangesPath

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/security SecurityUtil.java

2004-10-25 Thread Jan Luehe
Bill Barker wrote: - Original Message - From: [EMAIL PROTECTED] To: [EMAIL PROTECTED] Sent: Monday, October 25, 2004 2:18 PM Subject: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/security SecurityUtil.java @@ -251,18 +251,17 @@

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session PersistentManagerBase.java

2004-10-22 Thread luehe
luehe 2004/10/22 17:16:08 Modified:catalina/src/share/org/apache/catalina/session PersistentManagerBase.java Log: Fixed cut-and-paste error in log error message Revision ChangesPath 1.22 +9 -5 jakarta-tomcat-catalina/catalina/src

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core StandardWrapper.java mbeans-descriptors.xml

2004-10-21 Thread luehe
luehe 2004/10/21 12:03:46 Modified:catalina/src/share/org/apache/catalina/core StandardWrapper.java mbeans-descriptors.xml Log: Expose execution time of the servlet's service method under JSR 77 compliant name (ServiceTime) Revision ChangesPath

cvs commit: jakarta-tomcat-catalina/catalina/src/conf web.xml

2004-10-19 Thread luehe
luehe 2004/10/19 09:17:35 Modified:jasper2/src/share/org/apache/jasper Options.java JspC.java EmbeddedServletOptions.java jasper2/src/share/org/apache/jasper/compiler JspRuntimeContext.java catalina/src/conf

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler JspRuntimeContext.java

2004-10-19 Thread luehe
luehe 2004/10/19 09:21:46 Modified:jasper2/src/share/org/apache/jasper/compiler JspRuntimeContext.java Log: Removed printlns ;-) Revision ChangesPath 1.26 +1 -7 jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler

cvs commit: jakarta-tomcat-catalina/catalina/src/conf web.xml

2004-10-19 Thread luehe
luehe 2004/10/19 10:25:12 Modified:catalina/src/conf web.xml Log: Changed default of 'checkInterval' to zero, so that background compilations are off by default. This is consistent with the default (FALSE) of the (now removed) 'reloading' init param, which meant

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Compiler.java

2004-10-19 Thread luehe
luehe 2004/10/19 13:18:02 Modified:jasper2/src/share/org/apache/jasper/compiler Compiler.java Log: Update the JspServletWrapper's lastModificationTest timestamp at the right place in the code (the place where we used to set it was never reached if the JSP kept changing before

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper EmbeddedServletOptions.java JspC.java

2004-10-19 Thread luehe
luehe 2004/10/19 17:05:31 Modified:jasper2/src/share/org/apache/jasper EmbeddedServletOptions.java JspC.java Log: Changed default of 'checkInterval' to zero, so that background compilations are off by default. This is consistent with the default

cvs commit: jakarta-tomcat-catalina/catalina/src/conf web.xml

2004-10-18 Thread luehe
luehe 2004/10/18 16:51:08 Modified:catalina/src/conf web.xml Log: Reformated prior to making changes Revision ChangesPath 1.48 +7 -6 jakarta-tomcat-catalina/catalina/src/conf/web.xml Index: web.xml

cvs commit: jakarta-tomcat-catalina/catalina/src/conf web.xml

2004-10-18 Thread luehe
luehe 2004/10/18 16:58:21 Modified:catalina/src/conf web.xml Log: Updated description of 'development' init param Revision ChangesPath 1.49 +4 -2 jakarta-tomcat-catalina/catalina/src/conf/web.xml Index: web.xml

cvs commit: jakarta-tomcat-catalina/catalina/src/conf web.xml

2004-10-18 Thread luehe
luehe 2004/10/18 18:43:04 Modified:catalina/src/conf web.xml Log: Clarified description of 'reloading' init param. I'm about to remove this param altogether, as it is redundant and misleading (it's only evaluated in deployment mode): reloading=true should be covered

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core ApplicationHttpResponse.java

2004-10-15 Thread Jan Luehe
Remy/Bill, Remy Maucherat wrote: [EMAIL PROTECTED] wrote: luehe 2004/10/14 17:00:35 Modified:catalina/src/share/org/apache/catalina/core ApplicationHttpResponse.java Log: Expose any errors on an included resource. For example, a JSP with this include

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core ApplicationHttpResponse.java

2004-10-15 Thread luehe
luehe 2004/10/15 09:09:27 Modified:catalina/src/share/org/apache/catalina/core ApplicationHttpResponse.java Log: Reverted previous change Revision ChangesPath 1.7 +3 -1 jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/servlets DefaultServlet.java

2004-10-14 Thread luehe
luehe 2004/10/14 16:58:38 Modified:catalina/src/share/org/apache/catalina/servlets DefaultServlet.java Log: Expose any errors on an included resource. For example, a JSP with this include action: jsp:include page=nonexistent or jsp:include

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core ApplicationHttpResponse.java

2004-10-14 Thread luehe
luehe 2004/10/14 17:00:35 Modified:catalina/src/share/org/apache/catalina/core ApplicationHttpResponse.java Log: Expose any errors on an included resource. For example, a JSP with this include action: jsp:include page=nonexistent

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina Globals.java

2004-10-14 Thread luehe
luehe 2004/10/14 17:18:35 Modified:catalina/src/share/org/apache/catalina Globals.java Log: - Grouped javax.servlet.include.* and javax.servlet.forward.* attributes - Fixed description of javax.servlet.include.* attributes: They do not refer to the properties of the original

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core StandardWrapper.java

2004-10-07 Thread luehe
luehe 2004/10/07 11:09:10 Modified:catalina/src/share/org/apache/catalina/core StandardWrapper.java Log: Added comment Revision ChangesPath 1.51 +5 -1 jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core

cvs commit: jakarta-tomcat-catalina/webapps/manager/WEB-INF/classes/org/apache/catalina/manager StatusTransformer.java

2004-10-06 Thread luehe
luehe 2004/10/06 10:10:25 Modified:webapps/docs changelog.xml catalina/src/share/org/apache/catalina/core StandardWrapper.java webapps/manager/WEB-INF/classes/org/apache/catalina/manager

cvs commit: jakarta-tomcat-catalina/webapps/docs changelog.xml

2004-10-06 Thread luehe
luehe 2004/10/06 10:16:17 Modified:webapps/docs changelog.xml Log: Fixed changelog. Sorry about that Revision ChangesPath 1.142 +3 -3 jakarta-tomcat-catalina/webapps/docs/changelog.xml Index: changelog.xml

Re: TCKs for 5.5.3 and 5.0.29

2004-10-06 Thread Jan Luehe
(in StandardWrapper.java): revision 1.49 date: 2004/10/06 00:54:46; author: luehe; state: Exp; lines: +1 -1 Undid previous change, as in the case where a servlet has a jsp-file and also declares some init params, as in: servlet servlet-namexxx/servlet-name jsp-file/xxx.jsp/jsp-file init

cvs commit: jakarta-tomcat-catalina/webapps/docs changelog.xml

2004-10-06 Thread luehe
luehe 2004/10/06 11:48:05 Modified:webapps/docs changelog.xml Log: Moved Register JSP monitoring mbean for each servlet that declares a jsp-file in web.xml item to 5.5.4 section, since it did not make it into 5.5.3 Revision ChangesPath 1.143 +3 -3 jakarta

cvs commit: jakarta-tomcat-catalina/webapps/docs changelog.xml

2004-10-05 Thread luehe
luehe 2004/10/05 11:53:47 Modified:webapps/docs changelog.xml Log: Update Revision ChangesPath 1.138 +3 -0 jakarta-tomcat-catalina/webapps/docs/changelog.xml Index: changelog.xml === RCS

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler AntCompiler.java JDTCompiler.java

2004-10-05 Thread luehe
luehe 2004/10/05 12:06:31 Modified:jasper2/src/share/org/apache/jasper/compiler AntCompiler.java JDTCompiler.java Log: Determine t1 only as needed Revision ChangesPath 1.6 +7 -2 jakarta-tomcat-jasper/jasper2/src/share/org/apache

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Compiler.java

2004-10-05 Thread luehe
luehe 2004/10/05 12:28:20 Modified:jasper2/src/share/org/apache/jasper/compiler Compiler.java Log: Determine various JSP compilation time intervals only as needed Revision ChangesPath 1.96 +18 -10 jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper

  1   2   3   4   5   6   7   8   9   >