Re: [Toybox] [PATCH] toysh: fix -Wuse-after-free

2024-03-13 Thread Rob Landley
On 3/8/24 21:22, Oliver Webb via Toybox wrote: > TL;DR: Rant about sh.c's variable names I forgot to include in main email, I > have a patch to start fixing it but it conflicts with other stuff and I have > to re-do it > > Reading through sh.c, most of the variable names are 2 letters long >

Re: [Toybox] [PATCH] toysh: fix -Wuse-after-free

2024-03-13 Thread Oliver Webb via Toybox
Added P.S.: If this is territorial, just admit it. I won't bring up the "is keeping territory a good thing in a open-source project?" argument. I never mentioned territory because I don't think like that (I've waited for and welcomed cleanup passes on code I'm actively developing). You mentioned

Re: [Toybox] [PATCH] toysh: fix -Wuse-after-free

2024-03-13 Thread Oliver Webb via Toybox
> On 3/8/24 21:22, Oliver Webb via Toybox wrote: > > Reading through sh.c, most of the variable names are 2 letters long > > (repeating the same letter), > > I switched from single character local variables to double character ones > because they're easier to search for without an elaborate IDE

Re: [Toybox] [PATCH] watch: flush the buffer each round.

2024-03-13 Thread Rob Landley
On 3/12/24 12:24, enh wrote: > On Tue, Mar 12, 2024 at 8:45 AM Rob Landley wrote: >> >> Hello from Minneapolis: https://mstdn.jp/@landley/112078501045637288 >> >> Still _really_ fried from my move, but at least chipping away at the email >> backlog... > > at least it's the same timezone :-)