[Toybox] Probably another release over the weekend.

2012-06-13 Thread Rob Landley
Now that I've built the static binaries for all the targets (which took a day and a half on my netbook, left running overnight), I'm noticing some cross-platform bugs. For example, ls -l in x86-64 works fine (even built against uClibc), but on i686 it prints (null) for the time field, and on

[Toybox] Found the ls bug on 32 bit targets.

2012-06-13 Thread Rob Landley
It's that printf was treating st-blah fields as integers, which had various behavior based on endianness and word size. (on x86-64 it coincidentally worked out great, i686 always got null, arm segfaulted, powerpc corrupted the stack and behaved _really_weird_...) Fixed. I'm bringing the roadmap

Re: [Toybox] [PATCH] Support HOSTCFLAGS on musl

2012-06-14 Thread Rob Landley
On 06/14/2012 04:04 AM, orc wrote: And crypt.h exists because you only get crypt() defined out of that if you #define a feature test macro nobody ever uses. (Feature test macros in standard C headers: still an EPICALLY STUPID IDEA.) I agree. Btw sed -i '/crypt.h/d' ... recursively on other

Re: [Toybox] Editors and such.

2012-06-17 Thread Rob Landley
On 06/16/2012 10:47 AM, David Seikel wrote: On Fri, 15 Jun 2012 21:20:11 +1000 David Seikel onef...@gmail.com wrote: Then there would be a toy I'm calling toyboxes. Hmm, seems toybox does not like toy names that partially match the names of other toys. Every time I try to use toyboxes,

Re: [Toybox] Editors and such.

2012-06-20 Thread Rob Landley
On 06/18/2012 10:10 PM, Andre Renaud wrote: No, they have an implementation of screen. The first one I used (circa 1993) was from Sun. The wonkypedia article says the first pair of maintainers handed it over to a second pair of maintainers who handed it over to the gnu project. So it's a bit

Re: [Toybox] Notes about netcat toy

2012-06-20 Thread Rob Landley
toys should be ready for ipv6 by default. Note the date: changeset: 189:22d22427dec6 user:Rob Landley r...@landley.net date:Mon Dec 03 18:53:00 2007 -0600 files: toys/Config.in toys/netcat.c toys/toylist.h description: Add first pass at netcat. Base applet, -f, and -w

[Toybox] And 0.3.1 is out.

2012-06-25 Thread Rob Landley
Trying to do the release early, release often thing more. I got a new laptop to switch to (with _more_ than 2 gigs of ram, woo!), and I'm _not_ setting up thunderbird on it (piece of garbage) so my email may be a bit funky until I find a new email client I can tolerate. I'll save my 39 pending

Re: [Toybox] Editors and such.

2012-07-01 Thread Rob Landley
On 07/01/2012 01:13 AM, David Seikel wrote: On Sat, 30 Jun 2012 20:02:55 -0500 Rob Landley r...@landley.net wrote: On 06/30/2012 07:01 PM, David Seikel wrote: Oh yeah, my infrastructure is aiming at sed to. All fairly similar at the basic level anyway. What does interactive line editing

Re: [Toybox] od (was: Editors and such.)

2012-07-03 Thread Rob Landley
On 07/01/2012 02:47 PM, Andre Renaud wrote: If the output of od gets dropped (-EPIPE), what happens? Should it retry short writes, which implies xprintf() should do an xmprintf() into a malloc buffer and then do a writeall() on it, although I really am trying to get automatic retry in there

Re: [Toybox] cmp.c EOF notice on stderr vs stdout

2012-07-07 Thread Rob Landley
On 07/05/2012 01:19 PM, Elie De Brauwer wrote: Hi all, In this changeset http://www.landley.net/hg/toybox/rev/e7c742f78361 the EOF notification of cmp.c went to stdout iso of to stderr. This however causes the cmp tests to fail, since on my debian laptop with the fsf cmp it goes to stderr:

Re: [Toybox] patch: taskset-work-as-nice (was Re: new toy: taskset)

2012-07-20 Thread Rob Landley
On 07/20/2012 02:51 AM, Elie De Brauwer wrote: On 07/19/2012 03:41 AM, Rob Landley wrote: Meaning to works as renice, rather than nice. I'm open to suggestions, I can as well the 'work-as-nice' functionality, Is there more to it than: if (opt.argc2) xexec(toys.optargs+2); Well, taskset

[Toybox] Notes about mount: VFS flags.

2012-08-12 Thread Rob Landley
The mount system call takes five arguments: int mount(char *source, char *target, char *filesystemtype, unsigned long mountflags, void *data); The first is what to mount, the second where to mount it, and the third is filesystem type. The simplest variant of this is a block device, a

Re: [Toybox] linenoise

2012-10-27 Thread Rob Landley
On 12/05/2011 05:11:52 PM, David Seikel wrote: On Mon, 5 Dec 2011 14:41:06 +0100 Jens Staal staal1...@gmail.com wrote: Would this be interesting for some toybox utilities? https://github.com/antirez/linenoise Rob was looking at that before, plus a few other similar readline alternatives.

Re: [Toybox] [df] percentage different from GNU df

2012-11-09 Thread Rob Landley
On 11/09/2012 12:24:39 AM, Roy Tam wrote: Hello, 2012/11/9 Roy Tam roy...@gmail.com: Hello, 2012/11/9 Rob Landley r...@landley.net: On 10/28/2012 10:50:50 PM, Roy Tam wrote: Hello, I noticed that toybox df shows different percentage from GNU df. GNU df calculates percentage by used

[Toybox] 0.4.1 is out.

2012-11-15 Thread Rob Landley
Release notes are on the website, and this time I remembered to build the static binaries. This release was a giant backlog-clearing exercise. Aboriginal Linux is now converted over to build toybox by default, so I've got a built in regression test that I can plug each new version of

Re: [Toybox] Compile errors when compiling for ARM

2012-11-28 Thread Rob Landley
On 11/28/2012 10:59:38 PM, Ashwini Sharma wrote: Hi Rob, I am getting few other warnings related to portability.h. When compiling for ARM target it throws warning: implicit declaration of function 'getsid' warning: implicit declaration of function 'getpgid' I'm not finding either of those in

Re: [Toybox] Compile errors when compiling for ARM

2012-11-28 Thread Rob Landley
On 11/28/2012 10:59:38 PM, Ashwini Sharma wrote: Hi Rob, I am getting few other warnings related to portability.h. When compiling for ARM target it throws warning: implicit declaration of function 'getsid' warning: implicit declaration of function 'getpgid' I tried the code sourcery armv7l

Re: [Toybox] More expand cleanups

2012-11-30 Thread Rob Landley
On 11/28/2012 03:34:59 AM, Jonathan Clairembault wrote: Back to expand_file(). The downside of using readall() is that interactive granularity goes way down. I had this problem with tee once upon a time, it meant that piping the output of anything through tee made it appear in 4k

Re: [Toybox] Fix, killall is not allowed to kill itself

2012-12-17 Thread Rob Landley
On 12/16/2012 11:31:49 AM, David Seikel wrote: On Sun, 16 Dec 2012 16:54:24 +0100 Elie De Brauwer eliedebrau...@gmail.com wrote: The LSB specification of killall says A killall process never kills itself (but may kill other killall processes). The current implementation of killall does not

Re: [Toybox] Add -m option to mkdir

2012-12-23 Thread Rob Landley
On 12/23/2012 01:31:10 PM, Bastian Bittorf wrote: * Felix Janda felix.ja...@posteo.de [23.12.2012 20:23]: Hi, of created directory), the other adds a test script for it. The test script uses the non-standard command stat since it seems to be the right tool for determining permissions

Re: [Toybox] Fix, killall is not allowed to kill itself

2012-12-23 Thread Rob Landley
On 12/16/2012 11:12:59 AM, Elie De Brauwer wrote: All, In my previous patch, the pif shouldn't be stored inside the GLOBAL(), it should be just a regular global variable. In attach a patch which corrects this. Ok, I finally took a proper look at this, and I don't understand why can't

Re: [Toybox] Fix, killall is not allowed to kill itself

2012-12-23 Thread Rob Landley
On 12/23/2012 02:45:57 PM, Elie De Brauwer wrote: On 12/23/2012 09:42 PM, Rob Landley wrote: On 12/16/2012 11:12:59 AM, Elie De Brauwer wrote: All, In my previous patch, the pif shouldn't be stored inside the GLOBAL(), it should be just a regular global variable. In attach a patch which

Re: [Toybox] Fix, killall is not allowed to kill itself

2012-12-23 Thread Rob Landley
On 12/23/2012 11:44:27 PM, David Seikel wrote: On Sun, 23 Dec 2012 23:25:46 -0600 Rob Landley r...@landley.net wrote: On 12/23/2012 08:45:07 PM, David Seikel wrote: Like rm'ing something that does not exist, the end result is the same, except for the useless error. Using

Re: [Toybox] [groups] : ! More than one in group is error

2012-12-27 Thread Rob Landley
On 12/27/2012 11:06:37 AM, Felix Janda wrote: When trying to implement the remaining options for pwd I could also test toybox's group option handling. The option string I wanted to use is: 0LP[!LP] (It's the same for LP[!LP].) With the current argparsing I get a segfault for pwd -L -P. When

Re: [Toybox] [groups] : ! More than one in group is error

2012-12-29 Thread Rob Landley
On 12/27/2012 10:32:51 PM, Ashwini Sharma wrote: Hi Rob, With your fix, it doesn't segfault now. But does it matter, to give the proper option name in error message. If yes, then the fix fails in that. e.g. when running *./toybox touch -d 12 -r f2 f1* it throws the error message as *touch:

Re: [Toybox] Add remaining pwd options

2012-12-29 Thread Rob Landley
On 12/28/2012 03:24:17 PM, Felix Janda wrote: Hi, the first patch adds the -L and -P options to pwd as specified by POSIX. The test script again uses stat. This time in order to get inode numbers of directories. For future reference adding the test in the same commit as the changes

Re: [Toybox] Add remaining pwd options

2012-12-29 Thread Rob Landley
On 12/29/2012 07:38:24 AM, Felix Janda wrote: On 12/29/12 at 03:53am, Rob Landley wrote: On 12/28/2012 03:24:17 PM, Felix Janda wrote: Hi, the first patch adds the -L and -P options to pwd as specified by POSIX. The test script again uses stat. This time in order to get inode

Re: [Toybox] Add remaining pwd options

2012-12-30 Thread Rob Landley
On 12/29/2012 07:38:24 AM, Felix Janda wrote: POSIX says that pwd should behave the same as pwd -L. The current pwd -P should behave the same way as the previous version of pwd. It just returns the getcwd() output. pwd -L does just check whether the environment variable PWD is also a valid

Re: [Toybox] Add remaining pwd options

2012-12-30 Thread Rob Landley
On 12/30/2012 04:47:13 AM, Felix Janda wrote: Thanks for the various clarifications and making pwd -L check for dot and dot-dot as described in the standard. Looking at the POSIX man page toysh should set $PWD at some point, too. Right now we have toysh is hugely incomplete and I just

Re: [Toybox] Add remaining pwd options

2013-01-13 Thread Rob Landley
distracted and sleep deprived...), so I'm wrong a lot. I just try to fix it when I notice. On 01/12/13 at 11:33pm, Rob Landley wrote: On 01/10/2013 02:25:13 PM, Felix Janda wrote: On 01/02/13 at 12:41am, Rob Landley wrote: What I did was disable #3 in the case where cwd doesn't exist. So

Re: [Toybox] Issues with 'xexec()', 'losetup' and 'cp'

2013-02-04 Thread Rob Landley
Sorry for the delay answering, still working out work/life balance at my new contract. On 01/30/2013 03:11:58 AM, Ashwini Sharma wrote: Hi Rob, 1. I was using 'xexec()' function. It gives me the coredump from function toy_init() in main.c at line #82. My use case is as follows. I

Re: [Toybox] toybox initd

2013-02-04 Thread Rob Landley
And I got permission! (Second attempt. If balsa eats this one, I'm taking a hex editor to it.) Rob On 01/24/2013 11:36:48 AM, Rob Landley wrote: On 01/17/2013 02:50:38 PM, Ilya Kuzmich wrote: Hi Rob. Can you please share with me your vision on what exactly toybox initd should look like

Re: [Toybox] Introduction

2013-02-22 Thread Rob Landley
Sorry for the delay. Crazy month, writing this from an Android panel at CELF I really should be paying attention to. :) On 02/06/2013 10:10:18 AM, Bas Pape wrote: Hi all, Speaking to him on IRC yesterday, Rob requested I send a mail to this list, so here goes. Having looked at the toybox

Re: [Toybox] Working on unxz-some questions

2013-03-03 Thread Rob Landley
On 03/01/2013 01:10:36 AM, Isaac Dunham wrote: I'm looking into adding an unxz based on xz-embedded, which is public domain. Cool! I noticed this recently (due to the busybox thread about it) and was pondering the same myself. I downloaded the git repo but am not going to have time to

[Toybox] 0.4.4 is out.

2013-03-14 Thread Rob Landley
And I checked in the license file simplification afterwards. Rob (By the way, if anybody were to object to the change, who _didn't_ send me a copy of the entire license file with their code submission... I would be confused.) ___ Toybox mailing

Re: [Toybox] Min/Max bug fix

2013-03-17 Thread Rob Landley
On 03/14/2013 03:46:02 PM, Andre Renaud wrote: There is a minor bug in the min/max macros that can result in unexpected results when doing things like: 5 + min(a,b) This currently essentially becomes (5 + a) (b) ? (a) : (b) instead of: 5 + ((a b) ? a : b) Attached patch resolves it with the

Re: [Toybox] new toy: uuencode

2013-03-17 Thread Rob Landley
On 03/14/2013 05:35:30 PM, Andre Renaud wrote: Hi, Attached is a simple implementation of uuencode. It isn't the prettiest, but it seems to do the job for all of the input I've thrown at it. Any feedback? At this stage, I haven't done uudecode. I see the one from you, and I see the one from

Re: [Toybox] uuen/decode

2013-03-17 Thread Rob Landley
On 03/14/2013 09:04:18 PM, Erich Plondke wrote: Looks like I might be a bit late on this browsing the archives... but uuencode and uudecode implementations are attached. Both passed basic tests. Support both base64 and traditional format. Also, I needed to put parens around min/max, but I

Re: [Toybox] [musl] toybox: Rough edges in pending

2013-03-19 Thread Rob Landley
On 03/19/2013 06:09:39 AM, Szabolcs Nagy wrote: * Szabolcs Nagy n...@port70.net [2013-03-19 10:42:25 +0100]: * Isaac Dunham idun...@lavabit.com [2013-03-18 23:50:43 -0700]: execve(./toybox-musl, [./toybox-musl, sh, -c, ls], [/* 22 vars */]) = 0 ... ioctl(0, SNDCTL_TMR_TIMEBASE or

[Toybox] My CELF talk on toybox.

2013-03-19 Thread Rob Landley
Video is up! http://www.youtube.com/watch?v=SGmtP5Lg_t0 90% of it is really Why is toybox, rather than what is. The what is parts don't go into anything that you wouldn't get from roadmap.html and status.html (with maybe a little of http://landley.net/aboriginal/about.html). Rob

Re: [Toybox] [musl] Re: toybox: Rough edges in pending

2013-03-20 Thread Rob Landley
On 03/19/2013 02:32:21 PM, Isaac Dunham wrote: A couple things that would have cleared this up for me-- Either a note in toys/pending/README that said: Code in this directory may or may not work. (somehow, ...await review and/or cleanup doesn't seem to communicate this) Good point. I'll add

Re: [Toybox] new toy: logger

2013-03-24 Thread Rob Landley
On 03/22/2013 09:47:38 AM, Ilya Kuzmich wrote: Implements -t -p ans -s. Same functionality as busybox logger sans numeric facility. Do we really need this? There is one sublte corner case though: logger , logger , or even logger /dev/null gnu silently ignores all of them busybox logs logger

Re: [Toybox] complaining about 'ifconfig' - better use 'ip'

2013-04-03 Thread Rob Landley
On 04/03/2013 09:05:26 AM, Bastian Bittorf wrote: it needed some days to find the right arguments, but i try to make it short: dont implement 'ifconfig'. I didn't. A third party submitted it, because they use it. Nobody's ever bothered to submit ip. it's totally obsolete since nearly

Re: [Toybox] complaining about 'ifconfig' - better use 'ip'

2013-04-03 Thread Rob Landley
On 04/03/2013 10:28:00 AM, Bastian Bittorf wrote: * Isaac Dunham idun...@lavabit.com [03.04.2013 17:16]: I learned Linux in 2006, and use ifconfig all the time. It's much more informative, much more obvious to use ofcourse this is always, from which side you are looking. if you are used to

Re: [Toybox] complaining about 'ifconfig' - better use 'ip'

2013-04-03 Thread Rob Landley
On 04/03/2013 03:21:17 PM, Bastian Bittorf wrote: * Rob Landley r...@landley.net [03.04.2013 21:44]: it's totally obsolete since nearly 10 years. nobody uses it anymore, *shrug* I use it. So did the people who submitted their implementation of it. It's in the $PATH on ubuntu LTS without

Re: [Toybox] bc, etc.

2013-04-04 Thread Rob Landley
On 04/03/2013 10:38:28 PM, Isaac Dunham wrote: Hello, After seeing that the ifconfig storm was because someone had implemented it I read the development log again, and this email is in response to a couple things on there. First, regarding bc:

[Toybox] Error messages and internationalization.

2013-04-04 Thread Rob Landley
Ok, I need to ask an opinion here. The authors of the recent ifconfig submission are from Japan (I think) but they're using longish english error messages. I've been trying to keep my error strings as concise as possible. A chunk of examples from the current code turned up by a quick grep:

Re: [Toybox] complaining about 'ifconfig' - better use 'ip'

2013-04-04 Thread Rob Landley
On 04/04/2013 03:09:39 AM, Bastian Bittorf wrote: * Rob Landley r...@landley.net [04.04.2013 10:03]: $ man ip | wc -l 1853 $ man ifconfig | wc -l 185 here: bastian@box:~$ for F in ifconfig arp netstat route; do man $F; done | wc -l 756 Ok. bastian@box:~$ man ip | wc -l 150 bastian

Re: [Toybox] complaining about 'ifconfig' - better use 'ip'

2013-04-04 Thread Rob Landley
On 04/04/2013 03:17:17 AM, Bastian Bittorf wrote: * Rob Landley r...@landley.net [04.04.2013 10:03]: I've used ip a couple times. I mostly use ifconfig, because it's there and I see no upside in using ip. I also use iwlist and iwlist is also dead since a long time, the successor is 'iw' which

Re: [Toybox] complaining about 'ifconfig' - better use 'ip'

2013-04-04 Thread Rob Landley
On 04/04/2013 04:25:03 AM, Bastian Bittorf wrote: * Rob Landley r...@landley.net [04.04.2013 10:03]: Yup, just pulled up my old Red Hat 9 image under qemu and did ifconfig eth0 10.0.2.15/31 and it worked fine. you are right, shame on me. Sorry for complaining about it in the last email

Re: [Toybox] complaining about 'ifconfig' - better use 'ip'

2013-04-04 Thread Rob Landley
On 04/04/2013 04:42:00 AM, Bastian Bittorf wrote: * David Seikel onef...@gmail.com [04.04.2013 11:25]: My copy of the ifconfig man page does not mention the ip command, and certainly does not say to switch. http://linux.die.net/man/8/ifconfig So a third random guy has an opinion, on the

Re: [Toybox] complaining about 'ifconfig' - better use 'ip'

2013-04-04 Thread Rob Landley
On 04/04/2013 09:52:47 AM, Isaac Dunham wrote: On Thu, 4 Apr 2013 10:17:17 +0200 Bastian Bittorf bitt...@bluebottle.com wrote: if you are really using 'ifconfig', you should better switch now. the pain will be much worse if you wait again 2 years... In what way? I vaguely recall first

Re: [Toybox] Github mirror

2013-04-06 Thread Rob Landley
On 04/05/2013 10:50:53 AM, Jeremy Huntwork wrote: Hello, After talking with Rob on IRC, I decided to experiment with setting up a github mirror of the mercurial repository. The benefits, hopefully, would be failover plus easy access for those that like/prefer git. Cool! Here's how I

Re: [Toybox] --help

2013-04-08 Thread Rob Landley
On 04/05/2013 03:12:18 PM, Jeremy Huntwork wrote: Hi, I'm a bit confused about how help text should operate. To me it would make sense to be a universal option which toybox handled for every command, but I'm seeing unexpected results. There's a help command. ./toybox help cat In bash (and

[Toybox] Explaining the ifconfig cleanup: part I.

2013-04-09 Thread Rob Landley
I blogged a bit (http://landley.net/notes-2013.html#31-03-2013) about how I'd like more cleanup submissions. Possibly if I explain the kind of cleanup I'm going for, it might help with that. When ifconfig was submitted, it touched a half-dozen files. I glued it together into a single

Re: [Toybox] towards xzcat cleanup

2013-04-10 Thread Rob Landley
On 04/10/2013 01:33:12 AM, Isaac Dunham wrote: Hello, First, I'd like to thank Landley for explaining the ifconfig cleanup... Yay! Glad it was useful. Would a similar description of the recent uuencode/uudecode cleanup help? That was fairly good code made tighter, so it's a less-obvious

Re: [Toybox] Broken find [Was: Re: Towards find cleanup]

2013-04-11 Thread Rob Landley
On 04/11/2013 04:37:36 PM, Felix Janda wrote: Now I think that I know better how this toy works and see that my cleanup has broken it. if (filter-op==OP_OR) { -result = evaluate(filter-next, node, fnext); -result2 = evaluate(*fnext, node,

Re: [Toybox] Towards find cleanup

2013-04-11 Thread Rob Landley
On 04/11/2013 04:17:59 PM, Felix Janda wrote: On 04/10/13 at 07:34pm, Rob Landley wrote: snip I think that some function parameters should be made const and that the code could be made less repetitive. I specify static because it allows the compiler to produce better code, but I've

Re: [Toybox] Broken find [Was: Re: Towards find cleanup]

2013-04-11 Thread Rob Landley
On 04/11/2013 07:53:18 PM, Tim Bird wrote: Of maybe the expression tree should actually be put into a binary tree form, instead of serial pre-fix form, for easier traversal. -- Tim The vast majority of my bandwidth is taken up by day job and real life, what's left for toybox I'm cycling

Re: [Toybox] ifconfig: error helper?

2013-04-14 Thread Rob Landley
On 04/13/2013 07:56:34 PM, Isaac Dunham wrote: Hello, I took a look at ifconfig to see about show_help vs toys.exithelp, and I saw this repeated 16 times (string is the only thing that changes): } else if (!strcmp(*argv, string)) { if(*++argv == NULL) { errno = EINVAL;

[Toybox] [CLEANUP] the rest of uuencode.c

2013-04-16 Thread Rob Landley
The rest of the uuencode cleanup was a big opportunity to inline stuff, put common code next to each other, and then eliminate duplication. Alas, if you edit a file and move it in the same commit, mercurial loses track of it. We can beat the patch out of it via: diff -u (hg cat -r 830

Re: [Toybox] ifconfig: simplify exit with help

2013-04-17 Thread Rob Landley
On 04/14/2013 01:03:51 AM, Isaac Dunham wrote: This patch simplifies exiting with help in ifconfig. Has no change on binary size, but loses 37 lines. Also means that ifconfig --help exits cleanly with help disabled. I screwed this up on my first attempt at applying it, but fixed it up in a

[Toybox] [CLEANUP]

2013-04-17 Thread Rob Landley
On 04/16/2013 10:18:59 AM, Kyungwan Han wrote: Hello, I learn programming skill and knowledge from following up code cleaning, so I'm checking the change set: http://www.landley.net/hg/toybox/rev/6be04ec7b7ac Ah, I never did summarize that one, did I? Sorry, my day job at Cray's been

Re: [Toybox] More find cleanup

2013-04-21 Thread Rob Landley
On 04/20/2013 01:39:10 PM, Felix Janda wrote: Hello, some more find cleanup in an attached patch. The main change was to make some code in build_filter_list() less repetitive using a suitable struct and a loop. Huh, it didn't complain building defconfig. (Presumably because it's a pointer

Re: [Toybox] [CLEANUP] stat: Some cleanup

2013-04-21 Thread Rob Landley
On 04/21/2013 04:40:16 PM, Felix Janda wrote: If you can come up with a clean way to share the code, go for it. Ok, actually I'd only put something like get_access_str() of stat into the lib. Cool. Although a quick glance at the one in stat implies it doesn't handle the fun combinations of

Re: [Toybox] [PATCH] ifconfig FTBFS here-needs sys/un.h

2013-04-22 Thread Rob Landley
On 04/21/2013 06:56:03 PM, Isaac Dunham wrote: Hello, I did make allyesconfig; make (to test ifconfig) and get this: Compile toybox... toys/pending/ifconfig.c: In function 'is_host_unix': toys/pending/ifconfig.c:121: error: invalid application of 'sizeof' to incomplete type 'struct

Re: [Toybox] [CLEANUP] [PATCH] stat: Some cleanup

2013-04-22 Thread Rob Landley
On 04/22/2013 04:27:56 PM, Felix Janda wrote: On 04/21/13 at 11:30pm, Rob Landley wrote: Should %T be implemented? I'd wait for somebody to complain about its absence. I like that approach. Attached is another patch removing unimplemented options/formats and doing a bit of cleanup (mainly

Re: [Toybox] Differences between modinfo in toybox and standard version

2013-04-22 Thread Rob Landley
On 04/22/2013 05:40:28 PM, Isaac Dunham wrote: Hello, The kernel maps all occurences of '-' in module names to '_', so that if you load a module such as snd-pcm-oss.ko or phc-k8.ko, it is presented by lsmod and /proc/modules as module snd_pcm_oss or phc_k8. Modinfo from module-init-tools

Re: [Toybox] XBSPATH() bug

2013-04-26 Thread Rob Landley
On 04/25/2013 12:12:20 AM, Ashwini Sharma wrote: Hi Rob, Calling xabspath() function with exact=1, makes sure that the last path component exists. I think the decision making statement fd = openat(dirfd, s, 0); if (fd == -1 (exact || todo || errno != ENOENT)) goto error; will jump to

Re: [Toybox] About supporting long(--) option

2013-04-29 Thread Rob Landley
On 04/29/2013 01:17:46 AM, Kyungwan Han wrote: Hello all, I have a question about treating long(--) option in toybox. There are two style options - short(-) and long(--) - in linux system. (

Re: [Toybox] generated/help.h depends on CONFIG_TOYBOX_HELP

2013-05-01 Thread Rob Landley
On 04/30/2013 02:13:11 PM, Felix Janda wrote: Hello, the build of toybox was broken if CONFIG_TOYBOX_HELP was enabled but CONFIG_HELP was disabled (and help.h was not yet generated). The attached patch fixes it. Felix Applied, thanks. Probably won't get to rsync until this evening. Rob

Re: [Toybox] toynet.h to be included in toys.h

2013-05-03 Thread Rob Landley
On 05/03/2013 01:09:56 AM, Ashwini Sharma wrote: And from 2~3 days I don't see the link to download the latest source from Mercurial. -Ashwini Ah, the reset didn't copy the right hgrc file. Fixed. Thanks, Rob ___ Toybox mailing list

Re: [Toybox] new toy: lsusb

2013-05-14 Thread Rob Landley
On 05/14/2013 12:56:00 AM, Andre Renaud wrote: Hi, Attached is a pretty simple implementation of lsub. It doesn't implement any of the flags/options, but does the raw output. I believe this is essentially the same functionality as what is available from busybox. Very nice. (Applied.) Is there

Re: [Toybox] new toy: lsusb

2013-05-14 Thread Rob Landley
On 05/14/2013 06:27:24 PM, Andre Renaud wrote: Hi Rob, On 15 May 2013 11:06, Rob Landley r...@landley.net wrote: Is there something special about the entries that have DEVTYPE= as the first line? Depending on the ordering seems darn subtle here. I did a quick: You're right, relying

Re: [Toybox] new toy: lsusb

2013-05-14 Thread Rob Landley
On 05/15/2013 12:06:09 AM, Andre Renaud wrote: As a separate feature (I'm not suggesting we actually use this patch), lsusb is supposed to parse /usr/share/misc/usb.ids to get readable names for devices. You're way ahead of me. :) Obviously for space reasons we don't want to use this file.

Re: [Toybox] Would you consider adding showkey...but

2013-05-15 Thread Rob Landley
On 05/14/2013 08:04:33 PM, scsijon wrote: Would you consider adding the busybox showkey, but with a user set time including 0 for immediate, rather than the default 10 seconds? Um, details? I don't think I've ever used busybox showkey, but I'm happy to look at patch submissions. (I may be

Re: [Toybox] Would you consider adding showkey...but

2013-05-17 Thread Rob Landley
On 05/15/2013 04:29:25 PM, Isaac Dunham wrote: On Wed, 15 May 2013 11:32:28 -0500 Rob Landley r...@landley.net wrote: On 05/14/2013 08:04:33 PM, scsijon wrote: Would you consider adding the busybox showkey, but with a user set time including 0 for immediate, rather than the default 10

Re: [Toybox] add groups implementation to id.c

2013-05-18 Thread Rob Landley
On 05/17/2013 08:13:12 AM, Ivo van Poorten wrote: It's reasonably straightforward to add via loopfiles(). See toys/posix/wc.c for example. I did it slightly different because the arguments are not files (see attached patch). Perhaps this could move to lib.c as loopstrings() or something in

[Toybox] --help option.

2013-05-18 Thread Rob Landley
On 04/29/2013 12:35:00 PM, Felix Janda wrote: Is there special reason for not supporting long option? That they are from GNU. It simplifies deleting files named --help.^^ A while back I jadded --help to the toybox multiplexer (as an alias for the help command), so at least busybox people

[Toybox] [CLEANUP] Next ifconfig pass (commit 905)

2013-05-19 Thread Rob Landley
Cleaning up ifconfig, commit 905: http://landley.net/hg/toybox/rev/905 get_strtou() isn't actually needed: it's a wrapper for strtoul() that's only ever called once. It sets most of its effort setting errno, but all you need to know is that the endptr from strtou isn't the end of the

[Toybox] [CLEANUP] ifconfig commit 906

2013-05-21 Thread Rob Landley
http://landley.net/hg/toybox/rev/906 I started by doing the table cleanup I mentioned last message, bringing the table back down to three members. I took out the array and made all three members separate, called name, on, and off, and just had the flag setting logic doing two ? : swaps to

[Toybox] [CLEANUP] ifconfig commit 907

2013-05-21 Thread Rob Landley
http://landley.net/hg/toybox/rev/907 --- show_ip_addr The function show_ip_addr() is only ever called from display_ifconfig. It's called four times in a row, so it's better to have it be a function that repeated inline four times. However, it's even better to have it be the body of a loop

Re: [Toybox] Regarding if() condition in dirtree_add_node

2013-05-21 Thread Rob Landley
On 05/21/2013 12:36:41 AM, Sandeep Sharma wrote: Hi Rob, I have came across a condition in dirtree_add_node(), where we are reading the link even though symfollow is not set :- if (S_ISLNK(st.st_mode) { if (0(linklen = readlinkat(fd, name, buf,

Re: [Toybox] Hello, I would like to carve out a project

2013-05-24 Thread Rob Landley
On 05/24/2013 12:06:37 PM, Terrel Shumway wrote: need to swap uClibc out for musl as soon as I get time to rewrite ccwrap. (After finishing mount.c.) OT: Exactly what remains to ditch uClibc? musl looks pretty complete. It's not musl that's incomplete (so far, anyway), it's my ccwrap.c.

[Toybox] [CLEANUP] stat's done.

2013-06-02 Thread Rob Landley
I put description text into commits 912, 914, 916, and 917, all building on Felix's work. And then the actual mv was its own commit (918) in hopes of confusing source control less. (Although I did switch default n to default y in the same commit so the file wasn't _identical_...)

[Toybox] Posix: failing by omission since 1988.

2013-06-19 Thread Rob Landley
The split command creates output files. If an output file exists, does it truncate it? Append to it? Fail? Posix doesn't say. If you split an empty file, does it create one empty output file, or no output files? What are the permissions of the new files? Maybe I'm not reading the spec

[Toybox] Pending fiddliness

2013-06-19 Thread Rob Landley
I've been holding off on mv forever, even though it's a commonly used command that I've got the infrastructure for (it's a simpler version of cp), because I haven't figured out how to get the code sharing quite right yet. I want to share infrastructure between mv an option of cp. The

Re: [Toybox] [PATCH] Re: modinfo...

2013-06-23 Thread Rob Landley
On 06/20/2013 11:24:48 PM, Isaac wrote: On Wed, Jun 19, 2013 at 11:44:08PM -0500, Rob Landley wrote: On 06/18/2013 08:55:42 AM, Isaac wrote: Oh, there's a trivial option to add to modinfo: -b basedir (used for constructing an initrd-it locates the modules within a given directory). Um

Re: [Toybox] Posix: failing by omission since 1988.

2013-06-26 Thread Rob Landley
On 06/22/2013 02:32:12 AM, Felix Janda wrote: If you split an empty file, does it create one empty output file, or no output files? The split utility shall read an input file and write one or more output files. So the implementation in ubuntu is nonconforming then? I tested

Re: [Toybox] Posix: failing by omission since 1988.

2013-07-01 Thread Rob Landley
On 06/26/2013 10:43:42 PM, David Seikel wrote: On Wed, 26 Jun 2013 01:06:28 -0500 Rob Landley r...@landley.net wrote: Remember: the S-100 systems were standardized. (IEEE 646 was it?) The PC systems were merely copying what IBM did, then what Compaq did, then copying each other. Guess

[Toybox] Sigh. Anybody spot the bug?

2013-07-03 Thread Rob Landley
Tail has a double free somewhere. (Aboriginal's more/buildall.sh is complaining, that uses toybox in host-tools.) Haven't had time to track it down yet, wondering if anybody else could spot it. From the behavior it's looking like it's on file close... Rob *** glibc detected *** tail:

Re: [Toybox] Implement paste

2013-07-03 Thread Rob Landley
On 06/29/2013 08:17:03 AM, Felix Janda wrote: Hello, here's a version of paste. It doesn't deal with wide characters yet and likely behaves very badly when given too many files or delimiters. --Felix Applied. There are some pending cleanups but it's small enough I can do 'em in situ

Re: [Toybox] ls segfault

2013-07-07 Thread Rob Landley
On 06/29/2013 04:11:26 PM, Felix Janda wrote: ls segfaults if there is only one file to display. And /dev/tty reports a screen size of 0,0. The problem seems to be: static void listfiles(int dirfd, struct dirtree *indir) { ... for (ul = 0; uldtlen; ul++) { unsigned curcol; ... //

Re: [Toybox] Sigh. Anybody spot the bug?

2013-07-07 Thread Rob Landley
On 07/03/2013 01:56:46 PM, Felix Janda wrote: Rob Landley wrote: Tail has a double free somewhere. (Aboriginal's more/buildall.sh is complaining, that uses toybox in host-tools.) Haven't had time to track it down yet, wondering if anybody else could spot it. From the behavior it's

Re: [Toybox] Modinfo parm/parmtype patch

2013-07-08 Thread Rob Landley
On 07/07/2013 05:57:41 PM, Andre Renaud wrote: Yes, you're correct - the only way to handle that output type is to buffer the parm/parmtype options until the end, and then intelligently merge them. For such a minimal toy that doesn't really seem like a sensible thing to do. I guess the question

[Toybox] [CLEANUP] ifconfig commit 957

2013-07-20 Thread Rob Landley
http://landley.net/hg/toybox/rev/957 It's been a while. I got a bit blocked on get_sockaddr() cleanup, because although it's only ever called twice (once for ipv6 and once for ipv4), I don't understand what the addresses it's parsing should look like. For example, does local: apply to just

[Toybox] [CLEANUP] paste

2013-07-20 Thread Rob Landley
Description of the paste cleanup that accidentally got checked in during commit 944 because hg import -f has side effects. http://landley.net/hg/toybox/rev/944 (Yes, that commit description is actively ironic. Scroll down to patch.c.) Minor tweaks to the first loop: if -d isn't set then

[Toybox] Is the list working again?

2013-07-23 Thread Rob Landley
The list server's disk filled up. I submitted a support ticket to dreamhost last night, if this goes through presumably it's working again... (About 4000 emails behind, catching up...) Rob ___ Toybox mailing list Toybox@lists.landley.net

Re: [Toybox] lspci

2013-07-23 Thread Rob Landley
On 07/22/2013 10:57:38 PM, Isaac wrote: On Tue, Jul 23, 2013 at 11:40:46AM +1000, scsijon wrote: Can I take it that even though you've not mentioned them to date that you are including the three double character switches. They are absolutely magic when debugging a build with a device problem.

Re: [Toybox] [PATCH] grep: cleanup, add -Hs

2013-07-24 Thread Rob Landley
On 07/23/2013 08:22:08 PM, Strake wrote: # HG changeset patch # User Strake # Date 1374628771 18000 # Node ID 8ad85a95f7c3b75214fbd3a46fe834de45c39417 # Parent 019f54d50c8be39306675e0f182a124f6446307d grep Would have preferred a litle more description than that, but it's applied to my

  1   2   3   4   5   6   7   8   9   10   >