Re: [U-Boot] [PATCH] mx53loco: Fix PMIC name

2013-01-03 Thread Stefano Babic
On 02/01/2013 21:02, Fabio Estevam wrote: On Wed, Jan 2, 2013 at 5:58 PM, Robert Nelson robertcnel...@gmail.com wrote: Sweet! Thanks Troy, That fixes it on my Dialog based mx53loco with linaro's 4.7.3 gcc toolchain... Excellent, Troy! Fixes the issue for me with gcc 4.6.2 as well.

Re: [U-Boot] [PATCH] mx53loco: Fix PMIC name

2013-01-03 Thread Fabio Estevam
Hi Stefano, On Thu, Jan 3, 2013 at 6:53 AM, Stefano Babic sba...@denx.de wrote: Hi all, the patch was only blocked for Wolfgang's comment regarding the introduced ALIGN() macro. I think the other doubts regarding issues on other Socs (i.e., MX6) can be considered closed as well. IMHO it is

Re: [U-Boot] [PATCH] mx53loco: Fix PMIC name

2013-01-03 Thread Marek Vasut
Dear Fabio Estevam, Hi Stefano, On Thu, Jan 3, 2013 at 6:53 AM, Stefano Babic sba...@denx.de wrote: Hi all, the patch was only blocked for Wolfgang's comment regarding the introduced ALIGN() macro. I think the other doubts regarding issues on other Socs (i.e., MX6) can be

Re: [U-Boot] [PATCH] mx53loco: Fix PMIC name

2013-01-03 Thread Fabio Estevam
On Thu, Jan 3, 2013 at 11:30 AM, Marek Vasut ma...@denx.de wrote: Ugh, why can't the stuff from common.h be used ? Yes, I tried it initially, but it throws a lot of errors that I am not sure that they can be easily fixed: gcc -Wall -Wstrict-prototypes -O2 -fomit-frame-pointer -idirafter

Re: [U-Boot] [PATCH] mx53loco: Fix PMIC name

2013-01-03 Thread Marek Vasut
Dear Fabio Estevam, On Thu, Jan 3, 2013 at 11:30 AM, Marek Vasut ma...@denx.de wrote: Ugh, why can't the stuff from common.h be used ? Yes, I tried it initially, but it throws a lot of errors that I am not sure that they can be easily fixed: Only with #include common.h ? Regards,

Re: [U-Boot] [PATCH] mx53loco: Fix PMIC name

2013-01-03 Thread Stefano Babic
On 03/01/2013 14:25, Fabio Estevam wrote: Hi Stefano, On Thu, Jan 3, 2013 at 6:53 AM, Stefano Babic sba...@denx.de wrote: Hi all, the patch was only blocked for Wolfgang's comment regarding the introduced ALIGN() macro. I think the other doubts regarding issues on other Socs (i.e., MX6)

Re: [U-Boot] [PATCH] mx53loco: Fix PMIC name

2013-01-03 Thread Stefano Babic
On 03/01/2013 14:49, Marek Vasut wrote: Dear Fabio Estevam, Hi, On Thu, Jan 3, 2013 at 11:30 AM, Marek Vasut ma...@denx.de wrote: Ugh, why can't the stuff from common.h be used ? Yes, I tried it initially, but it throws a lot of errors that I am not sure that they can be easily fixed:

Re: [U-Boot] [PATCH] mx53loco: Fix PMIC name

2013-01-03 Thread Fabio Estevam
On Thu, Jan 3, 2013 at 11:49 AM, Marek Vasut ma...@denx.de wrote: Dear Fabio Estevam, On Thu, Jan 3, 2013 at 11:30 AM, Marek Vasut ma...@denx.de wrote: Ugh, why can't the stuff from common.h be used ? Yes, I tried it initially, but it throws a lot of errors that I am not sure that they can

Re: [U-Boot] [PATCH] mx53loco: Fix PMIC name

2013-01-03 Thread Troy Kisky
On 1/3/2013 7:07 AM, Stefano Babic wrote: On 03/01/2013 14:49, Marek Vasut wrote: Dear Fabio Estevam, Hi, On Thu, Jan 3, 2013 at 11:30 AM, Marek Vasut ma...@denx.de wrote: Ugh, why can't the stuff from common.h be used ? Yes, I tried it initially, but it throws a lot of errors that I am

Re: [U-Boot] [PATCH] mx53loco: Fix PMIC name

2013-01-03 Thread Fabio Estevam
On Thu, Jan 3, 2013 at 4:18 PM, Troy Kisky troy.ki...@boundarydevices.com wrote: It would be good to include this in commit log if not already committed. Ok, just sent a v2 with such comment. Regards, Fabio Estevam ___ U-Boot mailing list

Re: [U-Boot] [PATCH] mx53loco: Fix PMIC name

2013-01-02 Thread Robert Nelson
On Wed, Dec 26, 2012 at 11:51 AM, Robert Nelson robertcnel...@gmail.com wrote: On Wed, Dec 26, 2012 at 11:21 AM, Fabio Estevam feste...@gmail.com wrote: On Wed, Dec 26, 2012 at 3:08 PM, Robert Nelson robertcnel...@gmail.com wrote: I'll keep debugging it here, did reverting this commit, help

Re: [U-Boot] [PATCH] mx53loco: Fix PMIC name

2013-01-02 Thread Fabio Estevam
On Wed, Jan 2, 2013 at 4:27 PM, Robert Nelson robertcnel...@gmail.com wrote: Okay success on another bisect run to find what was causing the Data Abort with linaro's gcc toolchain.. gcc version 4.7.3 20121205 (prerelease) (crosstool-NG linaro-1.13.1-4.7-2012.12-20121214 - Linaro GCC 2012.12)

Re: [U-Boot] [PATCH] mx53loco: Fix PMIC name

2013-01-02 Thread Troy Kisky
On 1/2/2013 11:33 AM, Fabio Estevam wrote: Thanks for bisecting, Robert. Troy/Stefano, Any suggestions about this? It would be really nice if we could keep mx53loco functional when using gcc 4.6.2. Regards, Fabio Estevam Could you see if this patch makes any difference? It still needs cleaned

Re: [U-Boot] [PATCH] mx53loco: Fix PMIC name

2013-01-02 Thread Robert Nelson
On Wed, Jan 2, 2013 at 1:42 PM, Troy Kisky troy.ki...@boundarydevices.com wrote: On 1/2/2013 11:33 AM, Fabio Estevam wrote: Thanks for bisecting, Robert. Troy/Stefano, Any suggestions about this? It would be really nice if we could keep mx53loco functional when using gcc 4.6.2. Regards, Fabio

Re: [U-Boot] [PATCH] mx53loco: Fix PMIC name

2013-01-02 Thread Fabio Estevam
On Wed, Jan 2, 2013 at 5:58 PM, Robert Nelson robertcnel...@gmail.com wrote: Sweet! Thanks Troy, That fixes it on my Dialog based mx53loco with linaro's 4.7.3 gcc toolchain... Excellent, Troy! Fixes the issue for me with gcc 4.6.2 as well. It would be really nice to have this one applied

Re: [U-Boot] [PATCH] mx53loco: Fix PMIC name

2012-12-26 Thread Fabio Estevam
Robert, On Thu, Dec 20, 2012 at 8:04 PM, Robert Nelson robertcnel...@gmail.com wrote: Hi Fabio, It looks like we need one more fixup after commit c73368150 on the first run/older (non R, Dialog, bug wired extra Capacitor) version of this board.. Do you happen to have any in your lab?

Re: [U-Boot] [PATCH] mx53loco: Fix PMIC name

2012-12-26 Thread Fabio Estevam
On Wed, Dec 26, 2012 at 1:02 PM, Fabio Estevam feste...@gmail.com wrote: With the new PMIC framework: is it safe to call the PMIC API from board_init function? Calling it from board_late_init fixes the issue for me. Will send the patch soon. Regards, Fabio Estevam

Re: [U-Boot] [PATCH] mx53loco: Fix PMIC name

2012-12-26 Thread Fabio Estevam
Robert, On Wed, Dec 26, 2012 at 1:07 PM, Fabio Estevam feste...@gmail.com wrote: On Wed, Dec 26, 2012 at 1:02 PM, Fabio Estevam feste...@gmail.com wrote: With the new PMIC framework: is it safe to call the PMIC API from board_init function? Calling it from board_late_init fixes the issue

Re: [U-Boot] [PATCH] mx53loco: Fix PMIC name

2012-12-26 Thread Fabio Estevam
On Wed, Dec 26, 2012 at 1:51 PM, Robert Nelson robertcnel...@gmail.com wrote: Interesting, I'm still only getting this far on the old Dialog board.. U-Boot 2013.01-rc2-00173-gd781d95-dirty (Dec 26 2012 - 09:42:43) Board: MX53 LOCO I2C: ready DRAM: 1 GiB I tested with 2 mx53loco boards

Re: [U-Boot] [PATCH] mx53loco: Fix PMIC name

2012-12-26 Thread Robert Nelson
Hi Fabio, On Wed, Dec 26, 2012 at 9:21 AM, Fabio Estevam feste...@gmail.com wrote: Robert, On Wed, Dec 26, 2012 at 1:07 PM, Fabio Estevam feste...@gmail.com wrote: On Wed, Dec 26, 2012 at 1:02 PM, Fabio Estevam feste...@gmail.com wrote: With the new PMIC framework: is it safe to call the

Re: [U-Boot] [PATCH] mx53loco: Fix PMIC name

2012-12-26 Thread Robert Nelson
On Wed, Dec 26, 2012 at 9:54 AM, Fabio Estevam feste...@gmail.com wrote: On Wed, Dec 26, 2012 at 1:51 PM, Robert Nelson robertcnel...@gmail.com wrote: Interesting, I'm still only getting this far on the old Dialog board.. U-Boot 2013.01-rc2-00173-gd781d95-dirty (Dec 26 2012 - 09:42:43)

Re: [U-Boot] [PATCH] mx53loco: Fix PMIC name

2012-12-26 Thread Fabio Estevam
On Wed, Dec 26, 2012 at 2:04 PM, Robert Nelson robertcnel...@gmail.com wrote: Okay, good to hear it works with the Dialog PMIC you have, as that should cover a majority of the Dialog based boards customers actually have. As the one I have here was one of the very first ones and i know

Re: [U-Boot] [PATCH] mx53loco: Fix PMIC name

2012-12-26 Thread Robert Nelson
On Wed, Dec 26, 2012 at 10:50 AM, Fabio Estevam feste...@gmail.com wrote: On Wed, Dec 26, 2012 at 2:04 PM, Robert Nelson robertcnel...@gmail.com wrote: Okay, good to hear it works with the Dialog PMIC you have, as that should cover a majority of the Dialog based boards customers actually

Re: [U-Boot] [PATCH] mx53loco: Fix PMIC name

2012-12-26 Thread Fabio Estevam
On Wed, Dec 26, 2012 at 3:08 PM, Robert Nelson robertcnel...@gmail.com wrote: I'll keep debugging it here, did reverting this commit, help with the resets? http://git.denx.de/?p=u-boot.git;a=commit;h=28e5ac2d974547bde0c72aa0c1d66fd22c6ef3ad Tried reverting it and still see the data-aborts. I

Re: [U-Boot] [PATCH] mx53loco: Fix PMIC name

2012-12-26 Thread Robert Nelson
On Wed, Dec 26, 2012 at 11:21 AM, Fabio Estevam feste...@gmail.com wrote: On Wed, Dec 26, 2012 at 3:08 PM, Robert Nelson robertcnel...@gmail.com wrote: I'll keep debugging it here, did reverting this commit, help with the resets?

Re: [U-Boot] [PATCH] mx53loco: Fix PMIC name

2012-12-22 Thread Fabio Estevam
Hi Robert, On Thu, Dec 20, 2012 at 8:04 PM, Robert Nelson robertcnel...@gmail.com wrote: Hi Fabio, It looks like we need one more fixup after commit c73368150 on the first run/older (non R, Dialog, bug wired extra Capacitor) version of this board.. Do you happen to have any in your lab?

Re: [U-Boot] [PATCH] mx53loco: Fix PMIC name

2012-12-20 Thread Robert Nelson
On Tue, Dec 11, 2012 at 10:36 AM, Fabio Estevam fabio.este...@freescale.com wrote: commit c73368150 (pmic: Extend PMIC framework to support multiple instances of PMIC devices) has incorrectly passed the PMIC name under the FSL PMIC case. Fix that by passing FSL_PMIC as the parameter of

Re: [U-Boot] [PATCH] mx53loco: Fix PMIC name

2012-12-13 Thread Stefano Babic
On 11/12/2012 17:36, Fabio Estevam wrote: commit c73368150 (pmic: Extend PMIC framework to support multiple instances of PMIC devices) has incorrectly passed the PMIC name under the FSL PMIC case. Fix that by passing FSL_PMIC as the parameter of pmic_get. Signed-off-by: Fabio Estevam

[U-Boot] [PATCH] mx53loco: Fix PMIC name

2012-12-11 Thread Fabio Estevam
commit c73368150 (pmic: Extend PMIC framework to support multiple instances of PMIC devices) has incorrectly passed the PMIC name under the FSL PMIC case. Fix that by passing FSL_PMIC as the parameter of pmic_get. Signed-off-by: Fabio Estevam fabio.este...@freescale.com ---