Can someone summarize conclusion from Mozilla's site? I can work on it
but not until there's a clear what is required.
[:gsvelto] are you willing to participate on the reviews?
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to the bug report.
Okay, it seems that we're moving in circles. Who's going to decide which
approach to choice? I can implement storing password to system keyrings
but I won't do this without clear statement from Mozilla what they would
like more. I still prefer storing only master password because of loose
Okay, it seems that we're moving in circles. Who's going to decide which
approach to choice? I can implement storing password to system keyrings
but I won't do this without clear statement from Mozilla what they would
like more. I still prefer storing only master password because of loose
(In reply to Jesse Glick from comment #102)
explain how a user would switch from Linux to Windows and bring their
passwords with them
Same way you would for secrets used by any other application: enter them
again. This is an OS/desktop issue, not the responsibility of an individual
(In reply to Jesse Glick from comment #102)
explain how a user would switch from Linux to Windows and bring their
passwords with them
Same way you would for secrets used by any other application: enter them
again. This is an OS/desktop issue, not the responsibility of an individual
(In reply to Brian Smith (:briansmith), was bsm...@mozilla.com (:bsmith) from
comment #94)
4) Some people at Mozilla are working on this Sign into the browser /
Profile in the Cloud thing, of which Sync is a part. See
https://wiki.mozilla.org/Identity/AttachedServices. I think it is important
(In reply to Brian Smith (:briansmith), was bsm...@mozilla.com (:bsmith) from
comment #94)
4) Some people at Mozilla are working on this Sign into the browser /
Profile in the Cloud thing, of which Sync is a part. See
https://wiki.mozilla.org/Identity/AttachedServices. I think it is important
Created attachment 736256
Save resolution (dpi) and duplex settings v4
Hmm, strange, looks like part:
const unsigned long kInitSaveResolution = 0x0400;
const unsigned long kInitSaveDuplex = 0x0800;
disappeared from patch during checkin somehow, maybe bitrotten patch? I'm
Created attachment 732297
Save uri for downloaded files patch v3
Thanks, I'm aware of changing uuid when idl is changing but I forgot to
do it, sorry guys.
Attaching patch with fixed uuid, copying review and superreview from
previous comments.
--
You received this bug notification because you
Created attachment 730597
Save resolution (dpi) and duplex settings v2
Thanks for feedback, asking roc for review of fixed patch.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/526482
Title:
Do I need superreview while changing idl file before it can be checked
in?
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/526482
Title:
Firefox don't save print settings
To manage notifications
Created attachment 729488
Save resolution (dpi) and duplex settings v1
I've made patch which adds support of saving print resolution and duplex
settings to preferences. It saves these preferences only when they are
available to selected printer.
--
You received this bug notification because you
The SmcCloseConnection called after nsIAppStartup::Quit improved
situation a bit, but it's not 100%. The best so far was not to call
SmcCloseConnection from DieCB at all. Destructor of
nsNativeAppSupportUnix calls DisconnectFromSM and according to my
testing it seems to be working just fine.
--
I think problem is that nsIAppStartup::Quit have some async calls and
returns sooner than application is actually quit. The session manager is
expecting that Firefox quit is finished when it returns from
nsNativeAppSupportUnix::DieCB method.
We need to wait in nsNativeAppSupportUnix::DieCB until
Ignore last comment, problem was with Fedora's Gnome shell.
Basically it looks like it's working fine. Problem is that Firefox quit,
ie. nsIAppStartup::Quit takes some time and session manager is sometimes
impatient and kills Firefox sooner that it actually quits which leads to
another 'Well,
Created attachment 713868
Store Master Password by using libsecret to Gnome Keyring patch v2
Thanks Stef for feedback. I've fixed mentioned issues.
(In reply to Stef Walter from comment #84)
@@ +808,5 @@
+
+ secret_password_lookup(MOZILLA_SECRET_SCHEMA, nullptr,
on_lookup_finished, this,
Created attachment 713868
Store Master Password by using libsecret to Gnome Keyring patch v2
Thanks Stef for feedback. I've fixed mentioned issues.
(In reply to Stef Walter from comment #84)
@@ +808,5 @@
+
+ secret_password_lookup(MOZILLA_SECRET_SCHEMA, nullptr,
on_lookup_finished, this,
Created attachment 713377
Store Master Password by using libsecret to Gnome Keyring patch v1
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/217300
Title:
Seahorse integration
To manage
Created attachment 713377
Store Master Password by using libsecret to Gnome Keyring patch v1
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/41179
Title:
Integrate with Gnome Keyring
To
Created attachment 709034
Store Master Password to Gnome Keyring patch v3
Changes
- Prompt user if he wants to store master password to Gnome Keyring.
- rewritten patch a bit to avoid a lot of nested ifs.
Changing reviewer as long as Kai showed some interest in this patch. Thanks.
--
You
Created attachment 709034
Store Master Password to Gnome Keyring patch v3
Changes
- Prompt user if he wants to store master password to Gnome Keyring.
- rewritten patch a bit to avoid a lot of nested ifs.
Changing reviewer as long as Kai showed some interest in this patch. Thanks.
--
You
Created attachment 707001
Store Master Password to Gnome Keyring patch v2
Fixed patch, asking for review from PSM.
The patch has one drawback though. In Saved Passwords list the master password
is not required to show password for each record. However Gnome keyring also
allows to show password
I'm getting IO error occured doing Protocol Setup on connection when calling
SmcOpenConnection.
Libs used:
libSM-1.2.1-2.fc18.x86_64
libICE-1.0.8-2.fc18.x86_64
it dies somewhere in _IceRead function.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is
Created attachment 707001
Store Master Password to Gnome Keyring patch v2
Fixed patch, asking for review from PSM.
The patch has one drawback though. In Saved Passwords list the master password
is not required to show password for each record. However Gnome keyring also
allows to show password
(In reply to fabrice.neyret from comment #74)
Hi guys. I came here BTWof the author of a linkifyer extension for
thunderbird.
I must say I'm a bit afraid by what I read in this discussions.
- '+' IS a legal character for files in unix.
- svn+ssh: IS an extremely important url for developpers
Created attachment 706354
Store Master Password to Gnome Keyring patch v1
I've made a patch for storing Master password to Gnome Keyring. Not sure
who ask for review. I'm trying you neil as long as I see you as peer on
Passwords Permissions module.
--
You received this bug notification because
(In reply to n...@parkwaycc.co.uk from comment #78)
Comment on attachment 706354
Store Master Password to Gnome Keyring patch v1
You need build system and PSM reviews, so I'll just comment on code patterns.
+ PRUnichar *password = nullptr;
+ nsAutoString promptString;
+
Created attachment 706354
Store Master Password to Gnome Keyring patch v1
I've made a patch for storing Master password to Gnome Keyring. Not sure
who ask for review. I'm trying you neil as long as I see you as peer on
Passwords Permissions module.
--
You received this bug notification because
(In reply to n...@parkwaycc.co.uk from comment #78)
Comment on attachment 706354
Store Master Password to Gnome Keyring patch v1
You need build system and PSM reviews, so I'll just comment on code patterns.
+ PRUnichar *password = nullptr;
+ nsAutoString promptString;
+
Storing only master password in (Gnome/KDE) keyring could be less
complicated in this case and it would still work with Mozilla's Sync,
wouldn't it?
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
Storing only master password in (Gnome/KDE) keyring could be less
complicated in this case and it would still work with Mozilla's Sync,
wouldn't it?
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to the bug report.
So what is current Mozilla point of view to incorporate this enhancement to
Firefox directly (without extension)? And if so what is more preferable:
1. store all saved password in keyring
2. store only master password in keyring.
--
You received this bug notification because you are a member of
So what is current Mozilla point of view to incorporate this enhancement to
Firefox directly (without extension)? And if so what is more preferable:
1. store all saved password in keyring
2. store only master password in keyring.
--
You received this bug notification because you are a member of
Created attachment 680081
fix for gconf v1
This is simple hack to avoid showing the error window. It shouldn't
affect Firefox or Thunderbird when GIO backend was enabled, as long as
gvfs is used only as fallback when GIO service is not available. This
fix suitable for long time support version of
My fix works for RHEL5, where's no gio, so I can't recompile with
--enable-gio there. You may consider to disable gio in your builds,
because as you say Ubuntu is using early version of gio and it is
probably only wrapper to gvfs (when you experience same popup error
window as gvfs creates).
Created attachment 681454
workaround for old gconf
(In reply to n...@parkwaycc.co.uk from comment #56)
Comment on attachment 680081
fix for gconf v1
Sorry, we can't accept a diff against the mozilla-beta part of a comm-beta
checkout. If you think the issue affects Thunderbird 17 then you
Jonathan, could you please try to disable gio for your build and test if
this workaround works? Thanks.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/411358
Title:
Thunderbird2 gconf gmt problem
(In reply to Karl Tomlinson (:karlt) from comment #66)
Comment on attachment 681454
fix for gconf v2
+ /* This check is to avoid bug #541130 when old version of gnomevfs (2.16
tested)
+ is installed then error window pops up if scheme is containing '+'
character.
+ Let's
Comment on attachment 681454
workaround for old gconf
Thanks for digging these bug numbers.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/411358
Title:
Thunderbird2 gconf gmt problem 'Bad key or
Hm, I can't say it's a fault of --enable-gio, this seems to be related to
g(nome)vfs. There's no libgio in RHEL5 (usually located in glib2 package) and
g(nome)vfs backend is used during compilation and I see same error message.
Affected versions:
- gnome-vfs2-2.16.2
- gnome-2.16.0
--
You
I'm getting popup and I don't have libgio installed. I think it is
related to older version of gnome-vfs2. I'll try to do some debugging
tomorrow, and we'll see.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
Any news on this subject? I may try to create some patch for this one.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/867424
Title:
Oneric: On boot up Firefox always displays the “Well, This Is
Created attachment 579030
gsettings proxy patch v5
Thanks for review, attaching patch with replaced PR_FALSE.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/875266
Title:
Firefox ignores GNOME 3
Created attachment 578520
gsettings proxy patch v4
- Removed forgotten org.gnome.system.proxy.http
- GetProxyFromEnvironment moved to the end as the last method to use to
determine proxy
- Part for checking org.gnome.syste.proxy schema removed.
--
You received this bug notification because you
Created attachment 577534
gsettings proxy patch v2
Thanks for reviewing. Attaching patch which should respect mentioned
issues.
There is a new symbol that needs to be added to the GSETTINGS_FUNCTIONS at the
top of the file for dynamic lookup, and some other things to touch up there so
that this
Created attachment 578249
gsettings proxy patch v3
Attaching next version. Mentioned issues should be resolved. Also
changed UUID of nsIGSettingsService due to its change.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
(In reply to Karl Tomlinson (:karlt) from comment #7)
Think about whether using NS_NewAdoptingUTF8StringEnumerator instead of
nsIMutableArray would simplify things:
http://hg.mozilla.org/mozilla-central/annotate/84117219ded0/xpcom/ds/
nsStringEnumerator.h#l90
Isn't
Considering first option: I understand that using dbus is suitable only
for Gnome but libgnome(ui) is also Gnome-only, right? So far only Gnome
platform was supported.
I also like third option but I'm unsure what's Mozilla's attitude to
embedding foreign sources.
What is for sure that we need to
Created attachment 567725
DumpJSStack
By checking js stacktrace getting proxy settings for this kind of URI
makes sense. I can't imagine how to avoid it during startup.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
Created attachment 567719
backtrace first run
Attaching backtrace of first run (when previous version of Firefox was
executed last time).
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/875266
Title:
Created attachment 567720
backtrace next run
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/875266
Title:
Firefox ignores GNOME 3 proxy settings
To manage notifications about this bug go to:
Setting checkin-needed, is it possible?
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/539226
Title:
firefox(-gnome-support) should be compiled with Gio support instead
GnomeVFS
--
ubuntu-bugs
Created attachment 502759
Patch 0.1, fixed license
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/539226
Title:
firefox(-gnome-support) should be compiled with Gio support instead
GnomeVFS
--
Created attachment 502458
Patch 0.9, fixed comments and mount operation enum
Ah, sorry about it, I was too hasty with enums. Thanks for fixing
comments too.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
Created attachment 501303
Patch 0.7, sync to mozilla-central
Please have a look at version synced with latest mozilla-central. When
review gets positive I'll try to set need-checkin.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
Created attachment 501632
Patch 0.8, fixed comments and added mount operation enum
Here it comes...
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/539226
Title:
firefox(-gnome-support) should be
56 matches
Mail list logo
