[UrJTAG-dev] typedef's

2019-07-31 Thread karl
When trying to understand the urjtag program code, I needed to get definitions of the types used. I many cases typedefs was used for structs and unions, making it unnessesary hard to the understand the type. The worst offenders was in include/urjtag/types.h where the typedefs is in a different

Re: [UrJTAG-dev] new driver, please review and/or commit

2019-07-31 Thread karl
Geert Stappers: > On Tue, Jul 30, 2019 at 12:23:10PM +0200, k...@aspodata.se wrote: > > My driver seems to be working now. > > Please review and/or commit the attached diff and files. > > Now available as > https://sourceforge.net/p/urjtag/git/ci/bae418ae734a7908a3c3ecf0ebf0432fe543ee5b/ > So at

Re: [UrJTAG-dev] data/MANUFACTURERS

2019-07-31 Thread karl
Karl: > But what is the best way to update the manufacturers list ? > > Jedec uses bank, and id within bank. How do I convert that to the > format used in data/MANUFACTURERS ? ... I come up the the attached code. The urjtag file has three columns: $ grep Hitachi data/MANUFACTURERS

Re: [UrJTAG-dev] data/MANUFACTURERS

2019-07-31 Thread karl
G G: > On Wed, Jul 31, 2019 at 10:44:45PM +0200, k...@aspodata.se wrote: ... > > The urjtag file has three columns: > > > > $ grep Hitachi data/MANUFACTURERS > > 111 hitachi Hitachi > > > > and mine only has two: > > > > $ ./jep106 | grep Hitachi > > 111 Hitachi

Re: [UrJTAG-dev] new driver, please review and/or commit

2019-07-31 Thread Geert Stappers
On Wed, Jul 31, 2019 at 10:50:53AM +0200, k...@aspodata.se wrote: > Geert Stappers: > > On Tue, Jul 30, 2019 at 12:23:10PM +0200, k...@aspodata.se wrote: > > > My driver seems to be working now. > > > Please review and/or commit the attached diff and files. > > > > Now available as > >

Re: [UrJTAG-dev] data/MANUFACTURERS

2019-07-31 Thread Geert Stappers
On Wed, Jul 31, 2019 at 10:44:45PM +0200, k...@aspodata.se wrote: > Karl: > > But what is the best way to update the manufacturers list ? > > > > Jedec uses bank, and id within bank. How do I convert that to the > > format used in data/MANUFACTURERS ? > ... > > I come up the the attached code.

Re: [UrJTAG-dev] patches Was: typedef's

2019-07-31 Thread karl
Geert Stappers: > On Wed, Jul 31, 2019 > > Would you accept patches that ? > > All patches will be reviewed. ... That is very good, thanks. Regards, /Karl Hammar ___ UrJTAG-development mailing list

[UrJTAG-dev] patches Was: typedef's

2019-07-31 Thread Geert Stappers
On Wed, Jul 31, 2019 > Would you accept patches that ? All patches will be reviewed. Good enough patches get accepted. Not yet good enough patches get further discussion. Patches too far away from good enough get rejection. Please note that these are emotional the hard

Re: [UrJTAG-dev] typedef's

2019-07-31 Thread karl
Karl: > When trying to understand the urjtag program code, I needed to get > definitions of the types used. I many cases typedefs was used for > structs and unions, making it unnessesary hard to the understand the > type. The worst offenders was in include/urjtag/types.h where the > typedefs