Re: Allow Customization of service.bat

Hi Violeta, On 11/7/2016 10:04 AM, Violeta Georgieva wrote: The fix is available in: - trunk for 9.0.0.M14 onwards - 8.5.x for 8.5.9 onwards Awesome, thanks! Igal - To unsubscribe, e-mail:

Re: Allow Customization of service.bat

Hi, 2016-11-02 19:27 GMT+02:00 Igal @ Lucee.org : > > Violeta, > > On 10/20/2016 11:10 PM, Violeta Georgieva wrote: >> >> Here [1] it is described how you can report a bug. Attach the patch to the >> bug. When you attaching the file there is a checkbox "patch". >> We also accept

Re: Allow Customization of service.bat

Violeta, On 10/20/2016 11:10 PM, Violeta Georgieva wrote: Here [1] it is described how you can report a bug. Attach the patch to the bug. When you attaching the file there is a checkbox "patch". We also accept PRs from GitHub [2]. [1]

Re: Allow Customization of service.bat

Chris, On 10/21/2016 12:05 PM, Christopher Schultz wrote: For some reason I thought that I read somewhere that the git repo is read-only. I didn't realize that I can submit a PR there. It *is* read-only. But you can clone the repo and make a read-write copy, then publish a pull-request from

Re: Allow Customization of service.bat

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Igal, On 10/21/16 1:02 PM, Igal @ Lucee.org wrote: > Thanks Violeta, > > On 10/20/2016 11:10 PM, Violeta Georgieva wrote: >> We also accept PRs from GitHub [2]. [2] >> https://github.com/apache/tomcat > > For some reason I thought that I read

Re: Allow Customization of service.bat

Thanks Violeta, On 10/20/2016 11:10 PM, Violeta Georgieva wrote: We also accept PRs from GitHub [2]. [2] https://github.com/apache/tomcat For some reason I thought that I read somewhere that the git repo is read-only. I didn't realize that I can submit a PR there. I'll do that. Igal

Re: Allow Customization of service.bat

Hi, 2016-10-21 1:23 GMT+03:00 Igal @ Lucee.org : > > Hi Mark, > > On 10/20/2016 1:19 PM, Mark Thomas wrote: >> >> >>> Can I submit a patch for that? >> >> Sure. Got for it. > > > I'm not very familiar with SVN (hopefully Apache will move to GIT soon), so I wasn't sure where to

Re: Allow Customization of service.bat

Hi Mark, On 10/20/2016 1:19 PM, Mark Thomas wrote: Can I submit a patch for that? Sure. Got for it. I'm not very familiar with SVN (hopefully Apache will move to GIT soon), so I wasn't sure where to submit the patch. The Apache Contributors Guide suggests the bug tracking platform.

Re: Allow Customization of service.bat

On 20/10/2016 21:09, Igal @ Lucee.org wrote: > service.bat is a great tool to install and remove Tomcat as a Windows > service, but it has a few hardcoded values that should be > customize-able, like the heap memory size and JVM args. > > I've modified the script slightly to address these issues.

Allow Customization of service.bat

service.bat is a great tool to install and remove Tomcat as a Windows service, but it has a few hardcoded values that should be customize-able, like the heap memory size and JVM args. I've modified the script slightly to address these issues. The first part sets default values: if