Re: WebappClassLoaderBase error when upgrading Tomcat 8 to 8.5

2023-05-03 Thread Christopher Schultz
Jeremy, On 5/3/23 12:27, Jeremy Nguyen wrote: Thanks Chris! That works for me now. Okay. I'll ask the rest of the team if it's an acceptable workaround. Honestly, that parent ClassLoader is violating The Rules. Only issue I have left is failing to compile/validate JSP. Caused by:

Re: WebappClassLoaderBase error when upgrading Tomcat 8 to 8.5

2023-05-03 Thread Jeremy Nguyen
Thanks Chris! That works for me now. Only issue I have left is failing to compile/validate JSP. Caused by: java.lang.NullPointerException > > at org.apache.jasper.compiler.Validator$ValidateVisitor.( > Validator.java:527) ~[jasper.jar:8.5.89] > > at

Re: WebappClassLoaderBase error when upgrading Tomcat 8 to 8.5

2023-05-03 Thread Christopher Schultz
Jeremy, On 5/3/23 11:00, jeremyn...@gmail.com wrote: Sure Ill run it. https://people.apache.org/~schultz/binaries/apache-tomcat-8.5.89-dev.tar.gz Please note that this is not an official Tomcat release (it's current 8.5.x HEAD plus a tiny patch to ignore any null resources obtained from

Re: WebappClassLoaderBase error when upgrading Tomcat 8 to 8.5

2023-05-03 Thread Jeremy Nguyen
If WebAppClassLoader.findResources returns null then it would come from java.net.URLClassLoader.findResources. @Override > public Enumeration findResources(String resources) throws IOException > { > logger.debug("finding resources " + resources); > Enumeration urls =

Re: WebappClassLoaderBase error when upgrading Tomcat 8 to 8.5

2023-05-03 Thread jeremyn408
Sure Ill run it. - Jeremy > On May 3, 2023, at 7:05 AM, Christopher Schultz > wrote: > >  > Jeremy, > >> On 5/2/23 22:27, Jeremy Nguyen wrote: >> I was able to retrieve some logs that might shed some insight on the >> parent classloader when running 8.5.87. I'll be frank that I don't quite

Re: WebappClassLoaderBase error when upgrading Tomcat 8 to 8.5

2023-05-03 Thread Christopher Schultz
Jeremy, On 5/2/23 22:27, Jeremy Nguyen wrote: I was able to retrieve some logs that might shed some insight on the parent classloader when running 8.5.87. I'll be frank that I don't quite understand the mechanics of classloaders in Java. LogFactory from

Re: WebappClassLoaderBase error when upgrading Tomcat 8 to 8.5

2023-05-02 Thread Jeremy Nguyen
I was able to retrieve some logs that might shed some insight on the parent classloader when running 8.5.87. I'll be frank that I don't quite understand the mechanics of classloaders in Java. LogFactory from > org.eclipse.osgi.internal.loader.EquinoxClassLoader@1628551735] [LOOKUP] > LogFactory

Re: WebappClassLoaderBase error when upgrading Tomcat 8 to 8.5

2023-05-02 Thread Jeremy Nguyen
I picked 8.5.34 because 8.5.35 has that code change while 34 doesn't. https://github.com/apache/tomcat/blob/8.5.35/java/org/apache/catalina/loader/WebappClassLoaderBase.java#L1050 I'll do some debugging for the classloader soon. I'm still trying to get my application running. I'm wrestling with

Re: WebappClassLoaderBase error when upgrading Tomcat 8 to 8.5

2023-05-02 Thread Christopher Schultz
Jeremy, On 5/1/23 17:46, Jeremy Nguyen wrote: I noticed this change was introduced: https://bz.apache.org/bugzilla/show_bug.cgi?id=62868 https://github.com/apache/tomcat/blame/8.5.x/java/org/apache/catalina/loader/WebappClassLoaderBase.java#L1122 I'll try running 8.5.34 and report back. Wow

Re: WebappClassLoaderBase error when upgrading Tomcat 8 to 8.5

2023-05-02 Thread Christopher Schultz
Rob, On 5/1/23 17:12, Rob Sargent wrote: => On 5/1/23 14:36, Christopher Schultz wrote: Jeremy, On 5/1/23 14:22, Jeremy Nguyen wrote: I'm trying to upgrade Tomcat 8 to 8.5 and I'm getting a nullpointerexception within WebappClassLoaderBase.CombinedEnumeration.inc. It seems to occur when it's

Re: WebappClassLoaderBase error when upgrading Tomcat 8 to 8.5

2023-05-01 Thread Jeremy Nguyen
Confirmed that running 8.5.34 resolves the issue. I'll have no choice but to run this version until the issue is resolved, or a workaround is found. Thanks all! On Mon, May 1, 2023 at 2:46 PM Jeremy Nguyen wrote: > I noticed this change was introduced: >

Re: WebappClassLoaderBase error when upgrading Tomcat 8 to 8.5

2023-05-01 Thread Jeremy Nguyen
I noticed this change was introduced: https://bz.apache.org/bugzilla/show_bug.cgi?id=62868 https://github.com/apache/tomcat/blame/8.5.x/java/org/apache/catalina/loader/WebappClassLoaderBase.java#L1122 I'll try running 8.5.34 and report back. Jeremy On Mon, May 1, 2023 at 2:12 PM Rob Sargent

Re: WebappClassLoaderBase error when upgrading Tomcat 8 to 8.5

2023-05-01 Thread Rob Sargent
On 5/1/23 14:36, Christopher Schultz wrote: Jeremy, On 5/1/23 14:22, Jeremy Nguyen wrote: I'm trying to upgrade Tomcat 8 to 8.5 and I'm getting a nullpointerexception within WebappClassLoaderBase.CombinedEnumeration.inc. It seems to occur when it's trying to initialize commons-logging

Re: WebappClassLoaderBase error when upgrading Tomcat 8 to 8.5

2023-05-01 Thread Christopher Schultz
Jeremy, On 5/1/23 14:22, Jeremy Nguyen wrote: I'm trying to upgrade Tomcat 8 to 8.5 and I'm getting a nullpointerexception within WebappClassLoaderBase.CombinedEnumeration.inc. It seems to occur when it's trying to initialize commons-logging LogFactory for any class specified in Web.xml, and

WebappClassLoaderBase error when upgrading Tomcat 8 to 8.5

2023-05-01 Thread Jeremy Nguyen
Hi, I'm trying to upgrade Tomcat 8 to 8.5 and I'm getting a nullpointerexception within WebappClassLoaderBase.CombinedEnumeration.inc. It seems to occur when it's trying to initialize commons-logging LogFactory for any class specified in Web.xml, and it's calling