Re: trimSpaces removing whitespace from html

2017-06-06 Thread Mark Thomas
On 29/05/17 09:43, Mark Thomas wrote: > On 29/05/17 09:09, David Kavanagh wrote: >> On 26 May 2017 at 22:33, Christopher Schultz >> wrote: >> >> Mark, >> >> On 5/26/17 6:59 AM, Mark Thomas wrote: > > > > This is a potential use case for a recently closed (as

Re: trimSpaces removing whitespace from html

2017-05-29 Thread Mark Thomas
On 29/05/17 13:00, Konstantin Kolinko wrote: > 2017-05-29 11:43 GMT+03:00 Mark Thomas : >> On 26/05/17 21:33, Christopher Schultz wrote: >>> Would it be reasonable to change trimSpaces so that spaces within >>> element attributes would be normalized to a single space, and

Re: trimSpaces removing whitespace from html

2017-05-29 Thread Konstantin Kolinko
2017-05-29 11:43 GMT+03:00 Mark Thomas : > On 26/05/17 21:33, Christopher Schultz wrote: >> Mark, >> >> On 5/26/17 6:59 AM, Mark Thomas wrote: >>> On 26/05/17 10:15, David Kavanagh wrote: Hey guys, Thanks for getting back to me. I didn't realise that the

Re: trimSpaces removing whitespace from html

2017-05-29 Thread David Kavanagh
Here is the link to the enhancement request. https://bz.apache.org/bugzilla/show_bug.cgi?id=45931 Thanks On 29 May 2017 at 13:32, David Kavanagh wrote: > > > On 29 May 2017 at 10:43, Mark Thomas wrote: > >> On 26/05/17 21:33, Christopher Schultz

Re: trimSpaces removing whitespace from html

2017-05-29 Thread David Kavanagh
On 29 May 2017 at 10:43, Mark Thomas wrote: > On 26/05/17 21:33, Christopher Schultz wrote: > > Mark, > > > > On 5/26/17 6:59 AM, Mark Thomas wrote: > >> On 26/05/17 10:15, David Kavanagh wrote: > >>> Hey guys, > >>> > >>> Thanks for getting back to me. I didn't realise that

Re: trimSpaces removing whitespace from html

2017-05-29 Thread Mark Thomas
On 26/05/17 21:33, Christopher Schultz wrote: > Mark, > > On 5/26/17 6:59 AM, Mark Thomas wrote: >> On 26/05/17 10:15, David Kavanagh wrote: >>> Hey guys, >>> >>> Thanks for getting back to me. I didn't realise that the >>> attachments would be stripped.> Here are the two files in full. > >>

Re: trimSpaces removing whitespace from html

2017-05-29 Thread Mark Thomas
On 29/05/17 09:09, David Kavanagh wrote: > On 26 May 2017 at 22:33, Christopher Schultz > wrote: > > Mark, > > On 5/26/17 6:59 AM, Mark Thomas wrote: This is a potential use case for a recently closed (as WONTFIX) enhancement request:

Re: trimSpaces removing whitespace from html

2017-05-29 Thread David Kavanagh
On 26 May 2017 at 22:33, Christopher Schultz wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > Mark, > > On 5/26/17 6:59 AM, Mark Thomas wrote: > > On 26/05/17 10:15, David Kavanagh wrote: > >> Hey guys, > >> > >> Thanks for getting back to me. I didn't

Re: trimSpaces removing whitespace from html

2017-05-26 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 5/26/17 6:59 AM, Mark Thomas wrote: > On 26/05/17 10:15, David Kavanagh wrote: >> Hey guys, >> >> Thanks for getting back to me. I didn't realise that the >> attachments would be stripped.> Here are the two files in full. > > That isn't

Re: trimSpaces removing whitespace from html

2017-05-26 Thread David Kavanagh
I will need to confirm with some people if that is a realistic fix for us and i will let you know. Thanks On 26 May 2017 at 13:05, David Kavanagh wrote: > Thanks Mark, > > I will try that out and let you know if it sorts our issue. > > Much appreciated > > On 26 May

Re: trimSpaces removing whitespace from html

2017-05-26 Thread David Kavanagh
Thanks Mark, I will try that out and let you know if it sorts our issue. Much appreciated On 26 May 2017 at 12:59, Mark Thomas wrote: > On 26/05/17 10:15, David Kavanagh wrote: > > Hey guys, > > > > Thanks for getting back to me. I didn't realise that the attachments > would

Re: trimSpaces removing whitespace from html

2017-05-26 Thread Mark Thomas
On 26/05/17 10:15, David Kavanagh wrote: > Hey guys, > > Thanks for getting back to me. I didn't realise that the attachments would > be stripped.> > Here are the two files in full. That isn't enough for us to reproduce it. Those files refer to a handful of other tag files and classes we don't

Re: trimSpaces removing whitespace from html

2017-05-26 Thread David Kavanagh
Hey guys, Thanks for getting back to me. I didn't realise that the attachments would be stripped. Here are the two files in full. The first is the imageTopWrapper.js <%@taglib prefix="hint" tagdir="/WEB-INF/tags/vhosts/marfeel/tags/hint" %> <%@ page

Re: trimSpaces removing whitespace from html

2017-05-24 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 David, Your attachments were stripped from the list. Can you put the text directly into your post? Thanks, - -chris On 5/24/17 6:29 AM, David Kavanagh wrote: > Hi Mark, > > Apologies for the delay. I have the files that should reproduce > the

Re: trimSpaces removing whitespace from html

2017-05-24 Thread David Kavanagh
Hi Mark, Apologies for the delay. I have the files that should reproduce the error for you. The imageTopWrapper.jsp loads the articleBody.tag. Then inside the articleBody.tag file the following section loads class names into the class attributes. data-mrf-transitioner="${transitioner}"

Re: trimSpaces removing whitespace from html

2017-05-17 Thread Mark Thomas
On 15/05/2017 10:29, David Kavanagh wrote: Ok cool, hopefully that will reproduce so you can see for yourself. Thanks! I've done the best I can to reproduce this without the access to the commerical tag library you appear to be using without success. I've also checked the trimSpaces

Re: trimSpaces removing whitespace from html

2017-05-15 Thread David Kavanagh
Ok cool, hopefully that will reproduce so you can see for yourself. Thanks! On 15 May 2017 at 10:39, Mark Thomas wrote: > On 12/05/17 17:08, David Kavanagh wrote: > > Yes, this is one of the .jsp files. I don't know how useful this is. > > Hopefully this will reproduce this.

Re: trimSpaces removing whitespace from html

2017-05-15 Thread Mark Thomas
On 12/05/17 17:08, David Kavanagh wrote: > Yes, this is one of the .jsp files. I don't know how useful this is. Hopefully this will reproduce this. Looking at this is on my TODO list while I'm at ApacheCon. > Has anyone heard of a similar issue using trimSpaces before, or do you > think this

Re: trimSpaces removing whitespace from html

2017-05-12 Thread David Kavanagh
Yes, this is one of the .jsp files. I don't know how useful this is. Has anyone heard of a similar issue using trimSpaces before, or do you think this might be something to do with the particular files being used? Thanks <%@taglib prefix="dali" uri="http://dev.marfeel.com/jsp/mrf/dali; %>

Re: trimSpaces removing whitespace from html

2017-05-11 Thread Mark Thomas
On 11 May 2017 15:34:32 BST, David Kavanagh wrote: >Yes, the problem happens in the class attribute string. >They are some examples but it happened throughout the files in many >cases. > >I am using .jsp files > >Also, in the second example that i gave, you can see

Re: trimSpaces removing whitespace from html

2017-05-11 Thread David Kavanagh
Yes, the problem happens in the class attribute string. They are some examples but it happened throughout the files in many cases. I am using .jsp files Also, in the second example that i gave, you can see that mrf-video was removed as well as mrf-m and mrf-image being joined. This was the

Re: trimSpaces removing whitespace from html

2017-05-11 Thread Torsten Krah
Am Donnerstag, den 11.05.2017, 09:23 -0400 schrieb Christopher Schultz: > So, removing the trailing space in the "class" attribute's value? That too - but have a look at: mrf-mmrf-image it was before / should be: mrf-m mrf-image there are missing whitespaces in the actual class attributes

Re: trimSpaces removing whitespace from html

2017-05-11 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 David, On 5/11/17 3:27 AM, David Kavanagh wrote: > Thanks for the quick reply. > > This is the code that i added to the web.xml file to activate trimSpaces: > > trimSpaces > true > > This is the HTML code: > > 1. Before > >

Re: trimSpaces removing whitespace from html

2017-05-11 Thread David Kavanagh
Thanks for the quick reply. This is the code that i added to the web.xml file to activate trimSpaces: trimSpaces true This is the HTML code: 1. Before class="mrf-article mrf-article--photo mrf-page mrf-noFillet mrf-author mrf-m mrf-image "> 1.After

Re: trimSpaces removing whitespace from html

2017-05-10 Thread Mark Thomas
On 10/05/17 17:17, David Kavanagh wrote: > Hey, > > I am wondering if anyone has come across this issue, and hopefully a way > to fix it. > When i enable the trimSpaces configuration option it removes the > whitespace but also > removes some whitespace from particular areas of the html. In my

trimSpaces removing whitespace from html

2017-05-10 Thread David Kavanagh
Hey, I am wondering if anyone has come across this issue, and hopefully a way to fix it. When i enable the trimSpaces configuration option it removes the whitespace but also removes some whitespace from particular areas of the html. In my case, it removes white space between some of the classes