Re: Branch with Google guice?

2010-06-07 Thread nicolas de loof
From a user perspective, no visible change is fine and is what we can expect. What for plugin developpers ? Moving to @Inject annotations is a significant API change, and set plugin prerequisites to maven3+. I supose we will have many debates on this... Also, considering Maven3 to be embeddable in

Re: Branch with Google guice?

2010-06-07 Thread Kristian Rosenvold
I think it's a really nice change, don't get me wrong on that ;) I'm also hoping it'll improve the error handling when something is wrong with the plexus configuration. As of today there's a fair amount of guesswork involved when a change breaks the plexus-configuration, I often end up

Re: Branch with Google guice?

2010-06-07 Thread Stuart McCulloch
On 7 June 2010 14:23, nicolas de loof nicolas.del...@gmail.com wrote: From a user perspective, no visible change is fine and is what we can expect. What for plugin developpers ? existing Plexus plugins should continue to work (that's the whole point of the compatibility layer) Moving to

Re: Branch with Google guice?

2010-06-07 Thread Jason van Zyl
On Jun 7, 2010, at 2:23 AM, nicolas de loof wrote: From a user perspective, no visible change is fine and is what we can expect. What for plugin developpers ? Moving to @Inject annotations is a significant API change, and set plugin prerequisites to maven3+. I supose we will have many

Re: Branch with Google guice?

2010-06-07 Thread nicolas de loof
2010/6/7 Jason van Zyl ja...@sonatype.com On Jun 7, 2010, at 2:23 AM, nicolas de loof wrote: Embedding is outside the scope of the 3.0 objective of backward compatibility for typical users. The embedding APIs are going to change a lot. Every time I look at another use case something

Re: Branch with Google guice?

2010-06-07 Thread Jason van Zyl
On Jun 7, 2010, at 10:09 AM, nicolas de loof wrote: 2010/6/7 Jason van Zyl ja...@sonatype.com On Jun 7, 2010, at 2:23 AM, nicolas de loof wrote: Embedding is outside the scope of the 3.0 objective of backward compatibility for typical users. The embedding APIs are going to change a

Re: Branch with Google guice?

2010-06-07 Thread nicolas de loof
Nothing is going to break, the current API does not change. Make plugins the way you currently make them. There are currently no supported embedding APIs. Use components at your own risk because they are going to change. Users will be fine using Maven and developing plugins as they did. This

Re: Branch with Google guice?

2010-06-06 Thread Stuart McCulloch
On 6 June 2010 02:27, Jemos Infra jemos.in...@googlemail.com wrote: Hi, Can somebody point me to the Maven 3 branch with Google guice? I undertsand that Google guice will replace Plexus classworlds, but the trunk still has Plexus in it. I'd like to have a look at what Maven 3 will look like

Re: Branch with Google guice?

2010-06-06 Thread Jemos Infra
Stuart, a couple of things re the below: 1) The first URL downloads spice-inject and the whole Guice. Question: was Guice extended for this compatibility layer? What actually is the compatibility layer? Is it just spice or the whole lot? If it's just spice, could we avoid from build the whole

Re: Branch with Google guice?

2010-06-06 Thread Stuart McCulloch
On 6 June 2010 17:22, Jemos Infra jemos.in...@googlemail.com wrote: Stuart, a couple of things re the below: 1) The first URL downloads spice-inject and the whole Guice. Question: was Guice extended for this compatibility layer? What actually is the compatibility layer? Is it just spice or

Re: Branch with Google guice?

2010-06-06 Thread Jemos Infra
Stuart, thank you for your email. Do you think that future emails related to the process below (mainly if I found any difficulties in building the whole thing plus observations, suggestions, etc) should be addressed to the dev mailing list? M. On Sun, 2010-06-06 at 18:11 +0800, Stuart McCulloch

Re: Branch with Google guice?

2010-06-06 Thread Stuart McCulloch
On 6 June 2010 19:27, Jemos Infra jemos.in...@googlemail.com wrote: Stuart, thank you for your email. Do you think that future emails related to the process below (mainly if I found any difficulties in building the whole thing plus observations, suggestions, etc) should be addressed to the

Re: Branch with Google guice?

2010-06-06 Thread Olivier Lamy
Hi Stuart, Any objections If I create a branch in asf svn repo ? 2010/6/6 Stuart McCulloch mccu...@gmail.com: On 6 June 2010 19:27, Jemos Infra jemos.in...@googlemail.com wrote: Stuart, thank you for your email. Do you think that future emails related to the process below (mainly if I found

Re: Branch with Google guice?

2010-06-06 Thread Stuart McCulloch
On 6 June 2010 22:16, Olivier Lamy ol...@apache.org wrote: Hi Stuart, Any objections If I create a branch in asf svn repo ? sure, fine with me 2010/6/6 Stuart McCulloch mccu...@gmail.com: On 6 June 2010 19:27, Jemos Infra jemos.in...@googlemail.com wrote: Stuart, thank you for your

Re: Branch with Google guice?

2010-06-06 Thread Olivier Lamy
stuff is here : http://svn.apache.org/repos/asf/maven/maven-3/branches/guice-support/ Thanks ! 2010/6/6 Stuart McCulloch mccu...@gmail.com: On 6 June 2010 22:16, Olivier Lamy ol...@apache.org wrote: Hi Stuart, Any objections If I create a branch in asf svn repo ? sure, fine with me

Re: Branch with Google guice?

2010-06-06 Thread Jemos Infra
On Sun, 2010-06-06 at 16:58 +0200, Olivier Lamy wrote: stuff is here : http://svn.apache.org/repos/asf/maven/maven-3/branches/guice-support/ Thanks ! Hi Oliver, I take it this branch contains everything that's needed, right? I mean Maven-3, the Plexus-Guice adapter and all required

Re: Branch with Google guice?

2010-06-06 Thread Olivier Lamy
yup. It build fine and it works for some builds I have tested since I have installed it (at least on my laptop :-) ) . 2010/6/6 Jemos Infra jemos.in...@googlemail.com: On Sun, 2010-06-06 at 16:58 +0200, Olivier Lamy wrote: stuff is here :

Re: Branch with Google guice?

2010-06-06 Thread nicolas de loof
Can we use the CI server to check how this branch supports the IT test harnesss ? It could make us more confident / help to detect incompatibilities when switching to Guive will become a concrete option. Nicolas 2010/6/6 Olivier Lamy ol...@apache.org yup. It build fine and it works for some

Re: Branch with Google guice?

2010-06-06 Thread Kristian Rosenvold
I have been running this patch on my CI (including m3 IT's) for quite some time now, and it works really well here. Obviously, the more the merrier! But then again, from a user's perspective this change really adds very little to the excitement. It's supposed to be a transparent change without