[jira] Commented: (VELTOOLS-68) VelocityViewServlet has hard coded ServletLogger

2006-11-04 Thread Henning Schmiedehausen (JIRA)
[ http://issues.apache.org/jira/browse/VELTOOLS-68?page=comments#action_12447135 ] Henning Schmiedehausen commented on VELTOOLS-68: Ah yes, I forgot about backwards compatibility again. So your point with LogSystem is surely

svn commit: r471244 - in /jakarta/velocity/tools/trunk/src/java/org/apache/velocity/tools: generic/ generic/log/ struts/ view/ view/servlet/ view/tools/

2006-11-04 Thread henning
Author: henning Date: Sat Nov 4 10:34:38 2006 New Revision: 471244 URL: http://svn.apache.org/viewvc?view=revrev=471244 Log: Some style fixes (remove unused Imports, unused Variables, adding Serial Version ID for serializable fields Modified:

[jira] Updated: (VELTOOLS-68) VelocityViewServlet has hard coded ServletLogger

2006-11-04 Thread Henning Schmiedehausen (JIRA)
[ http://issues.apache.org/jira/browse/VELTOOLS-68?page=all ] Henning Schmiedehausen updated VELTOOLS-68: --- Attachment: velocity-tools.patch How about the attached patch? It factors out the property setting by the servlet to work similar to

svn commit: r471245 - /jakarta/velocity/engine/trunk/src/java/org/apache/velocity/runtime/RuntimeConstants.java

2006-11-04 Thread henning
Author: henning Date: Sat Nov 4 10:59:08 2006 New Revision: 471245 URL: http://svn.apache.org/viewvc?view=revrev=471245 Log: Remove the random sorted qualifiers (public, static and final) from all constants as they are not needed inside an interface. Modified:

svn commit: r471246 - /jakarta/velocity/engine/trunk/src/java/org/apache/velocity/runtime/resource/ResourceManagerImpl.java

2006-11-04 Thread henning
Author: henning Date: Sat Nov 4 11:06:59 2006 New Revision: 471246 URL: http://svn.apache.org/viewvc?view=revrev=471246 Log: Serialize the resource retrieval per engine to avoid racing when parsing the template (one thread parses the template, another is reloading it). This showed prominently

svn commit: r471247 - /jakarta/velocity/engine/trunk/src/java/org/apache/velocity/runtime/resource/ResourceManagerImpl.java

2006-11-04 Thread henning
Author: henning Date: Sat Nov 4 11:08:45 2006 New Revision: 471247 URL: http://svn.apache.org/viewvc?view=revrev=471247 Log: Major rewrite of the ResourceManager implementation to use Iterators and clear up the init logic. Mostly happened while hunting for the template loading race condition

[jira] Assigned: (VELOCITY-24) calls to local macros not always made when template caching is off

2006-11-04 Thread Henning Schmiedehausen (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-24?page=all ] Henning Schmiedehausen reassigned VELOCITY-24: -- Assignee: Henning Schmiedehausen calls to local macros not always made when template caching is off

[jira] Resolved: (VELOCITY-24) calls to local macros not always made when template caching is off

2006-11-04 Thread Henning Schmiedehausen (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-24?page=all ] Henning Schmiedehausen resolved VELOCITY-24. Resolution: Fixed getResource() must be synchronized. Yes, that sucks for applications that hammer on that and have caching off. Here

[jira] Assigned: (VELOCITY-414) Extend the MethodInvocation exception to be able to give the velocity macro writer a usefull error page

2006-11-04 Thread Henning Schmiedehausen (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-414?page=all ] Henning Schmiedehausen reassigned VELOCITY-414: --- Assignee: Henning Schmiedehausen Extend the MethodInvocation exception to be able to give the velocity macro writer a

[jira] Commented: (VELOCITY-414) Extend the MethodInvocation exception to be able to give the velocity macro writer a usefull error page

2006-11-04 Thread Henning Schmiedehausen (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-414?page=comments#action_12447181 ] Henning Schmiedehausen commented on VELOCITY-414: - Yes, and we actually have everything we need already in place (in form of

svn commit: r471254 - in /jakarta/velocity/engine/trunk: ./ src/java/org/apache/velocity/exception/ src/java/org/apache/velocity/runtime/parser/node/

2006-11-04 Thread henning
Author: henning Date: Sat Nov 4 12:11:29 2006 New Revision: 471254 URL: http://svn.apache.org/viewvc?view=revrev=471254 Log: Reorganize the Throwable wrapping a bit (shuffle it up into VelocityException). Add Template Name, Line Number and Column Number recording to MethodInvocationException by

[jira] Commented: (VELOCITY-24) calls to local macros not always made when template caching is off

2006-11-04 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-24?page=comments#action_12447184 ] Will Glass-Husain commented on VELOCITY-24: --- So, it cuts the speed in half for uncached operation? Seems acceptable to me, since we offer a pretty

svn commit: r471259 - in /jakarta/velocity/engine/trunk/src/java/org/apache/velocity: exception/ runtime/resource/loader/

2006-11-04 Thread henning
Author: henning Date: Sat Nov 4 12:26:57 2006 New Revision: 471259 URL: http://svn.apache.org/viewvc?view=revrev=471259 Log: Add C'Tors taking Throwable to ResourceNotFoundException. Clean up the resource loaders using this (actually only one generates RNFE from another exception but this is a

[jira] Assigned: (VELOCITY-435) ParseErrorException not thrown with #macro parse error

2006-11-04 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-435?page=all ] Will Glass-Husain reassigned VELOCITY-435: -- Assignee: Will Glass-Husain ParseErrorException not thrown with #macro parse error

[jira] Resolved: (VELOCITY-414) Extend the MethodInvocation exception to be able to give the velocity macro writer a usefull error page

2006-11-04 Thread Henning Schmiedehausen (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-414?page=all ] Henning Schmiedehausen resolved VELOCITY-414. - Resolution: Fixed Make MethodInvocationException implement ExtendedParseException thus giving it access to Template name, line

svn commit: r471260 - in /jakarta/velocity/engine/trunk/src/java/org/apache/velocity: exception/VelocityException.java runtime/resource/ResourceManagerImpl.java

2006-11-04 Thread henning
Author: henning Date: Sat Nov 4 12:37:20 2006 New Revision: 471260 URL: http://svn.apache.org/viewvc?view=revrev=471260 Log: Javadoc fixes. Modified: jakarta/velocity/engine/trunk/src/java/org/apache/velocity/exception/VelocityException.java

svn commit: r471372 - in /jakarta/velocity/engine/trunk: src/java/org/apache/velocity/app/ src/java/org/apache/velocity/runtime/ src/java/org/apache/velocity/runtime/defaults/ src/java/org/apache/velo

2006-11-04 Thread wglass
Author: wglass Date: Sat Nov 4 22:02:20 2006 New Revision: 471372 URL: http://svn.apache.org/viewvc?view=revrev=471372 Log: Patch for VELOCITY-435. When new property velocimacro.arguments.strict is set to true, will throw a ParseErrorException after encountering macro call with invalid number

[jira] Resolved: (VELOCITY-435) ParseErrorException not thrown with #macro parse error

2006-11-04 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-435?page=all ] Will Glass-Husain resolved VELOCITY-435. Resolution: Fixed Fix applied. Need to set property velocimacro.arguments.strict to true for the exception to be thrown. Thanks for the

[jira] Updated: (VELOCITY-413) Add Velocity 1.5 jar to DVSL

2006-11-04 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-413?page=all ] Will Glass-Husain updated VELOCITY-413: --- Summary: Add Velocity 1.5 jar to DVSL (was: DVSL doesn't appear to work with Velocity 1.5) Fix Version/s: (was: 1.5) Add

svn commit: r471374 - /jakarta/velocity/engine/trunk/xdocs/changes.xml

2006-11-04 Thread wglass
Author: wglass Date: Sat Nov 4 22:24:39 2006 New Revision: 471374 URL: http://svn.apache.org/viewvc?view=revrev=471374 Log: update changelist with several recent changes. Modified: jakarta/velocity/engine/trunk/xdocs/changes.xml Modified: jakarta/velocity/engine/trunk/xdocs/changes.xml

synchronization of Template class

2006-11-04 Thread Will Glass-Husain
Henning-- Since you just dug into the synchronization issue, do you have any thoughts on http://issues.apache.org/jira/browse/VELOCITY-383 ? WILL -- Forio Business Simulations Will Glass-Husain [EMAIL PROTECTED] www.forio.com

Re: POLL - release beta 2?

2006-11-04 Thread Will Glass-Husain
We've a go-ahead to release Velocity 1.5 beta 2. I haven't cast an official vote yet, but mine is obviously +1. +1 Malcolm Edgar Matthijs Lambooy Nathan Bubna Henning P. Schmiedehausen Will Glass-Husain I'll go ahead and get things started. I'd like to put a link to it on the home page this