[jira] Reopened: (VELOCITY-362) can't load macros in file loaded with #parse

2006-11-10 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-362?page=all ] Will Glass-Husain reopened VELOCITY-362: As discussed on the dev list, I see this as an important to-do for version 1.6. Reopening. can't load macros in file loaded with

[jira] Commented: (VELOCITY-448) Can't define macro in separate file and use it in another file.

2006-11-10 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-448?page=comments#action_12448752 ] Will Glass-Husain commented on VELOCITY-448: As discussed on the dev list, I see this as an important todo for 1.6. I've reopened Velocity-362 as

[jira] Resolved: (VELOCITY-284) MethodInvocationException is handled inconsistently

2006-11-10 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-284?page=all ] Will Glass-Husain resolved VELOCITY-284. Fix Version/s: 1.5 (was: 2.0) (was: 1.6) Resolution: Fixed rsolved again. r473363

[jira] Commented: (VELOCITY-285) reference within macro and foreach is incorrect

2006-11-06 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-285?page=comments#action_12447568 ] Will Glass-Husain commented on VELOCITY-285: nice catch and nice fix! sometimes it takes an alert user to find a subtle use case that exposes a

[jira] Resolved: (VELOCITY-436) Remove Exception type throwing.

2006-11-05 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-436?page=all ] Will Glass-Husain resolved VELOCITY-436. Resolution: Fixed removed generic Exception throwing from Template.merge, and in fact many methods (including all public Template methods).

[jira] Resolved: (VELOCITY-477) DOCTYPE url correction in veltag.tld

2006-11-05 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-477?page=all ] Will Glass-Husain resolved VELOCITY-477. Fix Version/s: 1.5 beta2 Resolution: Fixed fixed - thanks! I'm a little puzzled by this though. The spec shows library but I

[jira] Commented: (VELOCITY-392) Switch to a better log system - slf4j

2006-11-05 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-392?page=comments#action_12447367 ] Will Glass-Husain commented on VELOCITY-392: Makes sense. Obviously, you could always create a LogChute that acts as a bridge between Velocity and

[jira] Assigned: (VELOCITY-284) MethodInvocationException is handled inconsistently

2006-11-05 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-284?page=all ] Will Glass-Husain reassigned VELOCITY-284: -- Assignee: Will Glass-Husain MethodInvocationException is handled inconsistently ---

[jira] Commented: (VELOCITY-227) ResourceFactory not extensible

2006-11-05 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-227?page=comments#action_12447368 ] Will Glass-Husain commented on VELOCITY-227: Since you can choose the implementation via velocity.properties, wouldn't this fall under a prohibited

[jira] Commented: (VELOCITY-183) StringResourceLoader

2006-11-05 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-183?page=comments#action_12447369 ] Will Glass-Husain commented on VELOCITY-183: I've changed my mind about this. It should go into the core. Eventually we need to re-do most of the

[jira] Commented: (VELOCITY-24) calls to local macros not always made when template caching is off

2006-11-04 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-24?page=comments#action_12447184 ] Will Glass-Husain commented on VELOCITY-24: --- So, it cuts the speed in half for uncached operation? Seems acceptable to me, since we offer a pretty

[jira] Assigned: (VELOCITY-435) ParseErrorException not thrown with #macro parse error

2006-11-04 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-435?page=all ] Will Glass-Husain reassigned VELOCITY-435: -- Assignee: Will Glass-Husain ParseErrorException not thrown with #macro parse error

[jira] Resolved: (VELOCITY-435) ParseErrorException not thrown with #macro parse error

2006-11-04 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-435?page=all ] Will Glass-Husain resolved VELOCITY-435. Resolution: Fixed Fix applied. Need to set property velocimacro.arguments.strict to true for the exception to be thrown. Thanks for the

[jira] Updated: (VELOCITY-413) Add Velocity 1.5 jar to DVSL

2006-11-04 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-413?page=all ] Will Glass-Husain updated VELOCITY-413: --- Summary: Add Velocity 1.5 jar to DVSL (was: DVSL doesn't appear to work with Velocity 1.5) Fix Version/s: (was: 1.5) Add

[jira] Commented: (VELOCITY-413) DVSL doesn't appear to work with Velocity 1.5

2006-11-02 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-413?page=comments#action_12446747 ] Will Glass-Husain commented on VELOCITY-413: Well that's good to know. Bug mysteriously appears, bug goes away. Does this mean this issue is no

[jira] Resolved: (VELOCITY-475) Javadocs for SecureUberspector are not correct.

2006-11-01 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-475?page=all ] Will Glass-Husain resolved VELOCITY-475. Resolution: Fixed fixed Javadocs for SecureUberspector are not correct. ---

[jira] Resolved: (VELOCITY-423) Report invalid references

2006-11-01 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-423?page=all ] Will Glass-Husain resolved VELOCITY-423. Resolution: Fixed excellent point. cleaned them all up. Report invalid references - Key:

[jira] Commented: (VELTOOLS-66) Velocity Tools gives access exception with $request reference under Tomcat security manager

2006-10-29 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELTOOLS-66?page=comments#action_12445511 ] Will Glass-Husain commented on VELTOOLS-66: --- This would be interesting to try. There's been zero response to my bug report in Tomcat-land.

[jira] Resolved: (VELOCITY-469) Spaces in velocimacro.library hard to troubleshoot

2006-10-27 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-469?page=all ] Will Glass-Husain resolved VELOCITY-469. Fix Version/s: 1.5 Resolution: Duplicate Fixed in upcoming version 1.5. See VELOCITY-274. Spaces in velocimacro.library hard to

[jira] Updated: (VELOCITY-468) Allowing putting objects into control context from VTL

2006-10-21 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-468?page=all ] Will Glass-Husain updated VELOCITY-468: --- Fix Version/s: 1.6 Just trying to figure out, why is this needed? (1) You can create your own context and pass it in to the parse (String

[jira] Commented: (VELOCITY-468) Allowing putting objects into control context from VTL

2006-10-21 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-468?page=comments#action_12444050 ] Will Glass-Husain commented on VELOCITY-468: Hi, I'm not a big texen user, so, could you explain wouldn't this work? You could subclass Generator

[jira] Commented: (VELTOOLS-66) Velocity Tools gives access exception with $request reference under Tomcat security manager

2006-10-16 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELTOOLS-66?page=comments#action_12442670 ] Will Glass-Husain commented on VELTOOLS-66: --- submitted bug to Tomcat bugzilla http://issues.apache.org/bugzilla/show_bug.cgi?id=40770 Velocity Tools

[jira] Created: (VELTOOLS-66) Velocity Tools gives access exception with $request reference under Tomcat security manager

2006-10-15 Thread Will Glass-Husain (JIRA)
Velocity Tools gives access exception with $request reference under Tomcat security manager --- Key: VELTOOLS-66 URL: http://issues.apache.org/jira/browse/VELTOOLS-66

[jira] Created: (VELOCITY-467) Throw more exceptions and log less errors

2006-10-15 Thread Will Glass-Husain (JIRA)
Throw more exceptions and log less errors - Key: VELOCITY-467 URL: http://issues.apache.org/jira/browse/VELOCITY-467 Project: Velocity Issue Type: Improvement Components: Source Affects

[jira] Resolved: (VELOCITY-457) documentation mistake? order of Velocimacros in template

2006-10-15 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-457?page=all ] Will Glass-Husain resolved VELOCITY-457. Resolution: Invalid it has to do with caching. The macro is never loaded the first time, but if the page is cached will be available the

[jira] Commented: (VELTOOLS-66) Velocity Tools gives access exception with $request reference under Tomcat security manager

2006-10-15 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELTOOLS-66?page=comments#action_12442456 ] Will Glass-Husain commented on VELTOOLS-66: --- Nathan, you make some good points. Though I'm not a Tools user, I don't mind making a patch for if you

[jira] Resolved: (VELOCITY-423) Report invalid references

2006-10-12 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-423?page=all ] Will Glass-Husain resolved VELOCITY-423. Resolution: Fixed I've added a new event handler InvalidReferenceEventHandler to address this. It's a little experimental -- may need some

[jira] Created: (VELOCITY-462) Change headers in source files to comply with new license header policy

2006-10-11 Thread Will Glass-Husain (JIRA)
Change headers in source files to comply with new license header policy --- Key: VELOCITY-462 URL: http://issues.apache.org/jira/browse/VELOCITY-462 Project: Velocity Issue

[jira] Updated: (VELOCITY-462) Change headers in source files to comply with new license header policy

2006-10-11 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-462?page=all ] Will Glass-Husain updated VELOCITY-462: --- Component/s: Source Fix Version/s: 1.5 Affects Version/s: 1.5 beta1 Change headers in source files to comply with new

[jira] Resolved: (VELOCITY-132) IllegalArgumentException while calling an overloaded method

2006-10-09 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-132?page=all ] Will Glass-Husain resolved VELOCITY-132. Resolution: Invalid Hi, thanks for reporting this and commenting. I'm marketing this issue as invalid. There's two different issues

[jira] Resolved: (VELOCITY-179) prevent execution of methods on Class, ClassLoader and related classes

2006-10-09 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-179?page=all ] Will Glass-Husain resolved VELOCITY-179. Fix Version/s: 1.5 (was: 1.6) Resolution: Fixed Committed a cleaned up version of this. r454595. To use,

[jira] Commented: (VELOCITY-461) Class loading issue

2006-09-27 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-461?page=comments#action_12438233 ] Will Glass-Husain commented on VELOCITY-461: That is fixed as well in Velocity-1.5-beta. Anything that comes from the class path is first searched

[jira] Commented: (VELOCITY-460) the IncludeRelativePath handler should treat paths beginning with a slash as absolute paths

2006-09-26 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-460?page=comments#action_12437902 ] Will Glass-Husain commented on VELOCITY-460: Hi Claude, are you sure? would you mind doing cd root svn up cd build ant clean ant test It appears

[jira] Commented: (VELOCITY-460) the IncludeRelativePath handler should treat paths beginning with a slash as absolute paths

2006-09-26 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-460?page=comments#action_12437903 ] Will Glass-Husain commented on VELOCITY-460: maybe do a svn status as well to double-check which files have changed. thanks. the

[jira] Resolved: (VELOCITY-460) the IncludeRelativePath handler should treat paths beginning with a slash as absolute paths

2006-09-26 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-460?page=all ] Will Glass-Husain resolved VELOCITY-460. Resolution: Fixed Turned out there was an extra newline at the end of test/includeevent/include-c.vm. removing this solved the issue and

[jira] Commented: (VELOCITY-460) the IncludeRelativePath handler should treat paths beginning with a slash as absolute paths

2006-09-25 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-460?page=comments#action_12437670 ] Will Glass-Husain commented on VELOCITY-460: Ant test failed. Did you forget to include BuiltInEventHandlerTestCase? Testsuite:

[jira] Commented: (VELOCITY-460) the IncludeRelativePath handler should treat paths beginning with a slash as absolute paths

2006-09-25 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-460?page=comments#action_12437702 ] Will Glass-Husain commented on VELOCITY-460: I'm on Windows. Let me tinker with this tonight. the IncludeRelativePath handler should treat paths

[jira] Commented: (VELOCITY-460) the IncludeRelativePath handler should treat paths beginning with a slash as absolute paths

2006-09-24 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-460?page=comments#action_12437452 ] Will Glass-Husain commented on VELOCITY-460: nice catch! would you mind fixing the unit test to check this case as well? if you have time to do

[jira] Resolved: (VELOCITY-459) localscope doesn't allow get to leak

2006-09-23 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-459?page=all ] Will Glass-Husain resolved VELOCITY-459. Resolution: Fixed patch applied. thanks again. revision #449333. localscope doesn't allow get to leak

[jira] Resolved: (VELOCITY-453) [PATCH] Fix IntrospectionCacheData caching

2006-09-23 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-453?page=all ] Will Glass-Husain resolved VELOCITY-453. Resolution: Fixed applied this patch. I'm a little shocked that this was broken. Though a subtle bug, it's a fundamental part of template

[jira] Resolved: (VELOCITY-122) 33 warnings when doing ant javadocs

2006-09-23 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-122?page=all ] Will Glass-Husain resolved VELOCITY-122. Resolution: Fixed resolving this old issue. the build process is very different now, the javadocs have been updated to remove most

[jira] Assigned: (VELOCITY-423) Report invalid references

2006-09-23 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-423?page=all ] Will Glass-Husain reassigned VELOCITY-423: -- Assignee: Will Glass-Husain Report invalid references - Key: VELOCITY-423

[jira] Commented: (VELOCITY-459) localscope doesn't allow get to leak

2006-09-21 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-459?page=comments#action_12436445 ] Will Glass-Husain commented on VELOCITY-459: Thanks for reporting this and submitting a patch. Does ant test pass? We should get this into 1.5.

[jira] Updated: (VELOCITY-459) localscope doesn't allow get to leak

2006-09-21 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-459?page=all ] Will Glass-Husain updated VELOCITY-459: --- Fix Version/s: 1.5 Priority: Minor (was: Major) localscope doesn't allow get to leak

[jira] Assigned: (VELOCITY-459) localscope doesn't allow get to leak

2006-09-21 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-459?page=all ] Will Glass-Husain reassigned VELOCITY-459: -- Assignee: Will Glass-Husain localscope doesn't allow get to leak Key:

[jira] Commented: (VELOCITY-459) localscope doesn't allow get to leak

2006-09-21 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-459?page=comments#action_12436449 ] Will Glass-Husain commented on VELOCITY-459: Reviewed the patch. Looks fine to me. (Minor formatting issues with the braces in the unit test).

[jira] Commented: (VELOCITY-458) InternalContextBase defines non-serializable non-transient fields

2006-09-16 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-458?page=comments#action_12435242 ] Will Glass-Husain commented on VELOCITY-458: so what's the current behavior? If someone serializes a VelocityContext object does it throw an

[jira] Commented: (VELOCITY-251) $\!{foo} doesn't render as expected

2006-09-12 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-251?page=comments#action_12434308 ] Will Glass-Husain commented on VELOCITY-251: From the mailing list (excerpt) -- Forwarded message -- From: sun davy [EMAIL

[jira] Commented: (VELOCITY-284) MethodInvocationException is handled inconsistently

2006-09-06 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-284?page=comments#action_12432847 ] Will Glass-Husain commented on VELOCITY-284: Question -- are there any good backwards-compatibility arguments against making VelocityException

[jira] Commented: (VELOCITY-179) prevent execution of methods on Class, ClassLoader and related classes

2006-09-06 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-179?page=comments#action_12432854 ] Will Glass-Husain commented on VELOCITY-179: Actually, I've recently cleaned this up a bit. Maybe we can even just include it as an alternate

[jira] Commented: (VELOCITY-453) [PATCH] Fix IntrospectionCacheData caching

2006-09-06 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-453?page=comments#action_12432856 ] Will Glass-Husain commented on VELOCITY-453: Hi Alexey, Looks great, thanks for submitting. Appreciate your attention to detail with code

[jira] Commented: (VELOCITY-449) Velocity Uberspector behaves differently for get(String) and put(String, Object) methods

2006-09-06 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-449?page=comments#action_12432863 ] Will Glass-Husain commented on VELOCITY-449: ah, forgot that get(string) is not a javabean semantic. ok, makes sense. in general, I agree that we

[jira] Updated: (VELOCITY-455) Error in chapter Escaping VTL Directives in the User Guide

2006-09-04 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-455?page=all ] Will Glass-Husain updated VELOCITY-455: --- Fix Version/s: 1.5 Error in chapter Escaping VTL Directives in the User Guide

[jira] Updated: (VELOCITY-454) clean up escaping to always escape \$ and \#

2006-09-04 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-454?page=all ] Will Glass-Husain updated VELOCITY-454: --- Priority: Major (was: Critical) It's tricky. This is specified in the parser syntax, it's not easily made configurable. clean up escaping

[jira] Commented: (VELOCITY-453) [PATCH] Fix IntrospectionCacheData caching

2006-08-31 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-453?page=comments#action_12431866 ] Will Glass-Husain commented on VELOCITY-453: Thanks for contributing! for some reason the patch didn't upload properly - I get a Tomcat error when

[jira] Commented: (VELOCITY-454) It's impossible to escape ${something == 3} if something is not in the context (in general, why can't $ ALWAYS be escaped?)

2006-08-31 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-454?page=comments#action_12431974 ] Will Glass-Husain commented on VELOCITY-454: Yes, this is a real pain. Right now it's a compatibility issue - if we change it then many user

[jira] Updated: (VELOCITY-454) clean up escaping to always escape \$ and \#

2006-08-31 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-454?page=all ] Will Glass-Husain updated VELOCITY-454: --- Summary: clean up escaping to always escape \$ and \# (was: It's impossible to escape ${something == 3} if something is not in the context

[jira] Commented: (VELOCITY-455) Error in chapter Escaping VTL Directives in the User Guide

2006-08-31 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-455?page=comments#action_12431977 ] Will Glass-Husain commented on VELOCITY-455: thanks for reporting this -- we'll investigate. just to confirm, did you actually test that bit of

[jira] Updated: (VELOCITY-453) [PATCH] Fix IntrospectionCacheData caching

2006-08-31 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-453?page=all ] Will Glass-Husain updated VELOCITY-453: --- Fix Version/s: 1.5 Assignee: Will Glass-Husain Priority: Major (was: Critical) Great, the download worked. Let me look at

[jira] Updated: (VELOCITY-452) In ASTMethod.execute the IllegalArgumentException should be catched

2006-08-31 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-452?page=all ] Will Glass-Husain updated VELOCITY-452: --- Priority: Minor (was: Major) Sounds reasonable. Let me review and if it looks good, commit. Thanks for submitting! P.S. Appreciate your

[jira] Resolved: (VELOCITY-438) toString is called twice on references

2006-08-24 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-438?page=all ] Will Glass-Husain resolved VELOCITY-438. Resolution: Fixed patched applied. sorry for the long delay. Thanks to Stephen for the patch (and Malcolm for the reminder :-) toString

[jira] Commented: (VELOCITY-448) Can't define macro in separate file and use it in another file.

2006-07-07 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-448?page=comments#action_12419828 ] Will Glass-Husain commented on VELOCITY-448: yes, we need to address this, though its not trivial. see this note:

[jira] Commented: (VELOCITY-383) NPE when processing template under heavy concurrent load

2006-06-22 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-383?page=comments#action_12417322 ] Will Glass-Husain commented on VELOCITY-383: Fabulous. So to sum up, if the caching is fixed per VELTOOLS-59, then this becomes a very rare case. The

[jira] Updated: (VELOCITY-383) Non thread-safe Template object can cause NPE under heavy concurrent load

2006-06-22 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-383?page=all ] Will Glass-Husain updated VELOCITY-383: --- Bugzilla Id: (was: 35331) Summary: Non thread-safe Template object can cause NPE under heavy concurrent load (was: NPE when

[jira] Commented: (VELTOOLS-59) WebappLoader's isSourceModified() and getLastModified() sometimes fail

2006-06-21 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELTOOLS-59?page=comments#action_12417200 ] Will Glass-Husain commented on VELTOOLS-59: --- Nice catch! Nathan - your suggestion makes sense. I'm a little worried about the race condition issue. Maybe we

[jira] Commented: (VELOCITY-445) Integrate Jython or BeanShell or Perl with Velocity to have complete macro language!

2006-06-15 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-445?page=comments#action_12416397 ] Will Glass-Husain commented on VELOCITY-445: Another possibility is to mix Velocity and JSP with the Veltag module of Velocity. This allows JSP pages -- which

[jira] Commented: (VELOCITY-442) Need a standard Velocity class for doing macro preprocessing for various files (XML, HTML, scripts, source files..)

2006-05-30 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-442?page=comments#action_12413980 ] Will Glass-Husain commented on VELOCITY-442: Thanks, Colbert. We welcome any suggestions and code patches you might have. Another one you might want to look

[jira] Commented: (VELOCITY-439) Improve Resource existence detection

2006-05-17 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-439?page=comments#action_12412290 ] Will Glass-Husain commented on VELOCITY-439: nice idea, thanks for suggesting it. Note that you can always do this in the calling code. This idea though

[jira] Commented: (VELOCITY-352) Need translation of change to user's guide re: math operations

2006-05-08 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-352?page=comments#action_12378390 ] Will Glass-Husain commented on VELOCITY-352: entered in Bugzilla. http://issues.apache.org/bugzilla/show_bug.cgi?id=33408 --- Additional Comments From

[jira] Updated: (VELOCITY-438) toString is called twice on references

2006-04-18 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-438?page=all ] Will Glass-Husain updated VELOCITY-438: --- Fix Version: 1.5 Thanks for the catch! I'll go ahead and commit this. Appreciate the unit test. Just as a quick side note, when submitting

[jira] Commented: (VELOCITY-437) Intercept output of objects

2006-04-18 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-437?page=comments#action_12374956 ] Will Glass-Husain commented on VELOCITY-437: No - not intentionally sarcastic at all! Where are the confusing comments? We should probably fix them. The

[jira] Commented: (VELOCITY-436) Remove Exception type throwing.

2006-04-17 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-436?page=comments#action_12374760 ] Will Glass-Husain commented on VELOCITY-436: Thanks for the note. Are there methods in particular that you were thinking of? A few examples would be helpful.

[jira] Updated: (VELOCITY-437) Intercept output of objects

2006-04-17 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-437?page=all ] Will Glass-Husain updated VELOCITY-437: --- Fix Version: 1.6 Ok, targeting this for v1.6. Nathan's suggestions are good ones. Intercept output of objects ---

[jira] Commented: (VELOCITY-437) Intercept output of objects

2006-04-11 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-437?page=comments#action_12374039 ] Will Glass-Husain commented on VELOCITY-437: Kind of a neat idea. Modifying ASTReference directly is the way to go -- we ignore all Node files generated by

[jira] Commented: (VELOCITY-435) ParseErrorException not thrown with #macro parse error

2006-03-20 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-435?page=comments#action_12371089 ] Will Glass-Husain commented on VELOCITY-435: Hi Malcolm, Actually this is intentional. We now allow comments or spaces are parameter separators in macros.

[jira] Commented: (VELOCITY-435) ParseErrorException not thrown with #macro parse error

2006-03-19 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-435?page=comments#action_12370990 ] Will Glass-Husain commented on VELOCITY-435: Hi, Spent some time working on this, even coded a solution. When I ran ant test though one of the Anakia tests

[jira] Commented: (VELOCITY-435) ParseErrorException not thrown with #macro parse error

2006-03-19 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-435?page=comments#action_12370991 ] Will Glass-Husain commented on VELOCITY-435: Just to clarify my findings, these errors cause exceptions to be thrown * errors in macro body * syntax errors in

[jira] Updated: (VELOCITY-435) ParseErrorException not thrown with #macro parse error

2006-03-19 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-435?page=all ] Will Glass-Husain updated VELOCITY-435: --- Attachment: macroargumenterror.patch Attached file - throws an argument for invalid macro argument count ParseErrorException not thrown with

[jira] Commented: (VELOCITY-432) #stop produces unexpected results when used with #parse

2006-03-14 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-432?page=comments#action_12370436 ] Will Glass-Husain commented on VELOCITY-432: Fixed the string out of bounds exception - thanks! (note - made minor code style adjustment) #stop produces

[jira] Resolved: (VELOCITY-432) #stop produces unexpected results when used with #parse

2006-03-14 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-432?page=all ] Will Glass-Husain resolved VELOCITY-432: Resolution: Fixed Fixed the #stop issue. Thanks for catching this and submitting a patch! #stop produces unexpected results when used

[jira] Resolved: (VELOCITY-433) Replace parser pool

2006-03-14 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-433?page=all ] Will Glass-Husain resolved VELOCITY-433: Fix Version: 1.5 Resolution: Fixed Patch applied. Nice idea and implementation. Thanks for contributing! Replace parser pool

[jira] Commented: (VELOCITY-434) Commons pool implementation of the parser pool

2006-03-14 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-434?page=comments#action_12370457 ] Will Glass-Husain commented on VELOCITY-434: Thanks for sharing this code. I've been thinking about this, and I believe the best place for CommonsParserPool

[jira] Updated: (VELOCITY-435) ParseErrorException not thrown with #macro parse error

2006-03-14 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-435?page=all ] Will Glass-Husain updated VELOCITY-435: --- Fix Version: 1.5 I agree. Let's make this work as Malcolm describes. ParseErrorException not thrown with #macro parse error

[jira] Updated: (VELOCITY-422) Add support for property and propertyset nested elements to TexenTask.

2006-03-14 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-422?page=all ] Will Glass-Husain updated VELOCITY-422: --- Fix Version: 1.5 marking this for 1.5 Add support for property and propertyset nested elements to TexenTask.

[jira] Updated: (VELOCITY-421) Downloaded libraries are checked twice when started by 'ant jar jar-src'

2006-03-14 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-421?page=all ] Will Glass-Husain updated VELOCITY-421: --- Fix Version: 1.5 should we be including this in 1.5? Downloaded libraries are checked twice when started by 'ant jar jar-src'

[jira] Updated: (VELOCITY-420) Library download failure when started by 'ant jar jar-src'

2006-03-14 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-420?page=all ] Will Glass-Husain updated VELOCITY-420: --- Fix Version: 1.5 Priority: Minor (was: Major) fix this for 1.5 Library download failure when started by 'ant jar jar-src'

[jira] Commented: (VELTOOLS-55) Add URLResourceLoader to VelocityTools 1.3

2006-03-13 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELTOOLS-55?page=comments#action_12370214 ] Will Glass-Husain commented on VELTOOLS-55: --- Yes, let's do that. Do the docs need to be updated? Add URLResourceLoader to VelocityTools 1.3

[jira] Resolved: (VELOCITY-431) Its has an apostrophe where it shouldn't, throughout the documentation

2006-03-10 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-431?page=all ] Will Glass-Husain resolved VELOCITY-431: Resolution: Fixed Fixed in source control. web files copied to web site. (changes to manuals will wait until 1.5). Thanks again for

[jira] Commented: (VELOCITY-433) Replace parser pool

2006-03-04 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-433?page=comments#action_12368923 ] Will Glass-Husain commented on VELOCITY-433: Fabulous. Did ant test pass? Replace parser pool --- Key: VELOCITY-433

[jira] Commented: (VELOCITY-434) Commons pool implementation of the parser pool

2006-03-04 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-434?page=comments#action_12368924 ] Will Glass-Husain commented on VELOCITY-434: Looks promising. A quick style note - remember to put braces on their own line. Let's discuss on the list the

[jira] Updated: (VELOCITY-432) #stop produces unexpected results when used with #parse

2006-02-07 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-432?page=all ] Will Glass-Husain updated VELOCITY-432: --- Fix Version: 1.5 Version: 1.4 Priority: Minor (was: Major) Thanks for reporting this. We'll get this into the source. #stop

[jira] Updated: (VELOCITY-431) Its has an apostrophe where it shouldn't, throughout the documentation

2006-02-06 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-431?page=all ] Will Glass-Husain updated VELOCITY-431: --- Fix Version: 1.5 Thanks for reporting this. Will fix the site next time I do an update and will fix the product manuals in the next version.

[jira] Resolved: (VELOCITY-95) Problems when #parse can't find its file

2006-01-29 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-95?page=all ] Will Glass-Husain resolved VELOCITY-95: --- Resolution: Fixed Looks like this was previously resolved for Velocity 1.4. Added a test case to double check. Problems when #parse

[jira] Updated: (VELOCITY-95) Problems when #parse can't find its file

2006-01-29 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-95?page=all ] Will Glass-Husain updated VELOCITY-95: -- Bugzilla Id: (was: 11065) Fix Version: 1.4 (was: 1.5) Problems when #parse can't find its file

[jira] Resolved: (VELOCITY-96) No error reporting when #parse doesn't

2006-01-29 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-96?page=all ] Will Glass-Husain resolved VELOCITY-96: --- Fix Version: 1.4 (was: 1.5) Resolution: Fixed Looks like this was previously resolved for Velocity 1.4. Added a

[jira] Resolved: (VELOCITY-274) Errant space in velocity.properties file can cause classpath resource loader to fail

2006-01-29 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-274?page=all ] Will Glass-Husain resolved VELOCITY-274: Resolution: Fixed ok, did this. Thanks for the suggestion. Fixed for version 1.5. Errant space in velocity.properties file can cause

[jira] Resolved: (VELOCITY-430) Allow commas or spaces to separate macro arguments

2006-01-29 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-430?page=all ] Will Glass-Husain resolved VELOCITY-430: Resolution: Fixed Implemented this in rev# 373465. Let me know what you think. If it seems like a good approach we can change the

[jira] Resolved: (VELOCITY-187) TexenTask javadoc does not match source code for its inheritance from Ant Task

2006-01-29 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-187?page=all ] Will Glass-Husain resolved VELOCITY-187: Resolution: Fixed Assign To: (was: Velocity-Dev List) This seems fine in the current svn head. Should be ok in version 1.5.

[jira] Commented: (VELOCITY-430) Allow commas or spaces to separate macro arguments

2006-01-18 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-430?page=comments#action_12363132 ] Will Glass-Husain commented on VELOCITY-430: Hi Daniel, Thanks for the comment! Your message confuses me. It's a usability improvement to make this change or

[jira] Created: (VELOCITY-430) Allow commas or spaces to separate macro arguments

2006-01-17 Thread Will Glass-Husain (JIRA)
Allow commas or spaces to separate macro arguments -- Key: VELOCITY-430 URL: http://issues.apache.org/jira/browse/VELOCITY-430 Project: Velocity Type: Improvement Components: Source Reporter: Will Glass-Husain

  1   2   3   4   >