[jira] Commented: (VELOCITY-453) [PATCH] Fix IntrospectionCacheData caching

2006-09-08 Thread Henning Schmiedehausen (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-453?page=comments#action_12433362 ] Henning Schmiedehausen commented on VELOCITY-453: - Do you have hard numbers for that claim? Are these checks used on a hot path? Just curious.

[jira] Commented: (VELOCITY-453) [PATCH] Fix IntrospectionCacheData caching

2006-09-08 Thread Henning Schmiedehausen (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-453?page=comments#action_12433363 ] Henning Schmiedehausen commented on VELOCITY-453: - attachments seem to work now. Henri has discovered that you uploaded your files with

[jira] Commented: (VELOCITY-453) [PATCH] Fix IntrospectionCacheData caching

2006-09-07 Thread Alexey Panchenko (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-453?page=comments#action_12433062 ] Alexey Panchenko commented on VELOCITY-453: --- in the equals method it is correct to use if (params[i] != other.params[i]) since the params[i] are

[jira] Commented: (VELOCITY-453) [PATCH] Fix IntrospectionCacheData caching

2006-09-06 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-453?page=comments#action_12432856 ] Will Glass-Husain commented on VELOCITY-453: Hi Alexey, Looks great, thanks for submitting. Appreciate your attention to detail with code

[jira] Commented: (VELOCITY-453) [PATCH] Fix IntrospectionCacheData caching

2006-08-31 Thread Alexey Panchenko (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-453?page=comments#action_12431832 ] Alexey Panchenko commented on VELOCITY-453: --- ASTMethod_IntrospectionCacheData_cache-v2.patch is the updated patch [PATCH] Fix IntrospectionCacheData

[jira] Commented: (VELOCITY-453) [PATCH] Fix IntrospectionCacheData caching

2006-08-31 Thread Will Glass-Husain (JIRA)
[ http://issues.apache.org/jira/browse/VELOCITY-453?page=comments#action_12431866 ] Will Glass-Husain commented on VELOCITY-453: Thanks for contributing! for some reason the patch didn't upload properly - I get a Tomcat error when