Throw more exceptions and log less errors
-----------------------------------------

                 Key: VELOCITY-467
                 URL: http://issues.apache.org/jira/browse/VELOCITY-467
             Project: Velocity
          Issue Type: Improvement
          Components: Source
    Affects Versions: 1.5 beta1
            Reporter: Will Glass-Husain
            Priority: Minor


Now that Velocity application exceptions are based on RuntimeException, we have 
more opportunity to use exceptions to signal application level problems.  I'm 
particularly concerned about initialization problems that are logged and may be 
missed.  We need to review all logged error messages and see if it would be 
more appropriate to throw an exception instead.  Some of these places we may 
need to leave as is for backwards compatibility reasons.  (e.g. macro in the 
global macro library doesn't parse properly).

Llewellyn Falco made a good case for this on the dev list recently:

http://www.mail-archive.com/velocity-dev@jakarta.apache.org/msg15067.html

#####
I still would like to put in my vote that sending error's to the log is an 
incredibly BAD idea.

If something is not working, it should be LOUDLY shown as an exception.
If it is working I don't really need a log.

The (velocity) log should be there for velocity developers (those programming 
the actual velocity code) not users.

I don't ever care to see tomcat's log, I care to see the things I log while in 
tomcat.

Most of all, many many many people do not check the log at all, let alone 
frequently.
####

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to