Will Glass-Husain [EMAIL PROTECTED] writes:
Thanks for the note. I made MethodCacheKey a public inner class so
that we could access it from the unit test. Couldn't figure out a
better way to do this, though suggestions are welcome.
Package private and the unit tests in the same package (though
That's a good idea. I think I'll leave it as it is though, there's a
convenience to having all the tests in one directory right now.
On 9/29/06, Henning P. Schmiedehausen [EMAIL PROTECTED] wrote:
Will Glass-Husain [EMAIL PROTECTED] writes:
Thanks for the note. I made MethodCacheKey a public
FYI.
* I applied Alexey's modified patch. (much appreciated)
* I applied Alexey's new hashCode routine. seems reasonable to me.
* I added NPE checks to equals and hash code. While Alexey's point
these are never needed is a good one, I worry about the consequence of
adding code in the future
Will Glass-Husain wrote:
* I applied Alexey's modified patch. (much appreciated)
You missed one point - MethodCacheKey is a static class in my patch.
The methodName is copied from the ASTMethod into the MethodCacheKey,
so the MethodCacheKey doesn't need access to it's parent class.
* I
Hi Alexey,
Thanks for the note. I made MethodCacheKey a public inner class so
that we could access it from the unit test. Couldn't figure out a
better way to do this, though suggestions are welcome.
I know, the NPE checks seem a little silly. Still, the checks are
cheap. I worry that the
Will Glass-Husain wrote:
Hi Alexey,
Thanks for the note. I made MethodCacheKey a public inner class so
that we could access it from the unit test. Couldn't figure out a
better way to do this, though suggestions are welcome.
@@ -320,7 +341,7 @@
* public access (and complete
