Re: svn commit: r471381 - in

2006-11-06 Thread Nathan Bubna
That's no problem for code calling the methods, but not for code overriding them. Are there any legitimate use cases for overriding these methods? On 11/5/06, Will Glass-Husain [EMAIL PROTECTED] wrote: You might be right. It started as a small change but became more significant as I worked

Re: svn commit: r471381 - in

2006-11-06 Thread Will Glass-Husain
Hmmm... Directive.init() might be a problem. If a user writes a custom directive, they subclass Directive. init used to throw Exception, now it throws TemplateInitException. Since this is a class not an interface we might still be ok. Let me test this. I previously tested this patch with a

svn commit: r471381 - in /jakarta/velocity/engine/trunk/src/java/org/apache/velocity: ./ app/ exception/ runtime/directive/ runtime/exception/ runtime/parser/node/

2006-11-05 Thread wglass
Author: wglass Date: Sun Nov 5 00:56:58 2006 New Revision: 471381 URL: http://svn.apache.org/viewvc?view=revrev=471381 Log: Removed generic Exception from throws for Template class and most Node classes. In response to VELOCITY-436. There's a danger of a change to an API call since this

Re: svn commit: r471381 - in

2006-11-05 Thread Henning P. Schmiedehausen
[EMAIL PROTECTED] writes: I like that but it is still a bold change right before beta2. :-) I do expect heavy bleeding edge users like Malcolm to squeal if that breaks things. :-) Best regards Henning Author: wglass Date: Sun Nov 5 00:56:58 2006 New Revision: 471381

Re: svn commit: r471381 - in

2006-11-05 Thread Will Glass-Husain
You might be right. It started as a small change but became more significant as I worked through it. Still, I think it's ok since we are taking away exceptions not adding them. WILL On 11/5/06, Henning P. Schmiedehausen [EMAIL PROTECTED] wrote: [EMAIL PROTECTED] writes: I like that but it