Re: [waffle] [PATCH 03/33] cgl: avoid leaking the PixelFormat

2014-07-15 Thread Chad Versace
Patches 1-3 look good and are committed to master. ___ waffle mailing list waffle@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/waffle

Re: [waffle] [PATCH 05/33] api: remove double NULL check

2014-07-15 Thread Chad Versace
On 07/07/2014 10:28 AM, Emil Velikov wrote: We check if the object is NULL before appending it to the obj_list and a second time as we append it. Drop the latter as it makes the code more confusing than it needs to be. Signed-off-by: Emil Velikov emil.l.veli...@gmail.com ---

Re: [waffle] [PATCH 10/33] cmake: build with fPIC when possible

2014-07-15 Thread Jose Fonseca
On 07/07/14 18:28, Emil Velikov wrote: Some of our third_party libraries may be build without it thus we'll fail at link tim. Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- cmake/Modules/WaffleDefineCompilerFlags.cmake | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [waffle] Some new and old fixes

2014-07-15 Thread Jose Fonseca
On 15/07/14 15:35, Jose Fonseca wrote: On 07/07/14 18:28, Emil Velikov wrote: Hi all, After respinning the latest changes (and ripping out WGL as it requires some api/abi changes) here is a lovely list of fixes that gets us closer to building waffle with mingw/msvc. The first four patches are

Re: [waffle] Some new and old fixes

2014-07-15 Thread Jose Fonseca
On 15/07/14 17:22, Emil Velikov wrote: On 15/07/14 15:35, Jose Fonseca wrote: On 07/07/14 18:28, Emil Velikov wrote: Hi all, After respinning the latest changes (and ripping out WGL as it requires some api/abi changes) here is a lovely list of fixes that gets us closer to building waffle with

Re: [waffle] Some new and old fixes

2014-07-15 Thread Emil Velikov
On 15/07/14 17:30, Jose Fonseca wrote: On 15/07/14 17:22, Emil Velikov wrote: On 15/07/14 15:35, Jose Fonseca wrote: On 07/07/14 18:28, Emil Velikov wrote: Hi all, After respinning the latest changes (and ripping out WGL as it requires some api/abi changes) here is a lovely list of fixes

Re: [waffle] Some new and old fixes

2014-07-15 Thread Jose Fonseca
On 15/07/14 18:14, Emil Velikov wrote: On 15/07/14 17:30, Jose Fonseca wrote: On 15/07/14 17:22, Emil Velikov wrote: On 15/07/14 15:35, Jose Fonseca wrote: On 07/07/14 18:28, Emil Velikov wrote: Hi all, After respinning the latest changes (and ripping out WGL as it requires some api/abi