Re: [waffle] [PATCH 2/7] nacl: add implementation for waffle_config_choose

2015-02-02 Thread Chad Versace
On 01/22/2015 11:59 PM, Tapani Pälli wrote: Patch fills attributes table suitable for Pepper API from wcore_config_attrs passed by the application. Signed-off-by: Tapani Pälli tapani.pa...@intel.com --- src/waffle/nacl/nacl_config.c | 30 ++

Re: [waffle] [PATCH 1/7] nacl: add supports_context_api implementation

2015-02-02 Thread Chad Versace
On 01/22/2015 11:59 PM, Tapani Pälli wrote: Currently only OpenGL ES 2.0 is supported. Signed-off-by: Tapani Pälli tapani.pa...@intel.com --- src/waffle/nacl/nacl_display.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/waffle/nacl/nacl_display.c

Re: [waffle] [PATCH 3/7] nacl: add implementation for waffle_context_create

2015-02-02 Thread Chad Versace
On 01/22/2015 11:59 PM, Tapani Pälli wrote: Patch creates and initializes pp::Graphics3D context for OpenGL ES 2.0. Signed-off-by: Tapani Pälli tapani.pa...@intel.com --- src/waffle/nacl/nacl_container.cpp | 81 ++ src/waffle/nacl/nacl_container.h |

Re: [waffle] [PATCH 07/17] core: Add arithmetic functions that detect overflow

2015-01-27 Thread Chad Versace
On 01/21/2015 06:06 AM, Emil Velikov wrote: On 4 January 2015 at 22:03, Chad Versace chad.vers...@intel.com wrote: Define the function below. All act on size_t inputs. wcore_add_size wcore_iadd_size : in-place addition wcore_mul_size wcore_imul_size : in-place multiplication

Re: [waffle] [PATCH 17/17] examples/gl_basic: Update to use waffle_window_create2()

2015-01-27 Thread Chad Versace
On 01/21/2015 06:12 AM, Emil Velikov wrote: On 4 January 2015 at 22:03, Chad Versace chad.vers...@intel.com wrote: Tested on GLX, X11/EGL, Wayland, and GBM. Signed-off-by: Chad Versace chad.vers...@intel.com --- examples/gl_basic.c | 10 -- 1 file changed, 8 insertions(+), 2

Re: [waffle] [PATCH 00/17 v2] Add new public function waffle_window_create2 (v2)

2015-01-27 Thread Chad Versace
On 01/21/2015 06:27 AM, Emil Velikov wrote: On 4 January 2015 at 22:02, Chad Versace chad.vers...@intel.com wrote: I've just send a couple of updates to get things working for WGL/MSVC. With those applied on top of your waffle_window_create2 branch (top commit

Re: [waffle] [PATCH] wflinfo: find glGetStringi on both Mali and WGL

2015-01-27 Thread Chad Versace
, 19 insertions(+), 21 deletions(-) LGTM Reviewed-by: Chad Versace chad.vers...@intel.com This will land in maint-1.5 and master later today. signature.asc Description: OpenPGP digital signature ___ waffle mailing list waffle@lists.freedesktop.org http

[waffle] [ANNOUNCE] Waffle 1.4.4

2015-01-22 Thread Chad Versace
--- Chad Versace (2): doc: Add release notes for Waffle 1.4.4 waffle: Bump version to 1.4.4 Dylan Baker (2): cmake: Add cmake PackageConfig files cmake: fix version search Jordan Justen (4): debian: Add WaffleConfig*.cmake to libwaffle-dev package signature.asc

[waffle] [ANNOUNCE] Waffle 1.5.1

2015-01-22 Thread Chad Versace
projects that use CMake and used FindWaffle.cmake. See bug [https://github.com/waffle-gl/waffle/issues/27]. Changes since 1.5.0 --- Chad Versace (3): doc: Add release notes for Waffle 1.5.1 doc: Add release notes for Waffle 1.4.4 wgl: Fix requirements

Re: [waffle] [PATCH 1/3] waffle: add public func waffle_teardown()

2015-01-20 Thread Chad Versace
waffle_get_proc_address waffle_is_extension_in_string This all looks good to me. Patch 1 is Reviewed-by: Chad Versace chad.vers...@intel.com signature.asc Description: OpenPGP digital signature ___ waffle mailing list waffle@lists.freedesktop.org http

Re: [waffle] [PATCH 2/3] examples: make use of waffle_teardown

2015-01-20 Thread Chad Versace
reachable: 23,451 bytes in 55 blocks Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- examples/gl_basic.c | 6 +- examples/simple-x11-egl.c | 5 + 2 files changed, 10 insertions(+), 1 deletion(-) Looks good. Patch 2 is Reviewed-by: Chad Versace chad.vers...@intel.com

Re: [waffle] [PATCH 3/3] wflinfo: use waffle_teardown

2015-01-20 Thread Chad Versace
-by: Chad Versace chad.vers...@intel.com signature.asc Description: OpenPGP digital signature ___ waffle mailing list waffle@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/waffle

Re: [waffle] [PATCH 0/3] Add the waffle_teardown API

2015-01-20 Thread Chad Versace
On 01/15/2015 05:31 AM, Emil Velikov wrote: On 15 January 2015 at 15:21, Emil Velikov emil.l.veli...@gmail.com wrote: Hello all, As mentioned a while back, here is the function waffle_teardown. Its purpose is to cleanup the global state (the api_platform variable and the respective platform

Re: [waffle] [PATCH 01/17] include: Define macro WAFFLE_DEPRECATED_1_06

2015-01-20 Thread Chad Versace
On 01/15/2015 04:29 AM, Emil Velikov wrote: On 4 January 2015 at 22:02, Chad Versace chad.vers...@intel.com wrote: This macro annotates symbols as deprecated in Waffle 1.6. The compiler emits deprecation warnings only if the user enables the feature macro for the Waffle 1.6 API. Signed-off

Re: [waffle] [PATCH v3 0/4] Initial NaCl patches v3

2015-01-20 Thread Chad Versace
On 01/04/2015 11:36 PM, Tapani Pälli wrote: Hello; Here is v3 of nacl support patches with many changes and fixes here and there! Thanks for Emil and Chad for review, I think it looks a lot cleaner now. In case you want to try on Chrome, I also put 'demo' of gl_basic here:

[waffle] [PATCH 00/17 v2] Add new public function waffle_window_create2 (v2)

2015-01-04 Thread Chad Versace
] - Be smarter about arithmetic overflows when allocating memory. - Handle malloc failure. [emil] - Fix some #include placements. [emil] Chad Versace (17): include: Define macro WAFFLE_DEPRECATED_1_06 include: Deprecate waffle_attrib_list funcs core: Rename functions s/wcore_attrib_list

Re: [waffle] [PATCH v2 2/4] waffle: add support for building Waffle using NaCl toolchain

2014-12-31 Thread Chad Versace
On 12/30/2014 11:30 PM, Tapani Pälli wrote: On 12/30/2014 12:53 AM, Emil Velikov wrote: On 22/12/14 22:28, Chad Versace wrote: On 12/21/2014 07:53 AM, Emil Velikov wrote: On 17 December 2014 at 10:17, Tapani Pälli tapani.pa...@intel.com wrote: Patch adds changes required to use NaCl compiler

Re: [waffle] [PATCH] waffle: make gl_basic to work with nacl

2014-12-31 Thread Chad Versace
On 12/29/2014 12:00 AM, Tapani Pälli wrote: On 12/23/2014 04:25 AM, Chad Versace wrote: On 12/21/2014 08:06 AM, Emil Velikov wrote: On 17 December 2014 at 13:12, Tapani Pälli tapani.pa...@intel.com wrote: Signed-off-by: Tapani Pälli tapani.pa...@intel.com --- .gitignore

Re: [waffle] [PATCH v2 2/4] waffle: add support for building Waffle using NaCl toolchain

2014-12-22 Thread Chad Versace
On 12/21/2014 07:53 AM, Emil Velikov wrote: On 17 December 2014 at 10:17, Tapani Pälli tapani.pa...@intel.com wrote: Patch adds changes required to use NaCl compiler and libraries to build Waffle. Build can be configured to use specific version of the NaCl SDK, toolchain for the build needs to

Re: [waffle] [PATCH v2 2/4] waffle: add support for building Waffle using NaCl toolchain

2014-12-22 Thread Chad Versace
On 12/17/2014 04:17 AM, Tapani Pälli wrote: Patch adds changes required to use NaCl compiler and libraries to build Waffle. Build can be configured to use specific version of the NaCl SDK, toolchain for the build needs to be selected with cmake variable CMAKE_TOOLCHAIN_FILE. Example command

Re: [waffle] [PATCH v2 3/4] waffle: initial empty implementation of nacl backend

2014-12-22 Thread Chad Versace
On 12/17/2014 04:17 AM, Tapani Pälli wrote: Patch adds nacl platform skeleton. Only thing it does is that it creates a container that holds the 3D context object which is responsible for any communication required with browser. v2: cleanups, remove unnecessary casts, use c99 initializer

Re: [waffle] [PATCH 02/11] core: Define intptr_t variants of wcore_attrib_list functions

2014-12-22 Thread Chad Versace
On 12/21/2014 08:22 AM, Emil Velikov wrote: On 16 December 2014 at 08:18, Chad Versace chad.vers...@linux.intel.com wrote: When designing the original Waffle 1.0 API, I made a mistake when I chose to declare attribute lists as arrays of int32_t. Instead, they should have been arrays

Re: [waffle] [PATCH 02/11] core: Define intptr_t variants of wcore_attrib_list functions

2014-12-22 Thread Chad Versace
On 12/21/2014 01:28 PM, Emil Velikov wrote: On 21 December 2014 at 14:22, Emil Velikov emil.l.veli...@gmail.com wrote: On 16 December 2014 at 08:18, Chad Versace chad.vers...@linux.intel.com wrote: When designing the original Waffle 1.0 API, I made a mistake when I chose to declare attribute

Re: [waffle] [PATCH 07/11] core: Add func wcore_attrib_list_copy()

2014-12-22 Thread Chad Versace
On 12/21/2014 09:00 AM, Emil Velikov wrote: On 16 December 2014 at 08:18, Chad Versace chad.vers...@linux.intel.com wrote: This is useful for making a writable copy of a read-only attribute list. Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- src/waffle/core

Re: [waffle] [PATCH] waffle: make gl_basic to work with nacl

2014-12-22 Thread Chad Versace
On 12/21/2014 08:06 AM, Emil Velikov wrote: On 17 December 2014 at 13:12, Tapani Pälli tapani.pa...@intel.com wrote: Signed-off-by: Tapani Pälli tapani.pa...@intel.com --- .gitignore | 2 ++ examples/CMakeLists.txt | 30 ++ examples/gl_basic.c |

Re: [waffle] [PATCH v2 1/4] examples: add waffle_has_x11_egl check for simple-x11-egl

2014-12-17 Thread Chad Versace
On 12/17/2014 02:17 AM, Tapani Pälli wrote: Signed-off-by: Tapani Pälli tapani.pa...@intel.com --- examples/CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/CMakeLists.txt b/examples/CMakeLists.txt index 281ef47..df66f60 100644 ---

Re: [waffle] [PATCH v2 1/4] examples: add waffle_has_x11_egl check for simple-x11-egl

2014-12-17 Thread Chad Versace
On 12/17/2014 12:22 PM, Chad Versace wrote: -if(waffle_on_linux) +if((waffle_on_linux) AND (waffle_has_x11_egl)) Please drop the parens around the conditions. It should be if(waffle_on_linux AND waffle_has_x11_egl Ugh... looks like this is all the reviewing I will get done today. I feel

[waffle] [PATCH 04/11] waffle: Fix signature of wcore_platform::window::create()

2014-12-16 Thread Chad Versace
Fix signature to match that of waffle_window_create(). The types of parameters 'width' and 'height' didn't match the public header. As a consequence, also fix the signature of ${PLATFORM}_window_create() for all platforms. Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- src/waffle

[waffle] [PATCH 05/11] core: Add func wcore_error_bad_attribute

2014-12-16 Thread Chad Versace
This little helper function emits WAFFLE_ERROR_BAD_ATTRIBUTE with a default error message. Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- src/waffle/core/wcore_error.c | 8 src/waffle/core/wcore_error.h | 4 2 files changed, 12 insertions(+) diff --git a/src/waffle

[waffle] [PATCH 00/11] Add new public func waffle_window_create2()

2014-12-16 Thread Chad Versace
the build on Windows, Android, and Mac. Before merging this series, I will ensure it doesn't break the build on those platforms. I don't have the ability to actually test on Android or Windows, though. This patch series is available on my personal branch 'waffle_window_create2'. Chad Versace (11

[waffle] [PATCH 01/11] core: Rename functions s/wcore_attrib_list/wcore_attrib_list32/

2014-12-16 Thread Chad Versace
intptr_t variants of the wcore_attrib_list functions. Make room for the new intptr_t wcore_attrib_list functions by renaming the old ones. Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- src/waffle/api/waffle_attrib_list.c | 8 +- src/waffle/core/wcore_attrib_list.c

[waffle] [PATCH 03/11] waffle: Fix mismatch in waffle_window_create prototype

2014-12-16 Thread Chad Versace
The prototype differed between the public header and file waffle_window.c. This is solely a cosmetic change, because 'int' and 'int32_t' are the same on all platforms supported by Waffle. Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- src/waffle/api/waffle_window.c | 2 +- 1 file

[waffle] [PATCH 10/11] tests/gl_basic: Update to use waffle_window_create2()

2014-12-16 Thread Chad Versace
Tested on GLX, X11/EGL, and Wayland. Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- tests/functional/gl_basic_test.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/tests/functional/gl_basic_test.c b/tests/functional/gl_basic_test.c index 03692e0

Re: [waffle] [RFC] Add display support to GBM backend

2014-12-16 Thread Chad Versace
On 12/12/2014 12:21 PM, Frank Henigman wrote: On Wed, Nov 19, 2014 at 2:38 PM, Chad Versace chad.vers...@intel.com wrote: +bool +wgbm_window_swap_buffers(struct wcore_window *wc_self) +{ +//XXX detect driver before invoking driver-specific code - gbm_device_get_backend_name() doesn't

[waffle] [ANNOUNCE] Waffle 1.5.0 (final)

2014-12-10 Thread Chad Versace
used glGetStringi incorrectly on Mali drivers. * gbm: Workaround Mesa linkage issue * gbm: Remove Mesa warning evoked by waffle_window_swap_buffers(). Contributors since Waffle 1.4.0 --- 80 Emil Velikov emil.l.veli...@gmail.com 39 Chad Versace chad.vers

[waffle] Branch and merge strategy

2014-12-10 Thread Chad Versace
If you are a contributor and want one take-away message from this email, it is: Continue to send patches and merge-requests to the mailing list. If in doubt, you should target the 'master' branch. If it's a bugfix, consider targeting one of the maintenance branches instead, but

[waffle] [ANNOUNCE] Waffle 1.5.0-rc2

2014-12-09 Thread Chad Versace
. * gbm: Workaround Mesa linkage issue * gbm: Remove Mesa warning evoked by waffle_window_swap_buffers(). Contributors since Waffle 1.4.0 --- 80 Emil Velikov emil.l.veli...@gmail.com 39 Chad Versace chad.vers...@linux.intel.com 9 Jordan Justen

Re: [waffle] nacl backend

2014-12-09 Thread Chad Versace
On 12/09/2014 04:15 AM, Tapani Pälli wrote: Hi; Hi Tapani :) I'm currently working on a NaCl backend for Waffle, I wanted to ask for opinions or comments on my current approach. Great to hear! First of all I'm using some c++ in the nacl backend code but AFAIK everything of this can be

[waffle] [PATCH (maint-1.4)] cmake: Fix building with CMake 2.8.11

2014-12-05 Thread Chad Versace
2.8.11. This patch fixes Waffle to use the PRIVATE keyword only if cmake = 2.8.12. Otherwise, it falls back to the LINK_INTERFACE_LIBRARIES hack removed by 92116dae. Reported-by: Matej Cepl mc...@cepl.eu Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- I tested this patch on Chrome OS

Re: [waffle] [PATCH (maint-1.4)] glx: Fix requirements for creation of ES2 context

2014-12-05 Thread Chad Versace
On 12/05/2014 04:44 PM, Chad Versace wrote: To create an ES2 context, Waffle required GLX_EXT_create_context_es2_profile. Fix Waffle to require either GLX_EXT_create_context_es_profile *or* GLX_EXT_create_context_es2_profile, because GLX_EXT_create_context_es_profile is an updated variant

[waffle] [PATCH] wgl: Fix requirements for creation of ES2 context

2014-12-05 Thread Chad Versace
that supercedes it. Cc: José Fonseca jfons...@vmware.com Cc: Emil Velikov emil.l.veli...@gmail.com Fixes #23: https://github.com/waffle-gl/waffle/issues/23 Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- Totally untested. I don't have MinGW setup right now. Windows people, please let know

Re: [waffle] [PATCH] revert commit 92116dae to make it build with cmake 2.8.12

2014-12-04 Thread Chad Versace
Jordan and Emil, does reverting 92116dae break anything for you? I don't have a Debian-based machine, (and this CMake hack was made specifically to silence Debian warnings), so I don't want to commit this without your ok. If this revert causes Debian any problems, then I think the next best thing

Re: [waffle] [RFC] Add display support to GBM backend

2014-12-01 Thread Chad Versace
On 11/20/2014 12:04 PM, Emil Velikov wrote: Hi all, On 19/11/14 19:38, Chad Versace wrote: Frank sent this patch as a proof-of-concept. It's a draft, and not ready for committing. I'm posting to the list just to start discussion. See [https://github.com/waffle-gl/waffle/issues/18]. I think

Re: [waffle] [PATCH (maint-1.4)] wflinfo: Fix glGetStringi on Mali

2014-11-20 Thread Chad Versace
On Thu 20 Nov 2014, Daniel Kurtz wrote: On Thu, Nov 20, 2014 at 10:34 AM, Chad Versace chad.vers...@intel.com wrote: diff --git a/src/utils/wflinfo.c b/src/utils/wflinfo.c index 0b03e55..0907b4b 100644 --- a/src/utils/wflinfo.c +++ b/src/utils/wflinfo.c @@ -1037,7 +1037,28 @@ main(int argc

[waffle] [RFC] Add display support to GBM backend

2014-11-19 Thread Chad Versace
Frank sent this patch as a proof-of-concept. It's a draft, and not ready for committing. I'm posting to the list just to start discussion. See [https://github.com/waffle-gl/waffle/issues/18]. I think detailed patch discussions like this are easier over email than Github's issue tracker, so

Re: [waffle] [PULL] WGL support

2014-11-12 Thread Chad Versace
On Wed 12 Nov 2014, Jose Fonseca wrote: Hi Emil, I went through the new patches and they look good AFAICT. Thanks for doing this. While going through wgl: fully support ARB_create_context and EXT_create_context_es_profile. again I noticed a couple of issues with the usage of

Re: [waffle] [PATCH 1/7] pkg/archlinux: use configure autodetection

2014-11-11 Thread Chad Versace
On Mon 10 Nov 2014, Emil Velikov wrote: Since waffle 1.4 we have autodetection at configure time. Let's use it and drop a couple of lines PKGBUILD magic. Signed-off-by: Emil Velikov emil.l.veli...@gmail.com Patch 1 is Reviewed-by: Chad Versace chad.vers...@linux.intel.com

Re: [waffle] [PATCH 2/7] pkg/archlinux: waffle does not link against libegl

2014-11-11 Thread Chad Versace
On Mon 10 Nov 2014, Emil Velikov wrote: As such demote libegl to makedepend/optdepent, so that one can build waffle, and optionally use x11_egl/gbm/wayland. Patch 2 is Reviewed-by: Chad Versace chad.vers...@linux.intel.com And, I see for *more* EGL dependency removal. If I understand

Re: [waffle] [PATCH 3/7] gbm: fetch the libgbm function pointers at wgbm_platform_init

2014-11-11 Thread Chad Versace
/wgbm_platform.h | 17 + 2 files changed, 59 insertions(+), 1 deletion(-) Patch 3 is Reviewed-by: Chad Versace chad.vers...@linux.intel.com ___ waffle mailing list waffle@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/waffle

Re: [waffle] Remove libgbm/libGL linktime dependency

2014-11-11 Thread Chad Versace
Emil, please collect my reviewed-bys onto your branch and look over the changes in my v2 of patch 4. If all looks good to you, let me know and I'll merge branch. On Mon 10 Nov 2014, Emil Velikov wrote: Hello all, As the name suggests, the series removes the hard dependency of waffle of the

Re: [waffle] [PULL] WGL support

2014-11-10 Thread Chad Versace
On Mon 10 Nov 2014, Emil Velikov wrote: On 10/11/14 06:17, Chad Versace wrote: On Sun 09 Nov 2014, Emil Velikov wrote: - As explained in man:gitworkflow(7), merges between branches always flow upwards and never downwards. That is, maint - master - next and never

Re: [waffle] [PULL] WGL support

2014-11-09 Thread Chad Versace
On Sun 09 Nov 2014, Emil Velikov wrote: As mentioned earlier here is a rebase of all the wgl work so far on top of origin/master. Merged to next! So... what does that mean??? That means I'll merge your branch to 'master' after it cooks for a little while and I'm certain Piglit doesn't

Re: [waffle] Drop the libEGL linking, take 2

2014-11-08 Thread Chad Versace
On Sat 08 Nov 2014, Emil Velikov wrote: On 08/11/14 05:18, Chad Versace wrote: On Wed 10 Sep 2014, Emil Velikov wrote: Changes comparing to previous round - raised the severity on dlopen/dlsym - crushed some typos - use the versioned lib on linux and the unversioned on android - updated

[waffle] [ANNOUNCE] Waffle 1.4.1

2014-11-07 Thread Chad Versace
Release Notes == Bugfixes * Update the CMake requirement to 2.8.11. Changes --- Chad Versace (3): waffle: Bump version to 1.4.1 .gitignore: Ignore static libraries *.a Android.mk: Fix version of 1.4.0 Emil Velikov (1): cmake: bump minimum

Re: [waffle] Drop the libEGL linking, take 2

2014-11-07 Thread Chad Versace
On Wed 10 Sep 2014, Emil Velikov wrote: Changes comparing to previous round - raised the severity on dlopen/dlsym - crushed some typos - use the versioned lib on linux and the unversioned on android - updated the android build (but untested) Emil, this looks good to me. It's nice to see one

Re: [waffle] Checking In

2014-10-24 Thread Chad Versace
On Wed 22 Oct 2014, Emil Velikov wrote: On 11/09/14 15:43, Chad Versace wrote: On 09/07/2014 05:37 PM, Jordan Justen wrote: Having a year between 1.3 and 1.4, I'm reluctant to introduce delays. To avoid delays like that in the future, I'm thinking that waffle should adopt a short

Re: [waffle] [PATCH] cmake: wire up check and check-func with valgrind

2014-09-17 Thread Chad Versace
} ${CMAKE_BINARY_DIR}/tests/functional/gl_basic_test COMMAND ${VALGRIND_EXECUTABLE} $TARGET_FILE:gl_basic_test Without or without Nils' changes, this patch is Reviewed-by: Chad Versace chad.vers...@linux.intel.com I've already applied Nil's changes in my local branch. Do you mind if I push with his

[waffle] [ANNOUNCE] Waffle 1.4.0-rc1

2014-09-07 Thread Chad Versace
information about the system's OpenGL capabilities, similar to 'glxinfo'. See the documentation at [man:wflinfo.1] or [http://www.waffle-gl.org/man/wflinfo.1.html]. (Implemented by Jordan Justen. Chad Versace fixed some bugs and corner cases). * Linux * GBM backend

Re: [waffle] [PATCH 0/8] make check cleanup windows support

2014-08-20 Thread Chad Versace
On 08/20/2014 05:58 AM, Emil Velikov wrote: On 20/08/14 00:38, Chad Versace wrote: On 08/04/2014 07:34 AM, Emil Velikov wrote: TEST_RUN2(gl_basic, glx_gl20, all_gl20); TEST_RUN2(gl_basic, glx_gl21, all_gl21); Note that this still gives us a ton of duplication, yet I feel that any further

Re: [waffle] [PATCH] x11: fix for a non-zero default screen

2014-08-20 Thread Chad Versace
On 08/20/2014 07:11 AM, Emil Velikov wrote: On 19/08/14 23:10, Marek Olšák wrote: From: Marek Olšák marek.ol...@amd.com Marek you have my vote if you ever run for a president, going through mesa and waffle to fix this - you're a star :) Must admit that I don't have much experience with xcb

Re: [waffle] [PATCH 4/4] wgl: attempt to fix the final test

2014-08-20 Thread Chad Versace
On 08/19/2014 11:42 AM, Jose Fonseca wrote: On 19/08/14 18:44, Emil Velikov wrote: On 19 August 2014 16:51, Jose Fonseca jfons...@vmware.com wrote: On 19/08/14 16:41, Jose Fonseca wrote: I'm sure it overflows on Linux too. valgrind might complain. But MSVC emits code to check for stack

Re: [waffle] Final (GSoCwise) waffle WGL release

2014-08-20 Thread Chad Versace
On 08/20/2014 06:55 AM, Emil Velikov wrote: waffle works like a champ with WGL, even piglit approves :P With branches 'yet-another-round-of-msvc-fixes-1.2' [1] and 'waffle-WGL-1.2' I can run piglit+waffle+wgl on my Windows 7 machine and even crash the drivers on a non-concurrent run :)

Re: [waffle] [PATCH 0/8] make check cleanup windows support

2014-08-19 Thread Chad Versace
On 08/04/2014 07:34 AM, Emil Velikov wrote: So it seems like I've completely missed out to send this series last week, so here it goes. The series covers - Consolidates the duplicating gl_basic_test(s) into two groups - all and all_but_cgl (as cgl is the wierd one this time). - Adds

Re: [waffle] [PATCH 1/4] wgl: strings.h does not exist in MSVC

2014-08-18 Thread Chad Versace
For this 4 patch series, Reviewed-by: Chad Versace chad.vers...@linux.intel.com I'll wait for a pull request. ___ waffle mailing list waffle@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/waffle

Re: [waffle] [PATCH 03/18] README_WIN: add some notes about configuring and building WGL

2014-07-30 Thread Chad Versace
On 07/23/2014 08:40 AM, Emil Velikov wrote: On 23/07/14 16:13, Jose Fonseca wrote: On 23/07/14 04:31, Emil Velikov wrote: TODO: - Fill in the missing sections. - Move to a better place. - Double-check for typos and thinkos. Signed-off-by: Emil Velikov emil.l.veli...@gmail.com ---

Re: [waffle] [PATCH 01/18] cmake: include the CPACK module

2014-07-30 Thread Chad Versace
more than the traditional GNU-style `make dist` or `make tarball`. Reviewed-by: Chad Versace chad.vers...@linux.intel.com Tested-by: Chad Versace chad.vers...@linux.intel.com ___ waffle mailing list waffle@lists.freedesktop.org http://lists.freedesktop.org

Re: [waffle] [PATCH 02/18] pkg/archlinux: add mingw-w64-waffle package

2014-07-30 Thread Chad Versace
..a2ebde5 --- /dev/null +++ b/pkg/archlinux/mingw-w64-waffle/PKGBUILD @@ -0,0 +1,80 @@ +# Maintainer: Chad Versace chad.vers...@linux.intel.com + +pkgname='mingw-w64-waffle' +pkgver='1.3.0' +pkgrel=1 +pkgdesc='a library for choosing window system and OpenGL API at runtime (mingw-w64)' +arch

Re: [waffle] [PATCH 06/18] wgl: implement display management

2014-07-30 Thread Chad Versace
On 07/23/2014 08:27 AM, Jose Fonseca wrote: On 23/07/14 16:25, Jose Fonseca wrote: On 23/07/14 04:31, Emil Velikov wrote: +PIXELFORMATDESCRIPTOR pfd = { +sizeof(PIXELFORMATDESCRIPTOR), +1, +PFD_SUPPORT_OPENGL | +PFD_DRAW_TO_WINDOW | +

Re: [waffle] [PATCH 16/33] third_party/threads: import c11 threads emulation wrappers

2014-07-27 Thread Chad Versace
On 07/23/2014 09:11 AM, Jose Fonseca wrote: On 21/07/14 17:45, Emil Velikov wrote: On 17/07/14 05:40, Chad Versace wrote: Emil, I think that mixing GLUT with other stuff is a bad idea. Otherwise -- whether to add some input support to waffle or not -- is a design choice that Chad needs

Re: [waffle] [PULL] waffle-fixes

2014-07-27 Thread Chad Versace
On 07/27/2014 05:38 AM, Emil Velikov wrote: Humble ping :) On 22/07/14 20:42, Emil Velikov wrote: Hi Chad, Can you please pull the series into master. It contains most of the lengthy series of fixes that was flowing on the mailing-list. Ping acknowledged :) I merged your series into

[waffle] Windows workflow and updates

2014-07-21 Thread Chad Versace
On 07/21/2014 09:45 AM, Emil Velikov wrote: On 17/07/14 05:40, Chad Versace wrote: I see that you're collecting reviewed-by tags and cleanups on versioned branches (for-upstream-3.*). I will defer cherry-picking patches off the mailing list onto master; and instead will wait for you to send

Re: [waffle] [PATCH 07/33] linux: plug a memory leak

2014-07-16 Thread Chad Versace
On 07/07/2014 10:28 AM, Emil Velikov wrote: Chad, do you have a plan/idea how to handle this ? I'm assuming that your plan is to tackle this once waffle_init is gone/replaced with a better solution (issue #7). There appears to be a straightforward solution: add a new API call

Re: [waffle] [PATCH 16/33] third_party/threads: import c11 threads emulation wrappers

2014-07-16 Thread Chad Versace
Emil, I'm finished reviewing for today, and am stopping here at patch 16. I'll resume reviewing tomorrow. I see that you're collecting reviewed-by tags and cleanups on versioned brancehs (for-upstream-3.*). I will defer cherry-picking patches off the mailing list onto master; and instead will

Re: [waffle] [PATCH 03/33] cgl: avoid leaking the PixelFormat

2014-07-15 Thread Chad Versace
Patches 1-3 look good and are committed to master. ___ waffle mailing list waffle@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/waffle

Re: [waffle] [PATCH 05/33] api: remove double NULL check

2014-07-15 Thread Chad Versace
/api/waffle_context.c | 2 +- src/waffle/api/waffle_gl_misc.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Chad Versace chad.vers...@linux.intel.com ___ waffle mailing list waffle@lists.freedesktop.org http

Re: [waffle] [PATCH 0/3] Memory leak fixes

2014-07-01 Thread Chad Versace
On Thu, Jun 26, 2014 at 01:17:30PM +0100, Emil Velikov wrote: On 06/06/14 07:38, Chad Versace wrote: On Sun, Jun 01, 2014 at 03:11:59PM +0100, Emil Velikov wrote: Spotted while searching for a severe memory corruption under wgl. Did not manage to find it yet, although notices these bad boys

Re: [waffle] waffle vs msvc: Round 1, Fight !!!

2014-07-01 Thread Chad Versace
On Mon, Jun 30, 2014 at 01:05:27AM +0100, Emil Velikov wrote: Hello all, Another day another long email :) As usual, a list of issues, possible solutions, and my personal preference for each. At the end I have tried to assign a priority for most. Any input would be greatly appreciated.

Re: [waffle] Waffle and GL dispatch

2014-06-27 Thread Chad Versace
On Thu, Jun 26, 2014 at 05:46:56PM +0100, Eric Anholt wrote: Emil Velikov emil.l.veli...@gmail.com writes: Not aiming at it atm, but just curious - which one would you consider as the better option: - Convert waffle to use libepoxy, or - clone the current implementation into waffle and

Re: [waffle] waffle-wgl a hefty mId-term code drop :)

2014-06-27 Thread Chad Versace
On Thu, Jun 26, 2014 at 12:55:53PM +0100, Emil Velikov wrote: Hi all, It's official the first half of the project is now complete. Concise and up-to the point information can be seen in the release notes [1]. [1] https://github.com/evelikov/waffle/releases/tag/v1.0 Awesome! P.S. If it

Re: [waffle] [PATCHv2 04/10] cmake: add autodetection for waffle_has_egl, glx...

2014-06-10 Thread Chad Versace
On Fri, Jun 06, 2014 at 02:18:37PM +0100, Emil Velikov wrote: Silence the pkg_check_modules and check set the default options depending on the packages found. Error out if the user has selected an option and it's requirements are not met. v2: - Do not silence pkg_check_modules. -

Re: [waffle] [PATCH 05/10] waffle: remove found_platform from waffle_init_parse_attrib_list

2014-06-10 Thread Chad Versace
On Fri, Jun 06, 2014 at 12:24:06PM +0100, Emil Velikov wrote: On 06/06/14 07:25, Chad Versace wrote: On Sat, May 31, 2014 at 03:22:03AM +0100, Emil Velikov wrote: Whenever a platform is missing a case statement, the default will kick in throwing an error and exiting the function. Ah

Re: [waffle] [PATCH 04/10] cmake: add autodetection for waffle_has_egl, glx...

2014-06-06 Thread Chad Versace
On Sat, May 31, 2014 at 03:22:02AM +0100, Emil Velikov wrote: Silence the pkg_check_modules and check set the default options depending on the packages found. This is a good idea and will make Waffle easier to configure for everyone. There are a few problems though. If configuration fails

Re: [waffle] [PATCH 05/10] waffle: remove found_platform from waffle_init_parse_attrib_list

2014-06-06 Thread Chad Versace
On Sat, May 31, 2014 at 03:22:03AM +0100, Emil Velikov wrote: Whenever a platform is missing a case statement, the default will kick in throwing an error and exiting the function. Ah, but that's not what 'found_platform' is checking for... -if (!found_platform) { -

Re: [waffle] [PATCH 08/10] cgl: avoid leaking the PixelFormat

2014-06-06 Thread Chad Versace
On Sat, May 31, 2014 at 03:22:06AM +0100, Emil Velikov wrote: According to apple developer page, starting with OS X v10.5 the pixelformat is reference counted. The object is created at CGLChoosePixelFormat and should be unrefeferenced via CGLReleasePixelFormat/CGLDestroyPixelFormat. The

Re: [waffle] [PATCH 09/10] x11: correctly set the screen number of the current display

2014-06-06 Thread Chad Versace
= DefaultScreen(self-xlib); return true; } Reviewed-by: Chad Versace chad.vers...@linux.intel.com ___ waffle mailing list waffle@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/waffle

Re: [waffle] [PATCH 10/10] glx: glx_context_create_native returns GLXContext not bool

2014-06-06 Thread Chad Versace
NULL; ctx = wrapped_glXCreateContextAttribsARB(platform, dpy-x11.xlib, -- Reviewed-by: Chad Versace chad.vers...@linux.intel.com ___ waffle mailing list waffle@lists.freedesktop.org http

Re: [waffle] [PATCH 0/3] Memory leak fixes

2014-06-06 Thread Chad Versace
On Sun, Jun 01, 2014 at 03:11:59PM +0100, Emil Velikov wrote: Spotted while searching for a severe memory corruption under wgl. Did not manage to find it yet, although notices these bad boys. Awesome. Patch 1 is rb'd and committed to master. I will case the corruption bug over the next few

Re: [waffle] [GSOC2014] Current design/implementation + the infamous corruption

2014-06-06 Thread Chad Versace
On Thu, Jun 05, 2014 at 05:49:04PM +0100, Emil Velikov wrote: On 05/06/14 03:19, Emil Velikov wrote: waffle_window_create(config, w, h) + waffle_window_resize() // Reuse the window... and boom. Any suggestions on // how to resolve this, or should we mandate that

Re: [waffle] [GSOC 2014] How to deal with non win32 api, wgl(Create, Make)Context depends on existing window

2014-06-05 Thread Chad Versace
On Wed, Jun 04, 2014 at 11:47:32PM -0700, Jose Fonseca wrote: I thought we wanted to go ahead an provide a binary build for windows, and thus: 1. It should be buildable under Linux using mingw 2. The binary should have a reasonable license situation Didn't we already pretty much have

Re: [waffle] [GSOC 2014] How to deal with non win32 api, wgl(Create, Make)Context depends on existing window

2014-06-05 Thread Chad Versace
On Wed, Jun 04, 2014 at 01:24:38PM -0700, Jose Fonseca wrote: - Original Message - On 02/06/14 19:55, Chad Versace wrote: On Sat, May 31, 2014 at 12:02:10PM -0700, Jose Fonseca wrote: - Original Message - - Original Message - On 24/05/14 20:28

Re: [waffle] [PATCH 01/10] pkg/archlinux: Update to a dual (+multilib) package

2014-06-05 Thread Chad Versace
On Sat, May 31, 2014 at 03:21:59AM +0100, Emil Velikov wrote: Include both 64bit and multilib binaries when building on x86-64 platform. This saves us deeping track of version numbers and interdependencies in case of a split package. v2: Rebase and bump pkgrel Signed-off-by: Emil Velikov

Re: [waffle] [PATCH 02/10] cmake: reformat/update install targets

2014-06-05 Thread Chad Versace
it to 'bin'. v2: Tag html documentation as htmldocs COMPONENT. Suggested by Chad. Signed-off-by: Emil Velikov emil.l.veli...@gmail.com Reviewed-by: Chad Versace chad.vers...@linux.intel.com ___ waffle mailing list waffle@lists.freedesktop.org http

Re: [waffle] [GSOC 2014] How to deal with non win32 api, wgl(Create, Make)Context depends on existing window

2014-06-02 Thread Chad Versace
On Sat, May 31, 2014 at 12:02:10PM -0700, Jose Fonseca wrote: - Original Message - - Original Message - On 24/05/14 20:28, Emil Velikov wrote: Hi all, Another round of interesting bits and bulbs. Bit of an update: The email came out a

Re: [waffle] [PATCH 4/8] cmake: use the relative path in the install targets

2014-05-30 Thread Chad Versace
Committed to master. On Sat, May 24, 2014 at 11:51:31PM +0100, Emil Velikov wrote: Otherwise make DESTDIR=... install will not function properly. Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- CMakeLists.txt| 4 ++-- doc/CMakeLists.txt| 4 ++--

Re: [waffle] [PATCH 6/8] waffle: move WAFFLE_API out of the API header

2014-05-30 Thread Chad Versace
On Sat, May 24, 2014 at 11:51:33PM +0100, Emil Velikov wrote: WAFFLE_API is used to define the symbol visibility and all functions provided by the API must be non-hidden. Thus the define should be used internally in conjunction with the compiler used in order to properly annotate the symbols.

Re: [waffle] [PATCH 0/8] Move WAFFLE_API out of the public header + misc patches

2014-05-30 Thread Chad Versace
Patch 7 is committed to master. I added an r-b tag for Jose. On Thu, May 29, 2014 at 11:17:55AM -0700, Jose Fonseca wrote: The Windows specifc change (patch 7) looks good. The rest looks sensible too FWIW, but I'm not the best person to comment, as I'm not yet familiar with the code base.

Re: [waffle] [PATCH 8/8] core: update wcore_enum_to_string()

2014-05-30 Thread Chad Versace
On Sat, May 24, 2014 at 11:51:35PM +0100, Emil Velikov wrote: Add a couple of missing cases - PLATFORM_GBM and DL_OPENGL_ES3. Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- src/waffle/core/wcore_util.c | 2 ++ 1 file changed, 2 insertions(+) Committed to master.

[waffle] ANNOUNCE: Waffle has moved to Github

2014-05-27 Thread Chad Versace
Waffle's website and source has moved from Freedesktop to Github. The mailing list will remain at Freedesktop. These are the new urls: source: git://github.com/waffle-gl/waffle gitweb: https://github.com/waffle-gl/waffle issue-tracker: https://github.com/waffle-gl/waffle/issues

Re: [waffle] [PATCH 1/3] doc/release-notes: Add waffle-next.txt

2014-05-12 Thread Chad Versace
On Fri, May 09, 2014 at 09:40:57AM -0700, Jordan Justen wrote: On Thu, May 8, 2014 at 9:31 PM, Chad Versace chad.vers...@linux.intel.com wrote: On Fri, May 02, 2014 at 07:51:07PM -0700, Jordan Justen wrote: Looks good to me, except that the next release will be 1.4.0, not 1.3.90. If you

Re: [waffle] [PATCH] pkg arch/mac: Update release tarball urls

2014-05-12 Thread Chad Versace
couldn't handle https. So the Portfile lookds good to me, though I didn't test either. (I tend to test Mac very infrequently). Feel free to slap Reviewed-by/Tested-by: Emil Velikov emil.l.veli...@gmail.com And add mine too. Reviewed-by: Chad Versace chad.vers...@linux.intel.com Just added your tree

<    1   2   3   >