The Windows specifc change (patch 7) looks good.
The rest looks sensible too FWIW, but I'm not the best person to comment, as
I'm not yet familiar with the code base.
Jose
- Original Message -
Hi all,
Here is a small selection of patches - mostly bugfixes, while going
though
Sorry for the late reply. I missed you first email somehow.
- Original Message -
Hi all,
Another round of interesting bits and bulbs.
The email came out a bit longer than expected, although it provides a decent
list of possible solutions. Let me know which one you'll go with.
- Original Message -
On 24/05/14 20:28, Emil Velikov wrote:
Hi all,
Another round of interesting bits and bulbs.
Bit of an update:
The email came out a bit longer than expected, although it provides a
decent
list of possible solutions. Let me know which one you'll go
- Original Message -
On Sun, May 25, 2014 at 08:00:49PM -0700, Jordan Justen wrote:
On Sun, May 25, 2014 at 2:43 PM, Emil Velikov emil.l.veli...@gmail.com
wrote:
On 25/05/14 21:35, Jordan Justen wrote:
On Sat, May 24, 2014 at 12:28 PM, Emil Velikov
emil.l.veli...@gmail.com
- Original Message -
On 31/05/14 19:59, Jose Fonseca wrote:
- Original Message -
On 24/05/14 20:28, Emil Velikov wrote:
[snip]
AFAICS waffle is unique wrt other projects (apitrace, epoxy, glut) as it
allows the PixelFormat to be called prior to the creation of either
- Original Message -
On 02/06/14 19:55, Chad Versace wrote:
On Sat, May 31, 2014 at 12:02:10PM -0700, Jose Fonseca wrote:
- Original Message -
- Original Message -
On 24/05/14 20:28, Emil Velikov wrote:
Hi all,
Another round of interesting bits
- Original Message -
On Wed, Jun 4, 2014 at 1:18 PM, Jose Fonseca jfons...@vmware.com wrote:
- Original Message -
On Sun, May 25, 2014 at 08:00:49PM -0700, Jordan Justen wrote:
On Sun, May 25, 2014 at 2:43 PM, Emil Velikov emil.l.veli...@gmail.com
wrote:
On 25/05
- Original Message -
- Original Message -
On Wed, Jun 4, 2014 at 1:18 PM, Jose Fonseca jfons...@vmware.com wrote:
- Original Message -
On Sun, May 25, 2014 at 08:00:49PM -0700, Jordan Justen wrote:
On Sun, May 25, 2014 at 2:43 PM, Emil Velikov
- Original Message -
On 05/06/14 03:19, Emil Velikov wrote:
Hi all,
Over the last few days I have been though some head-scratching and
re-writing
things, in order to resolve an interesting memory corruption to no avail
:'(
Before explaining more about the issue here is
On 07/07/14 18:28, Emil Velikov wrote:
Some of our third_party libraries may be build without it thus we'll fail at
link tim.
Signed-off-by: Emil Velikov emil.l.veli...@gmail.com
---
cmake/Modules/WaffleDefineCompilerFlags.cmake | 2 ++
1 file changed, 2 insertions(+)
diff --git
On 15/07/14 15:35, Jose Fonseca wrote:
On 07/07/14 18:28, Emil Velikov wrote:
Hi all,
After respinning the latest changes (and ripping out WGL as it
requires some
api/abi changes) here is a lovely list of fixes that gets us closer to
building
waffle with mingw/msvc.
The first four patches
On 15/07/14 17:22, Emil Velikov wrote:
On 15/07/14 15:35, Jose Fonseca wrote:
On 07/07/14 18:28, Emil Velikov wrote:
Hi all,
After respinning the latest changes (and ripping out WGL as it requires some
api/abi changes) here is a lovely list of fixes that gets us closer to building
waffle
On 15/07/14 18:14, Emil Velikov wrote:
On 15/07/14 17:30, Jose Fonseca wrote:
On 15/07/14 17:22, Emil Velikov wrote:
On 15/07/14 15:35, Jose Fonseca wrote:
On 07/07/14 18:28, Emil Velikov wrote:
Hi all,
After respinning the latest changes (and ripping out WGL as it requires some
api/abi
On 23/07/14 04:31, Emil Velikov wrote:
TODO:
- Fill in the missing sections.
- Move to a better place.
- Double-check for typos and thinkos.
Signed-off-by: Emil Velikov emil.l.veli...@gmail.com
---
README_WIN.txt | 157 +
1 file
On 23/07/14 04:31, Emil Velikov wrote:
Unlike GLX and EGL, WGL(Windows) does not have the concept of a display
in the sense used in waffle.
The 'root primitive' for WGL is a window with it's device context
which encapsulates the properties and capabilities of the device
doing the actual
On 23/07/14 16:25, Jose Fonseca wrote:
On 23/07/14 04:31, Emil Velikov wrote:
Unlike GLX and EGL, WGL(Windows) does not have the concept of a display
in the sense used in waffle.
The 'root primitive' for WGL is a window with it's device context
which encapsulates the properties
On 21/07/14 17:45, Emil Velikov wrote:
On 17/07/14 05:40, Chad Versace wrote:
Emil,
I'm finished reviewing for today, and am stopping here at patch 16. I'll
resume reviewing tomorrow.
I see that you're collecting reviewed-by tags and cleanups on versioned
brancehs (for-upstream-3.*). I will
No, I only peruse the excellent Archlinux's wiki sometimes, but I'm not
familiar with the actual distro, so I can't help.
Jose
From: Chad Versace chad.vers...@linux.intel.com
Sent: 31 July 2014 04:06
To: Emil Velikov; waffle@lists.freedesktop.org; Jose
On 19/08/14 18:44, Emil Velikov wrote:
On 19 August 2014 16:51, Jose Fonseca jfons...@vmware.com wrote:
On 19/08/14 16:41, Jose Fonseca wrote:
On 19/08/14 14:43, Emil Velikov wrote:
On 19/08/14 14:34, Emil Velikov wrote:
On 19/08/14 13:42, Jose Fonseca wrote:
On 12/08/14 16:37, Emil
On 21/08/14 00:15, Chad Versace wrote:
On 08/20/2014 06:55 AM, Emil Velikov wrote:
waffle works like a champ with WGL, even piglit approves :P
With branches 'yet-another-round-of-msvc-fixes-1.2' [1] and 'waffle-WGL-1.2' I
can run piglit+waffle+wgl on my Windows 7 machine and even crash the
Hi Emil,
I see you moved on!
Yes, I'd like to see WGL support in waffle all the way through, so we
can use it in piglit.
Could you summarize exactly what's missing?
Jose
On 26/08/14 19:09, Emil Velikov wrote:
Hello list,
Following my GSoC, I would like to list a couple of things that I
Hi Emil,
I went through the new patches and they look good AFAICT. Thanks for doing
this.
While going through wgl: fully support ARB_create_context and
EXT_create_context_es_profile. again I noticed a couple of issues with the
usage of WGL_EXT_create_context_es2_profile that I hadn't
On 03/12/14 18:52, Chad Versace wrote:
On 11/26/2014 04:01 AM, Jose Fonseca wrote:
On 26/11/14 11:33, Emil Velikov wrote:
Thanks for the reminder Jose.
The general consensus in #cmake (halfway though the GSoC) was that
find_package(OpenGL REQUIRED) for Windows development is (should
On 22/12/14 22:36, Dylan Baker wrote:
This adds the locations of the package files to the registry on windows,
which should allow them to be auto detected by cmake on windows when
linking against waffle in other projects.
Signed-off-by: Dylan Baker dylanx.c.ba...@intel.com
---
This patch is
From: José Fonseca jfons...@vmware.com
By default, Windows will limit windows too large to theu desktop size,
and windows too small to be big enough for the titlebar. Waffle's
windows don't get affected as their style is WS_POPUPWINDOW, which
doesn't include the WS_CAPTION style.
This change
From: José Fonseca jfons...@vmware.com
Useful to test huge/tiny windows.
---
examples/gl_basic.c | 22 +-
1 file changed, 17 insertions(+), 5 deletions(-)
diff --git a/examples/gl_basic.c b/examples/gl_basic.c
index fb62d52..69418c8 100644
--- a/examples/gl_basic.c
+++
On 29/12/14 17:07, Dylan Baker wrote:
On Monday, December 29, 2014 11:35:20 AM Jose Fonseca wrote:
On 22/12/14 22:36, Dylan Baker wrote:
This adds the locations of the package files to the registry on windows,
which should allow them to be auto detected by cmake on windows when
linking against
On 29/12/14 22:01, Emil Velikov wrote:
On 29/12/14 16:22, Jose Fonseca wrote:
From: José Fonseca jfons...@vmware.com
By default, Windows will limit windows too large to theu desktop size,
and windows too small to be big enough for the titlebar. Waffle's
windows don't get affected
On 30/01/15 22:21, Emil Velikov wrote:
On 30/01/15 20:02, Jose Fonseca wrote:
On 30/01/15 16:25, Emil Velikov wrote:
On 30 January 2015 at 11:07, Jose Fonseca jfons...@vmware.com wrote:
Workaround what seems to be a bug in MSVC parser for C99.
https://urldefense.proofpoint.com/v2/url?u=http
shamelessly copied from piglit.
v2: Do not evaluate but check the MSVC variable. (Jose)
Reviewed-by: Jose Fonseca jfons...@vmware.com
Signed-off-by: Emil Velikov emil.l.veli...@gmail.com
---
CMakeLists.txt | 5 +
README.txt | 2 +-
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git
Emil,
After my piglit change, I had to fix it as
http://cgit.freedesktop.org/piglit/commit/?id=1dca1680c1b29cf1eb242cf8c51e157ca88c929d
otherwise CMake would complain about invalid syntax outside MSVC.
With that,
Reviewed-by: Jose Fonseca jfons...@vmware.com
Jose
On 05/02/15 16:48, Emil
On 26/01/15 23:25, Frank Henigman wrote:
Do the glGetStringi lookup after making context current so it works on WGL.
Remove an incorrect glGetStringi lookup, which returned NULL on Mali.
Signed-off-by: Frank Henigman fjhenig...@google.com
---
Not sure what happened but wflinfo is still broken
On 19/03/15 22:26, Emil Velikov wrote:
C11 does not specify a static initializer, based on the idea that the
a mutex will be platform and/or implementation dependent. As such the
alternative solution is to initialize the mutex with mtx_init().
This will allow us to remove the transition hack,
---
man/waffle_config.3.xml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/man/waffle_config.3.xml b/man/waffle_config.3.xml
index edfa37e..8dc2fae 100644
--- a/man/waffle_config.3.xml
+++ b/man/waffle_config.3.xml
@@ -337,8 +337,8 @@ struct waffle_config;
hack, and in due time move
to the system's C11 threads implementation.
v2: Actually use call_once() to prevent the possibility of multiple
threads hitting the mtx_init() at the same time. Suggested by Jose.
v3: Do not destroy the mutex. Suggested by Chad.
Cc: Jose Fonseca jfons...@vmware.com
On 26/03/15 14:50, Chad Versace wrote:
Quoting Emil Velikov (2015-03-25 07:30:00)
On 24 March 2015 at 17:37, Jose Fonseca jfons...@vmware.com wrote:
Is wcore_display_teardown called only once, or when destroying each display?
If the latter, then it's not safe to call `mtx_destroy(mutex
On 15/04/16 20:04, Chad Versace wrote:
On 04/06/2016 02:12 AM, Jose Fonseca wrote:
On 05/04/16 22:45, Emil Velikov wrote:
This way if the user requests GL pre 3.0 context which lacks the
flags/extra bits which require ARB_create_context one can safely fall
back to the normal/legacy entry point
On 15/04/16 23:48, Emil Velikov wrote:
Direct port of previous commit.
v2: The version should be 3.2 and not 3.0 as originally.
Cc: Jose Fonseca <jfons...@vmware.com>
Cc: Ilia Mirkin <imir...@alum.mit.edu>
Signed-off-by: Emil Velikov <emil.l.veli...@gmail.com>
---
src/waffl
On 15/04/16 23:35, Emil Velikov wrote:
On 15 April 2016 at 20:04, Chad Versace <chad.vers...@intel.com> wrote:
On 04/06/2016 02:12 AM, Jose Fonseca wrote:
On 05/04/16 22:45, Emil Velikov wrote:
This way if the user requests GL pre 3.0 context which lacks the
flags/extra bits which r
39 matches
Mail list logo
