Re: [webkit-dev] Throwing SECURITY_ERR on cross-origin window.location property accesses

2010-08-16 Thread Mihai Parparita
I was wondering if there are any other thoughts on this. It seems like there's real-world need from this (based on the usages I tracked down, and log spam problem) and all other browsers (and the HTML5 spec) have the exception-throwing behavior. Thanks, Mihai On Fri, Aug 13, 2010 at 10:19 AM,

[webkit-dev] Report errors from Qt/Win EWS bots

2010-08-16 Thread Daniel Cheng
Is it possible to make the Qt/Windows EWS bots report what the build errors actually were? Qt doesn't seem to provide any stdio output. MSVC does, but it logs the output into BuildLog.htm files--would it be possible to scrape the text information out of these files and make them available? I ask

Re: [webkit-dev] Throwing SECURITY_ERR on cross-origin window.location property accesses

2010-08-16 Thread Sam Weinig
I am not sure I agree. Does our behavior actually cause any real bugs in the places you have tracked down? The log spam really doesn't seem like an issue, we can remove it if we want to, but have found it useful in the past. I agree with Maciej that the current behavior is in many ways better,

Re: [webkit-dev] ANGLE

2010-08-16 Thread David Hyatt
On Aug 14, 2010, at 10:26 PM, Darin Fisher wrote: On Sat, Aug 14, 2010 at 4:21 PM, k...@inf.u-szeged.hu wrote: On Aug 13, 2010, at 4:25 AM, Zoltan Herczeg wrote: Hi, ANGLE looks like a graphics helper library. Why it is placed in the root WebKit directory? Perhaps

Re: [webkit-dev] Canvas performance and memory usage

2010-08-16 Thread David Hyatt
The changes to ImageBuffer have landed. Here is what port authors need to know: Image* image() on ImageBuffer is gone. It has been replaced with: PassRefPtrImage copyImage() This function should always simply copy the image. It is used in any place where you want to get a snapshot of the

Re: [webkit-dev] ANGLE

2010-08-16 Thread Darin Fisher
On Mon, Aug 16, 2010 at 2:43 PM, Chris Marrin cmar...@apple.com wrote: On Aug 16, 2010, at 2:21 PM, David Hyatt wrote: On Aug 14, 2010, at 10:26 PM, Darin Fisher wrote: On Sat, Aug 14, 2010 at 4:21 PM, k...@inf.u-szeged.hu wrote: On Aug 13, 2010, at 4:25 AM, Zoltan Herczeg wrote:

Re: [webkit-dev] Tests that separate JS and HTML

2010-08-16 Thread Maciej Stachowiak
On Aug 16, 2010, at 12:44 PM, Ojan Vafai wrote: I agree that dealing with the script to generate tests and having the actual test content be in a different file is a significant maintenance overhead. But I also think that having standard testing code across many tests reduces the amount

[webkit-dev] DeviceOrientation/Motion on Document rather than Page

2010-08-16 Thread Dean Jackson
Hi, I've been looking into implementing the clients for DeviceOrientation/Motion Events. Currently, the controllers for these events are members of Page. I think they are better suited on Document. Here are a few reasons: - Page isn't tied to any actual web page or document. Would we want to

[webkit-dev] Why does isLocationChange() return false for redirection?

2010-08-16 Thread Eric Zhou
Hi all, following is the related code. My question is why it returns false when ScheduledRedirection.type is redirection. From the name of the function, I think if the url changes, it should return true. Thus, for most of redirection, it should return true. //FrameLoader.cpp bool